Skip to content

chore(ui): activity details as modal on wide viewport - #47309

Merged
n3ps merged 4 commits into
mainfrom
n3ps/activity-details-dialog-style-7f50
Nov 3, 2026
Merged

n3ps merged 4 commits into
mainfrom
n3ps/activity-details-dialog-style-7f50

Conversation

@n3ps

@n3ps n3ps commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR makes the Activity Details dialog look like a proper modal on wide viewports while preserving the current full-screen appearance on narrow sized viewports.

The goal is to serve as reference for future componetization of this pattern, to be used in wide layouts

Changelog

CHANGELOG entry: null

Related issues

Prepares for full-screen layout work by @amelieyc

Manual testing steps

Testing on wide viewport (desktop browser):

  1. Build and run the extension in a desktop browser (Chrome/Brave/Edge)
  2. Open MetaMask and navigate to the Activity tab
  3. Click on any transaction in the activity list to open the details dialog
  4. Verify the dialog appears as a centered modal
  5. Click outside the dialog or press Escape to close it

Testing on narrow viewport (popup/sidepanel):

  1. Open the extension
  2. Navigate to the Activity tab
  3. Click on any transaction to open the details
  4. Verify the dialog appears full-screen (same as before this PR)

Screenshots/Recordings

Before

N/A - No screenshots available (build not running during PR creation)

After

N/A - No screenshots available (build not running during PR creation)

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable (existing tests pass, no new tests needed for styling change)
  • I've documented my code using JSDoc format if applicable (no new functions added)
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Low Risk
Responsive styling and dialog UX only; no auth, routing logic, or data-handling changes beyond existing dialog open/close behavior.

Reviewed by Cursor Bugbot for commit 179ee4f. Bugbot is set up for automated code reviews on this repo. Configure here.

Apply design-system modal styling (rounded corners, border, shadow,
constrained width) to the activity details dialog at md: breakpoint.
On narrow/popup viewports it retains the current full-screen appearance.

Prepares for full-screen layout work by @amelieyc.

Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Oct 23, 2026
@metamask-ci

metamask-ci Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +11 -8)
  • 📁 ui/
    • 📁 pages/
      • 📁 activity/
        • 📄 activity-list.tsx +4 -1
      • 📁 details/
        • 📁 components/
          • 📄 token-row.tsx +7 -7

🎨 @MetaMask/design-system-engineers (1 files, +5 -1)
  • 📄 tailwind.config.js +5 -1

@metamask-ci

metamask-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7815024]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39898496425 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ confirmTx/longTaskTotalDuration: +61%
  • ↑ confirmTx/longTaskMaxDuration: +92%
  • ↑ confirmTx/tbt: +107%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +99%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +23%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +151%
  • ↑ bridgeUserActions/longTaskMaxDuration: +60%
  • ↑ bridgeUserActions/tbt: +309%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ loadNewAccount/load_new_account: +422%
  • ↑ loadNewAccount/total: +422%
  • ↓ loadNewAccount/fcp: -14%
  • ↑ loadNewAccount/lcp: +1872%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +1374%
  • ↑ bridgeUserActions/bridge_load_page: +339%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +150%
  • ↑ bridgeUserActions/bridge_search_token: +26%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +70%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +25%
  • ↑ bridgeUserActions/lcp: +1305%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 3.4s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +20%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +135%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/domInteractive: -36%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/fcp: -30%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +62%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +43%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +33%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +44%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +25%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -42%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -21%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.39 MiB +125 Bytes 0.00%
✅ ui 19.24 MiB +227 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB +324 Bytes 0.00%

@n3ps n3ps changed the title feat(ui): style activity details dialog as modal on wide viewports chore(ui): activity details dialog as modal on wide viewports Nov 3, 2026
@n3ps n3ps changed the title chore(ui): activity details dialog as modal on wide viewports chore(ui): activity details dialog as modal on wide viewport Nov 3, 2026
@n3ps
n3ps marked this pull request as ready for review November 3, 2026 00:31
@n3ps
n3ps requested a review from a team as a code owner November 3, 2026 00:31
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread ui/pages/activity/activity-list.tsx Resolved
Comment thread ui/pages/activity/activity-list.tsx Resolved
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ea46a85]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41553547212 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +415%
  • ↑ loadNewAccount/total: +415%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +65%
  • ↑ confirmTx/longTaskMaxDuration: +91%
  • ↑ confirmTx/tbt: +114%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +10%
  • ↑ confirmTx/lcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +105%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +51%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +90%
  • ↑ bridgeUserActions/longTaskMaxDuration: +22%
  • ↑ bridgeUserActions/tbt: +143%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +19%
  • ↑ loadNewAccount/lcp: +1315%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -29%
  • ↑ confirmTx/lcp: +1346%
  • ↑ bridgeUserActions/bridge_load_page: +364%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +234%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +64%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +1297%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -29%
  • ↓ startupStandardHome/load: -31%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -20%
  • ↓ startupStandardHome/firstPaint: -20%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↑ startupStandardHome/setupStore: +67%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -39%
  • ↓ startupStandardHome/longTaskMaxDuration: -36%
  • ↓ startupStandardHome/tbt: -40%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -31%
  • ↓ startupStandardHome/lcp: -17%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↓ startupStandardHome/fcp: -32%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +66%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +94%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +47%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +33%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +35%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +12%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +16%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -131.02 KiB -0.83%
🚨 ui 19.33 MiB +98.02 KiB +0.50%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +43 Bytes 0.00%
✅ content scripts 3.23 MiB -3.91 KiB -0.12%
unzipped 79.89 MiB n/a n/a
🚨 zip 24.07 MiB +62.72 KiB +0.26%

This comment was marked as outdated.

return (
<div className="flex items-center gap-2">
<ChainBadge chainId={chainId}>{avatar}</ChainBadge>
<Text

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text has built-in media-queries

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 35494a6. Configure here.

Comment thread ui/pages/activity/activity-list.tsx Resolved
@n3ps
n3ps requested a review from a team as a code owner November 3, 2026 03:26
@n3ps n3ps changed the title chore(ui): activity details dialog as modal on wide viewport chore(ui): activity details as modal on wide viewport Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [179ee4f]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41572259568 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↑ loadNewAccount/inp: +21%
  • ↑ loadNewAccount/lcp: +11%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +68%
  • ↑ confirmTx/longTaskMaxDuration: +100%
  • ↑ confirmTx/tbt: +120%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +96%
  • ↑ bridgeUserActions/longTaskMaxDuration: +28%
  • ↑ bridgeUserActions/tbt: +134%
  • ↑ bridgeUserActions/total: +33%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -24%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1266%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +18%
  • ↑ confirmTx/lcp: +1326%
  • ↑ bridgeUserActions/bridge_load_page: +325%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↑ bridgeUserActions/bridge_search_token: +18%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +64%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +21%
  • ↑ bridgeUserActions/lcp: +1308%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +165%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/domInteractive: -36%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +158%
  • ↑ startupStandardHome/inp: +50%
  • ↓ startupStandardHome/fcp: -30%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +44%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +51%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -131.02 KiB -0.83%
🚨 ui 19.33 MiB +98.13 KiB +0.50%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +43 Bytes 0.00%
✅ content scripts 3.23 MiB -3.91 KiB -0.12%
unzipped 79.89 MiB n/a n/a
🚨 zip 24.07 MiB +62.74 KiB +0.26%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

onClose={handleClose}
// @ts-expect-error closedby missing in React types
// eslint-disable-next-line react/no-unknown-property -- valid on <dialog>
closedby="any"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! cool

@ameliejyc ameliejyc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great for me. One small thing is that it probably makes sense to use the X in the top right for modal rather than the Back in top left, but this could be a next step

Image

@n3ps
n3ps enabled auto-merge November 3, 2026 15:07
Comment thread tailwind.config.js
extend: {},
extend: {
borderRadius: {
'4xl': '2rem',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be available in tailwind v4 https://tailwindcss.com/docs/border-radius

@n3ps
n3ps added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit f693520 Nov 3, 2026
147 of 148 checks passed
@n3ps
n3ps deleted the n3ps/activity-details-dialog-style-7f50 branch November 3, 2026 16:27
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch had an error being deployed

1 failed and 1 inactive deployments
pr-comment — 179ee4f1 Deployed Nov 3, 2026 by n3ps via Publish prerelease / Publish prerelease #172302
segment-schema — 179ee4f1 Deployed Nov 3, 2026 by n3ps via propose #2462
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants