Repository navigation
chore(ui): activity details as modal on wide viewport - #47309
Conversation
Apply design-system modal styling (rounded corners, border, shadow, constrained width) to the activity details dialog at md: breakpoint. On narrow/popup viewports it retains the current full-screen appearance. Prepares for full-screen layout work by @amelieyc. Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +11 -8)
🎨 @MetaMask/design-system-engineers (1 files, +5 -1)
|
Builds ready [7815024]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [ea46a85]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
| return ( | ||
| <div className="flex items-center gap-2"> | ||
| <ChainBadge chainId={chainId}>{avatar}</ChainBadge> | ||
| <Text |
There was a problem hiding this comment.
Text has built-in media-queries
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 35494a6. Configure here.
Builds ready [179ee4f]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
| onClose={handleClose} | ||
| // @ts-expect-error closedby missing in React types | ||
| // eslint-disable-next-line react/no-unknown-property -- valid on <dialog> | ||
| closedby="any" |
| extend: {}, | ||
| extend: { | ||
| borderRadius: { | ||
| '4xl': '2rem', |
There was a problem hiding this comment.
This will be available in tailwind v4 https://tailwindcss.com/docs/border-radius
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |





Description
This PR makes the Activity Details dialog look like a proper modal on wide viewports while preserving the current full-screen appearance on narrow sized viewports.
The goal is to serve as reference for future componetization of this pattern, to be used in wide layouts
Changelog
CHANGELOG entry: null
Related issues
Prepares for full-screen layout work by @amelieyc
Manual testing steps
Testing on wide viewport (desktop browser):
Testing on narrow viewport (popup/sidepanel):
Screenshots/Recordings
Before
N/A - No screenshots available (build not running during PR creation)
After
N/A - No screenshots available (build not running during PR creation)
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Responsive styling and dialog UX only; no auth, routing logic, or data-handling changes beyond existing dialog open/close behavior.
Reviewed by Cursor Bugbot for commit 179ee4f. Bugbot is set up for automated code reviews on this repo. Configure here.