Skip to content

release: 13.57.0 - #47670

Merged
sleepytanya merged 96 commits into
stablefrom
release/13.57.0
Nov 16, 2026
Merged

sleepytanya merged 96 commits into
stablefrom
release/13.57.0

Conversation

@metamaskbot

@metamaskbot metamaskbot commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

🚀 v13.57.0 Testing & Release Quality Process

Hi Team,
As part of our new MetaMask Release Quality Process, here’s a quick overview of the key processes, testing strategies, and milestones to ensure a smooth and high-quality deployment.


📋 Key Processes

Testing Strategy

  • Developer Teams:
    Conduct regression and exploratory testing for your functional areas, including automated and manual tests for critical workflows.
  • QA Team:
    Focus on exploratory testing across the wallet, prioritize high-impact areas, and triage any Sentry errors found during testing.
  • Customer Success Team:
    Validate new functionalities and provide feedback to support release monitoring.

GitHub Signoff

  • Each team must sign off on the Release Candidate (RC) via GitHub by the end of the validation timeline (Tuesday EOD PT).
  • Ensure all tests outlined in the Testing Plan are executed, and any identified issues are addressed.

Issue Resolution

  • Resolve all Release Blockers (Sev0 and Sev1) by Tuesday EOD PT.
  • For unresolved blockers, PRs may be reverted, or feature flags disabled to maintain release quality and timelines.

Cherry-Picking Criteria

  • Only critical fixes meeting outlined criteria will be cherry-picked.
  • Developers must ensure these fixes are thoroughly reviewed, tested, and merged by Tuesday EOD PT.

🗓️ Timeline and Milestones

  1. Today (Friday): Begin Release Candidate validation.
  2. Tuesday EOD PT: Finalize RC with all fixes and cherry-picks.
  3. Wednesday: Buffer day for final checks.
  4. Thursday: Submit release to app stores and begin rollout to 1% of users.
  5. Monday: Scale deployment to 10%.
  6. Tuesday: Full rollout to 100%.

✅ Signoff Checklist

Each team is responsible for signing off via GitHub. Use the checkbox below to track signoff completion:

Team sign-off checklist

  • Accounts
  • Assets
  • Bots Team
  • Confirmations
  • Core Extension UX
  • Core Platform
  • Design System
  • Earn
  • Emerging Opportunities
  • Extension Platform
  • Networks
  • Perps
  • Swaps and Bridge

This process is a major step forward in ensuring release stability and quality. Let’s stay aligned and make this release a success! 🚀

Feel free to reach out if you have questions or need clarification.

Many thanks in advance

Reference

georgewrmarshall and others added 30 commits October 29, 2026 21:13
…#47465)

## **Description**

Split from the UAT build in #47369. Stacked on #47128.

Perps account value, market price, and transaction amount use
`AmountDisplayLg` with the Hero font. Loading skeletons match the new
line height.

Owned by @MetaMask/perps.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Stacked on: #47128
Split from: #47369

## **Manual testing steps**

1. Load this branch in the extension.
2. Open the Perps tab. Confirm the account value and its loading
skeleton in both the popup and the expanded view.
3. Open a Perps market. Confirm the live price and the detail-page
loading skeleton.
4. Open a Perps transaction and confirm the hero amount.

## **Screenshots/Recordings**

Recorded on the combined UAT build:
#47369

### **Before**

![Before
1024px](https://github.com/user-attachments/assets/53845ec5-7f34-4e4d-9d8a-43f4b642ee56)

![Before
360px](https://github.com/user-attachments/assets/97bf009c-3042-4403-90a5-6830f8563ac6)

### **After**

<img width="1507" height="868" alt="Screenshot 2026-10-28 at 5 03 48 PM"
src="https://github.com/user-attachments/assets/e67451d6-8c41-4e08-a73a-abe1660c8578"
/>


https://github.com/user-attachments/assets/9c775f9a-75b6-4782-84b0-e2eed2ef1591

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with [Cursor](https://cursor.com)


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Typography and skeleton sizing only in Perps UI; no changes to
business logic, auth, or funds handling.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
16d4acd. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Amanda Yeoh <147617420+amandaye0h@users.noreply.github.com>
…ers (#47298)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Currently, the background process aggregates methods from various
controllers and services into an API object, and the UI calls a method
on this object by passing its name and arguments to
`submitRequestToBackground`.

The "root" messenger — the messenger for MetamaskController — is meant
to replace this API, and we want to transition to it by replacing
`submitRequestToBackground` calls so that they pass action type strings
(e.g. `NetworkController:addNetwork`) instead of method names (e.g.
`addNetwork`). Then, as it makes sense, we want to remove the original
methods from the legacy API. This is one of a series of PRs which aims
to achieve this.

The tactic used to create this PR was to look for
`submitRequestToBackground` calls in files owned by the Web3Auth team
(although the changes may have affected other files as well).

This commit migrates the following API methods defined within
`MetamaskController.getApi` to use messenger action type strings:

- `setOnboardingDate` (-> `AppStateController:setOnboardingDate`)

Other notes:

- `SeedlessOnboardingController` methods have already been migrated.
- Calls to `QrSyncController` methods within UI files used the
`messengerCall` RPC method with an action type string.
`submitRequestToBackground` now accepts action type strings natively, so
this commit simplifies these calls.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

https://consensyssoftware.atlassian.net/browse/WPC-1425

## **Manual testing steps**

This PR should have no functional changes. All flows should work like
they do today, and the changes here should be covered by tests.

## **Screenshots/Recordings**

(N/A)

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Refactor of background RPC shape only; behavior is unchanged and
covered by updated unit tests, including wallet sync and navigation
cleanup.
> 
> **Overview**
> Continues the move from legacy background API names and
**`messengerCall`** wrappers to **controller-scoped action strings** on
`submitRequestToBackground` / `submitRequestToBackgroundAndCatch`.
> 
> Onboarding now records the start date via
**`AppStateController:setOnboardingDate`** instead of
**`setOnboardingDate`**, with a test asserting that call on welcome
mount.
> 
> QR account sync UI (**OTP submit**, **session create/cancel**, **sync
with password**, **back from settings**) calls **`QrSyncController:*`**
actions directly (e.g. `submitOtp`, `cancelSync`, `createSession`,
`syncAccounts`) rather than nesting them under **`messengerCall`**.
Tests were updated for the new signatures and add coverage for **sync
after password + wallet selection** and **cancel on back** before
navigating to settings.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d83cbc7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

**Root cause:**

- Custom RPC history opens Add network and clicks the RPC dropdown
before typing a name.
- Chainlist v2 opens network suggestions on that empty form, and those
rows cover the RPC dropdown.
- Increase allowance and revoke allowance confirm a spend cap, then
click the confirmed activity row.
- The transaction confirmed toast stays on screen, and its link covers
that row.
- Request queuing confirms a send, then expects the home activity list.
- That same toast link is open on the transaction details route, so the
home activity list is not on screen.
- A fresh default wallet now creates a Money account on unlock, while
the committed fixture vault does not include the Money keyring yet.
- The default fixture records `defaultMoneyAccountId` as null. Unlock
with the Money account flag sets that field to the new account id, so
the dist fixture check sees a string.
- Solana swap tests have no local chain. Money account setup adds Monad,
Infura is redirected, and the primary RPC fails over to QuickNode.
- CHOMP's synced base URL is already `chomp.api.cx.metamask.io`, which
the privacy snapshot already lists.

**Solution:**

- Set `extensionUxChainlistV2`, `moneyEnableMoneyAccount`,
`moneyHomeScreenCardEnabled`, `moneyAccountGeoBlockedCountries`, and
`moneyAccountChompConfig` to the 2026-10-27 production values - these
specs now run against those defaults.
- Close the Chainlist name dropdown with Escape before opening the
add-RPC page - the RPC dropdown can be clicked.
- Close the transaction confirmed toast with its close button before
clicking the confirmed activity row - the row is no longer covered.
- On the request-queuing send, close that toast and leave transaction
details when the details route is open, then count the confirmed
activity row.
- Ignore `data.MoneyAccountController.moneyAccounts` and
`data.MoneyAccountController.defaultMoneyAccountId` in fixture schema
validation alongside `KeyringController.vault` and
`AccountsController.internalAccounts.accounts` - unlock sets the default
id to a string, and fresh wallet validation still passes while tests
create the Money keyring on unlock.
- Set `corePlatformRpcFailoverMode` to `disabled` in the Solana swap
flag mock, the same way the Bitcoin and Tron tests do - Monad does not
call the QuickNode host.
- Leave `chomp.dev-api.cx.metamask.io` out of the privacy snapshot -
this PR's CHOMP URL and the code default are already the production
host.

**Related pull requests:**

- #47375

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Start a test build with `yarn start:test`.
2. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/network/custom-rpc-history.spec.ts --debug
--leave-running`.
3. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/confirmations/transactions/increase-token-allowance-redesign.spec.ts
--debug --leave-running`.
4. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/confirmations/transactions/revoke-allowance-redesign.spec.ts
--debug --leave-running`.
5. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/request-queuing/dapp1-switch-dapp2-send.spec.ts --debug
--leave-running`.
6. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/solana/swap.spec.ts --debug --leave-running`.
7. Build dist with `yarn dist`, then run `SELENIUM_BROWSER=chrome yarn
test:e2e:single test/e2e/dist/wallet-fixture-validation.spec.ts --debug
--leave-running`.

## **Screenshots/Recordings**

### **Before**

Add network: the Chainlist panel is open under Network name. Ethereum,
Orderly Mainnet, and PrimusChain cover the form, and the click meant for
the RPC dropdown hits a Chainlist row.

Activity: the Transaction confirmed toast stays up over the Increased
spending row, and the click hits the toast link. Request queuing lands
on Sent ETH details with that toast still open, so the activity count
never sees the home list.

Solana swap: the home screen shows the same Money card and a Transaction
submitted toast. The test then fails because Monad's QuickNode failover
host is not in the privacy snapshot.

### **After**

No product UI change. The add-RPC step closes the Chainlist panel first.
The activity click closes the confirmed toast first. Request queuing
leaves transaction details when that route is open, then counts the
activity row. Fixture validation ignores the unlock-populated
`moneyAccounts` map and `defaultMoneyAccountId`. Solana swap disables
RPC failover instead of allowing the QuickNode host.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Harry Le <43307514+LeVinhGithub@users.noreply.github.com>
Co-authored-by: LeVinhGithub <levinh.hcmut@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This adds the new `SideNav` component: a persistent left navigation
panel that will be used in the new fullscreen redesign, made of:

- the MetaMask logo,
- the main navigation items, driven by the existing `useMainNavItems`
hook (Home, Perps, Money, Activity, subject to their usual availability
rules),
- an Accounts section (`SideNavAccounts`) with search, manage and
add-account actions and a scrollable account list.

Replit here: https://extension-full-screen-1.replit.app/

It also adds a Storybook story (`Components/App/SideNav`) and unit tests
for `SideNav` and `SideNavAccounts`.

`MultichainAccountList` gets a new opt-in `shouldNavigateOnSelect` prop.
It defaults to `true`, so existing usages behave exactly as before. When
set to `false`, selecting an account with the default click handler only
switches the account and does not navigate away. This is what lets the
list live inside a persistent surface like the side nav.

`SideNav` is not used yet.

Storybook note: the Perps item is not visible in the story because it
also depends on the compile-time `PERPS_ENABLED` build flag, which
Storybook does not set. Home, Money and Activity are shown (the Money
availability query is seeded in the story).

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Run Storybook (`yarn storybook`) and open `Components/App/SideNav` >
`Default`.
2. Verify the MetaMask logo, the nav items (Home, Money, Activity) and
the Accounts section with its wallets and accounts render, with no
errors in the browser console.
3. Click the search icon in the Accounts header, type part of an account
or wallet name, and verify the list filters accordingly.
4. Click an account and verify it becomes the selected account without
any navigation happening.
5. Load the extension and verify it looks and behaves unchanged (no side
navigation is shown anywhere, and selecting an account from any existing
account list still navigates as before).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!--
### **Before**

[screenshots/recordings]
-->

### **After**

Storybook: `Components/App/SideNav` > `Default`

![SideNav default
story](https://cursor.com/artifacts/c/art-6394f5f1-c6a6-4498-8818-23b99231fa98)

Search filtering (typing "Ledger"):

![SideNav
search](https://cursor.com/artifacts/c/art-4ba3261f-6783-411c-8006-208bb0453fc5)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-081e3a54-3df0-4880-961b-4b05857bde1d?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-081e3a54-3df0-4880-961b-4b05857bde1d&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>



<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> New UI is isolated until wired in; the account-list change is
backward-compatible with default navigation behavior unchanged.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
36f84b3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Amélie <ameliejyc@users.noreply.github.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2452

## **Manual testing steps**

No manual testing steps

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Localized MFA error routing and copy changes with test coverage; no
auth or server logic changes.
> 
> **Overview**
> When MFA returns **`max_identifiers_reached`** (profile has hit the
wallet pairing cap), the flow now treats it like
**`multi_primary_srp`**: **`support`** handling instead of a terminal
**`failure`**.
> 
> Users see the dedicated support failure copy (`mfaFailureSupportTitle`
/ `mfaFailureSupportDescription`) and can open support with
**`mfa_error=max_identifiers_reached`** in the link.
**`max_passkeys_reached`** stays a generic limit failure with
dismiss-only.
> 
> Tests and **`getErrorHandling`** expectations were updated;
**`max_identifiers_reached`** was removed from the generic limit message
map so it no longer shares **`mfaErrorLimitReached`** with passkey
limits.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
8b22dc7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…#47494)

## **Description**

Turning Basic Functionality off hides non-EVM networks from the home
network picker, but the selected filter stayed on that network. The
picker then showed only EVM networks while the button still named the
hidden non-EVM network.

When Basic Functionality is off and the enabled filter is only non-EVM
networks, the home network control bar now selects all popular networks
and activates Ethereum, or the first configured EVM network if mainnet
is not available. An existing EVM selection, including All networks, is
left unchanged.

## **Changelog**

CHANGELOG entry: Fixed the home network filter staying on a non-EVM
network after Basic Functionality is turned off

## **Related issues**

Fixes: #47341

## **Manual testing steps**

1. Run the extension and open the home screen.
2. Open the network filter and select a non-EVM network, such as Solana.
3. Open Settings, then Privacy
4. Turn off Basic Functionality and confirm.
5. Close Settings and return to the home screen.
6. Confirm the network filter no longer shows the non-EVM network as
selected.
7. Open the network filter and confirm only EVM networks are listed, and
the selection matches that list.


## **Screenshots/Recordings**
### **Before**
### **After**




https://github.com/user-attachments/assets/fbf6bb00-6ac4-4f5b-9639-352c334b9d18



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Localized UI state correction on the home asset control bar with a
focused unit test; no auth or payment paths touched.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
f4d3b7d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor <cursoragent@cursor.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The State Snap test flakes in two places. First, the install
confirmation popup is missed while it is still on the loading splash.
Later, a second click on Set State or Get State scrolls the page while
it clicks, so the click misses the button.

**Flake type:** Race Conditions on Driver/Helpers Functions / Race
Conditions with Windows

**Root cause:**

- The test opens the Test Snaps page and clicks Connect on the State
Snap card.
- That click closes the connection popup. MetaMask then opens a new
install confirmation popup.
- The new popup starts on the loading splash (the fox screen in
`screenshot-3.png`). The State Snap button still says Connecting
(`screenshot-2.png`).
- The test then looks for the window titled MetaMask Dialog so it can
confirm the install.
- The helper that reads each window (`getCurrentWindowProperties` in
`window-handles.ts`) is meant to wait until both the page title and the
URL are set.
- The wait loop stopped only when the title was missing and the URL was
missing.
- The splash page already has a URL, but its title is still empty.
- Because the URL was already set, the loop stopped after one 200ms
pause.
- The search then checked each open window once and threw `No window
with title: MetaMask Dialog`. It did not look again.
- Later, the test sets the first state entry (`foo: "bar"`).
- The state result box grows and pushes the Set State and Get State
buttons down.
- The test calls `scrollAndClickButton` a second time on those buttons.
- That helper scrolls the page smoothly and clicks at the same time, so
the click misses the button while the page is still moving.

**Solution:**

- In `getCurrentWindowProperties`, keep waiting while the title is
missing or the URL is missing, for up to 2 seconds, checking every 200ms
- a popup that already has a URL still waits for its title, and a window
that never gets a title does not pause for 5 seconds on every scan.
- In `switchToWindowWithProperty`, search the open windows again for up
to 5 seconds, pausing 250ms between passes, until one matches the title
or URL - the install confirmation popup can be found once its title
becomes MetaMask Dialog.
- Replace the second `scrollAndClickButton` on Set State and Get State
(encrypted and unencrypted) with `clickButton` - those buttons are
already on screen, so the second click does not start another smooth
scroll.

**Slack:**
https://consensys.slack.com/archives/CTQAGKY5V/p1792053501583089?thread_ts=1792052619.850169&cid=CTQAGKY5V

**Related pull requests:**

- #46580
- #46836

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Start a test build with `yarn start:test` and leave it running.
2. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/snaps/test-snap-managestate.spec.ts --browser=chrome`.
3. Confirm "Test Snap manageState can use the new state API" installs
the State Snap, sets both state entries, and reads them back.

## **Screenshots/Recordings**

### **Before**

- `test-failure-screenshot-1.png`: the MetaMask extension home tab on
Localhost 8545 showing Account 1 with 25 ETH balance (title `MetaMask`,
not the dialog window).
- `test-failure-screenshot-2.png` (`screenshot-2.png`): the Test Snaps
(`http://127.0.0.1:8080`) State Snap card
(`npm:@metamask/manage-state-example-snap`), with the connect button
disabled and still showing `Connecting` with a spinner while the install
confirmation popup has not been found.
- `test-failure-screenshot-3.png` (`screenshot-3.png`): the new install
confirmation popup (`380x600`) open on the MetaMask loading splash (fox
logo and orange loading spinner), before the page `<title>` (`MetaMask
Dialog`) and `Add to MetaMask` install header have rendered. The window
search stops after one 200ms pause (~398ms total) and throws `No window
with title: MetaMask Dialog`.
- Later in the same test, after `foo: "bar"` is saved, the
`#encryptedStateResult` box grows and shifts Set State and Get State
down. With `Key` (`#setStateKey`) filled with `baz` and `Value`
(`#dataState`) filled with `"qux"`, the second
`scrollAndClickButton('sendStateButton')` scrolls smoothly and clicks
during that scroll, so the next entry (`baz: "qux"`) is never submitted.

### **After**

No product UI change. The window helper waits for the popup title and
searches again for up to 5 seconds, so the install confirmation dialog
is found after the splash screen. The second click on each State Snap
button clicks in place and does not scroll the page again.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to e2e helpers and one snap spec; no production
extension or wallet logic is modified.
> 
> **Overview**
> Fixes flaky **Test Snap manageState** e2e by tightening Selenium
window discovery and avoiding redundant smooth-scroll clicks.
> 
> In `window-handles.ts`, **`getCurrentWindowProperties`** now keeps
polling until **both** title and URL are present (not only when both are
missing), for up to **2s** every **200ms**, so install popups on the
loading splash are not misclassified before **`MetaMask Dialog`**
appears. **`switchToWindowWithProperty`** retries finding a matching tab
for up to **5s** (250ms between passes) via a new
**`#findHandleWithProperty`** helper instead of scanning once and
failing immediately.
> 
> In **`test-snap-managestate.spec.ts`**, follow-up clicks on Set/Get
State (encrypted and unencrypted) use **`clickButton`** instead of
**`scrollAndClickButton`** so the second interaction does not scroll
while clicking after the result panel grows.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1dda820. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bumps `@metamask/assets-controller` from `^20.0.0` to `^20.0.2`.

`20.0.2` ([core#11078](MetaMask/core#11078))
keeps the 20.0.0 API. Balance batches use hand-rolled Multicall3
`aggregate3` codecs, and the Ethers codecs stay in place for a
byte-identical comparison. `20.0.1` is included on the way up and moves
the package onto `@metamask/assets-controllers` `^113.0.0`,
`@metamask/transaction-controller` `^72.3.0`, and
`@metamask/permission-controller` `^14.1.0`.

Companion ranges move so Yarn resolves a single
`@metamask/assets-controller@20.0.2`:

- `@metamask/assets-controllers` `^112.0.2` → `^113.0.0`.
`NftDetectionController` now requires `removeNft`, so initialization
forwards `nftController().removeNft`.
- `@metamask/bridge-controller` `^83.1.1` → `^83.1.2`
- `@metamask/transaction-pay-controller` `^30.3.0` → `^30.3.1`

LavaMoat policies pick up the permission-controller dedupe (`immer` is
now `@metamask/permission-controller>immer`). The 20.0.0 call-site
migration is already on main.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: N/A — dependency bump with no linked issue. Follow-up to #47400
and [core#11078](MetaMask/core#11078).

## **Manual testing steps**

1. Build and load this branch, then unlock a wallet that holds tokens on
Ethereum Mainnet.
2. Open the home asset list and confirm symbols, balances, and fiat
prices still appear.
3. Confirm NFT detection still starts when the preference is enabled.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-b8869cb8-6f26-4143-9bcb-78ef352a2bbc?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-b8869cb8-6f26-4143-9bcb-78ef352a2bbc&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches asset balance/NFT-related controller packages and LavaMoat
sandbox permissions; behavior changes live in upstream packages rather
than extension code in this diff.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
da12433. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
## **Description**

Bumps `@metamask/client-utils` aligning it with mobile

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: #46341

## **Manual testing steps**

1. Load the extension from this branch.
2. Send an ERC-721 NFT to another account; open Activity and confirm
quantity shows **1** (not 0) after the indexed row appears.
3. Repeat with an ERC-1155 send (quantity 1).
4. Optional: use a fresh profile or another browser with only indexed
history and confirm NFT send quantity is still correct.

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with [Cursor](https://cursor.com)


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Dependency major bump touches activity/NFT formatting paths via
client-utils and expands LavaMoat allowances (including fetch) for
nested controller-utils; regression risk is mainly in Activity display
and build-time policy enforcement.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d233195. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
…engers (#47326)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Currently, the background process aggregates methods from various
controllers and services into an API object, and the UI calls a method
on this object by passing its name and arguments to
`submitRequestToBackground`.

The "root" messenger — the messenger for MetamaskController — is meant
to replace this API, and we want to transition to it by replacing
`submitRequestToBackground` calls so that they pass action type strings
(e.g. `NetworkController:addNetwork`) instead of method names (e.g.
`addNetwork`). Then, eventually, we want to remove the original methods
from the legacy API object. This PR is one of a series of PRs which aims
to unlock this refactor.

The tactic used to create this PR was to look for
`submitRequestToBackground` calls in controllers, services, and files
owned by the Confirmations team (although the changes may have affected
other files as well).

Most of the migrations that would have taken place in this commit have
already happened in a previous one. As a result, the following API
methods have been removed from the TransactionController init file:

- `getLayer1GasFee`
- `getTransactions`
- `isAtomicBatchSupported`
- `updateAtomicBatchData`
- `updateEditableParams`
- `updatePreviousGasParams`
- `updateSelectedGasFeeToken`
- `updateTransactionGasFees`

Calls for the following API methods defined within
`MetamaskController.getApi` were migrated to use messenger action type
strings:

- `updateTransaction` (-> `TransactionController:updateTransaction`)

Calls for the following API methods defined within the
TransactionController wallet library config file were not migrated for
the following reasons:

- `abortTransactionSigning` (is used by hardware wallets, and will be
migrated later)
- `updateBatchTransactions` (not registered on the messenger)
- `checkFirstTimeInteraction` (not registered on the messenger)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

https://consensyssoftware.atlassian.net/browse/WPC-1426

## **Manual testing steps**

This PR should have no functional changes. All flows should work like
they do today, and the changes here should be covered by tests.

## **Screenshots/Recordings**

(N/A)

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches transaction persistence and gas-fee update IPC paths in
confirmations; behavior should be unchanged but regressions would affect
signing and approval flows.
> 
> **Overview**
> Continues the move from the legacy background API to **messenger
action strings** for Confirmations-related transaction work.
> 
> **Legacy API cleanup:** `getTransactionControllerApi` no longer
exposes eight `TransactionController` methods (`getLayer1GasFee`,
`getTransactions`, atomic-batch and gas-fee updaters, etc.); callers are
expected to use the corresponding `TransactionController:*` messenger
actions instead. **`updateBatchTransactions`** and
**`checkFirstTimeInteraction`** remain on the legacy surface.
> 
> **UI call sites:** Money Account withdraw persistence now invokes
**`TransactionController:updateTransaction`** (not `updateTransaction`)
and passes a note string, **`Prepared Money Account withdrawal for
approval`**, alongside the transaction meta; tests assert that shape.
> 
> **Gas fees thunk:** The background request was already
**`TransactionController:updateTransactionGasFees`**; the change
replaces a `@ts-expect-error` with an explicit cast for the
**`userEditedGasLimit`** string vs boolean mismatch.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c8e1ac3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…47455)

## **Description**

Implements **Option C** from [ADR 0068 (state-write telemetry idle
definition)](https://github.com/MetaMask/decisions/blob/main/decisions/extension/0068-state-write-telemetry-idle-definition.md):
attach an agnostic **last-activity snapshot** to each sampled
split-state write so analysts can decide what context matters at query
time.

**Reason:** State-write telemetry already records size, controllers, and
related measurements. Option C adds a snapshot of what MetaMask did
before the write happenned, without baking an arbitrary idle definition
into the client.

**Solution:**
- On each sampled write, capture `LastActivity` and report it on the
Sentry state-write event:
  - `ms_since_app_start`
  - `ms_since_last_write`
  - `ms_since_ui_open`
  - `ms_since_ui_closed`
  - `ms_since_window_event`
  - `last_service_worker_reload`
  - `service_worker_reload_count`

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Reproduce manual testing steps detailed in this PR:
#46286
2. Confirm `ms_since_app_start`, `ms_since_last_write`,
`ms_since_ui_open`, `ms_since_ui_closed`, `ms_since_window_event`,
`last_service_worker_reload` and `service_worker_reload_count`
properties are now added to `state.write` metdata of [State
Persist](https://metamask.sentry.io/explore/traces/?project=273496&query=transaction%3A%22State%20Persist%22&statsPeriod=30d)
traces in Sentry.
3. To increment `service_worker_reload_count` property, visit
chrome://serviceworker-internals/ , search MetaMask by its ID, and click
on "Stop" to restart the service worker.

<img width="715" height="539" alt="Screenshot 2026-10-28 at 17 45 57"
src="https://github.com/user-attachments/assets/6a28af85-8dea-4a17-be51-4fdef82e80ff"
/>

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Telemetry-only changes on the persist path with best-effort, fail-open
handling; no user-facing behavior or vault logic changes.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
45963c1. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
release: sync stable to main for version 13.55.0
## **Description**

Removes unused exports from four unowned shared constant modules. The
modules themselves stay, and every export that still has a reference
stays. Owner set: `(none)`.

| path | removed (file / symbol / class) | why dead |
| --- | --- | --- |
| `shared/constants/signatures.ts` | `PRIMARY_TYPES` | unused export |
| `shared/constants/smartTransactions.ts` |
`FALLBACK_SMART_TRANSACTIONS_REFRESH_TIME`,
`FALLBACK_SMART_TRANSACTIONS_DEADLINE`,
`FALLBACK_SMART_TRANSACTIONS_EXPECTED_DEADLINE`,
`FALLBACK_SMART_TRANSACTIONS_MAX_DEADLINE`,
`FALLBACK_SMART_TRANSACTIONS_MAX_FEE_MULTIPLIER`,
`SMART_ACCOUNT_LEARN_MORE_URL` | unused export |
| `shared/constants/tokens.ts` | `LISTED_CONTRACT_ADDRESSES`,
`TokenDetails`, `MAX_TOKEN_ALLOWANCE_AMOUNT`,
`NUM_W_OPT_DECIMAL_COMMA_OR_DOT_REGEX` | unused export |
| `shared/constants/verification.ts` | `TX_SIG_LEN`,
`EXPERIENCES_TO_VERIFY`, `TRUSTED_SIGNERS` | unused export |

No user-facing behavior change.

Declaration blame is older than 90 days. `smartTransactions.ts` was last
committed on 2026-09-25; that commit did not touch these declarations.
No open pull request edits these files. `PRIMARY_TYPES_ORDER` and
`PRIMARY_TYPES_PERMIT` stay. `STATIC_MAINNET_TOKEN_LIST`,
`TOKEN_API_METASWAP_CODEFI_URL`, and `DECIMAL_REGEX` stay.
`getExperience` stays. A different `TokenDetails` type in
`ui/pages/confirmations/utils/token.ts` is unrelated and was not edited.

`yarn lint:tsc` passed. ESLint passed on the four files. `yarn
test:unit` on the importers passed (13 suites, 102 tests, 1 snapshot
unchanged).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

N/A — no UI change

### **After**

N/A — no UI change

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unreachable constants and types with no remaining importers;
no auth, transaction, or user-facing logic is modified.
> 
> **Overview**
> Removes **dead exports** from four shared constant modules
(`signatures`, `smartTransactions`, `tokens`, `verification`) after
confirming nothing in the extension still imports them.
> 
> **Signatures:** drops the `PRIMARY_TYPES` array;
`PRIMARY_TYPES_ORDER`, `PRIMARY_TYPES_PERMIT`, and the `PrimaryType`
type remain.
> 
> **Smart transactions:** removes legacy `FALLBACK_SMART_TRANSACTIONS_*`
timing/fee constants, the unused `SECOND` import, and
`SMART_ACCOUNT_LEARN_MORE_URL`; chain allowlists, RPC host flags, and
`SMART_TRANSACTIONS_LEARN_MORE_URL` stay.
> 
> **Tokens:** removes `LISTED_CONTRACT_ADDRESSES`, the shared
`TokenDetails` type, `MAX_TOKEN_ALLOWANCE_AMOUNT`, and
`NUM_W_OPT_DECIMAL_COMMA_OR_DOT_REGEX`, plus the unused `BigNumber`
import; `STATIC_MAINNET_TOKEN_LIST`, API URL, and `DECIMAL_REGEX` stay.
> 
> **Verification:** removes `TX_SIG_LEN`, `EXPERIENCES_TO_VERIFY`, and
`TRUSTED_SIGNERS`; `getExperience` stays.
> 
> No runtime or UI behavior change—export surface cleanup only.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
7d4aa40. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
## **Description**

Removes three unowned files that nothing in the extension imports. Owner
set: `(none)`.

| path | removed (file / symbol / class) | why dead |
| --- | --- | --- |
| `ui/helpers/utils/transaction-display.ts` | file;
`useTransactionDisplay` | zero refs |
| `ui/hooks/useBridgeHistoryLifecycle.ts` | file;
`useBridgeHistoryLifecycle` | zero refs |
| `ui/hooks/useNonEvmTransactionLifecycle.ts` | file;
`useNonEvmTransactionLifecycle` | zero refs |

No user-facing behavior change.

Each file was added on 2026-04-01 and has no colocated test, story, or
README. Whole-word search found no imports, string references, or
dynamic imports. No open pull request edits these paths. `yarn lint:tsc`
passed. `yarn test:unit` for these paths found no tests
(`--passWithNoTests`, no snapshot updates). ESLint does not apply: the
files were deleted and no surviving file was edited.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

N/A — no UI change

### **After**

N/A — no UI change

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unreachable code with no imports or runtime callers; no
functional or security impact.
> 
> **Overview**
> Removes three **unreferenced** UI modules that were never wired into
the extension: **`useTransactionDisplay`** (i18n titles for
pending/success/failed transaction states),
**`useBridgeHistoryLifecycle`** (bridge history diffing with
pending/success/failure callbacks), and
**`useNonEvmTransactionLifecycle`** (non-EVM tx list diffing with
recency filtering and success/failure handlers).
> 
> This is **dead-code cleanup only**—no surviving files are edited and
there is **no user-facing behavior change**.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a975912. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
## **Description**

Removes four unused URL exports from `shared/lib/ui-utils.ts`. The file
and every export that still has a caller stay. Owner set: `(none)`.

| path | removed (file / symbol / class) | why dead |
| --- | --- | --- |
| `shared/lib/ui-utils.ts` | `METAMETRICS_SETTINGS_LINK` | unused export
|
| `shared/lib/ui-utils.ts` | `ETHERSCAN_PRIVACY_LINK` | unused export |
| `shared/lib/ui-utils.ts` | `GAS_FEES_LEARN_MORE_URL` | unused export |
| `shared/lib/ui-utils.ts` | `SMART_ACCOUNT_INFO_LINK` | unused export |

No user-facing behavior change.

Declaration blame is older than 90 days. The file was edited on
2026-10-28 to retarget other legal URLs; those lines were not these four
exports, so they were left in place
(`AUTO_DETECT_TOKEN_LEARN_MORE_LINK`, `CONSENSYS_TERMS_OF_USE`, and the
live `CONSENSYS_PRIVACY_LINK`). `METAMETRICS_SETTINGS_LINK` in
`ui/helpers/constants/common.ts` is a separate live export and was not
edited. No open pull request edits `shared/lib/ui-utils.ts`.

`yarn lint:tsc` passed. ESLint passed on `shared/lib/ui-utils.ts`. `yarn
test:unit` on importers of the remaining exports passed (5 suites, 52
passed, 2 skipped, 1 snapshot unchanged).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

N/A — no UI change

### **After**

N/A — no UI change

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unused constants only; no callers or UI paths are affected.
> 
> **Overview**
> Removes four dead URL constants from **`shared/lib/ui-utils.ts`**:
`METAMETRICS_SETTINGS_LINK`, `ETHERSCAN_PRIVACY_LINK`,
`GAS_FEES_LEARN_MORE_URL`, and `SMART_ACCOUNT_INFO_LINK`. Nothing in the
extension imported them; remaining link exports are unchanged.
> 
> This is proactive dead-code cleanup (aligned with the mobile extension
counterpart). **No user-facing or runtime behavior change.**
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
cbb199f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
## **Description**

Sets the Perps market price to `AmountDisplayLg` with the Hero typeface
for cp-13.56.0. Only `perps-market-detail-page.tsx` changes.

That type is tall enough to fail Chrome e2e. The chart time-axis canvas
(`z-index: 2`) overlaps the sticky Long, Short, and Close buttons, and a
stale AVAX candle mock crashes the page with `Cannot update oldest
data`. Both fixes are in #47505, stacked on this branch so this PR still
shows the failing jobs. Merge #47505 here first, then merge this to
main.

## **Changelog**

CHANGELOG entry: Updated the perpetuals market price to the larger Hero
type.

## **Related issues**

Related: #47505

## **Manual testing steps**

1. Open the extension with Perps enabled.
2. Open a Perps market.
3. Confirm the price uses the large Hero typeface and Long/Short stay
reachable.

## **Screenshots/Recordings**

### **Before**

<img width="688" height="441" alt="Screenshot 2026-10-29 at 5 57 28 PM"
src="https://github.com/user-attachments/assets/8daf2411-d68b-475b-91e1-a8448be1799b"
/>

### **After**

<img width="1393" height="871" alt="Screenshot 2026-10-29 at 5 54 21 PM"
src="https://github.com/user-attachments/assets/dc50bc57-8504-4a85-835b-31def4850b24"
/>

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Visual typography and CSS stacking-context changes plus test mock
timing; no trading, auth, or persistence logic touched.
> 
> **Overview**
> Updates the **perps market detail** scrollable price row to
**`AmountDisplayLg`** with **`FontFamily.Hero`** instead of heading bold
styling, matching the cp-13.56.0 Grotzec spec.
> 
> Because the larger type and chart layout exposed stacking issues, the
PR also adds **`isolation: isolate`** on the candlestick chart wrapper
so the time-axis canvas cannot paint above the sticky Long/Short/Close
footer, and switches the Hyperliquid **candle subscribe** e2e mock from
a static follow-up to **`dynamicFollowUp`** that sets candle timestamps
at subscribe time—avoiding lightweight-charts **“Cannot update oldest
data”** and keeping **`chartCurrentPrice`** valid for close-position
flows in Chrome e2e.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ddd4bec. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

The onboarding completion screen ("Your wallet is ready!") draws its
card from the shared onboarding container
(`onboarding-flow__container`). That container used Tailwind
`rounded-lg`, which is 8px here. Modal dialogs use a larger radius.

`ModalContent` in this repo
(`ui/components/component-library/modal-content/modal-content.tsx`) and
in `@metamask/design-system-react@0.47.0` both set the dialog to
`rounded-[32px]` (32px). The design-system Tailwind preset does not
override the radius scale, so `rounded-3xl` stays the Tailwind 3 default
of 1.5rem (24px) and does not match the modal. This change uses the same
`rounded-[32px]` class as `ModalContent`.

Changing the shared container is appropriate. The completion screen does
not own a separate card, and the other onboarding steps that show this
card should keep the same chrome.

Screens where the muted card is visible, so the larger radius shows:

- Wallet ready / creation successful (not the Secret Recovery Phrase
reminder variant)
- Create password
- MetaMetrics opt-in
- Privacy settings ("Manage default settings")
- Import with Secret Recovery Phrase
- Download the mobile app
- Account already exists
- Account not found
- Set up passkey
- Passkey PRF migration
- Those same steps when onboarding runs in the side panel

Screens where this does not show a distinct card (full-bleed,
transparent, or the same color as the page):

- Welcome
- Unlock
- Reveal, review, and confirm Secret Recovery Phrase
- Completion opened from a Secret Recovery Phrase reminder
- Popup onboarding
- Flask experimental area

## **Changelog**

CHANGELOG entry: Updated onboarding card corners so they match modal
corners.

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Build and load the extension, then start onboarding and create a new
wallet.
2. Continue until the "Your wallet is ready!" screen. Skip Secret
Recovery Phrase backup for the shortest path.
3. Confirm the card corners match a modal dialog (32px), rather than the
previous tighter corners.
4. Open Manage default settings from that screen, or revisit Create
password, and confirm that card uses the same corners.

## **Screenshots/Recordings**

### **Before**

![Onboarding completion card before the radius change. Pink boxes mark
the tighter
corners.](https://cursor.com/artifacts/c/art-0f200f07-021c-49ea-aab6-b636c380a126)

### **After**

![Onboarding completion card after matching the modal corner
radius.](https://cursor.com/artifacts/c/art-ab0c2a3e-f501-43ed-a3e0-c1d4f68bad40)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-16fa62c4-013d-52cb-8e5b-ebfe933bd4d1?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-16fa62c4-013d-52cb-8e5b-ebfe933bd4d1&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Single Tailwind class change on onboarding layout styling with no
logic, auth, or data handling impact.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
8eb9c90. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
…ies (#47527)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Clears the release-blocking Yarn audit advisories by raising
resolutions:
- `follow-redirects` to `^1.16.2` (high, production)
- `glob` `^10.3.7` and `^13.0.0` to `^14.0.2` (moderate, production)
- `minimatch` to `^11.0.1` (moderate, production)
- `joi` `^17.9.2` to `^17.13.9` and `^18.2.3` to `^18.3.1` (high,
dev-only)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: #47520
Fixes: #47519

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to Yarn resolutions and the lockfile; risk is
mainly verifying CI/build and audit gates pass on the upgraded
transitive dependency tree.
> 
> **Overview**
> Addresses release-blocking **Yarn audit** findings by pinning patched
versions in **`package.json` `resolutions`** and refreshing
**`yarn.lock`**.
> 
> **Production-facing:** `follow-redirects` is raised from `^1.16.1` to
**`^1.16.2`**. Transitive **`glob`** ranges (`^10.3.7`, `^13.0.0`) are
unified to **`^14.0.2`**, which pulls in **`glob@14.0.3`**,
**`minimatch@^11.0.2`**, and updated **`path-scurry@^3.0.0`** while
dropping older glob-10 CLI-related packages from the lockfile.
> 
> **Dev/tooling:** **`joi`** is bumped via resolutions (`^17.9.2` →
**`^17.13.9`**, `^18.2.3` → **`^18.3.1`**).
> 
> No runtime or UI source changes—only dependency graph updates tied to
issues **#47519** and **#47520**.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
2a9eac6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Removes unused exports from unowned `ui/helpers` files. Owner set:
`(none)` (no CODEOWNERS match). No user-facing behavior change.

The declarations are not imported anywhere. Whole-word search only hit
the definitions. None of these symbols or files are referenced by an
open pull request. Declaration blame is older than 90 days, and the
files themselves were not edited in the last 30 days. String values that
are still locale message keys remain quoted elsewhere in `ui/`, so `yarn
verify-locales` does not lose a message reference.

| path | removed (file / symbol / class) | why dead |
| --- | --- | --- |
| ui/helpers/constants/error-keys.js | INSUFFICIENT_FUNDS_ERROR_KEY |
unused export |
| ui/helpers/constants/error-keys.js | TRANSACTION_ERROR_KEY | unused
export |
| ui/helpers/constants/error-keys.js | IS_SIGNING_OR_SUBMITTING | unused
export |
| ui/helpers/constants/gas.js | PRIORITY_LEVEL_ICON_MAP | unused export
|
| ui/helpers/constants/connected-sites.js | STATUS_CONNECTED_TO_SNAP |
unused export |
| ui/helpers/utils/confirm-tx.util.ts | convertTokenToFiat | unused
export |
| ui/helpers/utils/confirm-tx.util.ts | roundExponential | unused export
|
| ui/helpers/utils/confirm-tx.util.ts | BigNumber import | cascade from
roundExponential |

Left in place on purpose: five other unused error-key exports and
`getGasFormErrorText`, because each is the only quoted reference to a
locale message key. Locales are out of scope.

Checks that passed: `yarn lint:tsc`, eslint on the touched files, and
`yarn test:unit --coverage=false` for
`ui/helpers/utils/confirm-tx.util.test.js` and `ui/helpers/constants`
(no snapshot updates). No stylesheets changed.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unreachable helper exports only; no runtime paths or
security-sensitive logic are modified.
> 
> **Overview**
> Removes dead exports from `ui/helpers` that are not imported
anywhere—proactive cleanup with no intended user-facing behavior change.
> 
> **Constants:** drops `STATUS_CONNECTED_TO_SNAP`, three error-key
constants (`INSUFFICIENT_FUNDS_ERROR_KEY`, `TRANSACTION_ERROR_KEY`,
`IS_SIGNING_OR_SUBMITTING`), and the unused `PRIORITY_LEVEL_ICON_MAP`
emoji map from gas helpers.
> 
> **Confirm-tx utils:** deletes `convertTokenToFiat` and
`roundExponential`, and removes the `bignumber.js` import that only
served `roundExponential`. Remaining helpers (gas totals, fee
formatting, dapp gas comparison, etc.) are unchanged.
> 
> Other unused symbols were left when they still anchor locale message
keys (per PR notes).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
2d41c1b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
## **Description**

Removes the unused `useSwapDefaultToToken` hook and the ESLint
suppression entry that named only that file. Owner set: `(none)`.
`ui/hooks/swap/` is unowned; swaps-engineers own `ui/pages/swaps` and
bridge paths, which this branch does not touch.

| path | removed (file / symbol / class) | why dead |
| --- | --- | --- |
| `ui/hooks/swap/useSwapDefaultToToken.ts` | file;
`useSwapDefaultToToken` | zero refs |
| `eslint-suppressions.json` | key
`ui/hooks/swap/useSwapDefaultToToken.ts` | cascade from
`useSwapDefaultToToken.ts` |

No user-facing behavior change.

The hook was added on 2025-03-13 and last changed on 2026-03-11. It has
no colocated test. The only other hit was the suppression key (blame
2026-08-20). `eslint-suppressions.json` was committed on 2026-10-28 on
other keys; this key was not in that diff. No open pull request edits
either file. `SWAPS_CHAINID_DEFAULT_TOKEN_MAP` and
`SWAPS_CHAINID_COMMON_TOKEN_PAIR` stay.

`yarn lint:tsc` passed. ESLint on a file that loads
`eslint-suppressions.json` (`ui/hooks/useAsync.ts`) passed after the key
was removed. `yarn test:unit` for this hook found no tests
(`--passWithNoTests`, no snapshot updates).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

N/A — no UI change

### **After**

N/A — no UI change

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unreachable code only; swap runtime behavior and shared token
maps are untouched.
> 
> **Overview**
> Removes dead swap UI code with **no user-facing impact**. The unused
**`useSwapDefaultToToken`** hook (which would have picked a default “to”
token from chain defaults and common pairs when none was set) is deleted
entirely.
> 
> The matching **`eslint-suppressions.json`** entry for that file’s
**`react-hooks/exhaustive-deps`** suppression is removed as well. Shared
swap constants like **`SWAPS_CHAINID_DEFAULT_TOKEN_MAP`** are unchanged.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
fc54ca3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
## **Description**

**Root cause:**

- The money-account deposit tests open Add funds and choose USDC on
Mainnet.
- The confirmation shows the amount field, the percentage buttons, and
the pay-with pill.
- The test presses 25% or Max, then waits for the amount to be 25 or
100.
- `confirmations_pay_extended` now prefills a money-account deposit.
That fill happens while the pay-with balance is still the raw USDC
figure. The field stays on 25000000 or 100000000, so the wait for 25 or
100 never passes. The pay-with pill later shows USDC ($100.00).

**Solution:**

- Set `confirmations_pay_extended` `productionDefault` to the synced
production payload, with money-account deposit prefill turned on. The
tests follow that flag instead of the old threshold default.
- Wait until the pay-with pill shows ($100.00) before pressing 25%, 50%,
or Max. The percentage then uses the $100 fiat balance, and the amount
checks stay 25, 50, and 100.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Build a test extension with `yarn start:test`.
2. Run the deposit percentage test:

```bash
SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/confirmations/metamask-pay/money-account-deposit.spec.ts --debug --leave-running
```

3. Run the Max deposit test:

```bash
SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/confirmations/metamask-pay/money-account-deposit-max.spec.ts --debug --leave-running
```

4. Confirm each test finishes with the amount field at $25, $50, or
$100, and the deposit confirms.

## **Screenshots/Recordings**

### **Before**

CI failure on the Add funds screen. After 25%, the amount field shows
$25000000 in red, with Insufficient funds. Pay with still shows USDC
($100.00). The footer says Max deposit: $500,000. The Max test shows
$100000000 in the amount field on the same screen.

### **After**

No product UI change. The test waits until the pay-with pill reads
($100.00), then presses 25% or Max, so the amount field is $25 or $100.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: LeVinhGithub <levinh.hcmut@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Harry Le <43307514+LeVinhGithub@users.noreply.github.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2455

## **Manual testing steps**

Feature: MFA email verification code entry

  Background:
Given the user reaches the "Enter your verification code" screen in an
MFA flow
    And a 6-digit code has been sent to their email

  Scenario: user no longer sees a Paste button
    Then there is no "Paste" button above the code boxes
And the code boxes sit directly under the description at the standard
gap

  Scenario: user pastes the code with a long press
    Given the user has copied the code from the email
    When user long-presses any of the code boxes
    Then all 6 boxes fill with the code
    And the code is submitted automatically
    And releasing the long press does not clear any digits

  Scenario: user types the code
    When user taps the boxes and types 6 digits
    Then the focused box has a darker border than the others
    And the code is submitted automatically after the 6th digit

  Scenario: user enters a wrong code and tries again
    When user enters an incorrect 6-digit code
Then the boxes clear, their borders turn red and "This code isn't
correct. Try again" shows
    When user types the first digit of a new code
    Then the red borders and the error message disappear

  Scenario: Android keyboard offers the code
Given the user is on a real Android device that has received the code
    When user focuses the code boxes
    Then the keyboard can suggest the one-time code

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Localized MFA OTP UI and accessibility tweaks with no auth or
verification logic changes.
> 
> **Overview**
> Updates the MFA **6-digit code entry** screen so invalid-code feedback
matches design-system text fields and the ticket’s retry flow.
> 
> After a wrong code, the digits still clear as before, but **red cell
borders** and the alert now use a dedicated **`showErrorState`** (error
+ empty input). As soon as the user types again, the message and red
styling drop while **`aria-invalid`** follows the same rule.
> 
> **Cell styling** moves to **`getCellBorder`**: error red,
**`border-default`** on the active cell, **`border-muted`** otherwise
(replacing primary focus rings and a thicker border). Digit typography
uses **`HeadingLg`** instead of a custom size.
> 
> The email **Resend** button no longer shows a loading state during
verification—progress stays in the **“Verifying…”** row under the boxes.
**`StepMessage`** drops medium font weight for step helper/error text.
> 
> Adds a test that the invalid-code alert hides once the user enters a
new digit.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1f91362. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## Version Bump After Release

This PR bumps the main branch version from 13.56.0 to 13.57.0 after
cutting the release branch.

### Why this is needed:
- **Nightly builds**: Each nightly build needs to be one minor version
ahead of the current release candidate
- **Version conflicts**: Prevents conflicts between nightlies and
release candidates
- **Platform alignment**: Maintains version alignment between MetaMask
mobile and extension
- **Update systems**: Ensures nightlies are accepted by app stores and
browser update systems

### What changed:
- Version bumped from `13.56.0` to `13.57.0`
- Platform: `extension`
- Files updated by `set-semvar-version.sh` script

### Next steps:
This PR should be **manually reviewed and merged by the release
manager** to maintain proper version flow.

### Related:
- Release version: 13.56.0
- Release branch: release/13.56.0
- Platform: extension
- Test mode: false

---
*This PR was automatically created by the
`create-platform-release-pr.sh` script.*

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
…on return error after user confirm (#47528)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR fix the failure message is not show up
when a non-evm transaction return error after user confirm from the
confirmation dialog

**Previous**
any error b4 dialog show, it return to amt input screen (bitcoin
example)
any error after dialog show , it return home, no error

**After fix**
any error b4 dialog show, it return to amt input screen (bitcoin
example)
any error after dialog show , it return home, toast with error (stellar
example)


the root cause is 
the loader component replace the navigation history
the current failure handle will redirect back to home

the solution is
display the error in toast when redirect back to home

as result
we can keep the same behavior when non-evm transaction return error
**before** user confirm from the confirmation dialog
but only using toast when non-evm transaction return error **after**
user confirm from the confirmation dialog

https://www.loom.com/share/c614df7241a54d08b36fdd4ef88a3832

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fixed a bug that the failure message is omitted when
having error in non-evm send fund

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes non-EVM send error UX and routing detection via
`window.location.hash`; logic is scoped to failure handling but affects
a core user-facing send path.
> 
> **Overview**
> Fixes **missing failure feedback** when a non-EVM send fails **after**
the user confirms in the Snap dialog. The send loader **replaces
navigation history**, so navigating back no longer lands on the amount
screen and **`updateNonEVMSubmitError` had nothing visible to attach
to**.
> 
> **`useSendActions`** now uses a new **`isRemainInSendScreen()`**
helper (hash route still under **`SEND_ROUTE`**) to choose how errors
surface: **on the send flow**, behavior is unchanged—validation and snap
errors still set context via **`updateNonEVMSubmitError`** (including
mapped snap codes). **Once the user has left the send screen**, the same
failures show a **generic `toast.error`** instead, then still navigate
**`PREVIOUS_ROUTE`**. **User rejection (4001)** stays silent—no toast,
error cleared.
> 
> Tests mock **`toast.error`**, drive **`window.location.hash`** to
simulate post-loader routes, and cover validation/RPC failures (toast
shown) vs rejection (no toast).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
4cc098e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
selectAccountGroupBalanceForEmptyState didn't include the Tron CAIP
namespace from its mainnet non-EVM check so a funded Tron account is
treated as zero-balance even though the asset list has the TRX.
The same omission exists in the selector that decides whether the
balance has loaded. Both the "has a balance" check and the "balance has
loaded" check now include Tron mainnet, while Tron testnets such as Nile
stay excluded.

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: added tron to non evm list

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Small, targeted selector change with matching unit tests; behavior
only affects empty-state and loading gating for Tron accounts, not
balance aggregation or transactions.
> 
> **Overview**
> **Tron mainnet balances were ignored** when deciding whether to show
the funded wallet UI versus the “Fund Your Wallet” empty state, because
the non-EVM mainnet chain filter omitted the Tron CAIP namespace.
> 
> **`selectAccountGroupBalanceForEmptyState`** and
**`selectAccountGroupBalanceIsLoadedForEmptyState`** now treat
**`KnownCaipNamespace.Tron`** like Solana, Bitcoin, and Stellar: mainnet
TRX counts toward “has balance” and a zero mainnet record counts as
“loaded,” while **Tron testnets (e.g. Nile) stay excluded** from those
checks.
> 
> Tests add a Tron mock state factory and cases for positive mainnet
balance, loaded zero balance, and testnet-only balance ignored.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
5227769. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…ounts (#47532)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The send confirmation heading and the simulation / estimated changes
amounts showed only about 3 significant digits, and fewer decimals as
the amount grew (for example `121.456` showed as `121.5` and `1,034.123`
as `1,034`). That can hide cents on large stablecoin sends.

`formatAmount` now shows up to 8 decimal places by default, without
trailing zeros. Longer amounts are rounded to 8 decimals, and the
existing tooltip still shows the full value. Non-zero amounts below
`0.000001` still show `<0.000001`. The change lives in `formatAmount`,
so it applies everywhere that formatter is used.

- `formatAmount` keeps its signature and gets an optional trailing `{
compact }` option, so no existing caller has to change. `compact: true`
keeps the previous 3-significant-digit output.
- Only two callers opt out with `{ compact: true }`: the network fee
when paying with a token (`useGasFeeToken`) and swap / bridge
(`formatTokenAmount`).
- The other changed files are tests and one E2E check that expected the
old output.

**Decisions to confirm**

- [ ] `pay-token-amount.tsx` (MetaMask Pay "pay with" amount) and the
dapp-swap quote panel inside confirmations now show up to 8 decimals.
Swap / bridge pages are unchanged.
- [ ] In the pay-fee-with-token list, the fee amount keeps the old
format, but the token balance line (shown only when fiat is off) now
shows up to 8 decimals.
- [ ] The bridge E2E helper's fallback for unpriced tokens
(`getExpectedQuoteTotalCosts`) now uses the new default, while the
bridge UI stays compact. No current spec reaches it, since all mocked
quotes are priced, so it is left unchanged.
- [ ] Permit simulation pills and token-unit rows still cut text at 15
characters, so long amounts of about 10,000 or more get cut there (the
tooltip shows the full value). That limit is unchanged.

## **Changelog**

CHANGELOG entry: Increased the precision of amounts on the send
confirmation and in estimated changes to up to 8 decimals

## **Related issues**

Fixes: CONF-2212

## **Manual testing steps**

1. Run the extension and start a native token send of `1.234567` ETH.
2. Verify the confirmation heading shows `1.234567 ETH`, not `1.235
ETH`.
3. Send an amount with more than 8 decimals (e.g. `1.123456789`). Verify
the heading shows `1.12345679` and hovering it shows `1.123456789`.
4. Send an ERC-20 amount like `1034.123`. Verify the heading shows
`1,034.123`.
5. Open a dapp transaction with estimated changes (e.g. a swap on a
dapp). Verify the amounts show up to 8 decimals, and a tiny non-zero
amount still shows `<0.000001`.
6. On a network with gas fee tokens, pick a token to pay the network
fee. Verify the fee amount keeps the old short format (e.g. `1.235
USDC`).
7. Open Swap / Bridge and get a quote. Verify amounts keep the old short
format.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-0f959a75-c34e-54d5-8a57-e22a81538847?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-0f959a75-c34e-54d5-8a57-e22a81538847&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Widespread display change via shared `formatAmount` affects send and
confirmation UX; incorrect rounding could mislead users, though
bridge/gas fee paths are explicitly kept compact.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d22e17d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Daniel <dan437@users.noreply.github.com>
- Add app/images/frax-native.svg (pure vector, full square background).
PR #44832 removed it as "unused" (it embedded a PNG) while
FRAX_NATIVE_TOKEN_IMAGE_URL still referenced it, so the native icon
failed to load on Fraxtal.
- Use the ETH token icon for Katana's native token in
CHAIN_ID_TOKEN_IMAGE_MAP (Katana's native token is ETH; Mobile and the
static icon service already show it). The Katana network logo is
unchanged.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix native token icons for Fraxtal and Katana

## **Related issues**

Fixes:
https://consensyssoftware.atlassian.net/browse/WPN-2410?atlOrigin=eyJpIjoiN2EwMzI3YTdmMWEyNDkxOWI1ODJhMGMxZTQ4MGI5MmQiLCJwIjoiaiJ9

## **Manual testing steps**

1. On Fraxtal assets list, check that `FRAX` is the native token and
shows with the correct icon.
2. On Katana assets list, check that `ETH` is the native token and shows
with the correct icon.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->



### **After**

<!-- [screenshots/recordings] -->

<img width="300" alt="image"
src="https://github.com/user-attachments/assets/30ca783f-dcc9-4937-92a0-1857a46889e5"
/>
<img width="300" alt="image"
src="https://github.com/user-attachments/assets/2f6e361f-dea3-4099-91c2-3a20ace09425"
/>


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Display-only asset and icon map updates with no logic, auth, or
transaction behavior changes.
> 
> **Overview**
> Fixes broken **Fraxtal** native token artwork by re-adding
`app/images/frax-native.svg`, which `FRAX_NATIVE_TOKEN_IMAGE_URL` still
pointed at after an earlier cleanup removed the file.
> 
> On **Katana**, updates `CHAIN_ID_TOKEN_IMAGE_MAP` so the native token
uses the standard **ETH** icon instead of the Katana network logo,
matching that chain’s native currency is ETH. Katana’s network branding
image is unchanged.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d47c806. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

This PR makes the Activity Details dialog look like a proper modal on
wide viewports while preserving the current full-screen appearance on
narrow sized viewports.

The goal is to serve as reference for future componetization of this
pattern, to be used in wide layouts

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Prepares for full-screen layout work by @amelieyc

## **Manual testing steps**

**Testing on wide viewport (desktop browser):**
1. Build and run the extension in a desktop browser (Chrome/Brave/Edge)
2. Open MetaMask and navigate to the Activity tab
3. Click on any transaction in the activity list to open the details
dialog
4. Verify the dialog appears as a centered modal
5. Click outside the dialog or press Escape to close it

**Testing on narrow viewport (popup/sidepanel):**
1. Open the extension
2. Navigate to the Activity tab
3. Click on any transaction to open the details
4. Verify the dialog appears full-screen (same as before this PR)

## **Screenshots/Recordings**

<!--
I was unable to capture before/after screenshots because the development
build
was not running during PR creation. The build is managed externally per
repo
policy. Visual verification should be performed during review using the
manual
testing steps above.
-->

### **Before**

N/A - No screenshots available (build not running during PR creation)

### **After**

N/A - No screenshots available (build not running during PR creation)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable (existing tests pass, no new
tests needed for styling change)
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable (no new functions added)
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-a5e61e3e-8ab0-5920-af69-0ce80c3b7f50?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-a5e61e3e-8ab0-5920-af69-0ce80c3b7f50&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Responsive styling and dialog UX only; no auth, routing logic, or
data-handling changes beyond existing dialog open/close behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
179ee4f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…_SYSTEM_ACCESS (#47589)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
**Problem**
Some Firefox Selenium E2E test is failing during driver setup with
UnsupportedOperationError: Navigation to "about:debugging#addons" is not
allowed in this context. The cause is GitHub's new Ubuntu 24.04 runner
image (ubuntu24/20261101.360), which upgraded the preinstalled Firefox
from 158.0.1 to 159.0. Firefox 159 removed the
--remote-allow-system-access command-line flag (Firefox bug 2054896).
Our workaround from
[#44946](#44946) and
[#45014](#45014)
relied on that flag, since geckodriver's --allow-system-access just
passes it on to Firefox. Without system access, Firefox blocks
navigation to about:debugging, where we read the extension's internal
ID. The new image is still rolling out, so failures depend on which
image a runner gets, not on branch changes.

**Temp Fix**
Set MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 in the geckodriver service
environment (test/e2e/webdriver/firefox.js). Firefox inherits it when
geckodriver launches it. --allow-system-access stays in place so Firefox
158 and older keep working. I confirmed it locally with Firefox 159.0
and geckodriver 0.36.0: without the variable, Firefox throws the same
error as CI; with it, about:debugging#addons loads.

Eventually migrate to Playwright and use newer versions

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Check ci

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Test-only WebDriver bootstrap change with no production or user-facing
impact.
> 
> **Overview**
> Fixes Firefox Selenium E2E setup on **Firefox 159+** (e.g. new Ubuntu
24.04 CI images), where navigation to `about:debugging#addons` fails
because Mozilla removed the `--remote-allow-system-access` CLI flag that
geckodriver used to pass through via `--allow-system-access`.
> 
> The geckodriver service in `test/e2e/webdriver/firefox.js` now sets
**`MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1`** on the service environment so
Firefox inherits it at launch. **`--allow-system-access`** is unchanged
for **Firefox 153–158**. Comments were updated to document both paths
and link Mozilla bug 2054896.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d8a3ab9. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
sleepytanya
sleepytanya previously approved these changes Nov 13, 2026
This PR updates the change log for 13.57.0.
@metamask-ci

metamask-ci Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor
Builds ready [9e6398d]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43462129100 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +693%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskMaxDuration: +12%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -21%
  • ↑ confirmTx/lcp: +695%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +34%
  • ↓ bridgeUserActions/longTaskTotalDuration: -21%
  • ↓ bridgeUserActions/longTaskMaxDuration: -22%
  • ↓ bridgeUserActions/tbt: -39%
  • ↓ bridgeUserActions/inp: -26%
  • ↓ bridgeUserActions/fcp: -21%
  • ↑ bridgeUserActions/lcp: +683%
  • ↑ bridgeUserActions/cls: +578%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +23%
  • ↑ loadNewAccount/lcp: +1287%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1300%
  • ↑ bridgeUserActions/bridge_load_page: +301%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +122%
  • ↑ bridgeUserActions/bridge_search_token: +33%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +74%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +19%
  • ↑ bridgeUserActions/lcp: +1280%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +75%
  • ↑ startupStandardHome/load: +107%
  • ↑ startupStandardHome/domContentLoaded: +108%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +106%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +104%
  • ↑ startupStandardHome/longTaskMaxDuration: +141%
  • ↑ startupStandardHome/tbt: +127%
  • ↑ startupStandardHome/fcp: +98%
  • ↑ startupStandardHome/lcp: +789%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↓ startupStandardHome/domInteractive: -31%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -17%
  • ↓ startupStandardHome/setupStore: -19%
  • ↓ startupStandardHome/fcp: -25%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · real API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +22%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +36%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +65%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +11%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +35%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -70%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -71%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -31%
  • ↓ onboardingNewWallet/tbt: -91%
  • ↓ onboardingNewWallet/total: -66%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +252 Bytes 0.00%
✅ ui 19.4 MiB -3.6 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -8 Bytes 0.00%
✅ content scripts 3.23 MiB -16 Bytes 0.00%
🚨 unzipped 79.83 MiB +94.58 KiB +0.12%
🚨 zip 23.95 MiB +96.62 KiB +0.40%
🍒 What's in this RC

Cherry-picks (5 commits)
Commit Description
9e6398db34e release: release-changelog/13.57.0 (#47709)
93786b9fdb6 release(runway): cherry-pick fix(shield): make Transaction Shield entry modal close button clickable (#47917)
6f134cc9840 release(runway): cherry-pick feat(money): add origin to Money FTUE analytics (#47844)
b149d6105e4 release(runway): cherry-pick fix(money): align Money FTUE splash with Figma hero and heading (#47768)
6ead231a4b1 Merge pull request #47754 from MetaMask/stable-sync-release-13.57.0

Changelog (94 commits since v13.56.0)
Commit Description
9e6398db34e release: release-changelog/13.57.0 (#47709)
93786b9fdb6 release(runway): cherry-pick fix(shield): make Transaction Shield entry modal close button clickable (#47917)
6f134cc9840 release(runway): cherry-pick feat(money): add origin to Money FTUE analytics (#47844)
b149d6105e4 release(runway): cherry-pick fix(money): align Money FTUE splash with Figma hero and heading (#47768)
2d78e6076c4 release(runway): cherry-pick chore(perps): set the withdraw amount input in Grotzec Hero (#47672)
a52e6c488c8 release: release-changelog/13.57.0 (#47669)
726c7e85605 release(runway): cherry-pick chore(confirmations): set the MM Pay custom amount input in Grotzec Hero (#47679)
93182821534 Merge release/13.56.0 into release/13.57.0
7bd4b42b5c6 fix(bridge): reorder minimum received row and fix quote card tooltip copy (#47642)
019005347d9 chore(bridge): set the amount inputs in Grotzec Hero cp-13.57.0 (#47558)
ef0615cda25 chore(ramps): set the Buy amount input in Grotzec Hero cp-13.57.0 (#47559)
2659ea1b466 feat: send x-mm-service-profile on token search (assets-controllers ^113.2.0) (#47655)
0c56a8482af fix(perps): align outage banner links with mobile (#47617)
8b9678f8ee8 feat: remove bottom nav feature flag and have it show by default (#47206)
5d87f7fd293 fix(perps): force controller REST refresh when Activity refetches (#47643)
ad77086bdba fix(mfa): ask for a new code after too many wrong ones (#47647)
08c65c6e6fa feat: add a HeroAmountInput component for large amount inputs (#47564)
0144e9508f8 feat(confirmations): support Money Account withdrawals to hardware wallet recipients (#47111)
6c87b8d0831 feat(perf): measure initial transaction confirmation readiness (#47293)
de2c30d011a chore(build): update TypeScript baseline to Node 24 (#47496)
7c3f8348f7c chore: Expose polling methods through StaticAssetsController messenger (#47554)
ed14735901b fix(mfa): send no analytics after the flow has ended (#47641)
59895b9b01c feat(money): add first-visit splash for the Money account (#47626)
448dd92679f refactor: extract asset chart body (#47634)
e17de98ec0b chore: bump assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0 (#47609)
1bd70d216fa feat(swaps): show fee rebate banner in Swaps (SWAPS-5293) (#47618)
ed5caa55abf chore: Update outdated browser warnings (#47451)
3cc87004460 build: add @tailwindcss/container-queries plugin (#47631)
904fb444621 test: Run E2E on Chrome 137 (#47453)
216e8631a1e fix(money): keep money keyring transactions externally signed when gas sponsorship is opted out (#47616)
9722c8e458b refactor: move Bridge activity details into co-owned subfolder (#47434)
a22cb9f0291 refactor: move perps components + update codeowners (#47433)
6f684310f75 feat(mfa): add MFA flow analytics events (#47595)
8f2e99aa58d chore(app-components): remove unused imports and locals in ui/components/app (#47612)
324a76305c7 fix(confirmations): stop styling the nickname modal address as disabled (#47593)
a21adcb71db refactor(popup): redirect to swap (#47605)
1b6501c1b82 chore(hooks): remove unused imports in ui/hooks tests (#47613)
f9c92e293b1 chore(asset): remove unused asset type guard and test local (#47611)
d30ae5ae584 chore(shared): remove unused shared lib exports (#47610)
9e3e9ca1ea9 test: fix tests broken by locale copy change in #46148 (#47632)
2b98f8f6343 chore: New Crowdin Translations by GitHub Action cp-13.56.0 (#47484)
adeaf9ad59c fix(content): remove "please" from extension locale strings (batch 1 of 3) (#46148)
6aaf4639e66 bump: @metamask/perps-controller from ^20.1.0 to ^22.1.1 (#47600)
b77ee5026c3 test(e2e): cover send and swap max amount parity (#47386)
d7335cd9767 chore: bump bitcoin-wallet-snap@3.3.0 and tron-wallet-snap@4.3.1 (#47621)
d23a34014d9 bump: @metamask/client-mcp-core to 0.13.1 (#47526)
82ff52fd89e chore: update activity component codeowners (#47432)
2dca406b618 chore: Expose dismissSidePanelMigrationToast through PrefController messenger (#47553)
4b480318725 feat: show more of the recipient address in send (#47533)
f47f2f64a70 test(confirmations): cover deposit_limit in alert metrics (#47580)
387f2acd526 fix(assets): place the token ticker under the token name (#47552)
1752c4c6481 fix: refresh asset list with non-evm accounts (#47590)
c1496eda02d chore: point remaining legal URLs at metamask.com (#47571)
7fef6e229d1 fix(money): round withdraw available balance down to cents (#47569)
137b0234673 feat: add network pill selector component (#47542)
233817031b9 chore(cashtag): exact match symbol or ticker cp-13.56-0 (#47602)
5a5a61f5328 chore: remove MM Poly and MM Sans fonts (#47561)
feb5d41bcf1 test(e2e): add bitcoin assets network filter cases (#47587)
6eab0565af3 chore(swaps): remove unused swaps constant exports (#47578)
bffb9ad7457 refactor(cashtag): revised sidepanel open (#47430)
73f296fae15 chore(selectors): remove unused selector exports (#47579)
6b0ebbb7c7c chore(background): remove unused util helpers (#47577)
75bf2caaeeb chore(contacts): remove unused components barrel (#47576)
47d10cda96f chore(rewards): remove unused onboarding URL constants (#47575)
5e3dff1b280 feat: refactor Money screen for upcoming fullscreen redesign (#47581)
44ba3fefa5b test: enable Firefox 159 WebDriver system access via MOZ_REMOTE_ALLOW_SYSTEM_ACCESS (#47589)
f69352019bd chore(ui): activity details as modal on wide viewport (#47309)
d71a40722a8 fix: restore Frax native token icon and use ETH icon for Katana (#47583)
e231b08b34a feat(confirmations): show up to 8 decimals for send and simulation amounts (#47532)
75494fe0be7 fix: added tron to selectAccountGroupBalanceForEmptyState (#47570)
9089862f300 fix: use toast to handle the failure message when a non-evm transaction return error after user confirm (#47528)
d5e30104ea0 release: Bump main version to 13.57.0 (#47509)
ded204dd6d4 fix(mfa): align the code screen with the design system (#47539)
a98ce528382 test: Sync Feature Flag Registry - 2026-11-03 01:03 UTC (#47563)
81191b192fa chore(swap): remove unused useSwapDefaultToToken hook (#47482)
052debee081 chore(helpers): remove unused ui helper exports (#47518)
060669f8c1f chore: audit follow-redirects, glob, minimatch, and joi audit advisories (#47527)
c924e7ed0ce fix: match onboarding card border radius to modal (#47550)
a548c752306 chore(perps): set the market price in Grotzec Hero cp-13.56.0 (#47503)
64167fa857d chore(ui-utils): remove unused support link exports (#47480)
1c6f8856b17 chore(hooks): remove unused transaction lifecycle helpers (#47478)
072443f4e1d chore(constants): remove unused shared constant exports (#47479)
7acfaa31af4 feat(telemetry): add last-activity signals to sampled state writes (#47455)
85e928ef9d6 chore: Migrate Confirmations-involved legacy API method calls to messengers (#47326)
a3c349a2bcf Merge origin/main into stable-main-13.55.0
cf3309c9491 chore(activity): bump @metamask/client-utils (#47540)
7aa394ec920 chore(assets-controller): bump assets controller to 20.0.2 (#47489)
dc5a15bb4f1 test: fix flaky test Test Snap manageState (#47104)
0df0258addc fix(networks): leave a non-EVM filter when basic functionality is off (#47494)
869b645140b fix(mfa): send users at the wallet pairing limit to support (#47537)
231140969d3 feat(ui): add SideNav component and Storybook story (#47485)
63d44a1bd77 test: Sync Feature Flag Registry - 2026-10-27 01:21 UTC (#47373)
1744cd6791c chore: Migrate Web3Auth-referenced legacy API method calls to messengers (#47298)
0997172ccbe chore(perps): set Perps balance and prices in Grotzec Hero cp-13.56.0 (#47465)

AI Test Plan

Risk Score High Risk Medium Risk Files Changed Commits
47/100 4 6 485 97
Cherry-Pick Scenarios (1)

Medium Risk Scenarios (1)

1. Transaction Shield – Entry modal close behavior

Risk Level: MEDIUM

Why This Matters: Cherry-pick 47917 fixes a broken close button on the Transaction Shield entry modal; if regressed, users can get trapped in a modal and be unable to proceed.

Test Steps:

  1. From Home or a relevant entry point, open the Transaction Shield entry modal (e.g., via the Shield tile/banner or Learn more link).
  2. Click the modal’s top-right close (X) button and verify the modal closes immediately, returning focus to the underlying view without scroll freeze.
  3. Reopen the modal; press Escape and then click the backdrop to close, verifying both interactions work consistently.

Release Scenarios (9)

High Risk Scenarios (4)

1. Transaction Confirmation – Token amounts/units

Risk Level: HIGH

Why This Matters: Confirm screen components changed; incorrect formatting or labeling of token units can cause user confusion and financial mistakes.

Test Steps:

  1. On a test network (e.g., Sepolia), import a known ERC-20 with 6 decimals (e.g., USDC) and start a Send of 1.234567 to another account.
  2. On the confirm screen, verify the primary amount shows exactly 1.234567 with the correct ticker (USDC) and that the fiat equivalent renders without truncation or rounding errors.
  3. Verify gas fee rows show the correct network currency symbol and totals; approve the transaction and confirm the Activity detail reflects the same precise amount and units.

2. App initialization and Unlock flow

Risk Level: HIGH

Why This Matters: AppState/Preferences/Transaction-Pay controller init paths changed; startup regressions can block all wallet use.

Test Steps:

  1. Lock the wallet, close all extension popups, fully restart the browser.
  2. Open MetaMask from the toolbar and verify the unlock screen appears promptly without blank/white screens or error banners.
  3. Unlock and confirm Home loads with balances; reload the extension (via extensions manager) and ensure it reinitializes cleanly without losing session or showing errors.

3. Transaction Confirmation – ETH send accuracy

Risk Level: HIGH

Why This Matters: Core send flow relies on shared confirmation UI; recent UI and controller updates can cause miscalculation or display regressions.

Test Steps:

  1. On a test network, initiate a plain ETH transfer to another account and open the confirm screen.
  2. Adjust gas settings, then verify recipient address (checksum), network name, and Total (amount + gas) are correct and update as gas is changed.
  3. Submit and confirm Activity shows the same values; ensure Speed up and Cancel options behave as expected without UI errors.

4. Security & privacy – Basic functionality preference

Risk Level: HIGH

Why This Matters: Preferences controller changes can break consolidated behavior; incorrect gating could expose or hide assets unexpectedly.

Test Steps:

  1. Go to Settings → Security & privacy and turn Basic functionality off.
  2. Visit the NFTs tab and confirm the off-state message is shown and a control to open Privacy settings is present; receive a test NFT and verify it is not auto-detected while Basic functionality is off.
  3. Turn Basic functionality on; revisit NFTs and Tokens to verify normal UI returns and that new incoming assets are detected or detection banners behave as expected.

Medium Risk Scenarios (5)

1. Static Assets – Token and network icons

Risk Level: MEDIUM

Why This Matters: StaticAssetsController changes can impact asset/logo fetching and caching; broken images degrade trust and usability.

Test Steps:

  1. On Mainnet, open the Tokens list and verify popular token icons (ETH, USDC, WBTC) render correctly without broken images.
  2. Add or switch to a custom network lacking a known icon and verify a fallback avatar/identicon is shown (no broken image or layout shift).
  3. Temporarily go offline, reopen the wallet, and ensure icons gracefully fallback/cached placeholders render without freezing the UI.

2. Assets List – Control bar (search/filter)

Risk Level: MEDIUM

Why This Matters: This component saw significant updates; broken filtering or focus management confuses users and obscures assets.

Test Steps:

  1. In Home → Tokens, use the search bar to filter by symbol (e.g., “USDC”) and full name; verify instant filtering and that clearing input resets the list.
  2. Toggle any available filters (e.g., hide small balances) or sorting and verify counts and order update correctly without flicker.
  3. Use keyboard: focus search, type, press Escape or use the clear control and confirm expected behavior without focus loss bugs.

3. Navigation – Bottom nav bar

Risk Level: MEDIUM

Why This Matters: Refactors in navigation can introduce routing state bugs that strand users in the wrong view.

Test Steps:

  1. Switch between Home, Explore, and Portfolio/Activity via the bottom nav and verify the selected state updates correctly.
  2. Lock and unlock the wallet; confirm the nav returns to the correct section or the intended default without misrouting.
  3. Trigger a dapp confirmation and close it; verify the bottom nav selection and routing remain consistent.

4. Money – FTUE splash and account balance

Risk Level: MEDIUM

Why This Matters: Multiple Money components changed; layout/visibility issues on FTUE or balances directly impact first-time use and trust.

Test Steps:

  1. If available in your region, open Money from the app entry point and verify the FTUE splash displays the correct hero and heading; continue into Money.
  2. Confirm the Money account balance renders without errors and updates after refreshing the view.
  3. Switch the app language (e.g., to German) and revisit Money screens; verify headings and labels do not overflow or break layout.

5. Dapp prompts – Hyperliquid deposit prompt gating

Risk Level: MEDIUM

Why This Matters: Prompt logic changes can surface irrelevant or sticky modals, interrupting normal dapp use.

Test Steps:

  1. Connect to a common unrelated dapp (e.g., a DEX) and verify no Hyperliquid-specific deposit prompt appears.
  2. Navigate to the Hyperliquid app (if accessible) and connect; verify the deposit prompt appears appropriately and can be dismissed without trapping focus.
  3. Change networks to an unsupported one and confirm the prompt hides or updates correctly.

Teams Sign-off Status

Signed off: None yet

Awaiting sign-off (7):
Accounts, Assets, Confirmations, Networks, Security, Transactions, Wallet Integrations


Generated by AI Test Plan Analyzer (gpt-5) at 2026-11-13T16:45:50.489Z

AI generated test plan (JSON): test-plan-13.57.0.json

@runway-github
runway-github Bot deployed to release-branch November 13, 2026 17:45 Active
@sleepytanya
sleepytanya marked this pull request as draft November 13, 2026 18:54
@sleepytanya
sleepytanya marked this pull request as ready for review November 16, 2026 04:45
@sleepytanya
sleepytanya merged commit 8f83e78 into stable Nov 16, 2026
276 of 282 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026

This branch had an error being deployed

2 failed, 4 active, and 1 inactive deployments
segment-schema — 9e6398db Deployed Nov 16, 2026 by sleepytanya via propose #3182
release-branch — 9e6398db Deployed Nov 13, 2026 by runway-github[bot] via Phase 1 — publish release / Publish release #26
pr-comment — 9e6398db Deployed Nov 13, 2026 by HowardBraham via Publish prerelease / Publish prerelease #174643
release-ci — 9e6398db Deployed Nov 13, 2026 by HowardBraham via Publish prerelease / Generate AI test plan #174643
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.