Repository navigation
chore(shared): remove unused shared lib exports - #47610
Merged
georgewrmarshall merged 1 commit intoNov 5, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 4, 2026 09:28 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
November 4, 2026 09:44 — with
GitHub Actions
Inactive
Contributor
Builds ready [ac5fcc5]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
amandaye0h
approved these changes
Nov 4, 2026
AndyMBridges
approved these changes
Nov 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-shared-lib-20261104
branch
November 5, 2026 04:22
Contributor
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes five exported helpers and constants in
shared/libthat nothing in the repo imports.shared/lib/translate.tskeepsupdateCurrentLocaleandt; only its unusedgetCurrentLocalegetter goes (the Redux selector of the same name inui/ducks/locale/locale.tsis a separate, live function). The otherREDEEM_DELEGATIONS_SELECTORhits in the repo are separate local constants inui/pages/confirmations/utils/confirm.tsand an e2e spec; they are untouched.Owner set: none (no CODEOWNERS match for any touched file).
shared/lib/translate.tsgetCurrentLocaleshared/lib/conversion.utils.tsgetEthConversionFromWeiHexshared/lib/delegation/utils.tsisHexEqualshared/lib/delegation/delegation.tsREDEEM_DELEGATIONS_SELECTORshared/lib/shield/constants.tsSHIELD_CAROUSEL_IDEvery removed item was proven with a whole-repo whole-word search (only the definition matched), checked against the diffs of all open PRs (none reference these names or edit these files), and is older than the 60-day waiting window. No user-facing behavior change.
Checks passed:
yarn lint:tsc, eslint on the touched files,yarn test:unitfor the touched directories with no snapshot updates, andtsc --noUnusedLocalsshows no remaining unused locals in the touched files.Docs/comments updated: none
Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unreachable code only; no runtime paths or public API consumers are affected.
Overview
Removes five unused exports from
shared/libafter repo-wide verification that nothing imports them. No call sites or behavior change.Deleted symbols:
getEthConversionFromWeiHex(conversion.utils.ts),isHexEqual(delegation/utils.ts),REDEEM_DELEGATIONS_SELECTOR(delegation/delegation.ts— separate local constants elsewhere stay),SHIELD_CAROUSEL_ID(shield/constants.ts), andgetCurrentLocalefromtranslate.ts(UI still uses the Redux selector inui/ducks/locale/locale.ts).Reviewed by Cursor Bugbot for commit ac5fcc5. Bugbot is set up for automated code reviews on this repo. Configure here.