Skip to content

fix(perps): keep the chart time axis off the trade buttons - #47505

Merged
georgewrmarshall merged 2 commits into
chore/grotzec-hero-perps-market-detailfrom
chore/grotzec-hero-perps-e2e-fix
Nov 2, 2026
Merged

georgewrmarshall merged 2 commits into
chore/grotzec-hero-perps-market-detailfrom
chore/grotzec-hero-perps-e2e-fix

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Chrome e2e on the Grotzec Hero price change failed in perps-position-lifecycle.spec.ts and perps-geo-block.spec.ts. Two separate bugs.

What was going wrong

The CI screenshots were the error page, not a layout with a missing button. The chart threw Cannot update oldest data, React Router replaced the market page, and the Long/Short wait then timed out. The AVAX live-candle mock set its open time when the file loaded (Date.now() - 5m). History bars are built when the request arrives, so that live candle was older than the last bar and series.update() threw.

After the candle time was corrected, the page stayed up. The screenshot showed Close long still there, and the test was waiting for Long to come back. Logging the intercepted click named the element on top: a 680×28 canvas, position: absolute; z-index: 2, which is the lightweight-charts time axis. AmountDisplayLg makes the price row tall enough that this canvas overlaps the sticky footer in CI's window. The footer has no z-index, and position: relative does not create a stacking context, so the canvas received the click. The click retry scrolled the button away from the footer, the close update was missed, and Long never returned.

The fix

isolation: isolate on the chart wrapper keeps that z-index inside the chart. The footer comes later in the tree and paints above it, so the trade buttons receive the click.

The candle mock builds t and T when the test subscribes, with t set to that moment, so the live candle is newer than the history. Chrome e2e passed after both changes.

Changelog

CHANGELOG entry: Fixed the perpetuals chart time axis covering the trade buttons.

Related issues

Fixes the Chrome e2e failures on #47503.

Manual testing steps

  1. Run the extension and open Perps.
  2. Open the Avalanche market with no position.
  3. Confirm Long and Short are clickable and are not covered by the chart time axis.
  4. Open a position and confirm Modify and Close are clickable the same way.
  5. Hover the volume bars under the candles and confirm the volume label still appears on the right edge of the chart.

Screenshots/Recordings

The chart drawing is unchanged. Where the chart meets the sticky footer, the time axis no longer receives the click.

Before

The time axis received clicks meant for Long, Short, and Close.

After

Those buttons receive the clicks.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small CSS stacking-context change on the chart container and e2e mock timing only; no production trading or auth logic changes.

Overview
Fixes Perps market detail where the lightweight-charts time-axis canvas could sit above the sticky Long / Short / Close footer and steal clicks when the chart overlaps that area in smaller viewports. The chart wrapper now uses isolation: isolate so internal canvas stacking stays below the footer.

Also fixes Chrome e2e failures on AVAX flows: the Hyperliquid candle subscribe mock no longer uses candle open/close times frozen at module load. It switches to dynamicFollowUp so t / T are set at subscribe time, keeping the live candle newer than candleSnapshot history and avoiding series.update() “Cannot update oldest data” crashes that disabled close-position flows.

Reviewed by Cursor Bugbot for commit 1414708. Bugbot is set up for automated code reviews on this repo. Configure here.

@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner October 29, 2026 18:41
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Oct 29, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Oct 29, 2026
@metamask-ci

metamask-ci Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (2 files, +22 -14)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 perps/
          • 📁 mocks/
            • 📄 websocketDefaultMocks.ts +20 -14
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 perps/
          • 📁 perps-candlestick-chart/
            • 📄 perps-candlestick-chart.tsx +2 -0

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [21f4430] [reused from 0eed673]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40933120210 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +413%
  • ↑ loadNewAccount/total: +413%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -31%
  • ↓ loadNewAccount/lcp: -19%
  • ↑ confirmTx/longTaskTotalDuration: +12%
  • ↑ confirmTx/longTaskMaxDuration: +46%
  • ↑ confirmTx/tbt: +20%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -24%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +65%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +30%
  • ↓ bridgeUserActions/longTaskMaxDuration: -27%
  • ↓ bridgeUserActions/tbt: -32%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -28%
  • ↓ bridgeUserActions/lcp: -16%
  • ↑ loadNewAccount/load_new_account: +429%
  • ↑ loadNewAccount/total: +429%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1325%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -42%
  • ↑ confirmTx/lcp: +1434%
  • ↑ bridgeUserActions/bridge_load_page: +274%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +97%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +53%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1248%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -24%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -25%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -26%
  • ↑ startupStandardHome/setupStore: +44%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -34%
  • ↓ startupStandardHome/longTaskMaxDuration: -31%
  • ↓ startupStandardHome/tbt: -35%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -24%
  • ↓ startupStandardHome/domInteractive: -31%
  • ↑ startupStandardHome/backgroundConnect: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +158%
  • ↓ startupStandardHome/fcp: -26%
  • ↑ startupStandardHome/lcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -25%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -29%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -42%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +104 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +239 Bytes 0.00%
✅ zip 24.06 MiB +127 Bytes 0.00%

@georgewrmarshall
georgewrmarshall changed the base branch from chore/grotzec-hero-perps to chore/grotzec-hero-perps-market-detail October 29, 2026 19:03
@georgewrmarshall
georgewrmarshall force-pushed the chore/grotzec-hero-perps-e2e-fix branch from 21f4430 to b1c50ee Compare October 29, 2026 21:17
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b1c50ee]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40956508908 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -11%
  • ↑ confirmTx/longTaskTotalDuration: +18%
  • ↑ confirmTx/longTaskMaxDuration: +32%
  • ↑ confirmTx/tbt: +31%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -22%
  • ↑ bridgeUserActions/bridge_load_page: +21%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +62%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +37%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↑ bridgeUserActions/tbt: +11%
  • ↓ bridgeUserActions/fcp: -23%
  • ↓ bridgeUserActions/lcp: -15%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1276%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1367%
  • ↑ bridgeUserActions/bridge_load_page: +362%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +83%
  • ↑ bridgeUserActions/bridge_search_token: +43%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +80%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1268%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +165%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -15%
  • ↓ startupStandardHome/longTaskMaxDuration: -10%
  • ↓ startupStandardHome/tbt: -10%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↑ startupStandardHome/backgroundConnect: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +169%
  • ↑ startupStandardHome/fcp: +13%
  • ↑ startupStandardHome/lcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +49%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +43%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +49%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +28%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -31%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +71 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +206 Bytes 0.00%
✅ zip 24.06 MiB +69 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1cf2526] [reused from b1c50ee]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40961476152 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -11%
  • ↑ confirmTx/longTaskTotalDuration: +18%
  • ↑ confirmTx/longTaskMaxDuration: +32%
  • ↑ confirmTx/tbt: +31%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -22%
  • ↑ bridgeUserActions/bridge_load_page: +21%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +62%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +37%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↑ bridgeUserActions/tbt: +11%
  • ↓ bridgeUserActions/fcp: -23%
  • ↓ bridgeUserActions/lcp: -15%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1276%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1367%
  • ↑ bridgeUserActions/bridge_load_page: +362%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +83%
  • ↑ bridgeUserActions/bridge_search_token: +43%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +80%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1268%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +165%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -15%
  • ↓ startupStandardHome/longTaskMaxDuration: -10%
  • ↓ startupStandardHome/tbt: -10%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↑ startupStandardHome/backgroundConnect: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +169%
  • ↑ startupStandardHome/fcp: +13%
  • ↑ startupStandardHome/lcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +49%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +43%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +49%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +28%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -31%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +71 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +206 Bytes 0.00%
✅ zip 24.06 MiB +69 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b1c50ee]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40965599182 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -11%
  • ↑ confirmTx/longTaskTotalDuration: +18%
  • ↑ confirmTx/longTaskMaxDuration: +32%
  • ↑ confirmTx/tbt: +31%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -22%
  • ↑ bridgeUserActions/bridge_load_page: +21%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +62%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +37%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↑ bridgeUserActions/tbt: +11%
  • ↓ bridgeUserActions/fcp: -23%
  • ↓ bridgeUserActions/lcp: -15%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/fcp: -36%
  • ↑ loadNewAccount/lcp: +1276%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1367%
  • ↑ bridgeUserActions/bridge_load_page: +362%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +83%
  • ↑ bridgeUserActions/bridge_search_token: +43%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +80%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1268%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +165%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -15%
  • ↓ startupStandardHome/longTaskMaxDuration: -10%
  • ↓ startupStandardHome/tbt: -10%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↑ startupStandardHome/backgroundConnect: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +169%
  • ↑ startupStandardHome/fcp: +13%
  • ↑ startupStandardHome/lcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +49%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +43%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +49%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +28%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -31%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +71 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +206 Bytes 0.00%
✅ zip 24.06 MiB +69 Bytes 0.00%

@georgewrmarshall georgewrmarshall changed the title test(perps): build AVAX live candle at subscription time to fix e2e chart crash fix(perps): keep the chart time axis off the trade buttons Nov 2, 2026
georgewrmarshall and others added 2 commits November 2, 2026 14:02
The open time was captured when the mock module loaded, so it was older than the history bars and lightweight-charts crashed the market page.

Co-authored-by: Cursor <cursoragent@cursor.com>
The time-axis canvas uses z-index 2, and the chart wrapper did not create a stacking context, so the canvas received clicks meant for the sticky trade buttons.

Co-authored-by: Cursor <cursoragent@cursor.com>
style={{
position: 'relative',
// Confines the chart canvas z-index so it cannot paint over the sticky footer.
isolation: 'isolate',

@georgewrmarshall georgewrmarshall Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what made the Long, Short, and Close clicks fail in Chrome e2e once the page stopped crashing. Lightweight Charts draws the time axis on a canvas with position:absolute and z-index:2. The wrapper is only position:relative, which does not create a stacking context, so that canvas was compared with the sticky footer and received the click. isolation:isolate resolves the chart z-index inside the chart, and the footer then paints above it because it comes later in the tree. A higher z-index on the footer would also work, but it would have to stay above every chart layer.

https://www.joshwcomeau.com/css/stacking-contexts/#airtight-abstractions-with-isolation-6

Image

return {
channel: 'candle',
data: {
t: now,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what crashed the AVAX market page before the buttons could be clicked. The history mocks place their newest bar at request time minus 5 minutes, so an open time captured when this module loads is older than that bar. lightweight-charts then throws "Cannot update oldest data" and the error boundary replaces the page, which is the timeout on perps-long-cta-button in Chrome e2e. t is the subscription time, and T is one millisecond short of a 5 minute bar, matching the interval the chart requests.

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1414708]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41524723207 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +412%
  • ↑ loadNewAccount/total: +412%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskMaxDuration: +18%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -32%
  • ↓ confirmTx/lcp: -20%
  • ↑ bridgeUserActions/bridge_load_page: +12%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -24%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -13%
  • ↓ bridgeUserActions/longTaskMaxDuration: -28%
  • ↓ bridgeUserActions/tbt: -59%
  • ↓ bridgeUserActions/total: -11%
  • ↓ bridgeUserActions/inp: -23%
  • ↓ bridgeUserActions/fcp: -32%
  • ↓ bridgeUserActions/lcp: -18%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +25%
  • ↑ loadNewAccount/lcp: +1366%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +27%
  • ↑ confirmTx/lcp: +1411%
  • ↑ bridgeUserActions/bridge_load_page: +312%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +179%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +71%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1292%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.6s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +120%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -15%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +37%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +17%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -64%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +91 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +226 Bytes 0.00%
✅ zip 24.07 MiB +85 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall merged commit 1414708 into main Nov 2, 2026
296 of 305 checks passed
@georgewrmarshall
georgewrmarshall deleted the chore/grotzec-hero-perps-e2e-fix branch November 2, 2026 22:40
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
stacked auto-merge was automatically disabled November 2, 2026 23:59

Pull request removed from stack

This branch had an error being deployed

1 failed and 1 inactive deployments
segment-schema — 1414708d Deployed Nov 2, 2026 by georgewrmarshall via propose #2356
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants