Repository navigation
chore(perps): set the market price in Grotzec Hero cp-13.56.0 - #47503
Conversation
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (3 files, +25 -16)
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [662803a]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)
Bundle Size Diffs
|
662803a to
3675c24
Compare
Builds ready [3675c24]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue. You can view the agent here.
Reviewed by Cursor Bugbot for commit b554351. Configure here.
Builds ready [b554351]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs
|
Builds ready [5aed8c7]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs
|
Builds ready [2629163] [reused from 3675c24]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs
|
2629163 to
fbd4d1a
Compare
Builds ready [fbd4d1a]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)
Bundle Size Diffs
|
| n: 10, | ||
| }, | ||
| }; | ||
| }, |
| position: 'relative', | ||
| // Confines the chart canvas z-index so it cannot paint over the sticky footer. | ||
| isolation: 'isolate', | ||
| width: '100%', |
Co-authored-by: Cursor <cursoragent@cursor.com>
AmountDisplayMd is not a TextVariant, so the typecheck failed. DisplayMd is the existing size between HeadingLg and AmountDisplayLg. Co-authored-by: Cursor <cursoragent@cursor.com>
The open time was captured when the mock module loaded, so it was older than the history bars and lightweight-charts crashed the market page. Co-authored-by: Cursor <cursoragent@cursor.com>
The time-axis canvas uses z-index 2, and the chart wrapper did not create a stacking context, so the canvas received clicks meant for the sticky trade buttons. Co-authored-by: Cursor <cursoragent@cursor.com>
1414708 to
ddd4bec
Compare
Builds ready [ddd4bec] [reused from 1414708]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
Auto-merge was disabled for another pull request in the stack
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |




Description
Sets the Perps market price to
AmountDisplayLgwith the Hero typeface for cp-13.56.0. Onlyperps-market-detail-page.tsxchanges.That type is tall enough to fail Chrome e2e. The chart time-axis canvas (
z-index: 2) overlaps the sticky Long, Short, and Close buttons, and a stale AVAX candle mock crashes the page withCannot update oldest data. Both fixes are in #47505, stacked on this branch so this PR still shows the failing jobs. Merge #47505 here first, then merge this to main.Changelog
CHANGELOG entry: Updated the perpetuals market price to the larger Hero type.
Related issues
Related: #47505
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Visual typography and CSS stacking-context changes plus test mock timing; no trading, auth, or persistence logic touched.
Overview
Updates the perps market detail scrollable price row to
AmountDisplayLgwithFontFamily.Heroinstead of heading bold styling, matching the cp-13.56.0 Grotzec spec.Because the larger type and chart layout exposed stacking issues, the PR also adds
isolation: isolateon the candlestick chart wrapper so the time-axis canvas cannot paint above the sticky Long/Short/Close footer, and switches the Hyperliquid candle subscribe e2e mock from a static follow-up todynamicFollowUpthat sets candle timestamps at subscribe time—avoiding lightweight-charts “Cannot update oldest data” and keepingchartCurrentPricevalid for close-position flows in Chrome e2e.Reviewed by Cursor Bugbot for commit ddd4bec. Bugbot is set up for automated code reviews on this repo. Configure here.