Skip to content

chore(activity): bump @metamask/client-utils - #47540

Merged
n3ps merged 4 commits into
mainfrom
fix/bump-client-utils-46341
Nov 2, 2026
Merged

n3ps merged 4 commits into
mainfrom
fix/bump-client-utils-46341

Conversation

@n3ps

@n3ps n3ps commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/client-utils aligning it with mobile

Changelog

CHANGELOG entry: null

Related issues

Fixes: #46341

Manual testing steps

  1. Load the extension from this branch.
  2. Send an ERC-721 NFT to another account; open Activity and confirm quantity shows 1 (not 0) after the indexed row appears.
  3. Repeat with an ERC-1155 send (quantity 1).
  4. Optional: use a fresh profile or another browser with only indexed history and confirm NFT send quantity is still correct.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Dependency major bump touches activity/NFT formatting paths via client-utils and expands LavaMoat allowances (including fetch) for nested controller-utils; regression risk is mainly in Activity display and build-time policy enforcement.

Reviewed by Cursor Bugbot for commit d233195. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 2, 2026
@n3ps n3ps changed the title fix(activity): bump @metamask/client-utils for NFT send quantity chore(activity): bump @metamask/client-utils Nov 2, 2026
@socket-security

socket-security Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​client-utils@​2.0.2 ⏵ 3.1.0991007898 +1100

View full report

@n3ps
n3ps requested a review from a team November 2, 2026 15:15
@n3ps
n3ps marked this pull request as ready for review November 2, 2026 15:15
Fixes NFT send activity showing quantity 0 once indexed API rows replace local items.

Co-authored-by: Cursor <cursoragent@cursor.com>
@n3ps
n3ps force-pushed the fix/bump-client-utils-46341 branch from 95326af to b9545c7 Compare November 2, 2026 15:22
client-utils 3.x is ESM-only; LavaMoat must allow @metamask/client-utils>@metamask/* paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
@n3ps
n3ps requested a review from a team as a code owner November 2, 2026 15:35
@metamask-ci

metamask-ci Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +152 -16)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +19 -2
        • 📁 experimental/
          • 📄 policy.json +19 -2
        • 📁 flask/
          • 📄 policy.json +19 -2
        • 📁 main/
          • 📄 policy.json +19 -2
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +19 -2
        • 📁 experimental/
          • 📄 policy.json +19 -2
        • 📁 flask/
          • 📄 policy.json +19 -2
        • 📁 main/
          • 📄 policy.json +19 -2

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [60308a1]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41473124864 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +713 Bytes 0.00%
🚨 ui 19.33 MiB +47.96 KiB +0.24%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +588 Bytes +0.01%
🚨 content scripts 3.23 MiB +1.14 KiB +0.03%
🚨 unzipped 79.89 MiB +50.75 KiB +0.06%
🚨 zip 24.07 MiB +10.42 KiB +0.04%

Webpack resolves some client-utils imports as @metamask/utils and others as nested paths; allow both.

Co-authored-by: Cursor <cursoragent@cursor.com>
Run webpack:lavamoat:policy for MV2/MV3 so ESM client-utils imports match CI validation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d233195]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41479354845 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/confirm_tx: +10%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +110%
  • ↑ confirmTx/tbt: +133%
  • ↑ confirmTx/total: +10%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +20%
  • ↑ confirmTx/cls: +10%
  • ↑ bridgeUserActions/bridge_load_page: +120%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +156%
  • ↑ bridgeUserActions/longTaskMaxDuration: +37%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/total: +28%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/lcp: +17%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↑ loadNewAccount/inp: +105%
  • ↓ loadNewAccount/fcp: -66%
  • ↑ loadNewAccount/lcp: +945%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +1083%
  • ↑ bridgeUserActions/bridge_load_page: +151%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +90%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +21%
  • ↓ bridgeUserActions/fcp: -62%
  • ↑ bridgeUserActions/lcp: +855%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 loadNewAccount/INP: p75 216ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +15%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +11%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +135%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +13%
  • ↑ startupStandardHome/fcp: +10%
  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↑ startupStandardHome/fcp: +18%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +46%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +34%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +38%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +174%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +36%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -51%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +640 Bytes 0.00%
🚨 ui 19.33 MiB +47.89 KiB +0.24%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +515 Bytes +0.01%
🚨 content scripts 3.23 MiB +1020 Bytes +0.03%
🚨 unzipped 79.89 MiB +50.39 KiB +0.06%
🚨 zip 24.07 MiB +10.35 KiB +0.04%

@n3ps
n3ps enabled auto-merge November 2, 2026 17:35

@MajorLift MajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grants Buffer.from, fetch, setTimeout but for internal packages only

@n3ps
n3ps added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit cf3309c Nov 2, 2026
261 of 265 checks passed
@n3ps
n3ps deleted the fix/bump-client-utils-46341 branch November 2, 2026 18:12
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — d2331951 Deployed Nov 2, 2026 by n3ps via Publish prerelease / Publish prerelease #172192
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Send NFT displays 0 quantity in Activity

6 participants