Repository navigation
bump: @metamask/client-mcp-core to 0.13.1 - #47526
Conversation
- daemon: no KnowledgeStore / setKnowledgeStore; createServer no longer gets a knowledgeStore option. - metamask-provider: write session.json with writeSessionMetadata from @metamask/client-mcp-core to <artifactsDir>/<sessionId>/session.json, where artifactsDir is the workflow context's config.artifactsDir (falls back to 'test-artifacts'). Launch still fails if the write fails. - Session metadata no longer has goal or flowTags. - Tests: mock writeSessionMetadata and cover dir/metadata/failure; drop knowledge_* tools from the registry test; legacy-mode test uses get_context. - Docs: remove knowledge store commands from the llm-workflow README and the knowledge-search step from AGENTS.md.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…ient-mcp-core-0.13.0 # Conflicts: # yarn.lock
Builds ready [620e474]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
gauthierpetetin
left a comment
There was a problem hiding this comment.
lgtm on behalf of @MetaMask/extension-security-team
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |



Description
Bumps
@metamask/client-mcp-corefrom 0.12.0 to 0.13.1 (release PRs #80 and #82). 0.13.0 was not published, because its CI failed on Node 26. 0.13.1 only pins Node in CI, so its code is the same as 0.13.0. This also bumps the transitive@metamask/device-mcpdependency from 0.4.2 to 0.7.0, the latest version.0.13.0 removes the knowledge store (client-mcp-core#60). Without the first commit, the
mmdaemon does not compile, becausedaemon.tsandmetamask-provider.tsimportKnowledgeStore,setKnowledgeStoreandknowledgeStore.daemon.tsKnowledgeStoreand passes it tocreateServermetamask-provider.tsknowledgeStore.writeSessionMetadata()totest-artifacts/llm-knowledge/<id>/session.jsonwriteSessionMetadata(artifactsDir, …)totest-artifacts/<id>/session.json. Launch still fails if the write failsgoalandflowTagstagsis keptmm knowledge-*,mm launch --goal / --flow-tagsunknown command/unknown launch flagwarningAGENTS.md, llm-workflowREADME.mdmm knowledge-searchfirstOther 0.13.x changes that agents will notice (no Extension code change needed):
--observe none|diff|fullflag. Only mutating commands andrun-stepsreturn observations by default, and observations have no app state (usemm get-state).--pretty/MM_PRETTY=1to indent), andmeta.timingon every response.run-stepstakesobserveinstead ofincludeObservations.The
visual-testingskill is updated for these changes in MetaMask/skills#210.Commits:
chore(llm-workflow): drop the knowledge store: the consumer migration, with tests.bump: @metamask/client-mcp-core to 0.13.0 and @metamask/device-mcp to 0.7.0:package.jsonandyarn.lock.bump: @metamask/client-mcp-core to 0.13.1: the published version, with itsyarn.lockchecksum.No LavaMoat policy changes: both packages are dev-only and are not in the webpack bundle. Neither package has install scripts.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Related: MetaMask/client-mcp-core#80
Manual testing steps
yarn build:test), or reuse an existingdist/chrometest build.yarn mm launch. Verify that the wallet opens on the unlock screen and thattest-artifacts/<sessionId>/session.jsonis created.yarn mm type --testid unlock-password "correct horse battery staple" --observe none. Verify that the response has noobservationsand hasmeta.timing.yarn mm click --testid unlock-submit. Verify that the response hasobservationswithtestIdsanda11y, and nostate.yarn mm get-state. VerifyisUnlocked: trueandcurrentScreen: "home".yarn mm knowledge-last. VerifyError: unknown command 'knowledge-last'.yarn mm cleanup --shutdown.Local validation with 0.13.1 from npm (headless, test build from this branch)
yarn install --immutablepasses.yarn jest test/e2e/playwright/llm-workflow: 12 suites, 144 tests passed.tsc: no errors intest/e2e/playwright/llm-workflow.yarn build:testfrom this branch, then a scriptedyarn mmrun (MM_HEADLESS=true). Every check below passed. Three first-run failures were mistakes in the test script, not in the CLI. One ran the knowledge commands with no daemon running. Two triggered a change big enough that the CLI correctly returned a full observation instead of a diff. I fixed the script and re-ran those checks.mm --helphas noknowledge-*,--goalor--flow-tagsknowledge-search/last/sessions/summarizewith a daemon runningunknown command, exit 1launch --goal x --flow-tags sendunknown launch flag; launch succeedssession.jsontest-artifacts/<id>/session.json; keysschemaVersion, sessionId, createdAt, tags, launch; nollm-knowledge/dirdescribe-screenpriorKnowledge; browser nodes havepath--observe--observe requires one of: none, diff, full, exit 1type --observe noneobservations;observationMs: 0click(defaultdiff)observationswithtestIds+a11y, nostateget-state/cdp(defaultnone)observationsget-state --observe fulldiff{"added":["e18"],"removed":[],"unchanged":17}; only the new node returned--observe nonekeeps the baseline--pretty/MM_PRETTY=1meta.timinglaunch, tools andcleanuprun-stepsincludeObservationsincludeObservations was removed; use observebatchTimeoutMs: 60000expected number to be <=30000observe: "none"/ defaultbatchTimeoutMs: 1000with a slow stepskipped: 2)Click timed out, no late clickobservationMs: 659) and includes the animated elementscreenshot,navigate-home,cleanup --shutdownPre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Dev-only E2E/agent CLI wiring and documentation; no extension runtime, auth, or user wallet code changes.
Overview
Upgrades
@metamask/client-mcp-coreto 0.13.1 (and@metamask/device-mcpto 0.7.0) so the Playwrightmmdaemon matches core 0.13.x, which removes the knowledge store and related CLI commands.The extension-side migration stops wiring
KnowledgeStoreintocreateServerindaemon.tsandMetaMaskSessionManagernow callswriteSessionMetadata(artifactsDir, …)instead of the old singleton. Sessionsession.jsonis written undertest-artifacts/<sessionId>/(or workflowartifactsDir), withgoal/flowTagsdropped from metadata whiletagsremains; launch still fails if metadata cannot be written.Agent docs (
AGENTS.md,llm-workflow/README.md) no longer tell agents to runmm knowledge-*before visual flows. Integration and provider tests dropknowledge_*tools from expectations and add coverage for the new metadata path and failure behavior.Reviewed by Cursor Bugbot for commit 620e474. Bugbot is set up for automated code reviews on this repo. Configure here.