Skip to content

bump: @metamask/client-mcp-core to 0.13.1 - #47526

Merged
cryptotavares merged 4 commits into
mainfrom
cryptotavares/bump-client-mcp-core-0.13.0
Nov 4, 2026
Merged

cryptotavares merged 4 commits into
mainfrom
cryptotavares/bump-client-mcp-core-0.13.0

Conversation

@cryptotavares

@cryptotavares cryptotavares commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/client-mcp-core from 0.12.0 to 0.13.1 (release PRs #80 and #82). 0.13.0 was not published, because its CI failed on Node 26. 0.13.1 only pins Node in CI, so its code is the same as 0.13.0. This also bumps the transitive @metamask/device-mcp dependency from 0.4.2 to 0.7.0, the latest version.

0.13.0 removes the knowledge store (client-mcp-core#60). Without the first commit, the mm daemon does not compile, because daemon.ts and metamask-provider.ts import KnowledgeStore, setKnowledgeStore and knowledgeStore.

Area Before After
daemon.ts Creates a KnowledgeStore and passes it to createServer No knowledge store
metamask-provider.ts knowledgeStore.writeSessionMetadata() to test-artifacts/llm-knowledge/<id>/session.json writeSessionMetadata(artifactsDir, …) to test-artifacts/<id>/session.json. Launch still fails if the write fails
Session metadata Has goal and flowTags Those fields are removed; tags is kept
mm knowledge-*, mm launch --goal / --flow-tags Supported Removed in core: unknown command / unknown launch flag warning
AGENTS.md, llm-workflow README.md Tell agents to run mm knowledge-search first That step is removed

Other 0.13.x changes that agents will notice (no Extension code change needed):

  • Global --observe none|diff|full flag. Only mutating commands and run-steps return observations by default, and observations have no app state (use mm get-state).
  • One-line JSON output when stdout is not a terminal (--pretty / MM_PRETTY=1 to indent), and meta.timing on every response.
  • run-steps takes observe instead of includeObservations.
  • Timed-out calls are cancelled, and each Extension ref resolves to exactly one element.

The visual-testing skill is updated for these changes in MetaMask/skills#210.

Commits:

  1. chore(llm-workflow): drop the knowledge store: the consumer migration, with tests.
  2. bump: @metamask/client-mcp-core to 0.13.0 and @metamask/device-mcp to 0.7.0: package.json and yarn.lock.
  3. bump: @metamask/client-mcp-core to 0.13.1: the published version, with its yarn.lock checksum.

No LavaMoat policy changes: both packages are dev-only and are not in the webpack bundle. Neither package has install scripts.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Related: MetaMask/client-mcp-core#80

Manual testing steps

  1. Build a test build (yarn build:test), or reuse an existing dist/chrome test build.
  2. Run yarn mm launch. Verify that the wallet opens on the unlock screen and that test-artifacts/<sessionId>/session.json is created.
  3. Run yarn mm type --testid unlock-password "correct horse battery staple" --observe none. Verify that the response has no observations and has meta.timing.
  4. Run yarn mm click --testid unlock-submit. Verify that the response has observations with testIds and a11y, and no state.
  5. Run yarn mm get-state. Verify isUnlocked: true and currentScreen: "home".
  6. Run yarn mm knowledge-last. Verify Error: unknown command 'knowledge-last'.
  7. Run yarn mm cleanup --shutdown.
Local validation with 0.13.1 from npm (headless, test build from this branch)
  • yarn install --immutable passes. yarn jest test/e2e/playwright/llm-workflow: 12 suites, 144 tests passed. tsc: no errors in test/e2e/playwright/llm-workflow.
  • yarn build:test from this branch, then a scripted yarn mm run (MM_HEADLESS=true). Every check below passed. Three first-run failures were mistakes in the test script, not in the CLI. One ran the knowledge commands with no daemon running. Two triggered a change big enough that the CLI correctly returned a full observation instead of a diff. I fixed the script and re-ran those checks.
Area Check Result
Knowledge store removed mm --help has no knowledge-*, --goal or --flow-tags Pass
knowledge-search/last/sessions/summarize with a daemon running unknown command, exit 1
launch --goal x --flow-tags send Warns unknown launch flag; launch succeeds
session.json Written to test-artifacts/<id>/session.json; keys schemaVersion, sessionId, createdAt, tags, launch; no llm-knowledge/ dir
describe-screen No priorKnowledge; browser nodes have path
--observe Invalid level --observe requires one of: none, diff, full, exit 1
type --observe none No observations; observationMs: 0
click (default diff) observations with testIds + a11y, no state
get-state / cdp (default none) No observations
get-state --observe full Full observation, no diff
Diff after a small change {"added":["e18"],"removed":[],"unchanged":17}; only the new node returned
--observe none keeps the baseline Next call returns a diff
Output Default / --pretty / MM_PRETTY=1 1 line / indented / indented
meta.timing On launch, tools and cleanup
run-steps includeObservations Rejected: includeObservations was removed; use observe
batchTimeoutMs: 60000 Rejected: expected number to be <=30000
Top-level observe: "none" / default No observation / observation
batchTimeoutMs: 1000 with a slow step Remaining steps skipped (skipped: 2)
Timeouts Request timed out (30 s) while a click waited for its target; target added afterwards No late click; daemon serves the next request
Element timeout (60 s) Click timed out, no late click
Refs and settle Refs unique; click by ref from the latest response Pass
Click that starts a 600 ms off-screen animation Observation waited (observationMs: 659) and includes the animated element
Regression screenshot, navigate-home, cleanup --shutdown Pass

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dev-only E2E/agent CLI wiring and documentation; no extension runtime, auth, or user wallet code changes.

Overview
Upgrades @metamask/client-mcp-core to 0.13.1 (and @metamask/device-mcp to 0.7.0) so the Playwright mm daemon matches core 0.13.x, which removes the knowledge store and related CLI commands.

The extension-side migration stops wiring KnowledgeStore into createServer in daemon.ts and MetaMaskSessionManager now calls writeSessionMetadata(artifactsDir, …) instead of the old singleton. Session session.json is written under test-artifacts/<sessionId>/ (or workflow artifactsDir), with goal / flowTags dropped from metadata while tags remains; launch still fails if metadata cannot be written.

Agent docs (AGENTS.md, llm-workflow/README.md) no longer tell agents to run mm knowledge-* before visual flows. Integration and provider tests drop knowledge_* tools from expectations and add coverage for the new metadata path and failure behavior.

Reviewed by Cursor Bugbot for commit 620e474. Bugbot is set up for automated code reviews on this repo. Configure here.

- daemon: no KnowledgeStore / setKnowledgeStore; createServer no longer
  gets a knowledgeStore option.
- metamask-provider: write session.json with writeSessionMetadata from
  @metamask/client-mcp-core to <artifactsDir>/<sessionId>/session.json,
  where artifactsDir is the workflow context's config.artifactsDir
  (falls back to 'test-artifacts'). Launch still fails if the write fails.
- Session metadata no longer has goal or flowTags.
- Tests: mock writeSessionMetadata and cover dir/metadata/failure; drop
  knowledge_* tools from the registry test; legacy-mode test uses
  get_context.
- Docs: remove knowledge store commands from the llm-workflow README and
  the knowledge-search step from AGENTS.md.
@cryptotavares cryptotavares added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​client-mcp-core@​0.12.0 ⏵ 0.13.198 +5100100 +197 +1100

View full report

pnarayanaswamy
pnarayanaswamy previously approved these changes Nov 2, 2026
@cryptotavares cryptotavares changed the title bump: @metamask/client-mcp-core to 0.13.0 bump: @metamask/client-mcp-core to 0.13.1 Nov 2, 2026
@cryptotavares
cryptotavares marked this pull request as ready for review November 2, 2026 21:16
@cryptotavares
cryptotavares requested a review from a team as a code owner November 2, 2026 21:16
…ient-mcp-core-0.13.0

# Conflicts:
#	yarn.lock
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [620e474]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41527366946 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +91%
  • ↑ confirmTx/tbt: +100%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +82%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +94%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +80%
  • ↑ bridgeUserActions/tbt: +91%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1608%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -28%
  • ↑ confirmTx/lcp: +1350%
  • ↑ bridgeUserActions/bridge_load_page: +309%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +120%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +56%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +1296%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 3.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↑ startupStandardHome/tbt: +11%
  • ↑ startupStandardHome/fcp: +10%
  • ↑ startupStandardHome/lcp: +13%
  • ↑ startupStandardHome/domInteractive: +42%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/inp: +150%
  • ↑ startupStandardHome/fcp: +44%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -53%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +65 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.88 MiB +200 Bytes 0.00%
✅ zip 24.07 MiB +57 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@gauthierpetetin gauthierpetetin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on behalf of @MetaMask/extension-security-team

@cryptotavares
cryptotavares added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit d23a340 Nov 4, 2026
259 of 261 checks passed
@cryptotavares
cryptotavares deleted the cryptotavares/bump-client-mcp-core-0.13.0 branch November 4, 2026 17:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 620e474a Deployed Nov 2, 2026 by cryptotavares via Publish prerelease / Publish prerelease #172235
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants