Skip to content

fix(content): remove "please" from extension locale strings (batch 1 of 3) - #46148

Merged
alidotforrest merged 5 commits into
mainfrom
fix/content-please-removal-extension-batch-1
Nov 4, 2026
Merged

alidotforrest merged 5 commits into
mainfrom
fix/content-please-removal-extension-batch-1

Conversation

@alidotforrest

@alidotforrest alidotforrest commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Per MetaMask content guidelines: UI strings shouldn't ask for favors. Use direct imperative language instead.

Updated strings in app/_locales/en/messages.json and app/_locales/en_GB/messages.json.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

  1. Load the extension in a browser.
  2. Navigate to any screen that displays the updated strings.
  3. Confirm the updated wording appears correctly with no layout regressions.

Screenshots/Recordings

Before

N/A — locale string changes only.

After

N/A — locale string changes only.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Copy-only changes with no logic or API impact; meaning stays the same aside from clearer session-expired text.

Overview
Updates English UI copy in app/_locales/en/messages.json and app/_locales/en_GB/messages.json to match MetaMask content guidelines: drop favor-asking “please” and use direct imperatives (e.g. “Try again”, “Select a different quote”, “Upload a supported file format”).

The touched strings span errors, retries, bridge, device sync, Ledger/hardware wallet, login/session, file upload, IPFS, swaps maintenance, and network scam warnings—wording only; message keys and placeholders like $1 are unchanged. loginErrorSessionExpiredDescription is slightly expanded to “Your session has expired. Log in again to continue.” instead of only “Log in again to continue.”

This is batch 1 of 3; many other locale entries still contain “please” and are out of scope here.

Reviewed by Cursor Bugbot for commit 7f24df2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the size-S label Sep 8, 2026
@alidotforrest alidotforrest added the team-core-extension-ux Core Extension UX team label Sep 24, 2026
alidotforrest added a commit that referenced this pull request Sep 24, 2026
Updates 25 key(s) in en_GB to match the changes made in en for PR #46148.
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@alidotforrest
alidotforrest marked this pull request as ready for review September 24, 2026 19:12
Rebases PR #46148 onto current main, re-applying 'please' removal changes and syncing en_GB to match en.
@alidotforrest
alidotforrest force-pushed the fix/content-please-removal-extension-batch-1 branch from a89a137 to 252f055 Compare September 24, 2026 19:26
Comment thread app/_locales/en/messages.json Outdated
},
"ledgerWebHIDNotConnectedErrorMessage": {
"message": "The ledger device was not connected. If you wish to connect your Ledger, please click 'Continue' again and approve HID connection",
"message": "The ledger device was not connected. If you wish to connect your Ledger, click 'Continue' again and approve HID connection",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alidotforrest Ledger is a brand name, so it should be capitalized here. Not blocking, just FYI for fixing.

Comment thread app/_locales/en_GB/messages.json Outdated
},
"ledgerWebHIDNotConnectedErrorMessage": {
"message": "The ledger device was not connected. If you wish to connect your Ledger, please click 'Continue' again and approve HID connection",
"message": "The ledger device was not connected. If you wish to connect your Ledger, click 'Continue' again and approve HID connection",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alidotforrest Capitalization needed on Ledger. Not blocking, just FYI.

coreyjanssen
coreyjanssen previously approved these changes Sep 24, 2026
brianacnguyen
brianacnguyen previously approved these changes Sep 24, 2026
@alidotforrest
alidotforrest added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 25, 2026
@alidotforrest
alidotforrest added this pull request to the merge queue Sep 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 25, 2026
alidotforrest and others added 2 commits October 21, 2026 08:58
Ledger is a brand name.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Ledger is a brand name.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
coreyjanssen
coreyjanssen previously approved these changes Oct 21, 2026

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alidotforrest, is this PR still valid? If so could you ask cursor to update from main branch and fix the merge conflicts 🙏

Resolve conflict on loadingScreenSnapMessage: main removed the unused
key (#47294), so drop it from en and en_GB.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@alidotforrest
alidotforrest added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit adeaf9a Nov 4, 2026
53 checks passed
@alidotforrest
alidotforrest deleted the fix/content-please-removal-extension-batch-1 branch November 4, 2026 19:31
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 7f24df23 Deployed Nov 3, 2026 by alidotforrest via identify-codeowners #88348
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 risk:low size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants