Repository navigation
fix(content): remove "please" from extension locale strings (batch 1 of 3) - #46148
Merged
Merged
Conversation
alidotforrest
temporarily deployed
to
pr-comment
September 8, 2026 14:14 — with
GitHub Actions
Inactive
alidotforrest
added a commit
that referenced
this pull request
Sep 24, 2026
Updates 25 key(s) in en_GB to match the changes made in en for PR #46148.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
alidotforrest
marked this pull request as ready for review
September 24, 2026 19:12
Rebases PR #46148 onto current main, re-applying 'please' removal changes and syncing en_GB to match en.
alidotforrest
force-pushed
the
fix/content-please-removal-extension-batch-1
branch
from
September 24, 2026 19:26
a89a137 to
252f055
Compare
alidotforrest
temporarily deployed
to
pr-comment
September 24, 2026 19:26 — with
GitHub Actions
Inactive
| }, | ||
| "ledgerWebHIDNotConnectedErrorMessage": { | ||
| "message": "The ledger device was not connected. If you wish to connect your Ledger, please click 'Continue' again and approve HID connection", | ||
| "message": "The ledger device was not connected. If you wish to connect your Ledger, click 'Continue' again and approve HID connection", |
Contributor
There was a problem hiding this comment.
@alidotforrest Ledger is a brand name, so it should be capitalized here. Not blocking, just FYI for fixing.
| }, | ||
| "ledgerWebHIDNotConnectedErrorMessage": { | ||
| "message": "The ledger device was not connected. If you wish to connect your Ledger, please click 'Continue' again and approve HID connection", | ||
| "message": "The ledger device was not connected. If you wish to connect your Ledger, click 'Continue' again and approve HID connection", |
Contributor
There was a problem hiding this comment.
@alidotforrest Capitalization needed on Ledger. Not blocking, just FYI.
coreyjanssen
previously approved these changes
Sep 24, 2026
brianacnguyen
previously approved these changes
Sep 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2026
Ledger is a brand name. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Ledger is a brand name. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
alidotforrest
dismissed stale reviews from brianacnguyen and coreyjanssen
via
October 21, 2026 12:58
3b5e1cb
alidotforrest
had a problem deploying
to
pr-comment
October 21, 2026 12:58 — with
GitHub Actions
Error
alidotforrest
temporarily deployed
to
pr-comment
October 21, 2026 12:58 — with
GitHub Actions
Inactive
coreyjanssen
previously approved these changes
Oct 21, 2026
georgewrmarshall
left a comment
Contributor
There was a problem hiding this comment.
Hey @alidotforrest, is this PR still valid? If so could you ask cursor to update from main branch and fix the merge conflicts 🙏
Resolve conflict on loadingScreenSnapMessage: main removed the unused key (#47294), so drop it from en and en_GB. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
alidotforrest
temporarily deployed
to
pr-comment
November 2, 2026 19:56 — with
GitHub Actions
Inactive
georgewrmarshall
approved these changes
Nov 2, 2026
alidotforrest
temporarily deployed
to
pr-comment
November 3, 2026 20:04 — with
GitHub Actions
Inactive
NidhiKJha
approved these changes
Nov 4, 2026
alidotforrest
deleted the
fix/content-please-removal-extension-batch-1
branch
November 4, 2026 19:31
Contributor
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per MetaMask content guidelines: UI strings shouldn't ask for favors. Use direct imperative language instead.
Updated strings in
app/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
N/A — locale string changes only.
After
N/A — locale string changes only.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Copy-only changes with no logic or API impact; meaning stays the same aside from clearer session-expired text.
Overview
Updates English UI copy in
app/_locales/en/messages.jsonandapp/_locales/en_GB/messages.jsonto match MetaMask content guidelines: drop favor-asking “please” and use direct imperatives (e.g. “Try again”, “Select a different quote”, “Upload a supported file format”).The touched strings span errors, retries, bridge, device sync, Ledger/hardware wallet, login/session, file upload, IPFS, swaps maintenance, and network scam warnings—wording only; message keys and placeholders like
$1are unchanged.loginErrorSessionExpiredDescriptionis slightly expanded to “Your session has expired. Log in again to continue.” instead of only “Log in again to continue.”This is batch 1 of 3; many other locale entries still contain “please” and are out of scope here.
Reviewed by Cursor Bugbot for commit 7f24df2. Bugbot is set up for automated code reviews on this repo. Configure here.