Skip to content

chore: upgrade design system packages (v75.0.0) - #47128

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/upgrade-design-system-grotzec-114c
Oct 28, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/upgrade-design-system-grotzec-114c

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Upgrades the design system packages to the v75.0.0 release and registers Grotzec Cond Bold as the hero typeface.

Related: DSYS-1150

Packages upgraded:

  • @metamask/design-system-react: ^0.45.3 → ^0.47.0
  • @metamask/design-tokens: ^11.1.0 → ^12.0.0
  • @metamask/design-system-tailwind-preset: ^0.14.0 → ^0.15.0
  • @metamask/design-system-shared: ^0.39.0 → ^0.41.0

FontFamily.Hero and --font-family-hero now resolve to Grotzec Cond. Only the Bold cut is licensed. TextVariant.DisplayXl with that face computes to weight 600 below the md breakpoint and weight 500 at md and above, because design-system bold is 600, not 700. The @font-face rule maps weights 400–700 onto that one file so the browser does not synthesize a missing cut.

MM Poly stays in the repo. Removing it is a follow-up.

The NetworkListItem snapshot is updated because v74 changed the MoreVertical artwork. That test fails on this upgrade without the snapshot.

Screen adoption of MarketingMoment is split into follow-up PRs so each code owner can review their own surface.

Changelog

CHANGELOG entry: Updated the hero typeface to Grotzec Cond Bold.

Related issues

DSYS-1150

Manual testing steps

  1. Build the extension (yarn start) and load dist/chrome.
  2. Open the onboarding welcome screen and confirm the large welcome title renders in Grotzec Cond Bold, not a Helvetica fallback.
  3. Spot-check a normal screen (home, asset list) and confirm body text still uses Inter and accent text still uses MM Sans.
  4. Open a network list item options menu and confirm the vertical dots icon still renders.

Screenshots/Recordings

MarketingMoment template in Storybook at 1024px, light theme. Before is main. After uses Grotzec Cond Bold, captured on the #47424 branch, which is stacked on this PR.

Story Before After
MarketingMoment Default MarketingMoment Default before MarketingMoment Default after
MarketingMoment Examples MarketingMoment Examples before MarketingMoment Examples after

On main, the Examples titles are clipped at 1024px. With Grotzec they wrap cleanly.

Fast follows

Screen adoption of MarketingMoment is split by code owner into these follow-ups:

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Broad visual/token dependency bump and new licensed font assets; hero headlines across onboarding and marketing flows should be spot-checked, but no security or transaction logic changes.

Reviewed by Cursor Bugbot for commit d188118. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (4 files, +22 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 network-list-item/
          • 📁 __snapshots__/
            • 📄 network-list-item.test.js.snap +1 -1
    • 📁 css/
      • 📁 utilities/
        • 📁 fonts/
          • 📁 GrotzecCond/
            • 📄 GrotzecCond-Bold.woff2
            • 📄 LICENSE +9 -0
          • 📄 fonts.scss +12 -0

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Extension label Oct 15, 2026
@socket-security

socket-security Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​design-system-shared@​0.39.0 ⏵ 0.41.0100 +110077 +199100
Updated@​metamask/​design-system-react@​0.45.3 ⏵ 0.47.09410079 +1100100
Updated@​metamask/​design-system-tailwind-preset@​0.14.0 ⏵ 0.15.093 +310091 +195 +1100
Updated@​metamask/​design-tokens@​11.1.0 ⏵ 12.0.0100 +110010096 +1100

View full report

@metamask-ci

metamask-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Builds ready [90b1490]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 38806380095 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +67%
  • ↑ confirmTx/longTaskMaxDuration: +86%
  • ↑ confirmTx/tbt: +92%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +115%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +121%
  • ↑ bridgeUserActions/longTaskMaxDuration: +44%
  • ↑ bridgeUserActions/tbt: +239%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +18%
  • ↑ loadNewAccount/lcp: +1203%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -40%
  • ↑ confirmTx/lcp: +1258%
  • ↑ bridgeUserActions/bridge_load_page: +284%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +38%
  • ↑ bridgeUserActions/inp: +46%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1241%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↑ startupStandardHome/firstPaint: +12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↑ startupStandardHome/lcp: +14%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +163%
  • ↓ startupStandardHome/fcp: -27%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +34%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +27%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -20%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -21%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.44 MiB +412 Bytes 0.00%
🚨 ui 19.26 MiB +2.38 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.36 MiB +2.09 KiB +0.05%
✅ content scripts 3.15 MiB +112 Bytes 0.00%
🚨 zip 23.96 MiB +32.67 KiB +0.13%

@metamask-ci

metamask-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ac5c1ab] [reused from 90b1490]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 38810213495 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +67%
  • ↑ confirmTx/longTaskMaxDuration: +86%
  • ↑ confirmTx/tbt: +92%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +115%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +121%
  • ↑ bridgeUserActions/longTaskMaxDuration: +44%
  • ↑ bridgeUserActions/tbt: +239%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +18%
  • ↑ loadNewAccount/lcp: +1203%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -40%
  • ↑ confirmTx/lcp: +1258%
  • ↑ bridgeUserActions/bridge_load_page: +284%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +38%
  • ↑ bridgeUserActions/inp: +46%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1241%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↑ startupStandardHome/firstPaint: +12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↑ startupStandardHome/lcp: +14%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +163%
  • ↓ startupStandardHome/fcp: -27%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +34%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +27%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -20%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -21%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.44 MiB +412 Bytes 0.00%
🚨 ui 19.26 MiB +2.38 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.36 MiB +2.09 KiB +0.05%
✅ content scripts 3.15 MiB +112 Bytes 0.00%
🚨 zip 23.96 MiB +32.67 KiB +0.13%

@metamask-ci

metamask-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [74e95aa]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40031723174 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/fcp: -27%
  • ↑ loadNewAccount/lcp: +618%
  • ↑ confirmTx/longTaskMaxDuration: +29%
  • ↑ confirmTx/tbt: +12%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -28%
  • ↓ confirmTx/lcp: -18%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -20%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskMaxDuration: -27%
  • ↓ bridgeUserActions/tbt: -45%
  • ↓ bridgeUserActions/total: -11%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -29%
  • ↓ bridgeUserActions/lcp: -17%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↓ loadNewAccount/inp: -32%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +1235%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -37%
  • ↑ confirmTx/lcp: +1670%
  • ↑ bridgeUserActions/bridge_load_page: +244%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +138%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +43%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -51%
  • ↑ bridgeUserActions/lcp: +1231%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/LCP: p75 3.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +11%
  • ↑ startupStandardHome/firstPaint: +14%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +127%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +13%
  • ↓ startupStandardHome/uiStartup: -40%
  • ↓ startupStandardHome/load: -36%
  • ↓ startupStandardHome/domContentLoaded: -36%
  • ↓ startupStandardHome/domInteractive: -57%
  • ↓ startupStandardHome/backgroundConnect: -32%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -36%
  • ↑ startupStandardHome/setupStore: +24%
  • ↓ startupStandardHome/fcp: -40%
  • ↓ startupStandardHome/lcp: -34%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +54%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +37%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +35%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +23%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -85%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -51%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.39 MiB +417 Bytes 0.00%
🚨 ui 19.24 MiB +2.38 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.09 KiB +0.05%
✅ content scripts 3.23 MiB +112 Bytes 0.00%
🚨 zip 24.04 MiB +32.62 KiB +0.13%

georgewrmarshall added a commit that referenced this pull request Oct 27, 2026
## **Description**

Hero screens in the extension each build their own title, artwork, and
action stack. This adds the shared template only: `MarketingMoment` and
`MarketingMomentTitle`.

`MarketingMoment` lays out an optional title, description, artwork, and
primary and tertiary actions. It does not set a background, horizontal
padding, or close-button offset. The screen that places it owns that
chrome. `MarketingMomentTitle` always uses the hero face at DisplayXl
unless a size is passed, with 80% line height and −2% letter spacing.
The browser font stack covers languages Grotzec does not.

Stacked on #47128,
which adds the Grotzec hero face. Applying the template to wallet ready,
Transaction Shield, and mUSD education stays on
#47362 for a
follow-up split.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

<!--
Fixes:
-->

## **Manual testing steps**

1. Run Storybook and open Components/UI/MarketingMoment.
2. Check Actions, Artwork, Background, and the three extension
templates.
3. Confirm the order is title, description, artwork, then actions.
4. Confirm the root has no default background color and no horizontal
padding. The Background and Transaction Shield stories get their color
from a parent wrapper.
5. Confirm the title uses the hero face, including on the dark theme
preview.

## **Screenshots/Recordings**

### **Before**

No shared marketing-moment component. Each hero screen owns its own
layout.

### **After**

Review Components/UI/MarketingMoment in Storybook.

<img width="1512" height="870" alt="Screenshot 2026-10-26 at 6 49 45 PM"
src="https://github.com/user-attachments/assets/90028226-7f6d-4f37-be89-c80fbddc5803"
/>
<img width="1504" height="869" alt="Screenshot 2026-10-26 at 6 49 51 PM"
src="https://github.com/user-attachments/assets/21a25cd6-cf0e-4249-b2f4-93cb42eea3a5"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **High Risk**
> Removes TokenBalancesController and changes how balances are updated
after transactions; adds a new dApp-facing `wallet_pay` RPC path tied to
Pay/perps flows—both affect core wallet and assets behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
26bedb6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

Hero screens in the extension each build their own title, artwork, and
action stack. This adds the shared template only: `MarketingMoment` and
`MarketingMomentTitle`.

`MarketingMoment` lays out an optional title, description, artwork, and
primary and tertiary actions. It does not set a background, horizontal
padding, or close-button offset. The screen that places it owns that
chrome. `MarketingMomentTitle` always uses the hero face at DisplayXl
unless a size is passed, with 80% line height and −2% letter spacing.
The browser font stack covers languages Grotzec does not.

Stacked on #47128,
which adds the Grotzec hero face. Applying the template to wallet ready,
Transaction Shield, and mUSD education stays on
#47362 for a
follow-up split.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

<!--
Fixes:
-->

## **Manual testing steps**

1. Run Storybook and open Components/UI/MarketingMoment.
2. Check Default and Examples.
3. Confirm the order is title, description, artwork, then actions.
4. Confirm the root has no default background color and no horizontal
padding.
5. Confirm the title uses the hero face, including on the dark theme
preview.

## **Screenshots/Recordings**

### **Before**

No shared marketing-moment component. Each hero screen owns its own
layout.

### **After**

Review Components/UI/MarketingMoment in Storybook.

![Default
story](https://cursor.com/artifacts/c/art-20b2e2de-04eb-4596-8e57-e383aff6c939)

![Examples
story](https://cursor.com/artifacts/c/art-3eeac43c-8d09-4733-832d-12ebc5528679)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-d95d7724-b0b0-5410-8814-c306908ba701?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-d95d7724-b0b0-5410-8814-c306908ba701&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added size-L and removed size-S labels Oct 27, 2026
@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [50ad6f9]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40434973155 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -18%
  • ↑ confirmTx/longTaskTotalDuration: +22%
  • ↑ confirmTx/longTaskMaxDuration: +46%
  • ↑ confirmTx/tbt: +38%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -18%
  • ↑ bridgeUserActions/bridge_load_page: +23%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +74%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +50%
  • ↓ bridgeUserActions/longTaskMaxDuration: -14%
  • ↑ bridgeUserActions/tbt: +18%
  • ↓ bridgeUserActions/fcp: -19%
  • ↓ bridgeUserActions/lcp: -14%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↓ loadNewAccount/fcp: -38%
  • ↑ loadNewAccount/lcp: +1539%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1318%
  • ↑ bridgeUserActions/bridge_load_page: +247%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +140%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +35%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1294%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -21%
  • ↓ startupStandardHome/load: -23%
  • ↓ startupStandardHome/domContentLoaded: -23%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -23%
  • ↑ startupStandardHome/setupStore: +112%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -30%
  • ↓ startupStandardHome/longTaskMaxDuration: -27%
  • ↓ startupStandardHome/tbt: -30%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -22%
  • ↓ startupStandardHome/domInteractive: -24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +131%
  • ↓ startupStandardHome/fcp: -19%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +42%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +36%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +34%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +41%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +14%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +11%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +18%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -39%
  • ↓ onboardingNewWallet/tbt: -84%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -73%
  • ↓ dappPageLoad/domContentLoaded: -38%
  • ↓ dappPageLoad/firstPaint: -59%
  • ↓ dappPageLoad/firstContentfulPaint: -59%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.42 MiB +30.79 KiB +0.20%
🚨 ui 19.24 MiB +2.89 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +3.49 KiB +0.08%
🚨 content scripts 3.23 MiB +2.89 KiB +0.09%
🚨 zip 24.06 MiB +55.75 KiB +0.23%

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Education screen lost content insets
    • Restored 16px horizontal insets by passing px-4 on MarketingMoment, matching the Shield call site and prior education layout.

Create PR

Or push these changes by commenting:

@cursor push d2d07a5fb6
Preview (d2d07a5fb6)
diff --git a/ui/pages/musd/screens/education.tsx b/ui/pages/musd/screens/education.tsx
--- a/ui/pages/musd/screens/education.tsx
+++ b/ui/pages/musd/screens/education.tsx
@@ -306,7 +306,7 @@
         />
       </Box>
       <MarketingMoment
-        className="pt-12"
+        className="pt-12 px-4"
         title={t('musdEducationHeadline', [String(MUSD_CONVERSION_APY)])}
         titleProps={{
           style: { whiteSpace: 'pre-line' },

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 8cdd60d. Configure here.

Comment thread ui/pages/musd/screens/education.tsx Resolved
@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d188118]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40602494220 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ confirmTx/longTaskTotalDuration: +65%
  • ↑ confirmTx/longTaskMaxDuration: +100%
  • ↑ confirmTx/tbt: +114%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/lcp: +10%
  • ↑ bridgeUserActions/bridge_load_page: +91%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +107%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +81%
  • ↑ bridgeUserActions/tbt: +116%
  • ↑ bridgeUserActions/total: +16%
  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -61%
  • ↑ loadNewAccount/lcp: +1007%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +127%
  • ↑ confirmTx/lcp: +1039%
  • ↑ bridgeUserActions/bridge_load_page: +152%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +96%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +36%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -55%
  • ↑ bridgeUserActions/lcp: +1331%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/INP: p75 240ms
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +173%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↑ startupStandardHome/backgroundConnect: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/fcp: -26%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +417 Bytes 0.00%
🚨 ui 19.25 MiB +2.39 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.09 KiB +0.05%
✅ content scripts 3.23 MiB +112 Bytes 0.00%
🚨 zip 24.06 MiB +32.61 KiB +0.13%

@georgewrmarshall
georgewrmarshall requested review from a team and removed request for a team October 28, 2026 00:17
LabinatorSolutions pushed a commit to LabinatorSolutions/metamask-extension that referenced this pull request Oct 28, 2026
…etaMask#47409)

## **Description**

Storybook could not show the current Shield, wallet-ready, and mUSD
education screens accurately. The wallet-ready animation needs
`rive.wasm`, and mUSD education had no story.

This adds only those Storybook updates from
MetaMask#47128. It does not
include the MarketingMoment template from
MetaMask#47374, the Grotzec
font upgrade, or the screen layout changes. The stories still render the
current screens, so they can be captured as the before state.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Run `yarn storybook`.
2. Open Pages/OnboardingFlow/CreationSuccessful. Confirm “Your wallet is
ready!” still sits below the animation, and the animation plays.
3. Open Components/App/ShieldEntryModal. Confirm the current teal
dialog, with the illustration and the title using the existing hero
face.
4. Open Pages/Musd/Education. Confirm the current education screen,
including the uppercase headline and the coin artwork.

## **Screenshots/Recordings**

Current screens in Storybook. These are the before state for the
marketing layout.

### **Before**

Storybook did not load `rive.wasm`, and mUSD education had no story.

### **After**

Wallet ready, 360px wide

<img width="360" alt="Wallet ready at 360px"
src="https://github.com/user-attachments/assets/451f20cf-8eb5-4221-b527-2118423182e9"
/>

Wallet ready, 1024px wide

![Wallet ready at
1024px](https://github.com/user-attachments/assets/0b04c8f1-8c06-403e-bc84-f1d1163057c3)

Transaction Shield, 1024px wide

![Transaction Shield at
1024px](https://github.com/user-attachments/assets/1cc3d4fd-c3cd-44e0-8a1b-25fa3596a612)

mUSD education, 360px wide

<img width="360" alt="mUSD education at 360px"
src="https://github.com/user-attachments/assets/3e0c8691-5add-444a-923a-cca07bae7830"
/>

mUSD education, 1024px wide

![mUSD education at
1024px](https://github.com/user-attachments/assets/f357a46d-fb45-4599-9ac4-9d63e583f695)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to Storybook webpack config and story decorators;
production extension bundles are unaffected.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c540b43. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Register Grotzec Cond Bold as the hero typeface and exclude the commercial font from the repository license. The single Bold cut covers weights 400–700, which is the range DisplayXl and the design-system bold token actually request.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [012a5b3]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40738471782 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +415%
  • ↑ loadNewAccount/total: +415%
  • ↑ confirmTx/longTaskTotalDuration: +39%
  • ↑ confirmTx/longTaskMaxDuration: +66%
  • ↑ confirmTx/tbt: +68%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -10%
  • ↑ bridgeUserActions/bridge_load_page: +66%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +90%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +59%
  • ↓ bridgeUserActions/longTaskMaxDuration: -11%
  • ↑ bridgeUserActions/tbt: +48%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1297%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1311%
  • ↑ bridgeUserActions/bridge_load_page: +292%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +133%
  • ↑ bridgeUserActions/bridge_search_token: +18%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +50%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1370%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -14%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/firstPaint: -11%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -23%
  • ↓ startupStandardHome/longTaskMaxDuration: -18%
  • ↓ startupStandardHome/tbt: -20%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -16%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +48%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +37%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +40%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +22%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +31%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -91%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -73%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +417 Bytes 0.00%
🚨 ui 19.26 MiB +2.39 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.09 KiB +0.05%
✅ content scripts 3.23 MiB +112 Bytes 0.00%
🚨 unzipped 79.79 MiB +38.77 KiB +0.05%
🚨 zip 24.07 MiB +32.6 KiB +0.13%

@sonarqubecloud

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall marked this pull request as ready for review October 28, 2026 20:09
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 98ddc0e Oct 28, 2026
281 of 283 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/upgrade-design-system-grotzec-114c branch October 28, 2026 22:41
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
segment-schema — 012a5b37 Deployed Oct 28, 2026 by georgewrmarshall via propose #1373
pr-comment — 012a5b37 Deployed Oct 28, 2026 by georgewrmarshall via identify-codeowners #87750
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants