Skip to content

feat(onboarding): adopt MarketingMoment on the wallet-ready screen - #47423

Merged
amandaye0h merged 7 commits into
mainfrom
feat/wallet-ready-marketing-moment
Oct 29, 2026
Merged

amandaye0h merged 7 commits into
mainfrom
feat/wallet-ready-marketing-moment

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

After a wallet is created, the wallet-ready screen uses the shared MarketingMoment layout: hero title, animation, then actions.

Stacked on the Shield marketing-moment PR, which carries the shared title metrics and pinned actions. Base this PR on that branch until it merges, then retarget to main.

Code owner: @MetaMask/web3auth (ui/pages/onboarding-flow).

Changelog

CHANGELOG entry: Moved the wallet-ready screen onto the shared marketing layout.

Related issues

Follows the design system upgrade in #47128.

Manual testing steps

  1. Build the extension (yarn start) and load dist/chrome.
  2. Create a new wallet.
  3. On the wallet-ready screen, confirm the hero title renders in Grotzec Cond Bold, then the animation, then Open wallet and Manage default settings.
  4. Confirm the actions stay at the bottom of the screen.

Screenshots/Recordings

Storybook, light theme. Before is main, after is this branch. The title moves above the animation and uses Grotzec.

Screen Before After
Wallet ready (1024px) Wallet ready (1024px) before Wallet ready (1024px) after
Wallet ready (360px) Wallet ready (360px) before Wallet ready (360px) after

After (extension build)

The wallet-ready screen after creating a wallet in a local extension build.

Your wallet is ready screen in the extension

wallet-ready-after-extension.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Changes a core onboarding completion screen and shared marketing layout, but preserves existing navigation, side-panel disable behavior, and the SRP reminder variant.

Reviewed by Cursor Bugbot for commit faedef1. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (5 files, +86 -100)
  • 📁 ui/
    • 📁 pages/
      • 📁 onboarding-flow/
        • 📁 creation-successful/
          • 📄 creation-successful.stories.tsx +11 -2
          • 📄 creation-successful.tsx +73 -55
          • 📄 index.scss +0 -35
          • 📄 wallet-ready-animation.tsx +2 -7
          • 📄 index.scss +0 -1

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Extension label Oct 27, 2026
@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2d08725]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40602577374 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +43%
  • ↑ confirmTx/longTaskTotalDuration: +69%
  • ↑ confirmTx/longTaskMaxDuration: +104%
  • ↑ confirmTx/tbt: +122%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +129%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +126%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +193%
  • ↑ bridgeUserActions/longTaskMaxDuration: +66%
  • ↑ bridgeUserActions/tbt: +345%
  • ↑ bridgeUserActions/total: +26%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +21%
  • ↑ loadNewAccount/lcp: +1306%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1320%
  • ↑ bridgeUserActions/bridge_load_page: +295%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↑ bridgeUserActions/bridge_search_token: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +57%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -32%
  • ↑ bridgeUserActions/lcp: +1324%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +20%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +165%
  • ↓ startupStandardHome/uiStartup: -39%
  • ↓ startupStandardHome/load: -35%
  • ↓ startupStandardHome/domContentLoaded: -35%
  • ↓ startupStandardHome/domInteractive: -54%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -35%
  • ↑ startupStandardHome/setupStore: +29%
  • ↓ startupStandardHome/fcp: -47%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +47%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +36%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +31%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +59%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +44%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +42%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +26%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -57%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -94%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +445 Bytes 0.00%
🚨 ui 19.26 MiB +7.78 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.12 KiB +0.05%
✅ content scripts 3.23 MiB +168 Bytes 0.00%
🚨 zip 24.06 MiB +34.23 KiB +0.14%

@georgewrmarshall georgewrmarshall self-assigned this Oct 28, 2026
georgewrmarshall and others added 3 commits October 28, 2026 10:42
Register Grotzec Cond Bold as the hero typeface and exclude the commercial font from the repository license. The single Bold cut covers weights 400–700, which is the range DisplayXl and the design-system bold token actually request.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use the shared marketing layout for Transaction Shield, keep the hero title metrics stable while Grotzec loads, and pin the actions below the scrolling copy.

Co-authored-by: Cursor <cursoragent@cursor.com>
Show the hero title, animation, and actions through the shared marketing layout after a wallet is created.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f9448d6]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40738470885 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +11%
  • ↑ confirmTx/longTaskTotalDuration: +62%
  • ↑ confirmTx/longTaskMaxDuration: +95%
  • ↑ confirmTx/tbt: +108%
  • ↑ confirmTx/fcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +107%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +125%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +148%
  • ↑ bridgeUserActions/tbt: +148%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1259%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -36%
  • ↑ confirmTx/lcp: +1294%
  • ↑ bridgeUserActions/bridge_load_page: +316%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +109%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +40%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1246%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -17%
  • ↓ startupStandardHome/load: -19%
  • ↓ startupStandardHome/domContentLoaded: -19%
  • ↓ startupStandardHome/backgroundConnect: -25%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -20%
  • ↑ startupStandardHome/setupStore: +89%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -27%
  • ↓ startupStandardHome/longTaskMaxDuration: -25%
  • ↓ startupStandardHome/tbt: -26%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -20%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/fcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +36%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +31%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +23%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -63%
  • ↓ dappPageLoad/domContentLoaded: -15%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +445 Bytes 0.00%
🚨 ui 19.27 MiB +7.78 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.12 KiB +0.05%
✅ content scripts 3.23 MiB +168 Bytes 0.00%
🚨 unzipped 79.8 MiB +44.11 KiB +0.05%
🚨 zip 24.07 MiB +34.23 KiB +0.14%

Show the SRP backup reminder in Storybook and drop the stylesheet now that the illustration is sized with utility classes.

Co-authored-by: Cursor <cursoragent@cursor.com>
);
}

return (

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have these 2 components in the same file baffles me a bit but here we are. Checked in storybook

Screen.Recording.2026-10-28.at.1.36.20.PM.mov

…wrapper

Storybook reused one router, so the reminder query never applied. The animation height now lives on the marketing moment artwork wrapper.

Co-authored-by: Cursor <cursoragent@cursor.com>
status === 'failed'
) {
return <Box className="riv-animation__wallet-ready-container"></Box>;
return null;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same result regardless of approach

Image

Comment thread .storybook/preview.js
<QueryClientProvider client={queryClient}>
<MemoryRouter initialEntries={initialEntries}>
<MemoryRouter
key={initialEntries.join('|')}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MemoryRouter only applies initialEntries when it mounts, and this decorator stays mounted as you move between stories. The key is the story URL, so a story with a different entry gets a fresh router. The reminder story depends on that, because the page reads isFromReminder from the location and otherwise stays on the wallet-ready layout.


SrpBackupReminderStory.storyName = 'SRP backup reminder';
SrpBackupReminderStory.parameters = {
initialEntries: ['/?isFromReminder=true'],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page chooses the reminder layout from this query, through the same onboarding search params it uses in the app. The wallet-ready story leaves the default URL, so it renders the marketing moment. Both stories mount the same component; the URL is the switch.


if (!isFromSettingsSRPBackup) {
return (
<MarketingMoment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is the marketing moment: the ready title, the Rive artwork, and the done and manage-default-settings actions. The reminder path stays on the existing layout because it is a different screen, with the celebrating fox, the learn-how link, and a single back-to-wallet action. The test id stays on both roots so the completion checks still find the page.

title={t('yourWalletIsReady')}
artwork={<WalletReadyAnimation />}
artworkWrapperProps={{
className: 'pointer-events-none h-[400px] flex-none',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the old riv-animation container. The slot stays 400px tall and ignores pointer events, which is what that stylesheet did, and flex-none keeps the fixed height from being overridden by the template's flex-1. The animation itself only fills the slot.

@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7564259]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40766471523 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↑ confirmTx/longTaskTotalDuration: +65%
  • ↑ confirmTx/longTaskMaxDuration: +91%
  • ↑ confirmTx/tbt: +108%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +20%
  • ↑ bridgeUserActions/bridge_load_page: +128%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +174%
  • ↑ bridgeUserActions/longTaskCount: +178%
  • ↑ bridgeUserActions/longTaskTotalDuration: +199%
  • ↑ bridgeUserActions/longTaskMaxDuration: +89%
  • ↑ bridgeUserActions/tbt: +352%
  • ↑ bridgeUserActions/total: +30%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +16%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1309%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1357%
  • ↑ bridgeUserActions/bridge_load_page: +429%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +140%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +53%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1333%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -26%
  • ↓ startupStandardHome/load: -19%
  • ↓ startupStandardHome/domContentLoaded: -21%
  • ↓ startupStandardHome/domInteractive: -50%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -19%
  • ↑ startupStandardHome/setupStore: +88%
  • ↓ startupStandardHome/fcp: -37%
  • ↓ startupStandardHome/lcp: -18%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -14%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -12%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -34%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +23%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +23%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -50%
  • ↓ onboardingNewWallet/tbt: -98%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +445 Bytes 0.00%
🚨 ui 19.27 MiB +7.45 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
🚨 other 4.44 MiB +2.12 KiB +0.05%
✅ content scripts 3.23 MiB +168 Bytes 0.00%
🚨 unzipped 79.8 MiB +43.33 KiB +0.05%
🚨 zip 24.07 MiB +34.27 KiB +0.14%

@georgewrmarshall
georgewrmarshall requested a review from a team October 28, 2026 21:39
@georgewrmarshall georgewrmarshall added retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry DO-NOT-MERGE Pull requests that should not be merged and removed DO-NOT-MERGE Pull requests that should not be merged labels Oct 28, 2026
brianacnguyen
brianacnguyen previously approved these changes Oct 28, 2026
LabinatorSolutions pushed a commit to LabinatorSolutions/metamask-extension that referenced this pull request Oct 28, 2026
## **Description**

Upgrades the design system packages to the [v75.0.0
release](https://github.com/MetaMask/metamask-design-system/releases/tag/v75.0.0)
and registers Grotzec Cond Bold as the hero typeface.

Related:
[DSYS-1150](https://consensyssoftware.atlassian.net/browse/DSYS-1150)

**Packages upgraded:**
- `@metamask/design-system-react`: `^0.45.3` → `^0.47.0`
- `@metamask/design-tokens`: `^11.1.0` → `^12.0.0`
- `@metamask/design-system-tailwind-preset`: `^0.14.0` → `^0.15.0`
- `@metamask/design-system-shared`: `^0.39.0` → `^0.41.0`

`FontFamily.Hero` and `--font-family-hero` now resolve to Grotzec Cond.
Only the Bold cut is licensed. `TextVariant.DisplayXl` with that face
computes to weight 600 below the `md` breakpoint and weight 500 at `md`
and above, because design-system bold is 600, not 700. The `@font-face`
rule maps weights 400–700 onto that one file so the browser does not
synthesize a missing cut.

MM Poly stays in the repo. Removing it is a follow-up.

The NetworkListItem snapshot is updated because v74 changed the
`MoreVertical` artwork. That test fails on this upgrade without the
snapshot.

Screen adoption of `MarketingMoment` is split into follow-up PRs so each
code owner can review their own surface.

## **Changelog**

CHANGELOG entry: Updated the hero typeface to Grotzec Cond Bold.

## **Related issues**

[DSYS-1150](https://consensyssoftware.atlassian.net/browse/DSYS-1150)

## **Manual testing steps**

1. Build the extension (`yarn start`) and load `dist/chrome`.
2. Open the onboarding welcome screen and confirm the large welcome
title renders in Grotzec Cond Bold, not a Helvetica fallback.
3. Spot-check a normal screen (home, asset list) and confirm body text
still uses Inter and accent text still uses MM Sans.
4. Open a network list item options menu and confirm the vertical dots
icon still renders.

## **Screenshots/Recordings**

`MarketingMoment` template in Storybook at 1024px, light theme. Before
is `main`. After uses Grotzec Cond Bold, captured on the MetaMask#47424 branch,
which is stacked on this PR.

| Story | Before | After |
| --- | --- | --- |
| MarketingMoment Default | ![MarketingMoment Default
before](https://github.com/user-attachments/assets/0b1adc9b-46dc-46ce-9d2a-3df66e5e75ca)
| ![MarketingMoment Default
after](https://github.com/user-attachments/assets/565c83b1-bb2d-4375-ba3b-4fd0056dc7d1)
|
| MarketingMoment Examples | ![MarketingMoment Examples
before](https://github.com/user-attachments/assets/8926d0e6-cedb-4611-be1c-53effd418607)
| ![MarketingMoment Examples
after](https://github.com/user-attachments/assets/9309be4c-a80c-4be0-ad62-3ab8fd278643)
|

On `main`, the Examples titles are clipped at 1024px. With Grotzec they
wrap cleanly.

### **Fast follows**

Screen adoption of `MarketingMoment` is split by code owner into these
follow-ups:

- MetaMask#47424: Shield
entry modal (stacked on this PR)
- MetaMask#47423:
wallet-ready screen (stacked on MetaMask#47424)
- MetaMask#47425: mUSD
education screen (stacked on MetaMask#47424)

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Broad visual/token dependency bump and new licensed font assets; hero
headlines across onboarding and marketing flows should be spot-checked,
but no security or transaction logic changes.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d188118. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

[DSYS-1150]:
https://consensyssoftware.atlassian.net/browse/DSYS-1150?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[DSYS-1150]:
https://consensyssoftware.atlassian.net/browse/DSYS-1150?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: Cursor <cursoragent@cursor.com>
lwin-kyaw
lwin-kyaw previously approved these changes Oct 29, 2026
Base automatically changed from feat/shield-marketing-moment to main October 29, 2026 05:35
@georgewrmarshall
georgewrmarshall dismissed stale reviews from lwin-kyaw and brianacnguyen October 29, 2026 05:35

The base branch was changed.

@georgewrmarshall
georgewrmarshall requested a review from a team as a code owner October 29, 2026 05:35
…keting-moment

Keep the wallet-ready MarketingMoment scroll layout, take main's Tailwind Shield entry modal, and drop the unused stylesheet.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [faedef1]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40853384781 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/lcp: +20%
  • ↑ confirmTx/longTaskTotalDuration: +55%
  • ↑ confirmTx/longTaskMaxDuration: +88%
  • ↑ confirmTx/tbt: +96%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +85%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +113%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +147%
  • ↑ bridgeUserActions/longTaskMaxDuration: +64%
  • ↑ bridgeUserActions/tbt: +318%
  • ↑ bridgeUserActions/total: +30%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1283%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +18%
  • ↑ confirmTx/lcp: +1317%
  • ↑ bridgeUserActions/bridge_load_page: +254%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↑ bridgeUserActions/bridge_search_token: +34%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -38%
  • ↑ bridgeUserActions/lcp: +1233%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +11%
  • ↓ startupStandardHome/domInteractive: -17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +131%
  • ↓ startupStandardHome/fcp: -13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +40%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +43%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +30%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +28%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -48%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -56%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.41 MiB +130 Bytes 0.00%
✅ ui 19.26 MiB +857 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.99 MiB +691 Bytes 0.00%
✅ zip 24.11 MiB +392 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Oct 29, 2026
@amandaye0h
amandaye0h requested a review from lwin-kyaw October 29, 2026 11:46
@amandaye0h
amandaye0h added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 3c5531e Oct 29, 2026
264 of 266 checks passed
@amandaye0h
amandaye0h deleted the feat/wallet-ready-marketing-moment branch October 29, 2026 14:49
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut.

This branch was successfully deployed

1 active and 1 inactive deployments
pr-comment — faedef11 Deployed Oct 29, 2026 by amandaye0h via Publish prerelease / Publish prerelease #171840
segment-schema — faedef11 Deployed Oct 29, 2026 by amandaye0h via propose #1547
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-M team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants