Repository navigation
feat(onboarding): adopt MarketingMoment on the wallet-ready screen - #47423
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (5 files, +86 -100)
|
Builds ready [2d08725]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Register Grotzec Cond Bold as the hero typeface and exclude the commercial font from the repository license. The single Bold cut covers weights 400–700, which is the range DisplayXl and the design-system bold token actually request. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the shared marketing layout for Transaction Shield, keep the hero title metrics stable while Grotzec loads, and pin the actions below the scrolling copy. Co-authored-by: Cursor <cursoragent@cursor.com>
Show the hero title, animation, and actions through the shared marketing layout after a wallet is created. Co-authored-by: Cursor <cursoragent@cursor.com>
2d08725 to
f9448d6
Compare
301db9f to
0c022e1
Compare
Builds ready [f9448d6]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Show the SRP backup reminder in Storybook and drop the stylesheet now that the illustration is sized with utility classes. Co-authored-by: Cursor <cursoragent@cursor.com>
| ); | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Why we have these 2 components in the same file baffles me a bit but here we are. Checked in storybook
Screen.Recording.2026-10-28.at.1.36.20.PM.mov
…wrapper Storybook reused one router, so the reminder query never applied. The animation height now lives on the marketing moment artwork wrapper. Co-authored-by: Cursor <cursoragent@cursor.com>
| status === 'failed' | ||
| ) { | ||
| return <Box className="riv-animation__wallet-ready-container"></Box>; | ||
| return null; |
| <QueryClientProvider client={queryClient}> | ||
| <MemoryRouter initialEntries={initialEntries}> | ||
| <MemoryRouter | ||
| key={initialEntries.join('|')} |
There was a problem hiding this comment.
MemoryRouter only applies initialEntries when it mounts, and this decorator stays mounted as you move between stories. The key is the story URL, so a story with a different entry gets a fresh router. The reminder story depends on that, because the page reads isFromReminder from the location and otherwise stays on the wallet-ready layout.
|
|
||
| SrpBackupReminderStory.storyName = 'SRP backup reminder'; | ||
| SrpBackupReminderStory.parameters = { | ||
| initialEntries: ['/?isFromReminder=true'], |
There was a problem hiding this comment.
The page chooses the reminder layout from this query, through the same onboarding search params it uses in the app. The wallet-ready story leaves the default URL, so it renders the marketing moment. Both stories mount the same component; the URL is the switch.
|
|
||
| if (!isFromSettingsSRPBackup) { | ||
| return ( | ||
| <MarketingMoment |
There was a problem hiding this comment.
This path is the marketing moment: the ready title, the Rive artwork, and the done and manage-default-settings actions. The reminder path stays on the existing layout because it is a different screen, with the celebrating fox, the learn-how link, and a single back-to-wallet action. The test id stays on both roots so the completion checks still find the page.
| title={t('yourWalletIsReady')} | ||
| artwork={<WalletReadyAnimation />} | ||
| artworkWrapperProps={{ | ||
| className: 'pointer-events-none h-[400px] flex-none', |
There was a problem hiding this comment.
This replaces the old riv-animation container. The slot stays 400px tall and ignores pointer events, which is what that stylesheet did, and flex-none keeps the fixed height from being overridden by the template's flex-1. The animation itself only fills the slot.
Builds ready [7564259]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
## **Description** Upgrades the design system packages to the [v75.0.0 release](https://github.com/MetaMask/metamask-design-system/releases/tag/v75.0.0) and registers Grotzec Cond Bold as the hero typeface. Related: [DSYS-1150](https://consensyssoftware.atlassian.net/browse/DSYS-1150) **Packages upgraded:** - `@metamask/design-system-react`: `^0.45.3` → `^0.47.0` - `@metamask/design-tokens`: `^11.1.0` → `^12.0.0` - `@metamask/design-system-tailwind-preset`: `^0.14.0` → `^0.15.0` - `@metamask/design-system-shared`: `^0.39.0` → `^0.41.0` `FontFamily.Hero` and `--font-family-hero` now resolve to Grotzec Cond. Only the Bold cut is licensed. `TextVariant.DisplayXl` with that face computes to weight 600 below the `md` breakpoint and weight 500 at `md` and above, because design-system bold is 600, not 700. The `@font-face` rule maps weights 400–700 onto that one file so the browser does not synthesize a missing cut. MM Poly stays in the repo. Removing it is a follow-up. The NetworkListItem snapshot is updated because v74 changed the `MoreVertical` artwork. That test fails on this upgrade without the snapshot. Screen adoption of `MarketingMoment` is split into follow-up PRs so each code owner can review their own surface. ## **Changelog** CHANGELOG entry: Updated the hero typeface to Grotzec Cond Bold. ## **Related issues** [DSYS-1150](https://consensyssoftware.atlassian.net/browse/DSYS-1150) ## **Manual testing steps** 1. Build the extension (`yarn start`) and load `dist/chrome`. 2. Open the onboarding welcome screen and confirm the large welcome title renders in Grotzec Cond Bold, not a Helvetica fallback. 3. Spot-check a normal screen (home, asset list) and confirm body text still uses Inter and accent text still uses MM Sans. 4. Open a network list item options menu and confirm the vertical dots icon still renders. ## **Screenshots/Recordings** `MarketingMoment` template in Storybook at 1024px, light theme. Before is `main`. After uses Grotzec Cond Bold, captured on the MetaMask#47424 branch, which is stacked on this PR. | Story | Before | After | | --- | --- | --- | | MarketingMoment Default |  |  | | MarketingMoment Examples |  |  | On `main`, the Examples titles are clipped at 1024px. With Grotzec they wrap cleanly. ### **Fast follows** Screen adoption of `MarketingMoment` is split by code owner into these follow-ups: - MetaMask#47424: Shield entry modal (stacked on this PR) - MetaMask#47423: wallet-ready screen (stacked on MetaMask#47424) - MetaMask#47425: mUSD education screen (stacked on MetaMask#47424) ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Broad visual/token dependency bump and new licensed font assets; hero headlines across onboarding and marketing flows should be spot-checked, but no security or transaction logic changes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d188118. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> [DSYS-1150]: https://consensyssoftware.atlassian.net/browse/DSYS-1150?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [DSYS-1150]: https://consensyssoftware.atlassian.net/browse/DSYS-1150?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Cursor <cursoragent@cursor.com>
The base branch was changed.
…keting-moment Keep the wallet-ready MarketingMoment scroll layout, take main's Tailwind Shield entry modal, and drop the unused stylesheet. Co-authored-by: Cursor <cursoragent@cursor.com>
Builds ready [faedef1]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
|
No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut. |




Description
After a wallet is created, the wallet-ready screen uses the shared
MarketingMomentlayout: hero title, animation, then actions.Stacked on the Shield marketing-moment PR, which carries the shared title metrics and pinned actions. Base this PR on that branch until it merges, then retarget to
main.Code owner:
@MetaMask/web3auth(ui/pages/onboarding-flow).Changelog
CHANGELOG entry: Moved the wallet-ready screen onto the shared marketing layout.
Related issues
Follows the design system upgrade in #47128.
Manual testing steps
yarn start) and loaddist/chrome.Screenshots/Recordings
Storybook, light theme. Before is
main, after is this branch. The title moves above the animation and uses Grotzec.After (extension build)
The wallet-ready screen after creating a wallet in a local extension build.
wallet-ready-after-extension.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Made with Cursor
Note
Medium Risk
Changes a core onboarding completion screen and shared marketing layout, but preserves existing navigation, side-panel disable behavior, and the SRP reminder variant.
Reviewed by Cursor Bugbot for commit faedef1. Bugbot is set up for automated code reviews on this repo. Configure here.