Skip to content

release: 13.56.0 - #47508

Merged
sleepytanya merged 141 commits into
stablefrom
release/13.56.0
Nov 9, 2026
Merged

sleepytanya merged 141 commits into
stablefrom
release/13.56.0

Conversation

@metamaskbot

@metamaskbot metamaskbot commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

🚀 v13.56.0 Testing & Release Quality Process

Hi Team,
As part of our new MetaMask Release Quality Process, here’s a quick overview of the key processes, testing strategies, and milestones to ensure a smooth and high-quality deployment.


📋 Key Processes

Testing Strategy

  • Developer Teams:
    Conduct regression and exploratory testing for your functional areas, including automated and manual tests for critical workflows.
  • QA Team:
    Focus on exploratory testing across the wallet, prioritize high-impact areas, and triage any Sentry errors found during testing.
  • Customer Success Team:
    Validate new functionalities and provide feedback to support release monitoring.

GitHub Signoff

  • Each team must sign off on the Release Candidate (RC) via GitHub by the end of the validation timeline (Tuesday EOD PT).
  • Ensure all tests outlined in the Testing Plan are executed, and any identified issues are addressed.

Issue Resolution

  • Resolve all Release Blockers (Sev0 and Sev1) by Tuesday EOD PT.
  • For unresolved blockers, PRs may be reverted, or feature flags disabled to maintain release quality and timelines.

Cherry-Picking Criteria

  • Only critical fixes meeting outlined criteria will be cherry-picked.
  • Developers must ensure these fixes are thoroughly reviewed, tested, and merged by Tuesday EOD PT.

🗓️ Timeline and Milestones

  1. Today (Friday): Begin Release Candidate validation.
  2. Tuesday EOD PT: Finalize RC with all fixes and cherry-picks.
  3. Wednesday: Buffer day for final checks.
  4. Thursday: Submit release to app stores and begin rollout to 1% of users.
  5. Monday: Scale deployment to 10%.
  6. Tuesday: Full rollout to 100%.

✅ Signoff Checklist

Each team is responsible for signing off via GitHub. Use the checkbox below to track signoff completion:

Team sign-off checklist

  • Accounts
  • Assets
  • Bots Team
  • Confirmations
  • Core Extension UX
  • Core Platform
  • Design System
  • Emerging Opportunities
  • Extension Platform
  • Mobile Platform
  • Networks
  • Onboarding
  • Perps
  • Rewards

This process is a major step forward in ensuring release stability and quality. Let’s stay aligned and make this release a success! 🚀

Feel free to reach out if you have questions or need clarification.

Many thanks in advance

Reference

gauthierpetetin and others added 30 commits October 22, 2026 19:56
…47172)

## **Description**

Implements **Option B** from [ADR 0068 (state-write telemetry idle
definition)](https://github.com/MetaMask/decisions/blob/main/decisions/extension/0068-state-write-telemetry-idle-definition.md):
attach an agnostic **current-activity snapshot** to each sampled
split-state write so analysts can decide what context matters at query
time.

**Reason:** State-write telemetry already records size, controllers, and
related measurements. Option B adds a snapshot of what MetaMask is doing
when the write happens, without baking an arbitrary idle definition into
the client.

**Solution:**
- On each sampled write, capture `CurrentActivity` and report it on the
Sentry state-write event:
  - `popupCount`
  - `notificationIsOpen`
  - `fullscreenCount`
  - `sidePanelCount`
  - `startupPhase` (cold / warm / repair lifecycle, plus shutting-down)
- Reuse `uiPresence` for open-UI counts (no second census)
- Move reporting into `shared/lib/telemetry/state-write-reporter.ts` and
wire a `setCurrentActivityProvider` from the background

Historical/recency signals (Option C from the same ADR) are out of scope
here.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Reproduce manual testing steps detailed in this PR:
#46286
2. Confirm `environment_type`, `startup_phase`, and `ui_count`
properties are now added to `state.write` metdata of [State
Persist](https://metamask.sentry.io/explore/traces/?project=273496&query=transaction%3A%22State%20Persist%22&statsPeriod=30d)
traces in Sentry.

<img width="714" height="500" alt="Screenshot 2026-10-19 at 23 00 41"
src="https://github.com/user-attachments/assets/8a5288bd-4691-41a3-8c9b-76a1249d00d7"
/>

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Telemetry-only enrichment on persistence write events; startup-phase
updates are best-effort and do not gate init or repair.
> 
> **Overview**
> Adds **current-activity context** to sampled split-state write
telemetry (ADR Option B): each `splitStateWrite` event now carries
`environmentType` and a `currentActivity` snapshot (open UI counts from
`uiPresence`, plus `startupPhase`).
> 
> A new **`startup-phase`** helper tracks background lifecycle (cold /
warm / repair / shutting-down) via in-memory phase and MV3
`storage.session` flavor; `background.ts`, corruption repair, and safe
reload call `setStartupPhase` at the relevant milestones.
**`PersistenceManager.setCurrentActivityProvider`** snapshots that
context before async size measurement; missing or throwing providers
still emit writes with empty activity.
> 
> **`trackSplitStateWrite`** moves to
`shared/lib/telemetry/state-write-reporter.ts` and maps the new fields
onto Sentry `state.write.*` attributes (activity keys omitted when
undefined).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
64fbf7c. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
## **Description**

Bumps `@swc/core` from **1.13.3 → 1.16.2** to fix non-deterministic
Firefox builds (one of the [four root
causes](#46845) of
AMO rebuild mismatches in `runtime.js`). Background on the mechanism:
[comment on
#46845](#46845 (comment)).
Extracted from #46845. Webpack wiring was later simplified in #47092.

### Problem

SWC cached parsed `process.env` substitution values **with stale source
positions** from whichever file was compiled first. That corrupted
source maps, changed module hashes, and made rebuilds
non-byte-identical. The cache was also keyed incorrectly, so first-party
env substitutions could leak into `node_modules`.

Fixed upstream in swc-project/swc#12129 and swc-project/swc#12166
(shipped in **1.16.2**).

### What this PR changes

1. **Bump** `@swc/core` to 1.16.2.
2. **TypeScript loader:** `tsx: false` by default. Transform still
enables TSX from `.tsx` filenames, so `.ts` / `.mts` / `.tsx` share one
loader.
3. **`envValidationLoader`:** parse API does not enable TSX from the
filename, so it still sets `tsx` only for `.tsx` (avoids misparsing
generics in `.ts` / `.mts`).
4. **Vendor ESM env:** explicitly inline `IN_TEST` and `NODE_ENV` only.
`IN_TEST` used to leak in via the bad cache.
`@metamask/network-controller` needs it for the 1s test block-tracker
interval. Temporary until
[core#10831](MetaMask/core#10831) and
[#47090](#47090). CJS
vendors keep an empty env map.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Related:
[INFRA-3920](https://consensyssoftware.atlassian.net/browse/INFRA-3920)

## **Manual testing steps**

1. Compile webpack tooling if needed: `yarn webpack:tsc`
2. Build Firefox production: `yarn webpack:lavamoat:build:mv2 --env
production`
3. Load `dist/firefox` in Firefox (`about:debugging`), unlock or
onboard, confirm the UI works with no extension console errors.
4. Run the webpack unit tests that cover this change: `yarn test:unit
development/webpack/test/webpack.config.test.ts
development/webpack/test/loaders.envValidationLoader.test.ts`
5. Start a Chrome watch build: `yarn start`
6. Edit a `.tsx` file and confirm React Refresh updates without a parse
error.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
## **Description**

1. What is the reason for the change?
The current content makes no sense. It used to read `Continue to make
sure:`, now it reads `To continue make sure:`
2. What is the improvement/solution?
- `Continue to make sure:` ->  `To continue make sure:`


## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fix typo in hardware wallet error modal

## **Related issues**

Fixes: Follow up to:
https://consensyssoftware.atlassian.net/browse/MUL-2232

## **Manual testing steps**

1. Connect a Ledger
2. Close the eth app the device while it's connected
3. Initiate an action that requires the device (e.g. signing a
transaction)
4. Verify that the Eth app not open modal is shown and the content reads
`To continue make sure:``


## **Screenshots/Recordings**

### **Before**

<img width="860" height="674" alt="image"
src="https://github.com/user-attachments/assets/7553879e-b7f8-4573-872d-d2ab55b0e9a6"
/>

### **After**

<img width="423" height="896" alt="Screenshot 2026-10-21 at 7 16 03 PM"
src="https://github.com/user-attachments/assets/128d84ac-f9f4-433b-b3a5-849c9c91ed44"
/>


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> String-only change in two locale files with no logic, security, or
data-handling impact.
> 
> **Overview**
> Updates the hardware wallet error recovery screen heading in
**English** (`en` and `en_GB`) from *"Continue to make sure:"* to **"To
continue make sure:"** for clearer instructions when users troubleshoot
connection/unlock issues.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
7f6a58c. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…5.0 (#47302)

## **Howard intro**

This was done by Claude Sonnet 5.5 executing on [this
prompt](https://github.com/user-attachments/files/33750103/yarn-audit-triage-prompt.md),
and the description was written by Claude. We're testing to see if AI is
ready to do this all by itself.

## **Description**

I fixed 13 of the 14 advisories in the four new issues with a validated
change that sits uncommitted in the checkout. The remaining advisory
(`@vitest/mocker`) has no fix at this storybook major. I did not commit
or push, because you only authorized pushing to `trigger-ci-audit` for
the last run. I haven't run tests, `yarn audit` or the storybook build,
and I haven't regenerated LavaMoat policies. The post-change `yarn npm
audit` no longer lists the fixed packages, `yarn
lint:lockfile:dedupe:fix` caused no further change, and `git diff
--check` is clean.

## Audit Triage: #47251, #47258, #47297, #47299

**Target checked:** `main` at `6b79fa62` (fetched 2026-10-22). The
earlier fix is merged and its four issues are closed.
**Result:** 6 release-blocking advisory groups plus 1 low-severity
production one, all fixable. Informational: `storybook` (3 advisories)
and `stream-json` are fixable, `@vitest/mocker` is not, and the Electron
cluster is report-only.

### A. Already Resolved
None.

### B. Easy To Resolve
- **dompurify** (GHSA-cg2g-xh64-v4q7 critical, GHSA-mrv2-3pqr-j5jr high,
GHSA-c6gr-qvv4-5v3f low): production.
  - Chain: `metamask-crx -> dompurify`.
  - Fix: update `dompurify` from 3.4.16 to 3.4.17.
- It carries a yarn patch (two `<!-->` literals rewritten as `"<!" +
"--" + ">"`). The old patch didn't apply to 3.4.17, so I recreated it
with the same two substitutions in `dist/purify.cjs.js`, `purify.es.mjs`
and `purify.js`. The old patch file is removed. Please review this
patch.
- **toml** (GHSA-4qx8-w7c3-pj3p, GHSA-9j65-hcg3-gc64,
GHSA-9qmh-m7c6-f92p): high, production.
- Chain: `metamask-crx -> @metamask/eth-trezor-keyring ->
@trezor/connect-web -> @trezor/connect -> @trezor/blockchain-link ->
@stellar/stellar-sdk@13.3.0 -> toml@4.3.0`.
  - Fix: raise the existing resolution from `^4.2.0` to `^5.0.1`.
- No parent upgrade helps: `@stellar/stellar-sdk` latest is 17.3.0, and
it is a major jump through trezor.
- `stellar-sdk@13.3.0` asks for `toml@^3`, which the resolution already
overrides, so the major jump has precedent. I did not exercise stellar
at runtime.
- **ip-address** (GHSA-rxp7-6hxx-x8q5): moderate, production.
- Chain: `-> socks` and `-> @modelcontextprotocol/sdk ->
express-rate-limit -> ip-address`.
  - Fix: raise the existing resolution from `^10.7.2` to `^10.7.4`.
- **storybook** (GHSA-f2ph-cmg5-wxc8 critical, GHSA-px85-f4q5-jh77
high): dev-only, fixed in 9.1.21.
- Fix: bump `storybook`, `@storybook/addon-a11y`,
`@storybook/addon-docs` and `@storybook/react-webpack5` from 9.1.20 to
9.1.21, a patch bump that exists for all four.
  - I did not build or run storybook.
- **stream-json** (GHSA-jj87-hc4r-jwfw): moderate, dev-only.
- Chain: `metamask-crx -> @metamask/test-dapp-solana -> ... ->
jayson@4.2.0 -> stream-json@3.6.0`.
  - Fix: raise the existing resolution from `^3.5.0` to `^3.7.0`.

### C. Difficult To Resolve
- **@vitest/mocker** (GHSA-qxg6-89mg-rqv8 and the older
GHSA-82fw-gwwq-j7x9): moderate, dev-only.
  - Chain: `metamask-crx -> storybook -> @vitest/mocker@3.2.4`.
- Blocker: `storybook@9.1.21` still pins `@vitest/mocker` to exactly
3.2.4, and the fix needs 4.1.12 or later.
- Follow-up: storybook 10 (latest is 10.6.3), or a resolution across
majors. I didn't try the resolution.
- **Electron cluster (47 advisories)**: development-only,
`electron@23.3.0`.
  - This includes the seven new ones in #47251 and #47299.
  - Chain: `metamask-crx -> react-devtools@6.1.5 -> electron`.
- Blocker: `react-devtools` latest is 8.0.0 and still declares
`electron@^23.1.2`, while the advisories need 42.11.9 or later.
  - Status: report only.

### Development-only Leftovers
`@tootallnate/once`, `basic-ftp`, `bigint-buffer`, `braces`,
`decode-uri-component`, `got`, `ip`, `micromatch`, `nanoid`, `postcss`
and `sprintf-js` are unchanged from last time. None are fixable now, for
the same reasons as before: no patch exists, the patch is ESM-only, or
the fix needs a major bump through an old parent.

### Raw Recursive Audit
No numeric advisories outside these four issues' packages are new. The
only change in the leftover list is the new `@vitest/mocker` advisory,
GHSA-qxg6-89mg-rqv8 (#47258).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: #47251
Fixes: #47258
Fixes: #47297
Fixes: #47299

<!--## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Production bumps include dompurify (HTML sanitization), a major toml
resolution override, and patched dist edits that need review; Storybook
is dev-only.
> 
> **Overview**
> This PR bumps dependencies to clear security advisories, with
**`yarn.lock`** regenerated to match.
> 
> **Production-facing changes:** **`dompurify`** moves from **3.4.16**
to **3.4.17** via an updated Yarn patch that keeps the same two
string-splitting edits for empty-input and node-import paths (HTML
comment literals built as `"<!" + "--" + ">"` instead of a single
literal). Yarn **resolutions** raise **`ip-address`** to **^10.7.4**,
**`toml`** to **^5.0.1** (Stellar/Trezor chain), and **`stream-json`**
to **^3.7.0**.
> 
> **Dev-only:** Storybook packages (**`storybook`**,
**`@storybook/addon-a11y`**, **`@storybook/addon-docs`**,
**`@storybook/react-webpack5`**) go from **9.1.20** to **9.1.21**.
> 
> No application source changes—only **`package.json`**, lockfile, and
the dompurify patch file.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
dca0494. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
…47267)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Fixes LavaMoat scuttling errors when running Playwright tests against
production Chrome extension builds.

Changes:

- CDP bypass for executeScript — Uses CDP Runtime.evaluate in the main
world to avoid Playwright's internal Float32Array serialization, which
triggers scuttling.
- CDP bypass for pasteIntoField — Uses CDP isolated world to access
pristine DataTransfer/ClipboardEvent globals that LavaMoat hasn't
scuttled.
- Fix duplicate windows in dist builds — Polls for up to 3s to detect
auto-opened extension pages and reuses them instead of opening a second
window.

Fixes: https://consensyssoftware.atlassian.net/browse/AIENG-249

Note: we also need this for our Selenium => Playwright migration, so I
aimed for fixing the playwright driver methods instead of bypassing the
use of the paste which triggered the error (as it will eventually appear
in our e2e once we keep migrating).



## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Use a dist build
2. `yarn mm cleanup --shutdown`
3. `echo "SRP" | yarn mm launch --context prod --state onboarding
--self-onboarding`

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

See before and after



https://github.com/user-attachments/assets/626c2358-1265-4aa7-8902-a48ffead2a33


### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to E2E/Playwright test infrastructure and the LLM
extension launcher, not production extension code.
> 
> **Overview**
> Fixes Playwright **self-onboarding** and related E2E flows on **dist**
Chrome builds where **LavaMoat scuttling** broke `page.evaluate` /
locator evaluation (e.g. `Float32Array` during serialization) and where
forcing `home.html` on a blank tab fought dist’s auto-opened extension
page.
> 
> **`extension-launcher`**: After resolving the extension ID, it **polls
up to 3s** for an existing `chrome-extension://` tab and reuses it; only
if none appears does it open a blank tab and navigate to `home.html`.
> 
> **`driver-playwright`**: On **Chrome extension pages**,
**`executeScript`** runs via **CDP `Runtime.evaluate`** in the main
world, and **`pasteIntoField`** dispatches paste through **CDP
isolated-world** evaluation (with keyboard fallback). Non-extension
pages and Firefox keep the previous Playwright paths.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e68c505. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Package bump for AI agent orchestrator. Update: accept password param
for onboading script
Needed for this:
#47201


<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. You can try the whole flow in the PR branch:
#47201 pass an SRP
and password and see how the onboarding script works `printf '%s\n%s\n'
"<SRP>" "<password>" | yarn mm launch --state onboarding
--self-onboarding`

## **Screenshots/Recordings**
See 
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> <sup>[Cursor Bugbot](https://cursor.com/bugbot) is generating a
summary for commit 5450546. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
The self-onboarding launcher can now take a vault password from the
launch request, so callers can set a random one per run instead of the
fixed e2e default. Without one, it falls back to `DEFAULT_PASSWORD`. The
password is cleared after use.
Depends on the `@metamask/client-mcp-core` release that adds `password`
(bump pending).

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. yarn start
2. `yarn mm cleanup --shutdown`
2. `printf '%s\n%s\n' "<SRP>" "<password>" | yarn mm launch --state
onboarding --self-onboarding`
3. Lock the wallet and unlock it with `<password>`.

## **Screenshots/Recordings**


https://github.com/user-attachments/assets/01d25e85-1672-4ff1-9282-f3cca83e528c


<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> E2E/LLM launcher and test plumbing only; no production wallet or auth
paths, with fallback to the existing default password.
> 
> **Overview**
> **Self-onboarding** in the LLM workflow launcher can now take an
optional **vault password** on the launch path (documented as a second
stdin line for `mm launch --self-onboarding`). Callers can use a per-run
password instead of the fixed e2e default; if omitted, behavior stays on
`DEFAULT_PASSWORD`.
> 
> `MetaMaskSessionManager.launch` reads `password` from the session
request, forwards it to `MetaMaskExtensionLauncher`, and **clears it
from the request** alongside the SRP. The launcher uses that value for
`runSelfOnboarding` and `finishOnboarding`, zeroes it in a `finally`
block, and folds the post-import home navigation into the same guarded
block. Types and unit tests cover forwarding and the unset-password
case.
> 
> Depends on a `@metamask/client-mcp-core` release that adds `password`
to the launch input.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
8350911. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## Version Bump After Release

This PR bumps the main branch version from 13.55.0 to 13.56.0 after
cutting the release branch.

### Why this is needed:
- **Nightly builds**: Each nightly build needs to be one minor version
ahead of the current release candidate
- **Version conflicts**: Prevents conflicts between nightlies and
release candidates
- **Platform alignment**: Maintains version alignment between MetaMask
mobile and extension
- **Update systems**: Ensures nightlies are accepted by app stores and
browser update systems

### What changed:
- Version bumped from `13.55.0` to `13.56.0`
- Platform: `extension`
- Files updated by `set-semvar-version.sh` script

### Next steps:
This PR should be **manually reviewed and merged by the release
manager** to maintain proper version flow.

### Related:
- Release version: 13.55.0
- Release branch: release/13.55.0
- Platform: extension
- Test mode: false

---
*This PR was created manually (auto-create-release-pr failed on token
auth, see #47274).*

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Single metadata version bump in package.json with no runtime or
dependency changes.
> 
> **Overview**
> Bumps the extension package version on **main** from **13.55.0** to
**13.56.0** after the **13.55.0** release branch was cut. The only code
change is the `version` field in `package.json`, so upcoming **main**
nightlies and dev builds report a semver ahead of the current release
candidate and stay aligned with the release workflow described in the
PR.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
3a28079. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Removes four files under `shared/` that nothing in the repo imports or
references (no imports, no string/path references in configs, no jest
mocks, no open PRs touching them). All touched files have no CODEOWNERS
entry.

| path | removed | why dead |
| --- | --- | --- |
| `shared/constants/custody.ts` | file (`AccountType`, `CustodyStatus`
enums, MMI leftovers) | zero refs |
| `shared/lib/hash.utils.ts` | file (`sha256`) | zero refs |
| `shared/lib/keyring.ts` | file (`findKeyringId`,
`findKeyringIdByAddress`) | zero refs |
| `shared/constants/multichain/accounts.ts` | file
(`MULTICHAIN_ACCOUNT_TYPE_TO_SNAP_ID`,
`MULTICHAIN_ACCOUNT_TYPE_TO_NAME`) | zero refs |

All files were added more than 90 days ago and none changed in the last
30 days. Snap ID constants and `isEqualCaseInsensitive` that these files
imported remain used elsewhere, so there is no cascade.

No user-facing behavior change.

Checks run: `yarn lint:tsc`, `yarn test:unit shared/constants
shared/lib` (168 suites passed, no snapshot updates). No remaining
source files were edited, so there was nothing for eslint or stylelint
to lint.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<div><a
href="https://cursor.com/agents/bc-84700659-6745-4d51-a288-27b4d86aa9f6?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/b160435f-ce35-11f1-89ee-7aa6f0729b11"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Pure deletion of unreferenced code with no call sites; no security,
auth, or data-path changes.
> 
> **Overview**
> Deletes four unused modules under `shared/` with no remaining imports
or references: custody enums (`AccountType`, `CustodyStatus`),
multichain account-to-snap/name maps, `sha256` in `hash.utils.ts`, and
keyring helpers `findKeyringId` / `findKeyringIdByAddress`.
> 
> This is proactive dead-code cleanup (aligned with the mobile extension
counterpart); dependencies those files used elsewhere in the repo are
unchanged. **No user-facing or runtime behavior change.**
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
48494e0. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: george.marshall <george.marshall@consensys.net>
…works (#47239)

## **Description**

Tron's E2E suite already has a deterministic snap-account readiness poll
(`waitForTronAccountToBeReady` in `tron-network.flow.ts`), while the
shared `switchToNetworkFromNetworkSelect` flow still uses a fixed 5s
delay (`NON_EVM_SNAP_READY_DELAY_MS`) for `Tron` and `Bitcoin`, with a
TODO asking for exactly that deterministic wait.

**Changes:**
- Generalize the readiness poll into `waitForSnapAccountReady(driver, {
snapId, scope })` in `network.flow.ts`, with a pure predicate
(`isSnapAccountReady`) that checks: snap running, selected wallet ready,
selected group contains an internal account scoped to the network.
- Wire it into `switchToNetworkFromNetworkSelect` for snap-backed
non-EVM networks (Tron, Bitcoin, Solana), replacing the fixed 5s delay
hack.
- Deletes the now-redundant `waitForTronAccountToBeReady` shell;
`selectTronNetwork` is a thin wrapper over the universal switch, which
waits internally.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: #46113 (part of the flaky Tron E2E work — deterministic wait
replaces fixed delay)

## **Manual testing steps**

1. Run the extension and complete onboarding with an SRP that has Tron
and Bitcoin snap accounts enabled.
2. On the homepage, open the network filter and switch to Tron.
3. Verify the switch waits for the Tron snap to be ready (balances load)
rather than failing when switched too early.
4. Repeat with Bitcoin.
5. Optionally run: `yarn test:e2e:single
test/e2e/tests/tron/check-balance.spec.ts --browser=chrome`

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## **Description**

Adds a helper workflow that reads analytics TypeScript changes on a pull
request and can open one draft pull request on Consensys/segment-schema
after the author agrees. It is not a merge gate.

The action is pinned to github-tools
[v1.21.0](https://github.com/MetaMask/github-tools/releases/tag/v1.21.0)
(`5d993ac935eff3f248d2213bb2d6922ce9cb3510`). `propose` and `close` run
for changes under `ui/`, `app/scripts/`, or
`shared/constants/metametrics.ts`, excluding tests and snapshots.
`create` runs only after this file is on the default branch.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes
[MCWP-911](https://consensyssoftware.atlassian.net/browse/MCWP-911)
related to
[MCWP-575](https://consensyssoftware.atlassian.net/browse/MCWP-575)
Shipped in github-tools
[v1.21.0](https://github.com/MetaMask/github-tools/releases/tag/v1.21.0).

## **Manual testing steps**

This pull request only adds a workflow file, so `propose` does not run
here.

After merge:

1. Open a ready, same-repo pull request that changes a non-test file
under `ui/` or `app/scripts/`, or `shared/constants/metametrics.ts`, and
includes an analytics event change.
2. Confirm the `propose` job posts one sticky comment and does not open
a schema pull request yet.
3. As the pull request author, comment with the first line `I agree to
open a draft Segment schema PR`.
4. Confirm `did-user-agree-to-create-pr`, then `is-cross-repo-pr`, then
`create` open one draft on Consensys/segment-schema.
5. Close the client pull request without merging and confirm the schema
draft is closed. Reopen that schema pull request manually if the branch
should be kept.

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with [Cursor](https://cursor.com)

[MCWP-911]:
https://consensyssoftware.atlassian.net/browse/MCWP-911?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[MCWP-575]:
https://consensyssoftware.atlassian.net/browse/MCWP-575?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Introduces GitHub App credentials and cross-repo PR writes to
segment-schema, but creation is author opt-in and gated by labels, fork
checks, and protected environments—not a merge blocker.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d929f01. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

- Adds tests/account-activity/solana/solana-activity-types.spec.ts — E2E
coverage for Solana activity network filtering: EVM activity is hidden
under the Solana-only filter and shown again under all networks. The
Solana send renders from RPC history mocks through the snap's real
mapping path (no state seeding); the EVM send comes from the accounts
activity API mocks.
- Extends tests/solana/send-flow.spec.ts — asserts the local validator's
funding airdrop (a real receive classified by the snap mapper) renders
as 'Received SOL' in the activity list.
- Moves the previously duplicated mock-evm-activity-api.ts to
tests/account-activity/utils/ so the Tron and Solana clusters share one
copy, and updates the Tron spec's import.
- Documents, as TODOs in the new spec, the activity cases deferred until
the Solana snap supports them: approve (the mapper classifies by token
balance deltas only, so SPL delegations render as 'Interaction'), and
bridge / swap-and-bridge in+out details (no deterministic history-sync
trigger — the snap has no continuous-sync cronjob, unlike Tron).

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Related:
[WPN-524](https://consensyssoftware.atlassian.net/browse/WPN-524)

## **Manual testing steps**

1. Run the activity-types spec (2 tests: types + network filter)
`yarn test:e2e:single
test/e2e/tests/account-activity/solana/solana-activity-types.spec.ts
--browser chrome`

2. Run the activity-status spec (1 test: pending + failed)
`yarn test:e2e:single
test/e2e/tests/account-activity/solana/solana-activity-status.spec.ts
--browser chrome`

## **Screenshots/Recordings**

n/a

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[WPN-524]:
https://consensyssoftware.atlassian.net/browse/WPN-524?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to E2E tests and shared test mocks; no production
wallet or API behavior is modified.
> 
> **Overview**
> Adds **Solana activity E2E coverage** for the network filter: under
Solana-only, SOL activity shows and mocked EVM “Sent ETH” stays hidden;
switching to all networks shows both, then Solana-only hides EVM again.
The spec wires `buildSolanaTestSpecificMock` with the shared
`mockEvmActivityApi` helper.
> 
> **Test hygiene:** `mockEvmActivityApi` lives under
`test/e2e/tests/account-activity/utils/` (Tron import updated); its doc
comment now describes any non-EVM-only filter, not just Tron. The Solana
send-flow happy path also asserts a **“Received SOL”** entry for the
validator funding airdrop alongside the send.
> 
> Follow-up TODOs in the new spec document deferred cases (approve,
bridge/swap details) until snap-solana-wallet supports them.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
751470e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Money routes can be a dead-end if reached without the bottom navbar

The bottom navbar is dependent on LaunchDarkly and if unavailable can
cause the dead-end scenario above

Since bottom navbar has been resolved to treatment in the latest main
branch, retroactively applying it to older versions to avoid the issue
above

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: enable bottom navbar

## **Related issues**

https://consensys.slack.com/archives/C06FXU326RL/p1792765914662259

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.



<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes default UX for one AB test when flags are missing or invalid,
which affects navigation on money routes but is limited to non-test
runtime and preserves explicit flag assignments.
> 
> **Overview**
> When LaunchDarkly does not yield a valid bottom-nav AB assignment,
**`resolveABTestAssignment`** now falls back to **`treatment`** (bottom
navbar on) instead of **`control`**, matching the resolved behavior on
latest main and avoiding money flows that become a dead end without the
navbar.
> 
> The special-case applies only for **`BOTTOM_NAV_AB_TEST_KEY`** and is
skipped when **`IN_TEST`** or **`NODE_ENV === 'test'`**, so other AB
tests still default to **`control`** and unit tests keep the prior
behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d58b39a. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…47294)

## **Description**

Proactive dead-code cleanup. This PR deletes two `index.ts` barrels
under `ui/pages` that nothing imports, plus the
`SnapAccountTransactionLoadingScreen` page component, which is only
referenced by its own test (its barrel is unused too, and no route or
other component renders it).

All touched files have no CODEOWNERS entry.

| path | removed | why dead |
| --- | --- | --- |
| `ui/pages/basic-functionality-required/index.ts` | file (re-export of
`BasicFunctionalityOff`) | unused barrel (routes lazy-load
`basic-functionality-required.tsx` directly) |
| `ui/pages/snap-account-redirect/components/index.ts` | file (re-export
of `SnapAccountRedirectContent`) | unused barrel |
| `ui/pages/snap-account-transaction-loading-screen/index.ts` | file |
unused barrel |
|
`ui/pages/snap-account-transaction-loading-screen/snap-account-transaction-loading-screen.tsx`
| file (`SnapAccountTransactionLoadingScreen`) | only own test |
|
`ui/pages/snap-account-transaction-loading-screen/snap-account-transaction-loading-screen.test.tsx`
| file | cascade from the deleted component |

The `SnapAccountTransactionLoadingViewed` analytics event name and the
`loadingScreenSnapMessage` locale key are intentionally left in place.

No user-facing behavior change.

Checks run: `yarn lint:tsc` passes, and `yarn test:unit` passes on
`ui/pages/basic-functionality-required`,
`ui/pages/snap-account-redirect`, and
`ui/helpers/higher-order-components/require-basic-functionality` with no
snapshot updates. No surviving files were edited, so eslint has nothing
to check, and no stylesheets changed.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<div><a
href="https://cursor.com/agents/bc-a74bfe1d-58ce-4058-a480-30583153d174?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/b160435f-ce35-11f1-89ee-7aa6f0729b11"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unused files and orphaned i18n strings only; no routing, auth,
or transaction logic is modified.
> 
> **Overview**
> Removes unreachable UI under `ui/pages`: two unused `index.ts` barrel
re-exports (`basic-functionality-required`,
`snap-account-redirect/components`) and the entire
**`SnapAccountTransactionLoadingScreen`** page (component, unit tests,
and its barrel). That screen only showed the `loadingScreenSnapMessage`
copy and fired **`SnapAccountTransactionLoadingViewed`** analytics;
nothing in routes or other components imported it.
> 
> The **`loadingScreenSnapMessage`** entry is deleted from all locale
`messages.json` files now that the only consumer is gone. The
**`SnapAccountTransactionLoadingViewed`** metric name remains in
constants but is no longer emitted.
> 
> No intended user-facing behavior change—this is proactive dead-code
cleanup aligned with the mobile counterpart.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
247ee84. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: george.marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR removes five barrel `index.ts` files under `ui/components/app`
that nothing imports. Every consumer imports the component file directly
(for example `../../app/download-mobile-modal/download-mobile-modal`),
so the barrels are unreachable in all build types and both manifests.
The components themselves are untouched.

All touched files have no CODEOWNERS entry.

| path | removed | why dead |
| --- | --- | --- |
| `ui/components/app/delete-metametrics-data-button/index.ts` | file |
unused barrel |
| `ui/components/app/download-mobile-modal/index.ts` | file | unused
barrel |
| `ui/components/app/metametrics-toggle/index.ts` | file | unused barrel
|
| `ui/components/app/password-form/index.ts` | file | unused barrel |
| `ui/components/app/modals/pna25-modal/index.ts` | file | unused barrel
|

How they were verified as dead: knip reported each file as unreferenced,
with tests, stories, and mocks counted as roots. A whole-repo search for
the directory names and paths found no imports, `jest.mock` paths, or
config references that resolve to these barrels. No open PR references
or edits them. Each one was added more than 90 days ago.

No user-facing behavior change.

Checks that passed: `yarn lint:tsc`, and `yarn test:unit` on the
affected component directories and their consumers (`account-overview`,
`home`, `onboarding-flow/privacy-settings`): 12 suites, 102 tests, no
snapshot updates. No surviving source files changed, so ESLint had
nothing to lint.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)

## **Manual testing steps**

N/A — deletes unreachable code. There is no user-facing behavior to
click through.

## **Screenshots/Recordings**

N/A — no UI change

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<div><a
href="https://cursor.com/agents/bc-d5084802-192a-4265-a8f2-ed775562b2e8?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/b160435f-ce35-11f1-89ee-7aa6f0729b11"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Deletes unreferenced barrel files only; component implementations and
import paths are unchanged.
> 
> **Overview**
> Removes five dead `index.ts` barrel re-exports under
`ui/components/app` for **delete-metametrics-data-button**,
**download-mobile-modal**, **metametrics-toggle**, **password-form**,
and **modals/pna25-modal**.
> 
> Call sites already import the concrete component modules (e.g.
`../password-form/password-form`), so deleting these barrels does not
change exports or runtime behavior—only unreachable re-export shims.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
09afea0. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: george.marshall <george.marshall@consensys.net>
## **Description**

Stacked on
[#46302](#46302).

Removes `TokenBalancesController` initialization, messenger wiring,
polling APIs, and runtime consumers. Balance refresh paths now use
`AssetsController`, while Transaction Pay receives an
AssetsController-backed compatibility state shape. Fixtures and tests no
longer seed or mock the removed controller.

Persisted-state cleanup is intentionally deferred to one final migration
PR at the end of the controller-removal stack.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Build and load the extension with Assets Unified State enabled.
2. Unlock a wallet containing ERC-20 assets and verify balances appear
in the asset list.
3. Switch between enabled EVM networks, refresh the asset list, and
verify balances update.
4. Start an ERC-20 send and verify the displayed balance and max-balance
validation are correct.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with [Cursor](https://cursor.com)

---

<sub>Stack created with <a
href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a
href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Removes the dedicated EVM token balance polling/updater and shifts
refresh to AssetsController; incorrect unify selectors or refresh paths
could show stale or wrong balances until the rest of the stack lands.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a23ed97. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
…ate readiness check (#46863)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Refactors the snap E2E test install flow to streamline the specs and fix
a race-condition-driven flakiness.



1. `openTestSnapClickButtonAndInstall` absorbs
`checkInstallationComplete`: 25 spec files previously called the flow
and then separately called `testSnaps.checkInstallationComplete()` right
after.
Now they pass `expectedMessage` as an option and the flow handles it
internally.

2. Deterministic snap-ready state check: after install, the flow can now
poll MetaMask's Redux state via `getCleanAppState` to confirm the snap
is enabled and no longer in installing status before returning. This
ensures the background has fully committed the snap install before the
test continues.

3. Removed temporary retry from `openGlobalMenu`: [PR
#46503](#46503 (review))
added a retry block to `header-navbar.ts` as a temporary fix for a flaky
homepage snap test.

4. Fixed `localhost` to `127.0.0.1` in `test-snap-dialog` and
`test-snap-networkaccess`: both tests were failing locally because the
dapp page failed to open when using localhost.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:
[MMQA-2441](https://consensyssoftware.atlassian.net/browse/MMQA-2441?atlOrigin=eyJpIjoiZDgyMTllYzEwNzM3NGJhNmJlZjNhNGM4MmFhMzE5ZjIiLCJwIjoiaiJ9)

## **Manual testing steps**

1. Run the test to make sure they pass

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[MMQA-2441]:
https://consensyssoftware.atlassian.net/browse/MMQA-2441?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changes are limited to E2E test helpers, mocks, and specs with no
production wallet or security logic touched.
> 
> **Overview**
> **Refactors Snap E2E install helpers** to centralize post-install
waits and cut race-driven flakiness.
> 
> `openTestSnapClickButtonAndInstall` now accepts **`expectedMessage`**
(runs the former per-spec `checkInstallationComplete` on the connect
button) and optional **`snapId`** (polls MetaMask Redux via
`getCleanAppState` until the snap is enabled and not `installing`).
Dozens of snap specs pass these options instead of duplicating
install-complete checks.
> 
> **Other test fixes:** the test-snaps site mock proxies fetches to
**`127.0.0.1`** instead of `localhost`; **`openGlobalMenu`** drops a
temporary double-click retry now that install timing is handled in the
flow; dialog spec drops a redundant localhost URL override.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
3191544. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## **Description**

The development runtime is pinned to Node `v24.13`, and both package
manifests still accept Node `>=24.13.0`. [Node
24.22.1](https://nodejs.org/en/blog/release/v24.22.1), released October
20, 2026, is the latest Node 24 LTS patch.

Pin `.nvmrc` to `v24.22.1` and raise `engines.node` to `>=24.22.1` in
the root manifest and `development/generate-attributions/package.json`.
This excludes older Node releases while continuing to allow newer
versions. Yarn requirements and dependency versions are unchanged.

### Validation

Under Node `24.22.1`:

- Development build passed (`yarn build:dev`).
- Semver boundary checks passed for both manifests: older versions,
including `24.22.0`, are rejected; `24.22.1` and newer releases are
accepted. The exact `.nvmrc` pin matches both minimums.
- `yarn lint:changed:fix` passed (no changed code files to lint).
- JSON formatting checks passed for both manifests.
- `yarn circular-deps:check` passed.
- `git diff --check` passed.

Full typechecking is not passing in the local checkout: `yarn lint:tsc`
cannot find the `tsc` executable link. Invoking the installed compiler
directly reports errors in unchanged code, including missing dependency
exports such as `SwapFeatureTag` from `@metamask/bridge-controller`.
These errors were not addressed in this metadata-only change. CI
validation is pending.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Check out the branch, run `nvm install` and `nvm use`, and confirm
`node --version` reports `v24.22.1`.
2. Start the development build with `yarn start` and load `dist/chrome`
as an unpacked extension in Chrome.
3. Open the extension and confirm the onboarding or unlock screen loads
without a runtime error.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability.
- [x] I've included tests if applicable (no test-file changes needed for
runtime metadata; semver boundary checks passed).
- [x] I've documented my code using JSDoc if applicable (not applicable:
no code or public API changes).
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Metadata-only engine and `.nvmrc` updates with no application or
dependency changes; main impact is developers must upgrade local Node.
> 
> **Overview**
> Bumps the required Node.js version from **24.13** to **24.22.1**
(latest Node 24 LTS patch).
> 
> `.nvmrc` is pinned to `v24.22.1`, and `engines.node` is raised to
`>=24.22.1` in the root `package.json` and
`development/generate-attributions/package.json`. Older Node releases
(including `24.22.0` and prior `24.13.x`) are no longer accepted; newer
Node 24 versions remain allowed. Yarn and dependency versions are
unchanged.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d59fedc. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Mirror of this mobile PR:
MetaMask/metamask-mobile#38061

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2400

## **Manual testing steps**

Feature: email enrollment failure

  Scenario: enrollment fails
    Given the user is on the email verification screen
    When they enter a valid email and press Continue
    And POST /api/v2/mfa/enroll fails
    Then they stay on the email verification screen
And they see "Something went wrong. Try again." under the email field
    And they do not see "We sent a 6-digit code"

  Scenario: enrollment succeeds
    Given the user is on the email verification screen
    When they enter a valid email and press Continue
    And POST /api/v2/mfa/enroll succeeds
    Then they see the verification code screen
    And the description says a 6-digit code was sent

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Localized MFA email-enrollment navigation change with tests; no auth
or API contract changes beyond when the UI advances.
> 
> **Overview**
> Fixes misleading MFA email enrollment UX: users no longer land on the
OTP screen with “we sent a code” when `beginCredentialEnrollment` has
not succeeded.
> 
> **`submitEmailAddress` in the MFA flow engine** now runs enrollment
(`beginCodeChallenge`) while still on **email entry**, and only
transitions to the OTP step with `codeSent: true` after that call
succeeds. On failure, the flow stays on `emailEntry` with the error
(e.g. generic “Something went wrong”) instead of the code screen.
> 
> Adds engine and **EmailEntryStep** UI tests for failed enrollment and
server errors under the email field.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
7415d67. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The swap test flakes when it clicks mUSD on the Select token screen.
Search results rebuild the list, and the click hits a row that has
already been replaced.

**Flake type:** Race Conditions with React Re-renders

**Root cause:**

- The test opens Swap and searches the destination token list for mUSD.
- It waits until the mUSD row stops moving, then clicks that row.
- The list first shows a local placeholder for mUSD.
- Search results then come back and rebuild the list, and mUSD moves
down to a later row.
- The wait only checks that the row has stopped moving on screen, so it
passes on the placeholder.
- The click then hits a row that React has already removed.
- The failure screenshot still shows the Select token screen. The search
box says mUSD. The list shows DAI, USDT, USDC, FXS, WETH, and mUSD with
a red Malicious badge. The mUSD row is highlighted, and nothing covers
it.
- The click failed because that row was replaced, not because the row
was missing.

**Solution:**

- Point the quote page at the existing token-list loading skeleton
(`bridge-asset-loading-skeleton`) - the test can see when the list is
still loading.
- Add a helper that waits for the token row, waits until that skeleton
is gone (and does not pass before the search has had time to return),
clicks the row once, then waits until the picker search box is gone -
the click happens after the list has finished rebuilding, and a closed
picker confirms the click worked.
- Use that helper when entering a quote's destination token, and when
searching for a token or selecting a source or destination token - those
steps were clicking a row that could be replaced when search results
arrived.

Slack:
https://consensys.slack.com/archives/CTQAGKY5V/p1792751117762509?thread_ts=1792743734.004429&cid=CTQAGKY5V

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Start a test build with `yarn start:test` and leave it running.
2. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/bridge/swap-positive-cases.spec.ts --browser=chrome`.
3. Confirm "submits swap with price impact error and multiple token
alerts" selects mUSD on the Select token screen and submits the swap.

## **Screenshots/Recordings**
<img width="1366" height="682" alt="image"
src="https://github.com/user-attachments/assets/4202d0bd-10b5-4552-9938-859f77f891e9"
/>

### **Before**

CI failure screenshot from the Firefox job. The wallet is on the Select
token screen. The search field still contains mUSD. The list shows DAI,
USDT, USDC, FXS, WETH, and mUSD. mUSD has a red Malicious badge and is
highlighted. The click threw StaleElementReferenceError because the
virtualized list rebuilt when search results arrived, so the row node
the test had already found was no longer in the DOM.

### **After**

No product UI change. The test waits until the token-list loading
skeleton is gone, clicks the token once, then waits until the picker
search box is gone.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> E2E page-object changes only; no production bridge or swap UI logic is
modified.
> 
> **Overview**
> Stabilizes bridge/swap E2E flows when picking a token after search by
replacing **“wait until the row stops moving, then click”** with a
shared **`selectAssetFromPicker`** helper on `BridgeQuotePage`.
> 
> The helper waits for the matching token row, asserts
**`bridge-asset-loading-skeleton`** is gone (with at least the quote
debounce window), clicks once, then waits until the picker search field
disappears. **`enterBridgeQuote`**, **`searchForAssetAndSelect`**,
**`selectDestToken`**, and **`selectSrcToken`** now route
destination/source selection through this path so clicks happen after
the list finishes rebuilding, avoiding stale-row
**`StaleElementReferenceError`** flakes (e.g. mUSD on swap).
> 
> No application UI or behavior changes—test page object only.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a87d262. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Cursor <cursoragent@cursor.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2395

## **Manual testing steps**

Login with social, verify you don't have Email as an MFA method in the
MFA settings (security > 2 step verification)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped MFA settings UI change reusing an existing social-login
selector; no auth or enrollment API changes.
> 
> **Overview**
> **MFA settings** no longer shows the **email** verification row when
the user signed in via **social login**, since that address is tied to
the IdP rather than a separate second factor. **Authenticator app
(TOTP)** remains available.
> 
> The page reads `getIsSocialLoginFlow` from Redux and filters
`email_otp` out of the settings rows before render. A unit test asserts
the email row is absent and the TOTP row still appears for social-login
users.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a6f371f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## **Description**

Follow-up to #47239 (merged). With snap-account readiness now handled
deterministically inside `switchToNetworkFromNetworkSelect`, the
Tron-specific wrapper flows are redundant.

**Changes:**
- Deletes `tron-network.flow.ts` (`selectTronNetwork`, `landOnTronHome`)
and `tron-activity.flow.ts` (`openTronActivityList`).
- Callers now use the shared flows directly, matching how EVM/Solana
specs already work: `switchToNetworkFromNetworkSelect(driver, 'Tron')`
and inline `goToActivityList()` page-object calls.
- `tests/swaps/tron.spec.ts` inlines the shared `login` +
`switchToNetworkFromNetworkSelect(driver, 'Tron')` + homepage-readiness
calls. The default-token test waits for the seeded TRX balance before
opening the swap form so TRX is the default source token (snap balances
load asynchronously).
- `tests/tron/assets.spec.ts` keeps its spec-local `landOnTronHome` (it
has a different shape — it refreshes before checking the token list and
needs no balance assertion).

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Follow-up to: #47239
Continues the E2E refactor from: #46113

## **Manual testing steps**

No manual testing required: this PR only refactors E2E helpers and
specs, with no product code or user-facing behavior changes.

Affected specs: `tests/swaps/tron.spec.ts`,
`tests/tron/account-derivation.spec.ts`,
`tests/account-activity/tron/tron-activity-status.spec.ts`,
`tests/account-activity/tron/tron-activity-types.spec.ts`.

<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Removes the trigger to run the tests in the
extension-regression-validation-poc as that repo will be archived.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> CI-only change; it stops an external POC dispatch and does not alter
extension build, test, or release artifact logic.
> 
> **Overview**
> Removes the **Trigger Regression Validation** job from the main
workflow, so `release/*` PRs and pushes no longer dispatch
`release_pr_updated` to `MetaMask/extension-regression-validation-poc`
(build run id, version, branch, commit).
> 
> Also drops that job from **`ci-status-gate`** `needs`, so merge/CI
gating no longer waits on or reports its result.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ea93740. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
…on macOS (#47336)

## **Description**

On a fresh clone of `main` on macOS, `yarn install --immutable` fails
with:

```
@lavamoat/allow-scripts has detected dependencies without configuration.
packages missing configuration:
- gulp>glob-watcher>chokidar>fsevents#1.2.13
```

It seems to trace back to #46865 (9 Oct), which removed the global
`chokidar` resolution: `gulp` > `glob-watcher` now resolves
`chokidar@2.1.8`, which pulls in the macOS-only `fsevents@1.2.13`, and
that package has an install script with no `lavamoat.allowScripts`
entry. Linux CI never installs `fsevents`, which would explain why CI
stays green. A review to confirm the cause would help; in the meantime
this change fixes the install.

This adds a `glob-watcher/chokidar: ^3.6.0` resolution, which drops
`fsevents@1.2.13` and the chokidar 2 tree from `yarn.lock`, and
regenerates the LavaMoat policies.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Refs: https://consensyssoftware.atlassian.net/browse/TAT-4259

## **Manual testing steps**

1. On macOS, clone `main` and run `yarn install --immutable`: it fails
with the error above.
2. Check out this branch and run `yarn install --immutable`: it exits 0.
3. `find node_modules -name fsevents -type d` shows no 1.x version.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


## **Validation Recipe**

<details><summary>recipe.json (7 nodes — TAT-4259 yarn install without
fsevents@1)</summary>

```json
{
  "$schema": "https://farmslot.io/schemas/recipe-v1.schema.json",
  "title": "TAT-4259 yarn install without fsevents@1",
  "description": "Observes yarn install --immutable on macOS with no fsevents@1 installed, plus a local allow-scripts auto no-diff check. Linux allow-scripts and CI are not proven here.",
  "proofTargets": [
    {
      "id": "AC-1",
      "claim": "[TAT-4259] On macOS a clean yarn install --immutable on the PR branch exits 0 and no fsevents@1.2.13 is installed."
    },
    {
      "id": "AC-2",
      "claim": "[TAT-4259] On Linux yarn allow-scripts auto && git diff --exit-code stays clean and CI passes.",
      "proofMode": "review"
    },
    {
      "id": "AC-3",
      "claim": "[TAT-4259] The diff is only the resolution, the yarn.lock change and a changelog entry if required.",
      "proofMode": "review"
    }
  ],
  "workflow": {
    "entry": "ac1-yarn-install-immutable",
    "nodes": {
      "ac1-yarn-install-immutable": {
        "action": "command",
        "cmd": "yarn install --immutable; echo \"YARN_EXIT=$?\"",
        "timeout_ms": 600000,
        "next": "ac1-assert-install-output"
      },
      "ac1-assert-install-output": {
        "action": "assert_output",
        "source": "ac1-yarn-install-immutable",
        "stream": "stdout",
        "contains": "YARN_EXIT=0",
        "intent": "The install exited 0.",
        "proves": [
          "AC-1"
        ],
        "next": "ac1-list-fsevents"
      },
      "ac1-list-fsevents": {
        "action": "command",
        "cmd": "find node_modules -type d -name fsevents -prune -exec grep -H '\"version\"' {}/package.json \\; ; echo \"SCAN_DONE\"",
        "intent": "Collect every installed fsevents version in node_modules.",
        "next": "ac1-assert-no-fsevents-1"
      },
      "ac1-assert-no-fsevents-1": {
        "action": "assert_output",
        "source": "ac1-list-fsevents",
        "stream": "stdout",
        "match": "^(?![\\s\\S]*\"version\": \"1\\.)[\\s\\S]*SCAN_DONE",
        "intent": "No installed fsevents is a 1.x version, and the scan did run.",
        "proves": [
          "AC-1"
        ],
        "next": "ac2-allow-scripts-auto"
      },
      "ac2-allow-scripts-auto": {
        "action": "command",
        "cmd": "a=$(shasum package.json yarn.lock); yarn allow-scripts auto >/dev/null 2>&1; echo \"AUTO_EXIT=$?\"; b=$(shasum package.json yarn.lock); [ \"$a\" = \"$b\" ] && echo UNCHANGED || echo CHANGED; grep -c 'fsevents@npm:^1' yarn.lock",
        "timeout_ms": 300000,
        "allow_failure": true,
        "intent": "allow-scripts auto produces no diff and the lockfile has no fsevents@1 entry.",
        "next": "ac2-assert-unchanged"
      },
      "ac2-assert-unchanged": {
        "action": "assert_output",
        "source": "ac2-allow-scripts-auto",
        "stream": "stdout",
        "match": "AUTO_EXIT=0\\nUNCHANGED\\n0\\n?$",
        "intent": "Local macOS observation only: allow-scripts auto leaves package.json and yarn.lock unchanged. Linux CI evidence is supplied after publication.",
        "next": "done"
      },
      "done": {
        "action": "end",
        "status": "pass"
      }
    }
  }
}
```
</details>

## **Validation Logs**

Run: bac71aaf-0b52-43a0-a032-478c1dfeafb1

Runner: @metamask/recipe-runner

Runner revision: unknown

Recipe digest:
sha256:c70dca2694d9b3535edce8616fda27ccc1a1114b8a4815aed88ae13280fc100c

<details><summary>Full output (7/7 passed, pass)</summary>

```
# MetaMask Recipe Run

Status: pass
Duration: 66s
Nodes: 7/7 passed

## Steps
- PASS ac1-yarn-install-immutable (command, 39s): exitCode=0, stdout=➤ YN0000: · Yarn 4.14.1
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 1s 267ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ @metamask/eslint-config is listed by your project with version 14.1.1 (pd6d96c), which doesn't satisfy what @metamask/eslint-config-jest and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ @metamask/providers is listed by your project with version 22.1.1 (p244a5b), which doesn't satisfy what @metamask/keyring-snap-client and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ @metamask/utils is listed by your project with version 12.0.0 (pb98a7d), which doesn't satisfy what @metamask/design-system-react requests (^11.12.1).
➤ YN0060: │ eslint-config-prettier is listed by your project with version 10.1.5 (pa0eea5), which doesn't satisfy what @metamask/eslint-config and other dependencies request (^9.1.0).
➤ YN0060: │ oxfmt is listed by your project with version 0.44.0 (pe75984), which doesn't satisfy what @metamask/auto-changelog and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react is listed by your project with version 18.3.1 (p7fd956), which doesn't satisfy what react-popper and other dependencies request (but they have non-overlapping ranges!).
➤ YN0002: │ metamask-crx@workspace:. doesn't provide @metamask/eth-block-tracker (p818142), requested by @metamask/transaction-controller and other dependencies.
➤ YN0002: │ metamask-crx@workspace:. doesn't provide playwright (pf1cab8), requested by @metamask/client-mcp-core.
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed in 0s 256ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 2s 451ms
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed in 2s 591ms
running lifecycle scripts for event "preinstall"
running lifecycle scripts for event "install"
running lifecycle scripts for event "postinstall"
- $root$
- @sentry/cli#2.56.0
- @swc/core#1.16.2
- core-js-pure#3.49.0
- react-devtools>electron#23.3.0
- tsx>esbuild#0.28.1
running lifecycle scripts for top level package
➤ YN0000: · Done with warnings in 37s 423ms
YARN_EXIT=0

- PASS ac1-assert-install-output (assert_output, 150ms): source=ac1-yarn-install-immutable, stream=stdout, contains=YARN_EXIT=0
- PASS ac1-list-fsevents (command, 16s): exitCode=0, stdout=node_modules/playwright/node_modules/fsevents/package.json:  "version": "2.3.2",
node_modules/fsevents/package.json:  "version": "2.3.3",
SCAN_DONE

- PASS ac1-assert-no-fsevents-1 (assert_output, 141ms): source=ac1-list-fsevents, stream=stdout, match=^(?![\s\S]*"version": "1\.)[\s\S]*SCAN_DONE
- PASS ac2-allow-scripts-auto (command, 10s): exitCode=1, stdout=AUTO_EXIT=0
UNCHANGED
0

- PASS ac2-assert-unchanged (assert_output, 120ms): source=ac2-allow-scripts-auto, stream=stdout, match=AUTO_EXIT=0\nUNCHANGED\n0\n?$
- PASS done (end, 1ms)
```
</details>

<details>
<summary>Full evidence gallery and publication receipt</summary>

<!-- farmslot-publication-receipt:start -->
### Publication approval

farm-automation · service · farm-automation · 2026-10-24T04:42:38.085Z
Package:
`c7d1a1935581530354753a772e2a061804ee12f5abe872044017dd8268c343df`.
Visual receipts: none.
<!-- farmslot-publication-receipt:end -->

</details>


[TAT-4259]:
https://consensyssoftware.atlassian.net/browse/TAT-4259?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Dependency-resolution and generated lockfile/policy churn only; no
application runtime logic changes, with lower install risk on macOS.
> 
> **Overview**
> Fixes **macOS `yarn install --immutable` failures** caused by gulp’s
`glob-watcher` resolving **chokidar 2**, which pulled darwin-only
**`fsevents@1.2.13`** (install script, no LavaMoat allowScripts entry).
> 
> Adds a Yarn resolution **`glob-watcher/chokidar: ^3.6.0`** and
regenerates **`yarn.lock`**, dropping the chokidar 2 / fsevents 1 tree
and a large set of legacy watcher-related packages. **Eight LavaMoat
webpack policies** are updated so `sc-channel` now allows
**`component-emitter`** at the flattened `socketcluster-client` path
instead of the nested `sc-channel>component-emitter` key.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
68a6d78. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Wires the `wallet_pay` EIP-1193 method from
[`@metamask/transaction-pay-middleware`](MetaMask/core#10786)
into the extension. The method, its request schema, the flag gate,
adding the transaction and the supported types (`perpsDeposit`,
`perpsWithdraw`) all live in that core package; this PR only connects
it:

- `walletPay` registered with `createScaffoldMiddleware` on the EIP-1193
provider, after the permission middleware, like `eip5792Middleware`.
`wallet_pay` is added to `unrestrictedMethods`.
- One hook, `getPermittedAccountsForOrigin`, from the origin's connected
accounts.
- A `TransactionPayMiddleware` messenger delegated
`RemoteFeatureFlagController:getState`,
`TransactionController:addTransaction`,
`NetworkController:findNetworkClientIdByChainId`,
`PerpsController:getState` and `PerpsController:refreshEligibility`.
- `mm_pay_rpc` / `mm_pay_rpc_origin` transaction metrics for
non-internal Pay transactions.
- Adds `@metamask/transaction-pay-middleware@^1.0.0`. It depends on
`@metamask/perps-controller@^21.0.0`, so v21 is installed nested
alongside the extension's v20 until the extension bumps to v21.

Gated by `confirmations_pay_rpc`; off by default.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[CONF-2131](https://consensyssoftware.atlassian.net/browse/CONF-2131)

## **Manual testing steps**

1. Set `confirmations_pay_rpc` to `{ "allowedTypes": ["perpsDeposit",
"perpsWithdraw"], "dapps": { "http://localhost": { "allowedTypes":
["perpsDeposit", "perpsWithdraw"] } } }` and enable
`confirmations_pay_post_quote` for `perpsWithdraw`. Set them in the
remote feature flag controller: `.manifest-overrides.json` is no longer
read for `wallet_pay`.
2. Build the extension and connect an account to a page on
`http://localhost` (e.g. the test dApp).
3. In the page's console run `await ethereum.request({ method:
'wallet_pay', params: [{ type: 'perpsDeposit', from: '<connected
account>', amount: '10' }] })`.
4. Verify the perps deposit confirmation opens with $10 prefilled. With
Arbitrum removed, verify it rejects with `-32603`.
5. Approve it and verify the request resolves with `{ transactionHash
}`; reject it and verify it rejects with `4001`.
6. Run the same with `type: 'perpsWithdraw'` and verify the withdraw
confirmation opens, including for a connected account that isn't
selected. With an account that isn't connected, verify it rejects with
`4100`.
7. Run with an unknown `type` and verify it rejects with `-32601`; run
with `params: []` and verify it rejects with `-32602`.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[CONF-2131]:
https://consensyssoftware.atlassian.net/browse/CONF-2131?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Exposes a new dApp-facing RPC path that can enqueue Pay transactions
using permitted accounts; behavior is feature-flagged in core but still
expands the provider attack surface and transaction submission flow.
> 
> **Overview**
> Integrates the **`wallet_pay`** EIP-1193 method from
`@metamask/transaction-pay-middleware` so connected dApps can start
MetaMask Pay flows (e.g. perps deposit/withdraw) via RPC instead of only
in-wallet UI.
> 
> The extension registers **`wallet_pay`** as an unrestricted method and
adds scaffold middleware on the provider pipeline (after core MetaMask
middleware, alongside EIP-5792), with a delegated messenger for network
lookup, feature flags, perps state, and
`TransactionController:addTransaction`. Only
**`getPermittedAccountsForOrigin`** is supplied from the extension;
validation, gating, and transaction creation stay in the core package.
> 
> Transaction metrics gain a **`getWalletPayMetricsProperties`** builder
that tags non-internal Pay transactions with **`mm_pay_rpc`** and
**`mm_pay_rpc_origin`** (distinguishing RPC-initiated Pay from internal
flows). **`PAY_TYPES`** is exported from the existing MetaMask Pay
metrics module for reuse.
> 
> Adds **`@metamask/transaction-pay-middleware@^1.0.0`** and
corresponding LavaMoat policy entries.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
17368ff. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

1. What is the reason for the change?

On dev builds, the camera preview in the QR hardware wallet flow
(pairing and signing) was just a black box, so you couldn't scan
anything. Prod wasn't affected.

Since the `createRoot` migration (#45130), dev builds run under React
StrictMode, which mounts every effect twice. `EnhancedQrReader` started
the camera with ZXing's `decodeFromConstraints`, and the cleanup could
only stop the scanner once that promise resolved. So the first mount's
late `stop()` ran after the second mount had already attached its
stream. ZXing's `stop()` clears `srcObject` on the `<video>` element
regardless of which stream is in it, so it wiped out the live stream and
left the preview black.

2. What is the improvement/solution?

- `EnhancedQrReader` now calls `getUserMedia` itself and passes the
stream to `decodeFromStream`. If the effect has already been cleaned up
when the camera resolves, the stream is stopped before it ever touches
the `<video>`.
- `onFrame` is kept in a ref, so a new callback no longer restarts the
camera mid-scan.
- Updated the unit tests and added coverage for the StrictMode double
mount, unmounting while the camera is starting, and start-up failures.

There's no user-facing change in prod. This mainly gets the QR flow
working again on dev builds and makes the camera cleanup more robust.


## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
4. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: #47160

## **Manual testing steps**

1. Run the app locally via yarn start
2. once the extension is loaded, create a wallet
3. open the accounts list, click add wallet, hardware wallet and then
select Keystone
4. grant permissions for camera access
5. the camera scanner should open and you should be able to see the
content in the webcam
6. then you should be able to successfully pair your keysone. 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/964e500a-d78d-4dbb-b46f-04bf45b1c91b

### **After**



https://github.com/user-attachments/assets/aaa41ce0-7cdb-4b9e-901b-6239c0c704e0



## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Scoped to QR scanner lifecycle in dev; production behavior is
unchanged aside from more robust stream cleanup and stable `onFrame`
handling.
> 
> **Overview**
> Fixes a **black camera preview** in dev when React StrictMode
double-mounts `EnhancedQrReader` during QR hardware wallet
pairing/signing.
> 
> **`EnhancedQrReader`** no longer uses ZXing’s `decodeFromConstraints`.
It acquires the camera with `getUserMedia`, then decodes via
`decodeFromStream`. If the effect cleans up while `getUserMedia` is
still pending, the orphan stream is released with
`stopMediaStreamTracks` before it hits the `<video>`, so a late `stop()`
from the first mount cannot clear the active `srcObject`. Cleanup uses a
`cancelled` flag and synchronous `controls?.stop()`; start failures are
still logged via `log.debug`. **`onFrame`** is held in a ref so callback
identity changes do not tear down and restart the camera mid-scan.
> 
> Unit tests now mock `getUserMedia` / `decodeFromStream` and add cases
for StrictMode double mount, unmount-before-resolve, decode-in-flight
unmount, startup failures, and stable `onFrame` across rerenders.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
6f3f4ff. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Extension's `Activity Details Opened` event previously only sent
`activity_type`

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: CEUX-1090

## **Manual testing steps**

1. Open the Activity tab
2. Click an activity row
3. Confirm segment events includes `transaction_status`,
`transaction_type`, `location`, `chain_id_source`, and
`chain_id_destination`

## **Screenshots/Recordings**

<!--
### **Before**
### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Analytics-only navigation tracking with no changes to transaction
handling, auth, or UI behavior beyond event payload fields.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
344f6e1. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

Extension's `Activity Details Opened` event previously only sent
`activity_type`. This PR adds additional mobile-parity properties to the
event: `transaction_status`, `location`, `chain_id_source`, and
`chain_id_destination`.

The `transaction_status` field maps activity statuses to segment-schema
enum values (success→confirmed, pending→submitted, cancelled→dropped,
etc.) with identity mappings for all valid segment-schema
transaction_status values to ensure validation compatibility.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: CEUX-1090

## **Manual testing steps**

1. Open the Activity tab
2. Click an activity row
3. Confirm segment events includes `transaction_status`,
`transaction_type`, `location`, `chain_id_source`, and
`chain_id_destination`

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-c32ba95f-114f-5a07-a9f4-053cf88c1ef9?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-c32ba95f-114f-5a07-a9f4-053cf88c1ef9&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

Migrates the bridge page's "block explorer link copied" toast
notification to the new system.

**What is the reason for the change?**
The old multichain Toast component is being phased out for consistency
across the extension.

- Replaces state-based toast rendering with `toast.success()` call
- Removes 40+ lines of absolute-positioned toast wrapper markup

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: 

CEUX-1256

## **Manual testing steps**

1. Click Swap
3. Click the token address
4. Verify toast appears

<!--
## **Screenshots/Recordings**

### **Before**


### **After**

-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-d06ad761-ca54-5f54-8fcc-0f807feef8f0?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-d06ad761-ca54-5f54-8fcc-0f807feef8f0&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> UI-only feedback change on the bridge page with no auth, transaction,
or data-path impact.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d319ed4. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The NonEVMHomepage was added recently but it's violating our page object
patterns:
- it instantiates a tokenTab to get balances
- adds nothing else

#44160

There is no reason to have a non evm homepage, as this [was already
unified with a single
homepage](#43156).
Also, the patterns used are incorrect.

For this reason, this has now been removed again.

Extra note: adding the skip e2e quality gate because the Tron tests take
almost a minute to start, so this would slow down ci by a lot. For this
reason skipping the extra runs, as the changes in this PR are safe (0
impact in the specs)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. ci continues to pass

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> E2E page-object refactor only; no production code changes, with Tron
specs updated to match existing unified home patterns.
> 
> **Overview**
> Removes the **`NonEvmHomepage`** E2E page object, which duplicated the
unified home screen and incorrectly delegated token balance checks by
spinning up **`TokensTab`** from a separate “non-EVM” type.
> 
> Tron flows and activity specs now use **`HomePage`** for
load/navigation (e.g. activity tab) and call
**`TokensTab.checkExpectedTokenBalanceIsDisplayed`** directly in
**`tron-send.flow`**. JSDoc on **`HomePage`** and **`TokensTab`** no
longer references the removed class.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b5f5f83. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
## **Description**

Fixes false-positive `Data persistence recovered after temporary
failure` events in PersistenceManager.

Previously, recovery detection used one global `#dataPersistenceFailing`
boolean. A backup IndexedDB write could fail, then a later primary-only
`set` or `persist` could succeed and incorrectly emit `set-recovered` or
`persist-recovered` even though the failed backup write path had not
recovered.

This changes recovery tracking to remember the specific failing write
target:

- `set-failed`
- `set-backup-failed`
- `persist-failed`
- `persist-backup-failed`

Recovery is now emitted only when the same failed target succeeds.
Backup recovery uses `set-backup-recovered` and
`persist-backup-recovered` events.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

1. Run the extension in a Chrome MV3 development build.
2. Trigger a wallet state change that writes backed-up state, while
forcing the backup IndexedDB write to fail.
3. Trigger a later wallet state change that only writes non-backed-up
state.
4. Verify no `Data persistence recovered after temporary failure` event
is emitted for the backup failure.
5. Trigger another backed-up state write with IndexedDB working again.
6. Verify a backup-specific recovery event is emitted.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes wallet state persistence telemetry and failure deduplication
logic; write behavior is unchanged but Sentry dashboards using old
`persistence.event` values need updating.
> 
> **Overview**
> Fixes false-positive **Data persistence recovered after temporary
failure** Sentry messages by tracking failures per write target instead
of one global flag.
> 
> `PersistenceManager` now keeps `#dataPersistenceFailures` keyed by
**primary** vs **backup**, with `#captureWriteFailure` /
`#captureWriteRecovery` centralizing reporting. Recovery fires only when
the same target that failed succeeds again; tags move from
`set-recovered` / `persist-recovered` to `primary-write-recovered` and
`backup-write-recovered`, plus `persistence.failed_operation` and
`persistence.successful_operation`. Primary recovery can still be
recorded when a later backup write fails.
> 
> Tests add coverage for primary-vs-backup recovery,
cross-`set`/`persist` deduplication, and updated mocks/teardown.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
80469eb. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@sleepytanya
sleepytanya marked this pull request as ready for review November 9, 2026 04:01
@sleepytanya
sleepytanya marked this pull request as draft November 9, 2026 04:10
@sleepytanya
sleepytanya marked this pull request as ready for review November 9, 2026 15:46
@sleepytanya
sleepytanya merged commit 6c77160 into stable Nov 9, 2026
270 of 273 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026

This branch had an error being deployed

1 failed, 3 active, and 2 inactive deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.