Skip to content

bump: multiple to fix audit, trying the new prompt cp-13.54.0 cp-13.55.0 - #47302

Merged
HowardBraham merged 1 commit into
mainfrom
audit-fixes
Oct 23, 2026
Merged

HowardBraham merged 1 commit into
mainfrom
audit-fixes

Conversation

@HowardBraham

@HowardBraham HowardBraham commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Howard intro

This was done by Claude Sonnet 5.5 executing on this prompt, and the description was written by Claude. We're testing to see if AI is ready to do this all by itself.

Description

I fixed 13 of the 14 advisories in the four new issues with a validated change that sits uncommitted in the checkout. The remaining advisory (@vitest/mocker) has no fix at this storybook major. I did not commit or push, because you only authorized pushing to trigger-ci-audit for the last run. I haven't run tests, yarn audit or the storybook build, and I haven't regenerated LavaMoat policies. The post-change yarn npm audit no longer lists the fixed packages, yarn lint:lockfile:dedupe:fix caused no further change, and git diff --check is clean.

Audit Triage: #47251, #47258, #47297, #47299

Target checked: main at 6b79fa62 (fetched 2026-10-22). The earlier fix is merged and its four issues are closed.
Result: 6 release-blocking advisory groups plus 1 low-severity production one, all fixable. Informational: storybook (3 advisories) and stream-json are fixable, @vitest/mocker is not, and the Electron cluster is report-only.

A. Already Resolved

None.

B. Easy To Resolve

  • dompurify (GHSA-cg2g-xh64-v4q7 critical, GHSA-mrv2-3pqr-j5jr high, GHSA-c6gr-qvv4-5v3f low): production.
    • Chain: metamask-crx -> dompurify.
    • Fix: update dompurify from 3.4.16 to 3.4.17.
    • It carries a yarn patch (two <!--> literals rewritten as "<!" + "--" + ">"). The old patch didn't apply to 3.4.17, so I recreated it with the same two substitutions in dist/purify.cjs.js, purify.es.mjs and purify.js. The old patch file is removed. Please review this patch.
  • toml (GHSA-4qx8-w7c3-pj3p, GHSA-9j65-hcg3-gc64, GHSA-9qmh-m7c6-f92p): high, production.
    • Chain: metamask-crx -> @metamask/eth-trezor-keyring -> @trezor/connect-web -> @trezor/connect -> @trezor/blockchain-link -> @stellar/stellar-sdk@13.3.0 -> toml@4.3.0.
    • Fix: raise the existing resolution from ^4.2.0 to ^5.0.1.
    • No parent upgrade helps: @stellar/stellar-sdk latest is 17.3.0, and it is a major jump through trezor.
    • stellar-sdk@13.3.0 asks for toml@^3, which the resolution already overrides, so the major jump has precedent. I did not exercise stellar at runtime.
  • ip-address (GHSA-rxp7-6hxx-x8q5): moderate, production.
    • Chain: -> socks and -> @modelcontextprotocol/sdk -> express-rate-limit -> ip-address.
    • Fix: raise the existing resolution from ^10.7.2 to ^10.7.4.
  • storybook (GHSA-f2ph-cmg5-wxc8 critical, GHSA-px85-f4q5-jh77 high): dev-only, fixed in 9.1.21.
    • Fix: bump storybook, @storybook/addon-a11y, @storybook/addon-docs and @storybook/react-webpack5 from 9.1.20 to 9.1.21, a patch bump that exists for all four.
    • I did not build or run storybook.
  • stream-json (GHSA-jj87-hc4r-jwfw): moderate, dev-only.
    • Chain: metamask-crx -> @metamask/test-dapp-solana -> ... -> jayson@4.2.0 -> stream-json@3.6.0.
    • Fix: raise the existing resolution from ^3.5.0 to ^3.7.0.

C. Difficult To Resolve

Development-only Leftovers

@tootallnate/once, basic-ftp, bigint-buffer, braces, decode-uri-component, got, ip, micromatch, nanoid, postcss and sprintf-js are unchanged from last time. None are fixable now, for the same reasons as before: no patch exists, the patch is ESM-only, or the fix needs a major bump through an old parent.

Raw Recursive Audit

No numeric advisories outside these four issues' packages are new. The only change in the leftover list is the new @vitest/mocker advisory, GHSA-qxg6-89mg-rqv8 (#47258).

Changelog

CHANGELOG entry: null

Related issues

Fixes: #47251
Fixes: #47258
Fixes: #47297
Fixes: #47299


Note

Medium Risk
Production bumps include dompurify (HTML sanitization), a major toml resolution override, and patched dist edits that need review; Storybook is dev-only.

Overview
This PR bumps dependencies to clear security advisories, with yarn.lock regenerated to match.

Production-facing changes: dompurify moves from 3.4.16 to 3.4.17 via an updated Yarn patch that keeps the same two string-splitting edits for empty-input and node-import paths (HTML comment literals built as "<!" + "--" + ">" instead of a single literal). Yarn resolutions raise ip-address to ^10.7.4, toml to ^5.0.1 (Stellar/Trezor chain), and stream-json to ^3.7.0.

Dev-only: Storybook packages (storybook, @storybook/addon-a11y, @storybook/addon-docs, @storybook/react-webpack5) go from 9.1.20 to 9.1.21.

No application source changes—only package.json, lockfile, and the dompurify patch file.

Reviewed by Cursor Bugbot for commit dca0494. Bugbot is set up for automated code reviews on this repo. Configure here.

…torybook, stream-json

- update dompurify to 3.4.17 and re-create its yarn patch
- raise `toml` resolution to ^5.0.1
- raise `ip-address` resolution to ^10.7.4
- raise `stream-json` resolution to ^3.7.0
- bump storybook packages to 9.1.21

Claude-Session: https://claude.ai/code/session_01DQZWqehXrCZzNT8F5Xrp2U
@HowardBraham HowardBraham self-assigned this Oct 22, 2026
@HowardBraham
HowardBraham requested a review from a team as a code owner October 22, 2026 21:52
@metamask-ci metamask-ci Bot added the team-extension-platform Extension Platform team label Oct 22, 2026
@socket-security

socket-security Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updateddompurify@​3.4.16 ⏵ 3.4.17100100 +751009370
Updated@​storybook/​react-webpack5@​9.1.20 ⏵ 9.1.2110010071100100
Updated@​storybook/​addon-a11y@​9.1.20 ⏵ 9.1.2110010075100100
Updatedstorybook@​9.1.20 ⏵ 9.1.2198100 +7588 +1100100
Updated@​storybook/​addon-docs@​9.1.20 ⏵ 9.1.219910099100100

View full report

@socket-security

socket-security Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • @storybook/addon-docs@9.1.21
  • storybook@9.1.21
  • @storybook/react@9.1.21

View full report

@HowardBraham HowardBraham added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 22, 2026
@HowardBraham

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/storybook@9.1.21
@SocketSecurity ignore npm/@storybook/addon-docs@9.1.21
@SocketSecurity ignore npm/@storybook/react@9.1.21

@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [dca0494]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39860771952 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +412%
  • ↑ loadNewAccount/total: +412%
  • ↓ loadNewAccount/fcp: -31%
  • ↓ loadNewAccount/lcp: -17%
  • ↑ confirmTx/longTaskMaxDuration: +21%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -29%
  • ↓ confirmTx/lcp: -17%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +40%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -13%
  • ↓ bridgeUserActions/longTaskMaxDuration: -29%
  • ↓ bridgeUserActions/tbt: -59%
  • ↓ bridgeUserActions/inp: -31%
  • ↓ bridgeUserActions/fcp: -33%
  • ↓ bridgeUserActions/lcp: -19%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1255%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1282%
  • ↑ bridgeUserActions/bridge_load_page: +344%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +53%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +1268%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -26%
  • ↓ startupStandardHome/domContentLoaded: -26%
  • ↓ startupStandardHome/domInteractive: -14%
  • ↓ startupStandardHome/firstPaint: -13%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -27%
  • ↑ startupStandardHome/setupStore: +59%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -33%
  • ↓ startupStandardHome/longTaskMaxDuration: -31%
  • ↓ startupStandardHome/tbt: -33%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -26%
  • ↓ startupStandardHome/lcp: -14%
  • ↓ startupStandardHome/domInteractive: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +49%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +40%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +28%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +17%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +24%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -85%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -50%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -74%
  • ↓ dappPageLoad/domContentLoaded: -39%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.39 MiB +125 Bytes 0.00%
🚨 ui 19.24 MiB +1.18 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB +421 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@HowardBraham
HowardBraham added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 2454d1f Oct 23, 2026
146 of 153 checks passed
@HowardBraham
HowardBraham deleted the audit-fixes branch October 23, 2026 01:27
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — dca04942 Deployed Oct 22, 2026 by HowardBraham via Publish prerelease / Publish prerelease #170847
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-S skip-release-validation team-extension-platform Extension Platform team

Projects

None yet

5 participants