Repository navigation
test(e2e): drop Tron-specific network wrapper flows - #47241
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (3 files, +2 -71)
|
a3450fb to
c1adb09
Compare
c1adb09 to
5179c98
Compare
5179c98 to
825f5b6
Compare
Builds ready [825f5b6] [reused from a3450fb]
⚡ Performance Benchmarks (Total: 🟢 2 pass · 🟡 1 warn · 🔴 1 fail)
Bundle Size Diffs
|
825f5b6 to
3bbb9a3
Compare
Builds ready [3bbb9a3] [reused from 21eec23]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
3bbb9a3 to
2506999
Compare
Builds ready [2506999]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs
|
|
2506999 to
3e4f65b
Compare
Builds ready [3e4f65b] [reused from 6b7ca07]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs
|
3e4f65b to
55acc78
Compare
Builds ready [55acc78] [reused from 5c61295]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs
|
55acc78 to
30ba989
Compare
Builds ready [30ba989] [reused from 5c61295]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs
|
| return sendPage; | ||
| } | ||
|
|
||
| export async function confirmTronSendAndAssertActivity({ |
There was a problem hiding this comment.
side: it seems this method could also be dropped as we could consolidate it with a generic one for send non EVM (snaps) --> it could be tackled in the future and remove the tron-send.flow.ts file altogether
|
|
||
| const TRON_CONFIRM_TIMEOUT_MS = 30_000; | ||
|
|
||
| export async function landOnTronSendScreen({ |
There was a problem hiding this comment.
this method as well: we should aim for re-usable methods, instead of adding 1 flow file per network, as that would not scale very well (could be tackled in the future)
|
No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut. |



Description
Follow-up to #47239 (merged). With snap-account readiness now handled deterministically inside
switchToNetworkFromNetworkSelect, the Tron-specific wrapper flows are redundant.Changes:
tron-network.flow.ts(selectTronNetwork,landOnTronHome) andtron-activity.flow.ts(openTronActivityList).switchToNetworkFromNetworkSelect(driver, 'Tron')and inlinegoToActivityList()page-object calls.tests/swaps/tron.spec.tsinlines the sharedlogin+switchToNetworkFromNetworkSelect(driver, 'Tron')+ homepage-readiness calls. The default-token test waits for the seeded TRX balance before opening the swap form so TRX is the default source token (snap balances load asynchronously).tests/tron/assets.spec.tskeeps its spec-locallandOnTronHome(it has a different shape — it refreshes before checking the token list and needs no balance assertion).Changelog
CHANGELOG entry: null
Related issues
Follow-up to: #47239
Continues the E2E refactor from: #46113
Manual testing steps
No manual testing required: this PR only refactors E2E helpers and specs, with no product code or user-facing behavior changes.
Affected specs:
tests/swaps/tron.spec.ts,tests/tron/account-derivation.spec.ts,tests/account-activity/tron/tron-activity-status.spec.ts,tests/account-activity/tron/tron-activity-types.spec.ts.Pre-merge author checklist
Pre-merge reviewer checklist