Repository navigation
chore: audit braces and http-cache-semantics cp-13.52.0 - #46865
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Chokidar’s watcher regression, stale LavaMoat policies, and defects in the vendored patch must be addressed.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates vulnerable production dependencies and vendors a depth-limited braces implementation for micromatch.
Changes:
- Upgrades
http-cache-semanticsandchokidar. - Patches micromatch and replaces vulnerable braces.
- Temporarily preapproves the newly released security fix.
| File | Description |
|---|---|
package.json |
Adds dependency resolutions and supporting packages. |
yarn.lock |
Locks updated dependency graph. |
.yarnrc.yml |
Temporarily bypasses the package age gate. |
.yarn/patches/micromatch-npm-4.0.8-c9570e4aca.patch |
Vendors depth-limited brace processing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,66 @@ | ||
| +'use strict'; | ||
| + | ||
| +const fill = require('fill-range'); |
| "buffer": "^6.0.3", | ||
| "chalk": "^4.1.2", | ||
| "chokidar": "^3.6.0", | ||
| "chokidar": "^4.0.3", |
131fc67 to
82e0824
Compare
|
@metamaskbot update-policies |
1 similar comment
|
@metamaskbot update-policies |
96fb285 to
85743ae
Compare
c37eece to
93594ea
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The vendored patch contains a crashing stringify path and an unintended debug log, while several additional upgrades remain undocumented.
Review effort: Balanced
Findings: 1
Open (5)
Regenerate LavaMoat policy for the new fill-range dependency Remove parser debug logging and revoke console.log permission · New Preserve parent node during recursive AST traversal · New Update Chokidar watcher to avoid unsupported glob patterns Document or remove unrelated dependency overrides · New
Regenerate yarn.lock under hardened mode, hoist fill-range for patched micromatch, fix chokidar 4 dashboard watch, update LavaMoat build policy, and restore @grpc/grpc-js resolution to clear production grpc advisories.
93594ea to
3b1fd70
Compare
Gudahtt
left a comment
There was a problem hiding this comment.
Still lots of unnecessary resolutions to remove. Also the many changes here related to the braces vulnerability can be undone
Builds ready [f85c59c]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 0 warn · 🔴 0 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Looks like another LavaMoat policy update and allow scripts config update are needed
|
@metamaskbot update-policies |
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
Builds ready [a5f3969]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [aa0004d]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|






Description
Clear release-blocking yarn audit advisories.
http-cache-semantics(GHSA-ch52-4w7c-c8xp): Resolve to 4.3.0. The.yarnrc.ymlage-gate preapproval was removed after 7 Oct 2026.braces(GHSA-vfj7-8cjw-p6xm): Resolvechokidarto 4.x (the dashboard watch uses directory roots plus an extension filter, because Chokidar 4 does not expand globs); patchmicromatch@4.0.8with the vendored depth-limit fix; resolvebracestonpm-empty-package; addfill-rangeand a LavaMoat build-policy grant so patched micromatch can load it.pbkdf2→^3.1.7for GHSA-477h-4r7f-fvrx.shell-quote→^1.11.0(lockfile 1.12.0) for GHSA-pqg4-j6r4-53mv.sharp→^0.35.5for GHSA-wq5f-xc86-pv6w.Additional production resolutions in the same lockfile:
postcss-selector-parser6.x →^7.1.6for GHSA-rj75-hqrm-r3gf. This is a major bump; 7.1.6 keeps parse output byte-identical and only changes the flat-selector complexity.compression→^1.8.2for GHSA-vc2v-76pw-4v95.proxy-addr→^2.0.8for GHSA-jqcg-44mw-7w3h.source-map-js→^1.2.2for GHSA-68fv-2mgg-jv7q.@grpc/grpc-js→^1.14.5for GHSA-99f4-grh7-6pcq (fixed in 1.14.4).Changelog
CHANGELOG entry: null
Related issues
Fixes: #46899
Fixes: #46883
Fixes: #46855
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches crypto (
pbkdf2/ hashing) LavaMoat allowances and a majorpostcss-selector-parserresolution; risk is mitigated as audit-driven graph alignment rather than application logic changes.Overview
Clears release-blocking yarn audit findings by adding or tightening Yarn resolutions in
package.json(notablypostcss-selector-parser6.x →^7.1.6,@grpc/grpc-js→^1.14.5,sharp→^0.35.5, plus bumps for GraphQL utils, tinypool, and OpenTelemetry instrumentation packages). Thechokidarresolution line is removed fromresolutionsin this diff slice.LavaMoat webpack policies are updated to match the new lockfile graph. In
lavamoat/webpack/build/policy.json, cssnano/tailwind consumers now allow a singlestylelint>postcss-selector-parserdependency instead of many nested duplicate entries;webpack-dev-server>compressiongainskoa>destroy.Across MV2/MV3 policy variants,
crypto-browserify>pbkdf2no longer references separatepbkdf2>create-hash/pbkdf2>ripemd160subtrees—it routes throughethereumjs-util>create-hashinstead. Relatedhash-base/readable-streamgrants are expanded (e.g.@ngraveio/bc-ur>sha.js>to-buffer, dedicated safe-buffer/string_decoder nodes), andremote-redux-devtools>socketcluster-client>sc-channelnow points at the nestedsc-channel>component-emitterpath.Reviewed by Cursor Bugbot for commit aa0004d. Bugbot is set up for automated code reviews on this repo. Configure here.