Skip to content

refactor(ui): migrate block explorer toast - #47295

Merged
n3ps merged 5 commits into
mainfrom
n3ps/bridge-block-explorer-toast-f8f0
Oct 26, 2026
Merged

n3ps merged 5 commits into
mainfrom
n3ps/bridge-block-explorer-toast-f8f0

Conversation

@n3ps

@n3ps n3ps commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Migrates the bridge page's "block explorer link copied" toast notification to the new system.

What is the reason for the change?
The old multichain Toast component is being phased out for consistency across the extension.

  • Replaces state-based toast rendering with toast.success() call
  • Removes 40+ lines of absolute-positioned toast wrapper markup

Changelog

CHANGELOG entry: null

Related issues

Fixes:

CEUX-1256

Manual testing steps

  1. Click Swap
  2. Click the token address
  3. Verify toast appears

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Low Risk
UI-only feedback change on the bridge page with no auth, transaction, or data-path impact.

Reviewed by Cursor Bugbot for commit d319ed4. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +26 -57)
  • 📁 ui/
    • 📁 pages/
      • 📁 bridge/
        • 📁 __snapshots__/
          • 📄 index.test.tsx.snap +1 -1
        • 📁 prepare/
          • 📁 __snapshots__/
            • 📄 prepare-bridge-page.test.tsx.snap +2 -2
            • 📄 prepare-bridge-page.tsx +23 -54

@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Oct 22, 2026
@n3ps n3ps changed the title refactor(bridge): migrate block explorer toast to react-hot-toast refactor(ui): migrate block explorer toast Oct 22, 2026
@github-actions github-actions Bot added size-S and removed size-M labels Oct 22, 2026
@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ac58a17] [reused from 0de5e00]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39829421733 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +93%
  • ↑ confirmTx/tbt: +108%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +106%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +38%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +183%
  • ↑ bridgeUserActions/longTaskMaxDuration: +67%
  • ↑ bridgeUserActions/tbt: +325%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -64%
  • ↑ loadNewAccount/lcp: +869%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +82%
  • ↓ confirmTx/fcp: -72%
  • ↑ confirmTx/lcp: +900%
  • ↑ bridgeUserActions/bridge_load_page: +100%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +32%
  • ↓ bridgeUserActions/bridge_search_token: -13%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -70%
  • ↑ bridgeUserActions/lcp: +813%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, firefox/webpack/startupStandardHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +47%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +45%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -92%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +36%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -52%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -56%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.47 MiB +120 Bytes 0.00%
✅ ui 19.34 MiB -499 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB -155 Bytes 0.00%

Replace the bridge page's block explorer link copied notification with
the new react-hot-toast system. This removes the old Toast/ToastContainer
from components/multichain and uses the globally-mounted Toaster.

- Import toast and ToastContent from #ui/components/ui/toast/toast
- Remove showBlockExplorerToast, blockExplorerToken, and toastTriggerCounter state
- Add handleBlockExplorerClick handler shared by both inputs
- Use toast.success with stable id 'bridge-block-explorer-copied'
- Fix bug: avatar now uses the clicked token's icon instead of always toToken
- Add unit test that verifies toast is called with correct id and icon
- Remove the absolutely positioned wrapper div and old toast markup

Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
@cursor
cursor Bot force-pushed the n3ps/bridge-block-explorer-toast-f8f0 branch from 414f53b to 1dad54f Compare October 22, 2026 18:28
@n3ps
n3ps marked this pull request as ready for review October 22, 2026 18:41
@n3ps
n3ps requested a review from a team as a code owner October 22, 2026 18:41
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a3782e6]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39834883581 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ confirmTx/longTaskTotalDuration: +53%
  • ↑ confirmTx/longTaskMaxDuration: +84%
  • ↑ confirmTx/tbt: +94%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +86%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +53%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +136%
  • ↑ bridgeUserActions/longTaskMaxDuration: +52%
  • ↑ bridgeUserActions/tbt: +282%
  • ↑ bridgeUserActions/total: +12%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -41%
  • ↑ loadNewAccount/lcp: +1223%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1279%
  • ↑ bridgeUserActions/bridge_load_page: +317%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +155%
  • ↑ bridgeUserActions/bridge_search_token: +44%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +82%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -32%
  • ↑ bridgeUserActions/lcp: +1345%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -32%
  • ↓ startupStandardHome/load: -35%
  • ↓ startupStandardHome/domContentLoaded: -35%
  • ↓ startupStandardHome/domInteractive: -22%
  • ↓ startupStandardHome/firstPaint: -20%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -35%
  • ↑ startupStandardHome/setupStore: +59%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -42%
  • ↓ startupStandardHome/longTaskMaxDuration: -40%
  • ↓ startupStandardHome/tbt: -44%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -35%
  • ↓ startupStandardHome/lcp: -18%
  • ↓ startupStandardHome/domInteractive: -37%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -35%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +39%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +35%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +40%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +28%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -42%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.47 MiB +120 Bytes 0.00%
✅ ui 19.34 MiB -438 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB -131 Bytes 0.00%

justifyContent: 'center',
}}
>
<ToastContainer>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated

@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d32dc82]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39839228741 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +21%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +73%
  • ↑ confirmTx/longTaskMaxDuration: +93%
  • ↑ confirmTx/tbt: +107%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +85%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +58%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +148%
  • ↑ bridgeUserActions/longTaskMaxDuration: +58%
  • ↑ bridgeUserActions/tbt: +284%
  • ↑ bridgeUserActions/total: +12%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +1220%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -41%
  • ↑ confirmTx/lcp: +1287%
  • ↑ bridgeUserActions/bridge_load_page: +370%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +196%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +61%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -43%
  • ↑ bridgeUserActions/lcp: +1256%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +142%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/fcp: -71%
  • ↓ startupStandardHome/domInteractive: -21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -17%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +53%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +44%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +25%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +47%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +28%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -51%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -37%
  • ↓ onboardingNewWallet/tbt: -77%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -73%
  • ↓ dappPageLoad/domContentLoaded: -38%
  • ↓ dappPageLoad/firstPaint: -59%
  • ↓ dappPageLoad/firstContentfulPaint: -59%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.47 MiB +120 Bytes 0.00%
✅ ui 19.34 MiB -427 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ zip 24.01 MiB -122 Bytes 0.00%

@n3ps
n3ps force-pushed the n3ps/bridge-block-explorer-toast-f8f0 branch from d32dc82 to d319ed4 Compare October 22, 2026 23:03
@metamask-ci

metamask-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d319ed4]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39869248208 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -24%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +70%
  • ↑ confirmTx/longTaskMaxDuration: +92%
  • ↑ confirmTx/tbt: +115%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +102%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +46%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +155%
  • ↑ bridgeUserActions/longTaskMaxDuration: +62%
  • ↑ bridgeUserActions/tbt: +307%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/lcp: +18%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -65%
  • ↑ loadNewAccount/lcp: +1026%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +1100%
  • ↑ bridgeUserActions/bridge_load_page: +87%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +41%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/inp: +15%
  • ↓ bridgeUserActions/fcp: -69%
  • ↑ bridgeUserActions/lcp: +1161%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↑ startupStandardHome/firstPaint: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +127%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +12%
  • ↑ startupStandardHome/lcp: +11%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -27%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +18%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +14%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +54%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +34%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +25%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -87%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -83%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -72%
  • ↓ dappPageLoad/domContentLoaded: -35%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.39 MiB -82.87 KiB -0.52%
✅ ui 19.23 MiB -113.15 KiB -0.57%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -2.21 KiB -0.05%
✅ content scripts 3.23 MiB -3.07 KiB -0.09%
✅ zip 24.01 MiB -1.18 KiB 0.00%

@metamask-ci

metamask-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b7133ee] [reused from d319ed4]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39876004193 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -24%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +70%
  • ↑ confirmTx/longTaskMaxDuration: +92%
  • ↑ confirmTx/tbt: +115%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +102%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +46%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +155%
  • ↑ bridgeUserActions/longTaskMaxDuration: +62%
  • ↑ bridgeUserActions/tbt: +307%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/lcp: +18%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -65%
  • ↑ loadNewAccount/lcp: +1026%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +1100%
  • ↑ bridgeUserActions/bridge_load_page: +87%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +41%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/inp: +15%
  • ↓ bridgeUserActions/fcp: -69%
  • ↑ bridgeUserActions/lcp: +1161%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↑ startupStandardHome/firstPaint: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +127%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +12%
  • ↑ startupStandardHome/lcp: +11%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -27%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +18%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +14%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +54%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +34%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +25%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -87%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -83%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -72%
  • ↓ dappPageLoad/domContentLoaded: -35%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.39 MiB -82.87 KiB -0.52%
✅ ui 19.23 MiB -113.15 KiB -0.57%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -2.21 KiB -0.05%
✅ content scripts 3.23 MiB -3.07 KiB -0.09%
✅ zip 24.01 MiB -1.18 KiB 0.00%

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Oct 23, 2026
@n3ps
n3ps requested a review from a team October 23, 2026 01:00
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Oct 26, 2026
@n3ps
n3ps added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit a0caa99 Oct 26, 2026
139 of 142 checks passed
@n3ps
n3ps deleted the n3ps/bridge-block-explorer-toast-f8f0 branch October 26, 2026 15:53
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Oct 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — b7133eef Deployed Oct 23, 2026 by n3ps via Publish prerelease / Publish prerelease #170856
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-S team-core-extension-ux Core Extension UX team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants