Repository navigation
feat: accept a vault password for self-onboarding - #47201
Conversation
Builds ready [8350911] [reused from 45ad871]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
There was a problem hiding this comment.
Guidance review (modern-web-guidance / chrome-extensions)
No changes in ui/, shared/, or app/ in this PR — nothing to flag against those checklists.
Actionable item
The README documents an optional second stdin line for the vault password, but mm launch --self-onboarding in @metamask/client-mcp-core@0.11.0 (pinned in this repo) still reads all of stdin as a single 12/24-word phrase (readSelfOnboardingPhrase). A second line (or any extra tokens) makes the word count check fail, and the CLI never sets password on the launch request.
The launcher/provider wiring for password looks fine for programmatic launch; the gap is the documented CLI/stdin path.
Suggested fix (pick one):
- Extend
client-mcp-coreto parse line 1 = phrase, optional line 2 = password (and bump the dependency here), or - Adjust the README to say password is only supported via the launch API until the CLI is updated.
Sent by Cursor Automation: Modern web guidance
| The phrase is read from stdin. A local setup writes a generated phrase; a | ||
| pooled setup writes the leased one. The wallet must start on onboarding: the | ||
| prod context always does, and the e2e context needs `--state onboarding`. | ||
| pooled setup writes the leased one. An optional second line sets the vault |
There was a problem hiding this comment.
@metamask/client-mcp-core@0.11.0 treats all of stdin as the SRP (12/24 whitespace-separated words). It does not read a second line for password, so this doc will mislead anyone using mm launch --self-onboarding < file. Either ship CLI/stdin support in client-mcp-core + bump the dep, or narrow this text to the API-only path for now.
There was a problem hiding this comment.
we'll bump the version to 0.12.0 once it's released, then we'll merge this PR afterwards
|
No release label on PR. Adding release label release-13.56.0 on PR, as PR was added to branch 13.56.0 when release was cut. |





Description
The self-onboarding launcher can now take a vault password from the launch request, so callers can set a random one per run instead of the fixed e2e default. Without one, it falls back to
DEFAULT_PASSWORD. The password is cleared after use.Depends on the
@metamask/client-mcp-corerelease that addspassword(bump pending).Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
yarn mm cleanup --shutdownprintf '%s\n%s\n' "<SRP>" "<password>" | yarn mm launch --state onboarding --self-onboarding<password>.Screenshots/Recordings
Screen.Recording.2026-10-23.at.08.56.25.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
E2E/LLM launcher and test plumbing only; no production wallet or auth paths, with fallback to the existing default password.
Overview
Self-onboarding in the LLM workflow launcher can now take an optional vault password on the launch path (documented as a second stdin line for
mm launch --self-onboarding). Callers can use a per-run password instead of the fixed e2e default; if omitted, behavior stays onDEFAULT_PASSWORD.MetaMaskSessionManager.launchreadspasswordfrom the session request, forwards it toMetaMaskExtensionLauncher, and clears it from the request alongside the SRP. The launcher uses that value forrunSelfOnboardingandfinishOnboarding, zeroes it in afinallyblock, and folds the post-import home navigation into the same guarded block. Types and unit tests cover forwarding and the unset-password case.Depends on a
@metamask/client-mcp-corerelease that addspasswordto the launch input.Reviewed by Cursor Bugbot for commit 8350911. Bugbot is set up for automated code reviews on this repo. Configure here.