Skip to content

test: fix flaky test Test Snap Homepage tests snap home page functionality - #46503

Merged
seaona merged 3 commits into
mainfrom
test/fix-flaky-snap-homepage-test
Sep 22, 2026
Merged

seaona merged 3 commits into
mainfrom
test/fix-flaky-snap-homepage-test

Conversation

@Unik0rnMaggie

@Unik0rnMaggie Unik0rnMaggie commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

After snap installation, the test immediately switched to MetaMask and opened the global-menu drawer.
At that exact moment, the AccountActivity WebSocket connected and fired a state update that closed the drawer. clickElement found the "Snaps" option in the DOM (still inside the closed drawer) but timed out waiting for it to become visible.

CI logs

Added testSnaps.checkInstallationComplete() between the snap install and the switch to MetaMask.
This holds the test on the TestSnaps page long enough for the AccountActivity WebSocket to connect and settle before the drawer is opened. The same pattern is used in test-snap-update-component.spec.ts.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Check CI

Screenshots/Recordings

test-failure-screenshot-1

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
E2e page-object timing/retry logic only; no production or security impact.

Overview
Makes global menu opening in e2e tests more reliable by changing how the test confirms the drawer actually opened.

In HeaderNavbar.openGlobalMenu(), the post-click wait waitForElementToStopMoving(drawerBackButton) is replaced with a visibility check on the drawer close button via findVisibleElement. If the back button never becomes visible (e.g. the menu click didn’t open the drawer or it closed immediately from a UI update), the flow retries opening the menu with clickElementUsingMouseMove and checks visibility again.

This targets flaky Snap homepage (and similar) flows where the test could proceed while the global menu drawer wasn’t reliably open.

Reviewed by Cursor Bugbot for commit 9fe3167. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +6 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📁 home/
            • 📄 header-navbar.ts +6 -1

@metamask-ci metamask-ci Bot added the team-qa QA team label Sep 21, 2026
@Unik0rnMaggie Unik0rnMaggie added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed flaky tests labels Sep 21, 2026
@metamask-ci

metamask-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1368848]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 35583956843 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +190%
  • ↑ loadNewAccount/total: +190%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +71%
  • ↑ confirmTx/tbt: +79%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +74%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +12%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +110%
  • ↑ bridgeUserActions/longTaskMaxDuration: +58%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +192%
  • ↑ loadNewAccount/total: +192%
  • ↓ loadNewAccount/fcp: -39%
  • ↑ loadNewAccount/lcp: +1227%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -43%
  • ↑ confirmTx/lcp: +1292%
  • ↑ bridgeUserActions/bridge_load_page: +206%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +38%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -46%
  • ↑ bridgeUserActions/lcp: +1169%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -15%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -14%
  • ↑ startupStandardHome/setupStore: +21%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -24%
  • ↓ startupStandardHome/longTaskMaxDuration: -17%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/fcp: -14%
  • ↓ startupStandardHome/uiStartup: -28%
  • ↓ startupStandardHome/load: -22%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -41%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -22%
  • ↑ startupStandardHome/setupStore: +83%
  • ↓ startupStandardHome/fcp: -32%
  • ↓ startupStandardHome/lcp: -20%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +30%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +21%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -94%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -93%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +28%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +14%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +37%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -22%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle size diffs
  • background: 120 Bytes (0%)
  • ui: 60 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 72 Bytes (0%)

@Unik0rnMaggie

Unik0rnMaggie commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Test was still failing after the first change (CI logs, so added update to openGlobalMenu()

@metamask-ci

metamask-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ee806df] [reused from 1368848]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 35590955629 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +190%
  • ↑ loadNewAccount/total: +190%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +71%
  • ↑ confirmTx/tbt: +79%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +74%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +12%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +110%
  • ↑ bridgeUserActions/longTaskMaxDuration: +58%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +192%
  • ↑ loadNewAccount/total: +192%
  • ↓ loadNewAccount/fcp: -39%
  • ↑ loadNewAccount/lcp: +1227%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -43%
  • ↑ confirmTx/lcp: +1292%
  • ↑ bridgeUserActions/bridge_load_page: +206%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +38%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -46%
  • ↑ bridgeUserActions/lcp: +1169%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -15%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -14%
  • ↑ startupStandardHome/setupStore: +21%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -24%
  • ↓ startupStandardHome/longTaskMaxDuration: -17%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/fcp: -14%
  • ↓ startupStandardHome/uiStartup: -28%
  • ↓ startupStandardHome/load: -22%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -41%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -22%
  • ↑ startupStandardHome/setupStore: +83%
  • ↓ startupStandardHome/fcp: -32%
  • ↓ startupStandardHome/lcp: -20%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +30%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +21%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -94%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -93%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +28%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +14%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +37%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -22%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle size diffs
  • background: 120 Bytes (0%)
  • ui: 60 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 72 Bytes (0%)

@metamask-ci

metamask-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [9fe3167]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 35611890536 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/inp: +14%
  • ↑ confirmTx/longTaskTotalDuration: +44%
  • ↑ confirmTx/longTaskMaxDuration: +66%
  • ↑ confirmTx/tbt: +76%
  • ↑ bridgeUserActions/bridge_load_page: +65%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +66%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +88%
  • ↑ bridgeUserActions/longTaskMaxDuration: +26%
  • ↑ bridgeUserActions/tbt: +136%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/fcp: -46%
  • ↑ loadNewAccount/lcp: +1144%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +1206%
  • ↑ bridgeUserActions/bridge_load_page: +227%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +99%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +34%
  • ↑ bridgeUserActions/inp: +31%
  • ↓ bridgeUserActions/fcp: -44%
  • ↑ bridgeUserActions/lcp: +1180%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -11%
  • ↓ startupStandardHome/load: -12%
  • ↓ startupStandardHome/domContentLoaded: -12%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -12%
  • ↑ startupStandardHome/setupStore: +44%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -19%
  • ↓ startupStandardHome/longTaskMaxDuration: -13%
  • ↓ startupStandardHome/tbt: -16%
  • ↓ startupStandardHome/fcp: -11%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +174%
  • ↓ startupStandardHome/fcp: -27%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +38%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +54%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +24%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +20%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +31%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +45%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 428 Bytes (0%)
  • ui: 6.67 KiB (0.03%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 4 Bytes (0%)
  • zip: 2.4 KiB (0.01%)

@sonarqubecloud

Copy link
Copy Markdown

@seaona seaona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as tmp fix, let's see if we can follow-up with https://consensyssoftware.atlassian.net/browse/MMQA-2441 and find the condition which causes sometimes the click to take no effect, and wait for that instead of retry

@seaona
seaona added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit 7a15470 Sep 22, 2026
143 checks passed
@seaona
seaona deleted the test/fix-flaky-snap-homepage-test branch September 22, 2026 08:05
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2026
@metamaskbot metamaskbot added the release-13.51.0 Issue or pull request that will be included in release 13.51.0 label Sep 22, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 9fe31673 Deployed Sep 21, 2026 by Unik0rnMaggie via Publish prerelease / Publish prerelease #165466
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.51.0 Issue or pull request that will be included in release 13.51.0 risk:low size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants