Skip to content

chore: audit follow-redirects, glob, minimatch, and joi audit advisories - #47527

Merged
sleepytanya merged 1 commit into
mainfrom
chore/audit-11-01
Nov 3, 2026
Merged

sleepytanya merged 1 commit into
mainfrom
chore/audit-11-01

Conversation

@DDDDDanica

@DDDDDanica DDDDDanica commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Clears the release-blocking Yarn audit advisories by raising resolutions:

  • follow-redirects to ^1.16.2 (high, production)
  • glob ^10.3.7 and ^13.0.0 to ^14.0.2 (moderate, production)
  • minimatch to ^11.0.1 (moderate, production)
  • joi ^17.9.2 to ^17.13.9 and ^18.2.3 to ^18.3.1 (high, dev-only)

Changelog

CHANGELOG entry: null

Related issues

Fixes: #47520
Fixes: #47519

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Changes are limited to Yarn resolutions and the lockfile; risk is mainly verifying CI/build and audit gates pass on the upgraded transitive dependency tree.

Overview
Addresses release-blocking Yarn audit findings by pinning patched versions in package.json resolutions and refreshing yarn.lock.

Production-facing: follow-redirects is raised from ^1.16.1 to ^1.16.2. Transitive glob ranges (^10.3.7, ^13.0.0) are unified to ^14.0.2, which pulls in glob@14.0.3, minimatch@^11.0.2, and updated path-scurry@^3.0.0 while dropping older glob-10 CLI-related packages from the lockfile.

Dev/tooling: joi is bumped via resolutions (^17.9.2 → ^17.13.9, ^18.2.3 → ^18.3.1).

No runtime or UI source changes—only dependency graph updates tied to issues #47519 and #47520.

Reviewed by Cursor Bugbot for commit 2a9eac6. Bugbot is set up for automated code reviews on this repo. Configure here.

@DDDDDanica DDDDDanica self-assigned this Nov 1, 2026
@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label Nov 1, 2026
@DDDDDanica
DDDDDanica requested a balanced review from Copilot November 1, 2026 21:41
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The global minimatch resolution breaks depcheck and Mocha ignore filtering because these legacy consumers expect a callable export rather than v11’s named export.

1 open issue
What changed in this PR

Updates dependency resolutions to address the release-blocking audit advisories in #47519 and #47520, along with the dev-only Joi advisory.

Changes:

  • Raises minimum versions for follow-redirects, glob, minimatch, and both Joi dependency ranges.
  • Regenerates the lockfile, consolidating dependency versions and removing obsolete transitive packages.
File Description
yarn.lock Records updated versions, checksums, and transitive dependencies.
package.json Updates resolutions to target versions containing advisory fixes.

Review effort: Balanced

Comment thread package.json Outdated
"minimatch@npm:9.0.3": "^9.0.9",
"glob@npm:^10.3.7": "^14.0.2",
"glob@npm:^13.0.0": "^14.0.2",
"minimatch": "^11.0.1",
@metamask-ci

metamask-ci Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7c72ab4]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41353290690 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ confirmTx/longTaskTotalDuration: +52%
  • ↑ confirmTx/longTaskMaxDuration: +85%
  • ↑ confirmTx/tbt: +91%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +130%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +54%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +151%
  • ↑ bridgeUserActions/longTaskMaxDuration: +58%
  • ↑ bridgeUserActions/tbt: +293%
  • ↑ bridgeUserActions/total: +10%
  • ↑ loadNewAccount/load_new_account: +413%
  • ↑ loadNewAccount/total: +413%
  • ↓ loadNewAccount/inp: -47%
  • ↓ loadNewAccount/fcp: -71%
  • ↑ loadNewAccount/lcp: +744%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -74%
  • ↑ confirmTx/lcp: +779%
  • ↑ bridgeUserActions/bridge_load_page: +86%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +16%
  • ↓ bridgeUserActions/bridge_search_token: -17%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -75%
  • ↑ bridgeUserActions/lcp: +1111%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -13%
  • ↓ startupStandardHome/load: -13%
  • ↓ startupStandardHome/domContentLoaded: -13%
  • ↓ startupStandardHome/backgroundConnect: -19%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -14%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -17%
  • ↓ startupStandardHome/tbt: -19%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -14%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -18%
  • ↓ startupStandardHome/domContentLoaded: -20%
  • ↓ startupStandardHome/domInteractive: -46%
  • ↓ startupStandardHome/backgroundConnect: -10%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -18%
  • ↑ startupStandardHome/setupStore: +110%
  • ↓ startupStandardHome/fcp: -35%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +43%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +26%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -48%
  • ↓ onboardingNewWallet/tbt: -95%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +65 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +200 Bytes 0.00%
✅ zip 24.06 MiB +60 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2a9eac6]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41430341056 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +14%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +80%
  • ↑ confirmTx/longTaskMaxDuration: +104%
  • ↑ confirmTx/tbt: +137%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +16%
  • ↑ bridgeUserActions/bridge_load_page: +147%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +76%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +166%
  • ↑ bridgeUserActions/longTaskMaxDuration: +27%
  • ↑ bridgeUserActions/tbt: +261%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -44%
  • ↑ loadNewAccount/lcp: +1299%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +21%
  • ↑ confirmTx/lcp: +1413%
  • ↑ bridgeUserActions/bridge_load_page: +241%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +159%
  • ↑ bridgeUserActions/bridge_search_token: +21%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +52%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -33%
  • ↑ bridgeUserActions/lcp: +1315%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -30%
  • ↓ startupStandardHome/domContentLoaded: -30%
  • ↓ startupStandardHome/domInteractive: -20%
  • ↓ startupStandardHome/firstPaint: -18%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -30%
  • ↑ startupStandardHome/setupStore: +74%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -38%
  • ↓ startupStandardHome/longTaskMaxDuration: -36%
  • ↓ startupStandardHome/tbt: -39%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -31%
  • ↓ startupStandardHome/lcp: -17%
  • ↓ startupStandardHome/domInteractive: -22%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↓ startupStandardHome/fcp: -16%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +42%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +31%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +35%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +15%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -57%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -48%
  • ↓ onboardingNewWallet/tbt: -94%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +106 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +759 Bytes 0.00%
✅ zip 24.06 MiB +147 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@DDDDDanica
DDDDDanica marked this pull request as ready for review November 2, 2026 19:34
@DDDDDanica
DDDDDanica enabled auto-merge November 2, 2026 19:54
@sleepytanya
sleepytanya disabled auto-merge November 3, 2026 01:59
@sleepytanya
sleepytanya added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 3, 2026
@sleepytanya
sleepytanya added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 060669f Nov 3, 2026
265 of 267 checks passed
@sleepytanya
sleepytanya deleted the chore/audit-11-01 branch November 3, 2026 03:53
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 2a9eac69 Deployed Nov 2, 2026 by DDDDDanica via identify-codeowners #88120
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-XS team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yarn Audit: new or newly blocking advisories on main (3febfc4974) Yarn Audit: new or newly blocking advisories on main (613e9ae78b)

7 participants