Skip to content

chore: bump assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0 - #47609

Merged
Prithpal-Sooriya merged 7 commits into
mainfrom
chore/bump-assets-controllers-1382.0.0
Nov 5, 2026
Merged

Prithpal-Sooriya merged 7 commits into
mainfrom
chore/bump-assets-controllers-1382.0.0

Conversation

@maxime-oe

@maxime-oe maxime-oe commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps the assets packages to the versions published by MetaMask/core#11300:

  • @metamask/assets-controller ^20.2.2
  • @metamask/assets-controllers ^113.1.1
  • @metamask/core-backend ^14.0.0
  • @metamask/client-utils ^3.1.1: it also depends on core-backend, so bumping it removes a duplicate core-backend 13. It pulls in eth-chainlist 0.0.873.

Transitive lockfile updates: @metamask/network-enablement-controller 7.1.0, @metamask/phishing-controller 18.3.0, and uuid ^14.0.1. LavaMoat policies narrow uuid's crypto access to crypto.getRandomValues / crypto.randomUUID.

Why: @metamask/assets-controller 20.2.x runs a launchpad check during the on-unlock spam-token cleanup. The check calls apiClient.token.fetchV2Assets(...), but no published core-backend 13.x has that method. With 20.2.1 + core-backend 13, the call threw a TypeError, and because the check fails closed, the cleanup removed no spam tokens. core-backend 14.0.0 adds fetchV2Assets, and assets-controller 20.2.2 requires it.

E2E: test-e2e-chrome-webpack (17) and test-e2e-firefox-webpack (16) failed on test/e2e/tests/tokens/spam-token-cleanup.spec.ts › removes below-floor spam tokens from persisted state on unlock with Expected KickToken to be removed from assetsInfo. The spec now also mocks Token API GET /v2/assets (the launchpad lookup) and returns [], since none of the tracked assets are launchpad tokens. Without the mock, the e2e fallback returns an empty 200, the lookup fails closed, and every spam token is kept.

core-backend 14 breaking change (OHLCV): OHLCVService WebSocket channels moved from market-data.v1 to ohlcv.v1. The extension does not construct OHLCVService or reference either channel string, so no code change is needed.

Changelog

CHANGELOG entry: Fixed spam tokens not being removed from the token list on unlock

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/WPN-2427

Related: MetaMask/core#11300

Manual testing steps

  1. Build and run the extension with a wallet that already holds low-occurrence airdropped spam tokens (e.g. KickToken on Ethereum mainnet) in its token list.
  2. Lock the wallet, then unlock it.
  3. Verify the spam tokens are removed from the token list, and legitimate tokens (e.g. USDC) and manually added custom tokens are still shown.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
User-visible token list cleanup on unlock depends on new upstream behavior and a major core-backend bump, though the extension itself only changes deps, LavaMoat policy, and test mocks.

Overview
Upgrades @metamask/assets-controller, @metamask/assets-controllers, @metamask/core-backend, and @metamask/client-utils so on-unlock spam-token cleanup can call Token API fetchV2Assets (added in core-backend 14). Without that API, the new launchpad check threw and cleanup failed closed, leaving spam tokens such as KickToken in the list.

LavaMoat policies for eight webpack variants now grant @metamask/assets-controllers>uuid and @metamask/core-backend>uuid only crypto.getRandomValues and crypto.randomUUID instead of the full crypto global, matching uuid ^14.

The spam-token-cleanup e2e spec mocks GET https://token.api.cx.metamask.io/v2/assets with an empty JSON array so the launchpad lookup succeeds and below-floor spam tokens are still removed in CI.

Reviewed by Cursor Bugbot for commit 145140f. Bugbot is set up for automated code reviews on this repo. Configure here.

…13.1.0

Also bump @metamask/core-backend to ^13.0.0 to match the version
required by the new assets controller releases.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​phishing-controller@​18.2.1 ⏵ 18.3.099 +11007898100
Updated@​metamask/​client-utils@​3.1.0 ⏵ 3.1.1991007898 +1100
Updated@​metamask/​assets-controller@​20.0.2 ⏵ 20.2.298 +110080 +1100 +1100
Updated@​metamask/​assets-controllers@​113.0.0 ⏵ 113.1.198 +110091 +1100 +1100
Updated@​metamask/​core-backend@​13.0.0 ⏵ 14.0.099 +110010099 +1100

View full report

@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [13bdba2]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41794227259 | Baseline logs

Metricschrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -17%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +17%
  • ↑ confirmTx/longTaskMaxDuration: +33%
  • ↑ confirmTx/tbt: +30%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -17%
  • ↓ confirmTx/lcp: -15%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +62%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +10%
  • ↓ bridgeUserActions/longTaskMaxDuration: -21%
  • ↓ bridgeUserActions/tbt: -28%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -29%
  • ↑ loadNewAccount/lcp: +1339%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1461%
  • ↑ bridgeUserActions/bridge_load_page: +228%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +150%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +43%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +21%
  • ↑ bridgeUserActions/lcp: +1364%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100 🔴 1
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🟡 uiStartup
🟡 load
🔴 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +11%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +10%
  • ↑ startupStandardHome/setupStore: +160%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/longTaskMaxDuration: +10%
  • ↑ startupStandardHome/tbt: +15%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/lcp: +11%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/uiStartup: +25%
  • ↑ startupStandardHome/load: +36%
  • ↑ startupStandardHome/domContentLoaded: +33%
  • ↑ startupStandardHome/domInteractive: +66%
  • ↑ startupStandardHome/backgroundConnect: +35%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/loadScripts: +35%
  • ↑ startupStandardHome/setupStore: +203%
  • ↑ startupStandardHome/inp: +250%
  • ↑ startupStandardHome/fcp: +67%
  • ↑ startupStandardHome/lcp: +38%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupStandardHome/LCP: p75 2.8s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +18%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +27%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +36%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +18%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +140%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -37%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -70%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.26 MiB +1.75 KiB +0.01%
🚨 ui 19.34 MiB +2.44 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -16 Bytes 0.00%
✅ content scripts 3.23 MiB -32 Bytes 0.00%
🚨 unzipped 79.64 MiB +4.15 KiB +0.01%
✅ zip 23.81 MiB +269 Bytes 0.00%

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@maxime-oe

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@maxime-oe maxime-oe changed the title chore: bump assets-controller to ^20.2.0 and assets-controllers to ^13.1.0 chore: bump assets-controller to ^20.2.1 and assets-controllers to ^13.1.0 Nov 4, 2026
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@metamask-ci

metamask-ci Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +32 -16)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +4 -2
        • 📁 experimental/
          • 📄 policy.json +4 -2
        • 📁 flask/
          • 📄 policy.json +4 -2
        • 📁 main/
          • 📄 policy.json +4 -2
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +4 -2
        • 📁 experimental/
          • 📄 policy.json +4 -2
        • 📁 flask/
          • 📄 policy.json +4 -2
        • 📁 main/
          • 📄 policy.json +4 -2

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@maxime-oe

Copy link
Copy Markdown
Contributor Author

Policies updated. 👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes 👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes 👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes 👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

Re Policies: My understanding is that policies got more restrictive and not more loose here, so no extra risk ?
Before:

   "crypto": true

After:

   "crypto.getRandomValues": true,
   "crypto.randomUUID": true

So now the specific functions are named now.

@maxime-oe
maxime-oe marked this pull request as ready for review November 4, 2026 14:59
@maxime-oe
maxime-oe requested a review from a team as a code owner November 4, 2026 14:59
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3c9d69f]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41850659328 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -18%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +18%
  • ↑ confirmTx/longTaskMaxDuration: +31%
  • ↑ confirmTx/tbt: +31%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -15%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +59%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +20%
  • ↓ bridgeUserActions/longTaskMaxDuration: -13%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -17%
  • ↓ bridgeUserActions/lcp: -17%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +94%
  • ↓ loadNewAccount/fcp: -65%
  • ↑ loadNewAccount/lcp: +957%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +75%
  • ↓ confirmTx/fcp: -72%
  • ↑ confirmTx/lcp: +778%
  • ↑ bridgeUserActions/bridge_load_page: +79%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +14%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -82%
  • ↑ bridgeUserActions/lcp: +1163%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/INP: p75 208ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -12%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/setupStore: +108%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -19%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -18%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -14%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +149%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +33%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +33%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +26%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +40%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +18%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +20%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +22%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -49%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -97%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -58%
  • ↓ dappPageLoad/domContentLoaded: -13%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.26 MiB +4.09 KiB +0.03%
🚨 ui 19.34 MiB +4.75 KiB +0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +94 Bytes 0.00%
✅ content scripts 3.23 MiB +188 Bytes +0.01%
🚨 unzipped 79.65 MiB +9.12 KiB +0.01%
🚨 zip 23.81 MiB +1.31 KiB +0.01%

@maxime-oe maxime-oe changed the title chore: bump assets-controller to ^20.2.1 and assets-controllers to ^13.1.0 chore: bump assets-controller to ^20.2.1 Nov 4, 2026
assets-controller 20.2.1 calls apiClient.token.fetchV2Assets in its
launchpad spam check, which core-backend 13 lacks. Bump to the
versions published in MetaMask/core#11300 (assets-controller 20.2.2,
core-backend 14.0.0, assets-controllers 113.1.1, client-utils 3.1.1).

Mock token API /v2/assets in the spam-token-cleanup e2e spec: the
launchpad lookup fails closed, so the unmocked empty response kept
every spam token.
@Prithpal-Sooriya

Prithpal-Sooriya commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Pushed 8c160fa on top of the branch:

  • Bump: @metamask/assets-controller ^20.2.2, @metamask/core-backend ^14.0.0, @metamask/assets-controllers ^113.1.1, @metamask/client-utils ^3.1.1 (client-utils was needed to drop the duplicate core-backend 13; it also pulls eth-chainlist 0.0.873). These are the versions from Release 1392.0.0 core#11300. With 20.2.1, findLaunchpadAssetIds called apiClient.token.fetchV2Assets, which isn't in core-backend 13. The unlock cleanup threw and removed no spam tokens.
  • Before: test-e2e-chrome-webpack (17) and test-e2e-firefox-webpack (16) both failed on spam-token-cleanup.spec.ts › removes below-floor spam tokens from persisted state on unlock with Expected KickToken to be removed from assetsInfo.
  • The bump alone wasn't enough: locally the cleanup now sends GET token.api.cx.metamask.io/v2/assets, but the spec didn't mock it. The e2e fallback returns an empty 200, and the launchpad lookup fails closed, so the same assertion still failed (reproduced 2/2). I added a /v2/assets mock to the spec that returns [] (none of the tracked assets are launchpad tokens). After that, both spam-cleanup cases pass locally on Chrome (2/2 runs).
  • core-backend 14 breaking change: the extension doesn't construct OHLCVService or reference market-data.v1 / ohlcv.v1, so no code change was needed.
  • Checks: yarn lint:tsc passes, and the 13 unit suites that touch assets-controller / core-backend pass (618 tests). yarn build:test with LavaMoat builds fine, and the policies are unchanged by this bump.
  • Adverse review: SHIP-WITH-CAVEATS (0 critical, 0 warning, 7 info). Only test-mock style and generic supply-chain notes; nothing to act on.

Follow-up:

  • Merged origin/main (4c84f06). Only yarn.lock conflicted: I took main's version, then re-ran yarn install and yarn dedupe. Re-running yarn lavamoat:auto changed no policy files, and yarn lint:tsc passes. With that, test-e2e-chrome-webpack (17) and test-e2e-firefox-webpack (16) now pass in CI.
  • 639c6d1 fixes unit tests that main itself breaks, to unblock CI on this PR. fix(content): remove "please" from extension locale strings (batch 1 of 3) #46148 removed "Please" from locale strings but didn't update the bridge-alert-banner-list.test.tsx snapshot or the token-list-item.test.tsx text expectations (main's Unit tests (2) fails the same way). This only changes test expectations; there's no product code change.

@Prithpal-Sooriya Prithpal-Sooriya changed the title chore: bump assets-controller to ^20.2.1 chore: bump assets-controller to ^20.2.2 Nov 4, 2026
@github-actions github-actions Bot added size-S and removed size-XS labels Nov 4, 2026
@Prithpal-Sooriya Prithpal-Sooriya changed the title chore: bump assets-controller to ^20.2.2 chore: bump assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0 Nov 4, 2026
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41919833054 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/inp: +12%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +13%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +77%
  • ↑ confirmTx/tbt: +96%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +22%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +82%
  • ↑ bridgeUserActions/longTaskMaxDuration: +12%
  • ↑ bridgeUserActions/tbt: +85%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1695%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1296%
  • ↑ bridgeUserActions/bridge_load_page: +310%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +49%
  • ↑ bridgeUserActions/inp: +135%
  • ↓ bridgeUserActions/fcp: -44%
  • ↑ bridgeUserActions/lcp: +1344%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 3.2s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 256ms
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +101%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -18%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -15%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/domInteractive: -23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -16%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +49%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +47%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -84%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -51%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +4.45 KiB +0.03%
🚨 ui 19.37 MiB +33.4 KiB +0.17%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +94 Bytes 0.00%
✅ content scripts 3.23 MiB +188 Bytes +0.01%
🚨 unzipped 79.68 MiB +38.14 KiB +0.05%
🚨 zip 23.82 MiB +6.33 KiB +0.03%

main's #46148 removed "Please" from locale strings but left the
bridge-alert-banner-list snapshot and token-list-item text
expectations unchanged, breaking unit tests on main. Fixed here to
unblock CI.
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [639c6d1] [reused from 4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41926507172 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/inp: +12%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +13%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +77%
  • ↑ confirmTx/tbt: +96%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +22%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +82%
  • ↑ bridgeUserActions/longTaskMaxDuration: +12%
  • ↑ bridgeUserActions/tbt: +85%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1695%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1296%
  • ↑ bridgeUserActions/bridge_load_page: +310%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +49%
  • ↑ bridgeUserActions/inp: +135%
  • ↓ bridgeUserActions/fcp: -44%
  • ↑ bridgeUserActions/lcp: +1344%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 3.2s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 256ms
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +101%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -18%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -15%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/domInteractive: -23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -16%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +49%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +47%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -84%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -51%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +4.45 KiB +0.03%
🚨 ui 19.37 MiB +33.4 KiB +0.17%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +94 Bytes 0.00%
✅ content scripts 3.23 MiB +188 Bytes +0.01%
🚨 unzipped 79.68 MiB +38.14 KiB +0.05%
🚨 zip 23.82 MiB +6.33 KiB +0.03%

…trollers-1382.0.0

# Conflicts:
#	ui/components/multichain/token-list-item/token-list-item.test.tsx
@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [145140f] [reused from 4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41959048706 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/inp: +12%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +13%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +77%
  • ↑ confirmTx/tbt: +96%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +22%
  • ↑ bridgeUserActions/bridge_load_page: +90%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +82%
  • ↑ bridgeUserActions/longTaskMaxDuration: +12%
  • ↑ bridgeUserActions/tbt: +85%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1695%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1296%
  • ↑ bridgeUserActions/bridge_load_page: +310%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +49%
  • ↑ bridgeUserActions/inp: +135%
  • ↓ bridgeUserActions/fcp: -44%
  • ↑ bridgeUserActions/lcp: +1344%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 3.2s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 256ms
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -15%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -16%
  • ↓ startupStandardHome/backgroundConnect: -20%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +101%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -18%
  • ↓ startupStandardHome/tbt: -21%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -15%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/domInteractive: -23%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -16%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +49%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +47%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -84%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -51%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +4.45 KiB +0.03%
🚨 ui 19.37 MiB +33.4 KiB +0.17%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +94 Bytes 0.00%
✅ content scripts 3.23 MiB +188 Bytes +0.01%
🚨 unzipped 79.68 MiB +38.14 KiB +0.05%
🚨 zip 23.82 MiB +6.33 KiB +0.03%

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@Prithpal-Sooriya
Prithpal-Sooriya added this pull request to the merge queue Nov 5, 2026
jpuri added a commit that referenced this pull request Nov 5, 2026
#47609 bumps assets-controller to ^20.2.2, assets-controllers to ^113.1.1
and core-backend to ^14.0.0, and adds the /v2/assets E2E mock.

That makes the local workarounds unnecessary, so this drops:
- the assets-controller 20.2.0 resolution pin
- the duplicate-core-backend type workaround in
  defi-positions-controller-v2-init (tsc is clean without it now that the
  root resolves core-backend 14)

Leaves this branch scoped to the pay-controller bump and the clientId
option. Note this now depends on #47609 landing first.
Merged via the queue into main with commit e17de98 Nov 5, 2026
255 of 257 checks passed
@Prithpal-Sooriya
Prithpal-Sooriya deleted the chore/bump-assets-controllers-1382.0.0 branch November 5, 2026 12:16
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-emerging-opportunities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants