Repository navigation
chore: bump assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0 - #47609
Conversation
…13.1.0 Also bump @metamask/core-backend to ^13.0.0 to match the version required by the new assets controller releases. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [13bdba2]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@metamaskbot update-policies |
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (8 files, +32 -16)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Re Policies: My understanding is that policies got more restrictive and not more loose here, so no extra risk ? After: So now the specific functions are named now. |
Builds ready [3c9d69f]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 1 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
assets-controller 20.2.1 calls apiClient.token.fetchV2Assets in its launchpad spam check, which core-backend 13 lacks. Bump to the versions published in MetaMask/core#11300 (assets-controller 20.2.2, core-backend 14.0.0, assets-controllers 113.1.1, client-utils 3.1.1). Mock token API /v2/assets in the spam-token-cleanup e2e spec: the launchpad lookup fails closed, so the unmocked empty response kept every spam token.
|
🤖 Pushed 8c160fa on top of the branch:
Follow-up:
|
…trollers-1382.0.0 # Conflicts: # yarn.lock
Builds ready [4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
main's #46148 removed "Please" from locale strings but left the bridge-alert-banner-list snapshot and token-list-item text expectations unchanged, breaking unit tests on main. Fixed here to unblock CI.
Builds ready [639c6d1] [reused from 4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
…trollers-1382.0.0 # Conflicts: # ui/components/multichain/token-list-item/token-list-item.test.tsx
Builds ready [145140f] [reused from 4c84f06]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
#47609 bumps assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0, and adds the /v2/assets E2E mock. That makes the local workarounds unnecessary, so this drops: - the assets-controller 20.2.0 resolution pin - the duplicate-core-backend type workaround in defi-positions-controller-v2-init (tsc is clean without it now that the root resolves core-backend 14) Leaves this branch scoped to the pay-controller bump and the clientId option. Note this now depends on #47609 landing first.
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |



Description
Bumps the assets packages to the versions published by MetaMask/core#11300:
@metamask/assets-controller^20.2.2@metamask/assets-controllers^113.1.1@metamask/core-backend^14.0.0@metamask/client-utils^3.1.1: it also depends on core-backend, so bumping it removes a duplicate core-backend 13. It pulls ineth-chainlist0.0.873.Transitive lockfile updates:
@metamask/network-enablement-controller7.1.0,@metamask/phishing-controller18.3.0, anduuid^14.0.1. LavaMoat policies narrowuuid'scryptoaccess tocrypto.getRandomValues/crypto.randomUUID.Why:
@metamask/assets-controller20.2.x runs a launchpad check during the on-unlock spam-token cleanup. The check callsapiClient.token.fetchV2Assets(...), but no published core-backend 13.x has that method. With 20.2.1 + core-backend 13, the call threw aTypeError, and because the check fails closed, the cleanup removed no spam tokens. core-backend 14.0.0 addsfetchV2Assets, and assets-controller 20.2.2 requires it.E2E:
test-e2e-chrome-webpack (17)andtest-e2e-firefox-webpack (16)failed ontest/e2e/tests/tokens/spam-token-cleanup.spec.ts › removes below-floor spam tokens from persisted state on unlockwithExpected KickToken to be removed from assetsInfo. The spec now also mocks Token APIGET /v2/assets(the launchpad lookup) and returns[], since none of the tracked assets are launchpad tokens. Without the mock, the e2e fallback returns an empty 200, the lookup fails closed, and every spam token is kept.core-backend 14 breaking change (OHLCV):
OHLCVServiceWebSocket channels moved frommarket-data.v1toohlcv.v1. The extension does not constructOHLCVServiceor reference either channel string, so no code change is needed.Changelog
CHANGELOG entry: Fixed spam tokens not being removed from the token list on unlock
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WPN-2427
Related: MetaMask/core#11300
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
User-visible token list cleanup on unlock depends on new upstream behavior and a major core-backend bump, though the extension itself only changes deps, LavaMoat policy, and test mocks.
Overview
Upgrades
@metamask/assets-controller,@metamask/assets-controllers,@metamask/core-backend, and@metamask/client-utilsso on-unlock spam-token cleanup can call Token APIfetchV2Assets(added in core-backend 14). Without that API, the new launchpad check threw and cleanup failed closed, leaving spam tokens such as KickToken in the list.LavaMoat policies for eight webpack variants now grant
@metamask/assets-controllers>uuidand@metamask/core-backend>uuidonlycrypto.getRandomValuesandcrypto.randomUUIDinstead of the fullcryptoglobal, matching uuid ^14.The spam-token-cleanup e2e spec mocks
GET https://token.api.cx.metamask.io/v2/assetswith an empty JSON array so the launchpad lookup succeeds and below-floor spam tokens are still removed in CI.Reviewed by Cursor Bugbot for commit 145140f. Bugbot is set up for automated code reviews on this repo. Configure here.