Repository navigation
chore(background): remove unused util helpers - #47577
Merged
georgewrmarshall merged 1 commit intoNov 3, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
November 3, 2026 09:33 — with
GitHub Actions
Inactive
georgewrmarshall
had a problem deploying
to
segment-schema
November 3, 2026 09:33 — with
GitHub Actions
Failure
georgewrmarshall
temporarily deployed
to
pr-comment
November 3, 2026 09:49 — with
GitHub Actions
Inactive
Contributor
Builds ready [f1f23c7]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
amandaye0h
approved these changes
Nov 3, 2026
vinnyhoward
approved these changes
Nov 3, 2026
vinnyhoward
left a comment
Contributor
There was a problem hiding this comment.
No correctness problems found
georgewrmarshall
deleted the
cursor/remove-dead-code-background-util-20261103-a4dd
branch
November 3, 2026 18:34
Contributor
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Remove four unused helpers from the background util module, plus the
CHAIN_IDS/TEST_CHAINSimport and thecharactersconstant that only those helpers used.getPlatformstays. Owner set:(none).No user-facing behavior change.
Docs/comments updated: none
Checks that passed:
yarn lint:tsc, eslint on the touched file,yarn test:unit --coverage=falseincludingapp/scripts/lib/util.test.jsandapp/scripts/detect-multiple-instances.test.js(31 suites, 449 tests, 5 snapshots passed, no snapshot updates). No stylesheets changed.Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unreachable exports only; no callers and no logic paths altered.
Overview
Proactive dead-code cleanup in
app/scripts/lib/util.ts: removes four unused exports (checkAlarmExists,getChainType,generateRandomId,isValidDate) and drops theCHAIN_IDS/TEST_CHAINSimport plus thecharactersconstant that only supported those helpers.The module’s export surface is narrowed to
getPlatformamong the removed batch (other existing exports in the file are unchanged). No user-facing or runtime behavior change—call sites already did not use these symbols; unit tests were run without snapshot updates.Reviewed by Cursor Bugbot for commit f1f23c7. Bugbot is set up for automated code reviews on this repo. Configure here.