Skip to content

test(confirmations): cover deposit_limit in alert metrics - #47580

Merged
jpuri merged 2 commits into
mainfrom
fix/conf-2222-deposit-limit-alert-metrics
Nov 4, 2026
Merged

jpuri merged 2 commits into
mainfrom
fix/conf-2222-deposit-limit-alert-metrics

Conversation

@jpuri

@jpuri jpuri commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Counterpart to the Mobile work in CONF-2194 (metamask-mobile#38715), where the deposit_limit alert was completely absent from Mixpanel — zero Transaction Added / Submitted / Rejected / Finalized events carried it between 2025-01-01 and 2026-10-26.

The headline result: that bug does not reproduce here, so this PR contains no production code change.

I verified each of the three Mobile defects against this codebase:

Mobile defect Extension status
Alert never registered in useConfirmationAlerts Already registered — useConfirmationAlerts.ts:58
Hook only read an explicit pendingAmount arg, so bare calls saw 0 Already falls back to primaryRequiredToken.amountFiat ?? amountUsd — useTransactionDepositLimitAlert.ts:42-54
trackAlertMetrics lived in a Footer that early-returns null for money-account deposits Mounted in the ConfirmAlerts provider at confirm.tsx:32, above <Footer /> at confirm.tsx:48

That third point is the important one. The Footer here does diverge for money-account deposits — isSingleActionFooterConfirmation (footer.tsx:94-124) routes moneyAccountDeposit, moneyAccountWithdraw, musdConversion, perpsDeposit, perpsWithdraw to a SingleActionFooter, which is the same failure shape as Mobile. But because the metrics hook sits two levels up in a pass-through provider with no early returns, no conditionals (confirm-alerts.tsx:8-28), the Footer's divergence cannot suppress the metric.

There is also a structural reason the Mobile "uncommitted amount" problem can't occur: Mobile gates the commit behind a Done button that the cap itself disables, so an over-cap amount is never persisted. Here useTransactionCustomAmount auto-commits on a debounce (:198-221) with no blocking gate, so the over-cap value does reach primaryRequiredToken and the committed fallback sees it.

What this PR actually does

The one real gap was test coverage: nothing pinned AlertsName.DepositLimit to its 'deposit_limit' metrics name, or asserted it survives the per-transaction-type exclusion filter. So a future edit to ALERTS_NAME_METRICS (useConfirmationAlertMetrics.ts:28), to EXCLUDED_ALERT_KEYS_BY_TRANSACTION_TYPE (:53-58), or to where ConfirmAlerts is mounted could silently reintroduce the Mobile regression with nothing failing.

Three tests added to useConfirmationAlertMetrics.test.ts:

  1. an over-cap money-account deposit reports alert_triggered: ['deposit_limit']
  2. the alert is not swept up by the exclusion that drops hexDataWhileInteractingWithNonContractAddress for this transaction type
  3. it is reported in alert_resolved once confirmed

These pass against current main, which is the evidence that the pipeline already works end to end rather than an assertion that it should.

Two differences from Mobile worth noting for reviewers

  • Property names differ. Extension emits alert_triggered / alert_triggered_count; Mobile emits alert_trigger_name / alert_trigger_count. Anyone querying both clients needs both names.
  • fiat_buy_amount_limit does not exist here at all — no useFiatBuyLimitAlert, no AlertsName member. On Mobile that alert was also dark and got fixed incidentally. Nothing to port.

Changelog

CHANGELOG entry: null

Related issues

Fixes: CONF-2222

Refs: CONF-2194 · metamask-mobile#38715

Manual testing steps

No user-facing change; the production behaviour is already correct. To confirm the instrumentation by hand:

  1. Set confirmations_pay_extended.depositLimit.moneyAccountDeposit to a low value (e.g. 100).
  2. Open a Money account deposit confirmation.
  3. Enter an amount above that limit.
  4. Confirm the blocking "Max deposit: $X" alert appears on the amount row and Confirm is disabled.
  5. Inspect the transaction event fragment / Segment payload and confirm alert_triggered contains deposit_limit.
  6. Back out of the confirmation and confirm the resulting rejected event still carries the property.

Automated: yarn jest ui/pages/confirmations/hooks/useConfirmationAlertMetrics.test.ts — 16 passed.

Screenshots/Recordings

N/A — test-only change, no UI impact.

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only change with no runtime or analytics pipeline modifications.

Overview
This PR adds test-only coverage for the money-account deposit limit alert in useConfirmationAlertMetrics — no production code changes.

A new deposit limit describe block adds three cases: over-cap money-account deposits emit alert_triggered: ['deposit_limit'], deposit_limit is not filtered by the same per-type exclusion that drops hexDataWhileInteractingWithNonContractAddress, and a user-confirmed deposit limit alert appears in alert_resolved. Together they lock the existing AlertsName.DepositLimit → deposit_limit mapping and behavior so future edits to metrics naming or exclusion rules cannot silently drop the alert (as happened on Mobile).

Reviewed by Cursor Bugbot for commit cc3c76a. Bugbot is set up for automated code reviews on this repo. Configure here.

Adds regression coverage asserting that an over-cap money account deposit
reports `alert_triggered: ['deposit_limit']` on the transaction event
fragment, that the alert survives the per-type exclusion filter, and that it
is reported as resolved once confirmed.

This is the extension counterpart to the Mobile work in CONF-2194. On Mobile
the same instrumentation was entirely dark: the alert was never registered in
`useConfirmationAlerts`, it only read an explicit `pendingAmount` argument, and
`trackAlertMetrics` lived inside a Footer that returns `null` for money
account deposits.

None of those three defects exist here. The alert is already registered
(`useConfirmationAlerts.ts:58`), already falls back to the committed amount
when called without arguments, and `useConfirmationAlertMetrics` is mounted in
the `ConfirmAlerts` provider above the page rather than inside the Footer, so
the Footer's `SingleActionFooter` divergence for money account deposits cannot
suppress it.

The only gap was that no test pinned the deposit limit to its metrics name, so
a future change to `ALERTS_NAME_METRICS`, to the exclusion list, or to where
the metrics hook is mounted could silently repeat the Mobile regression.

No production code change.
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-S label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +70 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📄 useConfirmationAlertMetrics.test.ts +70 -0

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [03460d7] [reused from 9089862]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41613938487 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↑ loadNewAccount/fcp: +16%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +77%
  • ↑ confirmTx/longTaskMaxDuration: +110%
  • ↑ confirmTx/tbt: +134%
  • ↑ confirmTx/fcp: +17%
  • ↑ confirmTx/lcp: +10%
  • ↑ bridgeUserActions/bridge_load_page: +155%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +151%
  • ↑ bridgeUserActions/longTaskMaxDuration: +59%
  • ↑ bridgeUserActions/tbt: +298%
  • ↑ bridgeUserActions/total: +29%
  • ↑ bridgeUserActions/inp: +46%
  • ↑ bridgeUserActions/fcp: +14%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -24%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1303%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -26%
  • ↑ confirmTx/lcp: +1455%
  • ↑ bridgeUserActions/bridge_load_page: +331%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +159%
  • ↑ bridgeUserActions/bridge_search_token: +12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +59%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +19%
  • ↑ bridgeUserActions/lcp: +1305%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +18%
  • ↑ startupStandardHome/load: +13%
  • ↑ startupStandardHome/domContentLoaded: +13%
  • ↑ startupStandardHome/domInteractive: +26%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/loadScripts: +12%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↑ startupStandardHome/longTaskMaxDuration: +11%
  • ↑ startupStandardHome/tbt: +16%
  • ↑ startupStandardHome/fcp: +13%
  • ↑ startupStandardHome/lcp: +14%
  • ↓ startupStandardHome/uiStartup: -42%
  • ↓ startupStandardHome/load: -38%
  • ↓ startupStandardHome/domContentLoaded: -39%
  • ↓ startupStandardHome/domInteractive: -57%
  • ↓ startupStandardHome/backgroundConnect: -37%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -38%
  • ↑ startupStandardHome/setupStore: +24%
  • ↓ startupStandardHome/fcp: -50%
  • ↓ startupStandardHome/lcp: -36%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +48%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +45%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +42%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +31%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +18%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +20%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +26%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -51%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB 0 Bytes 0.00%
✅ ui 19.33 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB 0 Bytes 0.00%
✅ zip 24.07 MiB 0 Bytes 0.00%

@jpuri jpuri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 3, 2026
@jpuri
jpuri marked this pull request as ready for review November 3, 2026 09:50
@jpuri
jpuri requested a review from a team as a code owner November 3, 2026 09:50
@jpuri
jpuri enabled auto-merge November 4, 2026 10:53
@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cc3c76a] [reused from 1752c4c]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41826460024 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +14%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskTotalDuration: +58%
  • ↑ confirmTx/longTaskMaxDuration: +77%
  • ↑ confirmTx/tbt: +97%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +11%
  • ↑ confirmTx/cls: +11%
  • ↑ bridgeUserActions/bridge_load_page: +59%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +126%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +115%
  • ↑ bridgeUserActions/longTaskMaxDuration: +56%
  • ↑ bridgeUserActions/tbt: +180%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/fcp: +14%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1290%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1286%
  • ↑ bridgeUserActions/bridge_load_page: +232%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +138%
  • ↑ bridgeUserActions/bridge_search_token: +60%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +75%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +16%
  • ↑ bridgeUserActions/lcp: +1278%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -10%
  • ↓ startupStandardHome/load: -12%
  • ↓ startupStandardHome/domContentLoaded: -12%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -12%
  • ↑ startupStandardHome/setupStore: +49%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -18%
  • ↓ startupStandardHome/longTaskMaxDuration: -14%
  • ↓ startupStandardHome/tbt: -16%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -12%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -21%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -48%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +84%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -20%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +43%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +33%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +23%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +36%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -36%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB 0 Bytes 0.00%
✅ ui 19.33 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.64 MiB 0 Bytes 0.00%
✅ zip 23.81 MiB 0 Bytes 0.00%

@jpuri
jpuri added this pull request to the merge queue Nov 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Merged via the queue into main with commit f47f2f6 Nov 4, 2026
60 checks passed
@jpuri
jpuri deleted the fix/conf-2222-deposit-limit-alert-metrics branch November 4, 2026 12:54
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — cc3c76aa Deployed Nov 4, 2026 by jpuri via Publish prerelease / Publish prerelease #172620
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants