Skip to content

fix(assets): place the token ticker under the token name - #47552

Merged
Prithpal-Sooriya merged 5 commits into
mainfrom
feature/use-memory-using-thi-ncx
Nov 4, 2026
Merged

Prithpal-Sooriya merged 5 commits into
mainfrom
feature/use-memory-using-thi-ncx

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

The token details header used the ticker as its title. ASSETS-4256 settles the layout as the token name on the title line, with the ticker directly beneath it. This mirrors the mobile change in MetaMask/metamask-mobile#38497.

What changed:

  • The header title is the token name, falling back to the symbol when the name is missing.
  • The ticker is shown on the subtitle line in the title color when it differs from the name. Comparison trims whitespace and is case-sensitive, so Pepe / PEPE shows both.
  • The contract address sits on the same line as the ticker. EVM addresses render as 0x.. plus the last four characters. Other addresses render as the first and last four characters. The copy control is unchanged.
  • A long ticker ellipsizes, and the address stays fully visible on that line.
  • When the name and ticker match (for example ETH), the ticker line is omitted so the symbol is not repeated.

Only presentation changes. Data, copy behavior, and badges are unchanged.

Changelog

CHANGELOG entry: Showed the token ticker under the token name on the token details page

Related issues

Fixes:

Refs: https://consensyssoftware.atlassian.net/browse/ASSETS-4256

Manual testing steps

Feature: token details header identity

  Scenario: token name and ticker differ
    Given a token whose name is Pepe and whose ticker is PEPE
    When the user opens that token on the token details page
    Then the header title is Pepe
    And PEPE is shown on the line directly under the name
    And the contract address is shown on that same line as 0x..XXXX
    And tapping the address copies the full contract address

  Scenario: token name and ticker match
    Given a token whose name and ticker are both ETH
    When the user opens that token on the token details page
    Then the header shows ETH once
    And no second ticker line is shown

  Scenario: long ticker
    Given a token with a long ticker
    When the user opens that token on the token details page
    Then the ticker is truncated with an ellipsis
    And the contract address and copy control remain fully visible

Screenshots/Recordings

Captured from a running test build, opened through asset deeplinks.

Before

The previous header used the ticker as the title and a longer address truncation.

After

The title is the token name. The ticker sits on the line beneath it, in the title color, next to the compact address. When the metadata name is the ticker itself, that second ticker is omitted.

Token details header screenshots (ERC-20, Solana, Tron, native)

Chainlink: title Chainlink Token, ticker LINK, address 0x..86CA

Chainlink header

Uniswap: title Uniswap, ticker UNI, address 0x..F984

Uniswap header

Pepe: title Pepe, ticker PEPE, address 0x..1933

Pepe header

USDC: title USDC, address 0x..eB48 (name matches ticker, so no second ticker line)

USDC header

Solana Bonk: title Bonk, ticker BONK, address DezX..B263

Bonk header

Tron Tether: title Tether, ticker USDT, address TR7N..Lj6t

Tether header

Native ETH: title Ethereum, ticker ETH, no address

Ethereum header

Native SOL: title SOL, no address (name matches ticker)

SOL header

Native TRX: title TRON, ticker TRX, no address

TRON header

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Presentation-only changes on the asset details header; copy behavior and asset data paths are unchanged aside from display-name selection.

Overview
The token details header no longer uses the ticker as the main title. It now shows the token name (from metadata via new resolveTokenDisplayName, with symbol fallback) and, when the symbol differs from that title (case-sensitive, trimmed), a subtitle row with the ticker plus the contract copy control on one line.

Contract addresses switch from shortenAddress to a compact format: EVM as 0x.. + last four characters; Solana/Tron-style as first four + .. + last four. Long tickers ellipsize while the address stays fully visible; duplicate name/ticker (e.g. ETH) drops the extra ticker line. The avatar badge is vertically centered against the name block.

AssetPage, native-asset, and token-asset pass name through; copy-on-click still uses the full address. Tests cover header layout, address formatting, and name resolution.

Reviewed by Cursor Bugbot for commit 0629cd1. Bugbot is set up for automated code reviews on this repo. Configure here.

ASSETS-4256: the token details header now uses the token name as the title and shows the ticker with a compact contract address on the line beneath it, matching the mobile token details layout.
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7c2c613]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41537644952 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +73%
  • ↑ confirmTx/longTaskMaxDuration: +92%
  • ↑ confirmTx/tbt: +126%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +118%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +110%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +95%
  • ↑ bridgeUserActions/longTaskMaxDuration: +19%
  • ↑ bridgeUserActions/tbt: +157%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +11%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/inp: +14%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1305%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +24%
  • ↑ confirmTx/lcp: +1388%
  • ↑ bridgeUserActions/bridge_load_page: +320%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +145%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +51%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +30%
  • ↑ bridgeUserActions/lcp: +1326%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -24%
  • ↓ startupStandardHome/domContentLoaded: -24%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/firstPaint: -12%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -25%
  • ↑ startupStandardHome/setupStore: +59%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -33%
  • ↓ startupStandardHome/longTaskMaxDuration: -31%
  • ↓ startupStandardHome/tbt: -33%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -26%
  • ↓ startupStandardHome/lcp: -11%
  • ↓ startupStandardHome/uiStartup: -32%
  • ↓ startupStandardHome/load: -27%
  • ↓ startupStandardHome/domContentLoaded: -28%
  • ↓ startupStandardHome/domInteractive: -19%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -27%
  • ↑ startupStandardHome/setupStore: +56%
  • ↓ startupStandardHome/fcp: -16%
  • ↓ startupStandardHome/lcp: -25%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +45%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +15%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -58%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -88%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -72%
  • ↓ dappPageLoad/domContentLoaded: -35%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB -79 Bytes 0.00%
✅ ui 19.33 MiB +92 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +18 Bytes 0.00%
✅ zip 24.07 MiB +37 Bytes 0.00%

Capture the running token details header for ERC-20, Solana, Tron, and native assets so the ASSETS-4256 layout can be reviewed on the pull request.

Co-authored-by: Cursor <cursoragent@cursor.com>
The details header was falling back to the ticker when asset metadata was ignored, so a distinct name never appeared above the symbol.

Co-authored-by: Cursor <cursoragent@cursor.com>
Screenshots are hosted in the pull request description instead of the repository.

Co-authored-by: Cursor <cursoragent@cursor.com>
The avatar wrapper aligned to the top of the name and ticker. Center it on that text block.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0629cd1]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41547347875 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/lcp: +17%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskTotalDuration: +72%
  • ↑ confirmTx/longTaskMaxDuration: +106%
  • ↑ confirmTx/tbt: +126%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +25%
  • ↑ bridgeUserActions/bridge_load_page: +107%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +123%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +104%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +177%
  • ↑ bridgeUserActions/total: +23%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -39%
  • ↑ loadNewAccount/lcp: +1025%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -46%
  • ↑ confirmTx/lcp: +1073%
  • ↑ bridgeUserActions/bridge_load_page: +381%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +161%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +48%
  • ↑ bridgeUserActions/inp: +77%
  • ↓ bridgeUserActions/fcp: -48%
  • ↑ bridgeUserActions/lcp: +1021%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -36%
  • ↓ startupStandardHome/domContentLoaded: -36%
  • ↓ startupStandardHome/domInteractive: -22%
  • ↓ startupStandardHome/firstPaint: -23%
  • ↓ startupStandardHome/backgroundConnect: -39%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -37%
  • ↑ startupStandardHome/setupStore: +74%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -43%
  • ↓ startupStandardHome/longTaskMaxDuration: -40%
  • ↓ startupStandardHome/tbt: -46%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -36%
  • ↓ startupStandardHome/lcp: -21%
  • ↑ startupStandardHome/domInteractive: +37%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/fcp: +41%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +15%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +12%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +43%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -91%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -32%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB -72 Bytes 0.00%
✅ ui 19.33 MiB +707 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
✅ unzipped 79.89 MiB +661 Bytes 0.00%
✅ zip 24.07 MiB +161 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@juanmigdr juanmigdr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya
Prithpal-Sooriya added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 387f2ac Nov 4, 2026
144 of 145 checks passed
@Prithpal-Sooriya
Prithpal-Sooriya deleted the feature/use-memory-using-thi-ncx branch November 4, 2026 12:39
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch had an error being deployed

1 failed and 1 inactive deployments
segment-schema — 0629cd14 Deployed Nov 2, 2026 by Prithpal-Sooriya via propose #2380
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants