Repository navigation
chore(assets-controller): bump assets controller to 20.0.0 - #47400
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
Builds ready [b357501]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
b357501 to
d500669
Compare
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (1 files, +12 -9)
|
d500669 to
fccb64c
Compare
Builds ready [fccb64c] [reused from d500669]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
fccb64c to
3f38eb3
Compare
Builds ready [3f38eb3]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Builds ready [cf4bd58]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Builds ready [ed54147]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs
|
|



Description
Bumps
@metamask/assets-controllerfrom^19.1.0to^20.0.0so Extension picks up the 20.0.0 asset pipeline (core#10892).20.0.0changes how token metadata and prices are filled in:symbol,name,decimals,image,aggregators, oroccurrencesis missing.DetectionMiddleware, theAssetsController:assetsDetectedevent,detectedAssetsonDataResponse, and theassetsForPriceUpdateoption ongetAssetsare removed. An explicit price refresh goes throughAssetsController:syncAssetsPrices.Extension already compiles against the remaining messenger surface, so this PR only updates dependency versions and two E2E fixtures.
@metamask/bridge-controller(^83.1.1) and@metamask/transaction-pay-controller(^30.3.0) move with it because they depend on assets-controller 20.Fixture updates:
assetsInfowithoccurrencesandimage, so those rows are complete metadata and the controller leaves them in place.Changelog
CHANGELOG entry: null
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
A major-version assets-controller bump can change how token metadata, balances, and prices are keyed and synced across Pay, bridge, and the wallet UI; risk is mitigated here by limited diff scope and targeted E2E fixture fixes.
Overview
Upgrades
@metamask/assets-controllerfrom 19.x to 20.0.0, with aligned bumps to@metamask/bridge-controller(^83.1.1) and@metamask/transaction-pay-controller(^30.3.0), plus the correspondingyarn.locktransitive updates.E2E fixtures are adjusted for AssetsController 20 behavior: ERC-20 state is keyed by EIP-55 checksummed asset IDs, so Perps withdraw mocks now build asset IDs from hex addresses and match spot-price mocks with case-insensitive lookups. The spam-token cleanup spec seeds
assetsInfowithoccurrencesandimageso fixture state matches what the new controller expects during cleanup tests.There are no application source changes in this PR—only dependency versions and test/fixture updates.
Reviewed by Cursor Bugbot for commit ed54147. Bugbot is set up for automated code reviews on this repo. Configure here.