Skip to content

chore(assets-controller): bump assets controller to 20.0.0 - #47400

Merged
Kriys94 merged 3 commits into
mainfrom
chore/bumpAssetsController20
Oct 29, 2026
Merged

Kriys94 merged 3 commits into
mainfrom
chore/bumpAssetsController20

Conversation

@Kriys94

@Kriys94 Kriys94 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/assets-controller from ^19.1.0 to ^20.0.0 so Extension picks up the 20.0.0 asset pipeline (core#10892).

20.0.0 changes how token metadata and prices are filled in:

  • Stored metadata is fetched again when symbol, name, decimals, image, aggregators, or occurrences is missing.
  • A balance refresh prices a balance from the current response only when that asset has no stored price, and it skips hidden assets. The price poll still refreshes stored prices for held balances and custom assets, and it skips metadata that has no balance.
  • DetectionMiddleware, the AssetsController:assetsDetected event, detectedAssets on DataResponse, and the assetsForPriceUpdate option on getAssets are removed. An explicit price refresh goes through AssetsController:syncAssetsPrices.

Extension already compiles against the remaining messenger surface, so this PR only updates dependency versions and two E2E fixtures. @metamask/bridge-controller (^83.1.1) and @metamask/transaction-pay-controller (^30.3.0) move with it because they depend on assets-controller 20.

Fixture updates:

  • Perps withdraw mocks build ERC-20 asset ids from the EIP-55 address. AssetsController 20 keys ERC-20 state by that checksummed id, and Pay reads the same key. A lowercase seed left the checksummed entry with metadata and no price, so the withdraw button stayed on its loading spinner. Spot-price mocks match those ids case-insensitively.
  • The spam-token cleanup fixture seeds assetsInfo with occurrences and image, so those rows are complete metadata and the controller leaves them in place.

Changelog

CHANGELOG entry: null

Manual testing steps

  1. Build and load this branch, then unlock a wallet that holds tokens on Ethereum Mainnet.
  2. Open the home asset list and confirm symbols, balances, and fiat prices still appear.
  3. Open a token whose stored metadata was missing an image or occurrence count, refresh assets, and confirm the icon and name fill in.
  4. Open Perps, start a withdraw, and confirm the pay-token price loads and the withdraw button leaves the loading spinner.
  5. Confirm a token that was previously hidden as spam stays out of the asset list.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
A major-version assets-controller bump can change how token metadata, balances, and prices are keyed and synced across Pay, bridge, and the wallet UI; risk is mitigated here by limited diff scope and targeted E2E fixture fixes.

Overview
Upgrades @metamask/assets-controller from 19.x to 20.0.0, with aligned bumps to @metamask/bridge-controller (^83.1.1) and @metamask/transaction-pay-controller (^30.3.0), plus the corresponding yarn.lock transitive updates.

E2E fixtures are adjusted for AssetsController 20 behavior: ERC-20 state is keyed by EIP-55 checksummed asset IDs, so Perps withdraw mocks now build asset IDs from hex addresses and match spot-price mocks with case-insensitive lookups. The spam-token cleanup spec seeds assetsInfo with occurrences and image so fixture state matches what the new controller expects during cleanup tests.

There are no application source changes in this PR—only dependency versions and test/fixture updates.

Reviewed by Cursor Bugbot for commit ed54147. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​assets-controller@​19.1.0 ⏵ 20.0.098 +210080 +1100100
Updated@​metamask/​bridge-controller@​83.0.0 ⏵ 83.1.199 +410080100 +1100
Updated@​metamask/​transaction-pay-controller@​30.2.0 ⏵ 30.3.099 +510081 +1100 +1100
Updated@​metamask/​assets-controllers@​112.1.3 ⏵ 112.2.096 +210091100 +1100

View full report

@socket-security

socket-security Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Priority Alert  (click "▶" to expand/collapse) Action
Low priority
Potential code anomaly (AI signal): npm @metamask/transaction-pay-controller is 96.0% likely to have a medium risk anomaly

Notes: This code implements a server-quote transaction flow and is not clearly malware. It signs quote-provided typed data and sends signatures to a quote-provided endpoint, and submits quote-derived transactions with requireApproval:false; a malicious or compromised quote source could therefore cause unauthorized signing or transaction submission. No fixed domain, URL, IP, credential target, or environment-variable access is present in the fragment. Severity is medium to high depending on validation and trust controls outside this file.

Confidence: 0.96

Severity: 0.63

From: package.json → npm/@metamask/transaction-pay-controller@30.3.0

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/transaction-pay-controller@30.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b357501]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40525697755 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/lcp: -10%
  • ↑ confirmTx/longTaskTotalDuration: +26%
  • ↑ confirmTx/longTaskMaxDuration: +56%
  • ↑ confirmTx/tbt: +45%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -12%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +42%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +78%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +66%
  • ↑ bridgeUserActions/tbt: +68%
  • ↓ bridgeUserActions/fcp: -13%
  • ↓ bridgeUserActions/lcp: -16%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +23%
  • ↑ loadNewAccount/lcp: +1315%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -37%
  • ↑ confirmTx/lcp: +1327%
  • ↑ bridgeUserActions/bridge_load_page: +313%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +119%
  • ↑ bridgeUserActions/bridge_search_token: +65%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +90%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +20%
  • ↑ bridgeUserActions/lcp: +1251%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -30%
  • ↓ startupStandardHome/load: -32%
  • ↓ startupStandardHome/domContentLoaded: -33%
  • ↓ startupStandardHome/domInteractive: -20%
  • ↓ startupStandardHome/firstPaint: -24%
  • ↓ startupStandardHome/backgroundConnect: -34%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -33%
  • ↑ startupStandardHome/setupStore: +59%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -39%
  • ↓ startupStandardHome/longTaskMaxDuration: -37%
  • ↓ startupStandardHome/tbt: -41%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -22%
  • ↓ startupStandardHome/uiStartup: -28%
  • ↓ startupStandardHome/load: -22%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -46%
  • ↓ startupStandardHome/backgroundConnect: -12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -22%
  • ↑ startupStandardHome/setupStore: +67%
  • ↓ startupStandardHome/fcp: -39%
  • ↓ startupStandardHome/lcp: -21%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +38%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +35%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +33%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB -25.17 KiB -0.16%
🚨 ui 19.25 MiB +6.33 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +21 Bytes 0.00%
✅ content scripts 3.23 MiB +42 Bytes 0.00%
✅ zip 24.03 MiB -3.52 KiB -0.01%

@Kriys94
Kriys94 force-pushed the chore/bumpAssetsController20 branch from b357501 to d500669 Compare October 27, 2026 16:39
@github-actions github-actions Bot added size-S and removed size-XS labels Oct 27, 2026
@metamask-ci

metamask-ci Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (1 files, +12 -9)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 perps/
          • 📄 perps-fixture-config.ts +12 -9

@Kriys94 Kriys94 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 27, 2026
@Kriys94
Kriys94 force-pushed the chore/bumpAssetsController20 branch from d500669 to fccb64c Compare October 27, 2026 16:54
@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [fccb64c] [reused from d500669]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40545488875 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +85%
  • ↑ confirmTx/longTaskMaxDuration: +103%
  • ↑ confirmTx/tbt: +125%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +14%
  • ↑ bridgeUserActions/bridge_load_page: +91%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +121%
  • ↑ bridgeUserActions/longTaskMaxDuration: +48%
  • ↑ bridgeUserActions/tbt: +239%
  • ↑ bridgeUserActions/total: +15%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +25%
  • ↑ loadNewAccount/lcp: +1345%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -57%
  • ↑ confirmTx/lcp: +1872%
  • ↑ bridgeUserActions/bridge_load_page: +338%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +151%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +53%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +23%
  • ↑ bridgeUserActions/lcp: +1338%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/LCP: p75 3.3s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupStandardHome

Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +127%
  • ↓ startupStandardHome/longTaskCount: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +18%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +35%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +22%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +23%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +23%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -51%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -58%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB -24.6 KiB -0.16%
🚨 ui 19.25 MiB +7.25 KiB +0.04%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +35 Bytes 0.00%
✅ content scripts 3.23 MiB +70 Bytes 0.00%
✅ zip 24.03 MiB -2.82 KiB -0.01%

@metamask-ci

metamask-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3f38eb3]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40551736205 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ confirmTx/longTaskTotalDuration: +54%
  • ↑ confirmTx/longTaskMaxDuration: +92%
  • ↑ confirmTx/tbt: +95%
  • ↑ confirmTx/lcp: +14%
  • ↑ bridgeUserActions/bridge_load_page: +89%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +89%
  • ↑ bridgeUserActions/tbt: +139%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +422%
  • ↑ loadNewAccount/total: +422%
  • ↑ loadNewAccount/inp: +14%
  • ↑ loadNewAccount/fcp: +28%
  • ↑ loadNewAccount/lcp: +1422%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -32%
  • ↑ confirmTx/lcp: +1439%
  • ↑ bridgeUserActions/bridge_load_page: +287%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +125%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +57%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +26%
  • ↑ bridgeUserActions/lcp: +1392%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +142%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/domInteractive: +35%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↑ startupStandardHome/fcp: +44%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +54%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +41%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +38%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -85%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.4 MiB -1.06 KiB -0.01%
✅ ui 19.25 MiB -567 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +14 Bytes 0.00%
✅ content scripts 3.23 MiB +28 Bytes 0.00%
✅ zip 24.03 MiB -69 Bytes 0.00%

@Kriys94
Kriys94 marked this pull request as ready for review October 27, 2026 18:05
@Kriys94
Kriys94 requested a review from a team as a code owner October 27, 2026 18:05
@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cf4bd58]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40669799397 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ loadNewAccount/lcp: +21%
  • ↑ confirmTx/longTaskTotalDuration: +70%
  • ↑ confirmTx/longTaskMaxDuration: +100%
  • ↑ confirmTx/tbt: +122%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +17%
  • ↑ bridgeUserActions/bridge_load_page: +118%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +125%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +150%
  • ↑ bridgeUserActions/longTaskMaxDuration: +70%
  • ↑ bridgeUserActions/tbt: +327%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/fcp: +14%
  • ↑ bridgeUserActions/lcp: +12%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/inp: +14%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1277%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -26%
  • ↑ confirmTx/lcp: +1385%
  • ↑ bridgeUserActions/bridge_load_page: +288%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +132%
  • ↑ bridgeUserActions/bridge_search_token: +28%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +76%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +25%
  • ↑ bridgeUserActions/lcp: +1305%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +195%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/domInteractive: -29%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -26%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +52%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +45%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +40%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.4 MiB -1.49 KiB -0.01%
✅ ui 19.25 MiB -807 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +8 Bytes 0.00%
✅ content scripts 3.23 MiB +16 Bytes 0.00%
✅ zip 24.03 MiB -340 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ed54147]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40722001595 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ confirmTx/longTaskTotalDuration: +62%
  • ↑ confirmTx/longTaskMaxDuration: +106%
  • ↑ confirmTx/tbt: +118%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +18%
  • ↑ bridgeUserActions/bridge_load_page: +112%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +147%
  • ↑ bridgeUserActions/longTaskMaxDuration: +65%
  • ↑ bridgeUserActions/tbt: +316%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ loadNewAccount/load_new_account: +415%
  • ↑ loadNewAccount/total: +415%
  • ↓ loadNewAccount/inp: -39%
  • ↓ loadNewAccount/fcp: -78%
  • ↑ loadNewAccount/lcp: +988%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -73%
  • ↑ confirmTx/lcp: +878%
  • ↑ bridgeUserActions/bridge_load_page: +125%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +24%
  • ↓ bridgeUserActions/bridge_search_token: -15%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -70%
  • ↑ bridgeUserActions/lcp: +840%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domInteractive: +17%
  • ↑ startupStandardHome/firstPaint: +18%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +158%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +18%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +147%
  • ↓ startupStandardHome/fcp: -11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +19%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +23%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +15%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -16%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -18%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -39%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.4 MiB -378 Bytes 0.00%
✅ ui 19.26 MiB -989 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
✅ unzipped 79.75 MiB -1.31 KiB 0.00%
✅ zip 24.04 MiB -57 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@Kriys94
Kriys94 added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 8cc52be Oct 29, 2026
143 checks passed
@Kriys94
Kriys94 deleted the chore/bumpAssetsController20 branch October 29, 2026 09:05
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — ed541471 Deployed Oct 28, 2026 by Kriys94 via Publish prerelease / Publish prerelease #171661
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-S team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants