Skip to content

fix: use toast to handle the failure message when a non-evm transaction return error after user confirm - #47528

Merged
stanleyyconsensys merged 9 commits into
mainfrom
fix/snap-txn-error-handle
Nov 3, 2026
Merged

stanleyyconsensys merged 9 commits into
mainfrom
fix/snap-txn-error-handle

Conversation

@stanleyyconsensys

@stanleyyconsensys stanleyyconsensys commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR fix the failure message is not show up
when a non-evm transaction return error after user confirm from the confirmation dialog

Previous
any error b4 dialog show, it return to amt input screen (bitcoin example)
any error after dialog show , it return home, no error

After fix
any error b4 dialog show, it return to amt input screen (bitcoin example)
any error after dialog show , it return home, toast with error (stellar example)

the root cause is
the loader component replace the navigation history
the current failure handle will redirect back to home

the solution is
display the error in toast when redirect back to home

as result
we can keep the same behavior when non-evm transaction return error before user confirm from the confirmation dialog
but only using toast when non-evm transaction return error after user confirm from the confirmation dialog

https://www.loom.com/share/c614df7241a54d08b36fdd4ef88a3832

Changelog

CHANGELOG entry: Fixed a bug that the failure message is omitted when having error in non-evm send fund

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes non-EVM send error UX and routing detection via window.location.hash; logic is scoped to failure handling but affects a core user-facing send path.

Overview
Fixes missing failure feedback when a non-EVM send fails after the user confirms in the Snap dialog. The send loader replaces navigation history, so navigating back no longer lands on the amount screen and updateNonEVMSubmitError had nothing visible to attach to.

useSendActions now uses a new isRemainInSendScreen() helper (hash route still under SEND_ROUTE) to choose how errors surface: on the send flow, behavior is unchanged—validation and snap errors still set context via updateNonEVMSubmitError (including mapped snap codes). Once the user has left the send screen, the same failures show a generic toast.error instead, then still navigate PREVIOUS_ROUTE. User rejection (4001) stays silent—no toast, error cleared.

Tests mock toast.error, drive window.location.hash to simulate post-loader routes, and cover validation/RPC failures (toast shown) vs rejection (no toast).

Reviewed by Cursor Bugbot for commit 4cc098e. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 2, 2026
@metamask-ci metamask-ci Bot added the team-networks PRs from the Networks team label Nov 2, 2026
@metamask-ci

metamask-ci Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +123 -4)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📁 send/
            • 📄 useSendActions.test.ts +90 -0
            • 📄 useSendActions.ts +33 -4

@stanleyyconsensys stanleyyconsensys changed the title fix: error handle in non-evm useSendActions fix: use toast to handle the failure message when a non-evm transaction return error after user confirm Nov 2, 2026
@stanleyyconsensys
stanleyyconsensys requested a balanced review from Copilot November 2, 2026 04:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change restoring failure feedback for non-EVM sends after leaving the send screen.

No open issues 🎉

What changed in this PR

This PR restores failure feedback for non-EVM sends when the confirmation flow moves the user away from the send screen.

Changes:

  • Shows a generic error toast when a send fails after leaving the send screen, while preserving inline errors on the send screen.
  • Keeps user rejections silent and preserves existing back navigation.
  • Adds tests for validation failures, thrown errors, and user rejections after leaving the send screen.
File Description
ui/​pages/​confirmations/​hooks/​send/​useSendActions.ts Selects inline errors or toast notifications based on the current route.
ui/​pages/​confirmations/​hooks/​send/​useSendActions.test.ts Adds toast mocks and tests for off-screen failures and silent rejection handling.

Review effort: Balanced

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e79d15b. Configure here.

// Show generic error message rather than error message from error code mapping
toast.error(genericErrorMessage);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toast hidden after send return

Medium Severity

After a post-confirm non-EVM failure, the new path calls toast.error and then navigate(PREVIOUS_ROUTE). The loader only replaces /send/loader, so -1 typically returns to the send form. That form uses useHideToasts and this branch never sets updateNonEVMSubmitError, so the failure can still never appear.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e79d15b. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, -1 will redirect to home from this case

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [e79d15b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41386202574 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -12%
  • ↑ confirmTx/longTaskTotalDuration: +13%
  • ↑ confirmTx/longTaskMaxDuration: +43%
  • ↑ confirmTx/tbt: +23%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -20%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +31%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +17%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +59%
  • ↓ bridgeUserActions/longTaskMaxDuration: -11%
  • ↑ bridgeUserActions/tbt: +20%
  • ↓ bridgeUserActions/fcp: -14%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/inp: +29%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1289%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1412%
  • ↑ bridgeUserActions/bridge_load_page: +265%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +39%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +1276%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -12%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/setupStore: +105%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -21%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -18%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -13%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +43%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +43%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +57%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -34%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -159.16 KiB -1.01%
🚨 ui 19.28 MiB +23.7 KiB +0.12%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -4.55 KiB -0.10%
✅ content scripts 3.23 MiB -9.16 KiB -0.28%
✅ unzipped 79.84 MiB -148.83 KiB -0.18%
✅ zip 24.06 MiB -50.33 KiB -0.20%

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5aedeec] [reused from e79d15b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41391217834 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -12%
  • ↑ confirmTx/longTaskTotalDuration: +13%
  • ↑ confirmTx/longTaskMaxDuration: +43%
  • ↑ confirmTx/tbt: +23%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -20%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +31%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +17%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +59%
  • ↓ bridgeUserActions/longTaskMaxDuration: -11%
  • ↑ bridgeUserActions/tbt: +20%
  • ↓ bridgeUserActions/fcp: -14%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/inp: +29%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1289%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1412%
  • ↑ bridgeUserActions/bridge_load_page: +265%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +39%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +1276%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -12%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/setupStore: +105%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -21%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -18%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -13%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +43%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +43%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +57%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -34%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -159.16 KiB -1.01%
🚨 ui 19.28 MiB +23.7 KiB +0.12%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -4.55 KiB -0.10%
✅ content scripts 3.23 MiB -9.16 KiB -0.28%
✅ unzipped 79.84 MiB -148.83 KiB -0.18%
✅ zip 24.06 MiB -50.33 KiB -0.20%

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5768551] [reused from e79d15b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41402395771 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -18%
  • ↓ loadNewAccount/lcp: -12%
  • ↑ confirmTx/longTaskTotalDuration: +13%
  • ↑ confirmTx/longTaskMaxDuration: +43%
  • ↑ confirmTx/tbt: +23%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -20%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +31%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +17%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +59%
  • ↓ bridgeUserActions/longTaskMaxDuration: -11%
  • ↑ bridgeUserActions/tbt: +20%
  • ↓ bridgeUserActions/fcp: -14%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/inp: +29%
  • ↓ loadNewAccount/fcp: -31%
  • ↑ loadNewAccount/lcp: +1289%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1412%
  • ↑ bridgeUserActions/bridge_load_page: +265%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +143%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +39%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +1276%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -12%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/setupStore: +105%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -21%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -18%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -13%
  • ↓ startupStandardHome/domInteractive: -32%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +43%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +43%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +57%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +34%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -34%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -159.16 KiB -1.01%
🚨 ui 19.28 MiB +23.7 KiB +0.12%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -4.55 KiB -0.10%
✅ content scripts 3.23 MiB -9.16 KiB -0.28%
✅ unzipped 79.84 MiB -148.83 KiB -0.18%
✅ zip 24.06 MiB -50.33 KiB -0.20%

khanti42
khanti42 previously approved these changes Nov 2, 2026
Comment on lines +144 to +147
} else {
// Show generic error message rather than error message from error code mapping
toast.error(genericErrorMessage);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirmSend return { valid: false } after the user has approved in the Snap dialog? If it still able to return { valid: false }, then this means our validations doesn't work isn't it?

If not, this else branch can’t be reached (we’re still on /send/loader), and we can keep the original updateNonEVMSubmitError(errorMessage) here. The toast would then only be needed in the catch path.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today most of the snap will return valid false after user approve transaction
but 1 or 2 snap they throw exception for situration

the reason for return valid false after user confirm is that , the situration can be different after user confirm the txn

e.g
i have enough balance right before i click the confirm
at the same second that i confirm txn, my wallet out of fund, so the txn cant be send (some snap doing validation again after confirm the txn)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-validating after approval makes sense, but returning { valid: false } after approval is the root issue. That shape means “fix your input” before the dialog, so the client has to guess which case it’s in. Tron, Solana and Bitcoin throw after approval, but Stellar returns valid: false, and it maps unexpected errors to Invalid too.

Can we align with the network snaps post-approval failures throw (or the Snap shows its own result screen)? I’m OK with this PR as a stopgap if there’s a follow-up issue. Also worth checking: in Stellar, if anything throws after sendTransaction (saving the pending transaction, scheduling the background event), it would report failure for a transaction that was actually broadcast.

OGPoyraz
OGPoyraz previously approved these changes Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [97e8e78]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41595934631 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ loadNewAccount/fcp: +12%
  • ↑ loadNewAccount/lcp: +15%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +106%
  • ↑ confirmTx/tbt: +133%
  • ↑ confirmTx/fcp: +14%
  • ↑ confirmTx/lcp: +21%
  • ↑ bridgeUserActions/bridge_load_page: +224%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +97%
  • ↑ bridgeUserActions/longTaskCount: +178%
  • ↑ bridgeUserActions/longTaskTotalDuration: +216%
  • ↑ bridgeUserActions/longTaskMaxDuration: +68%
  • ↑ bridgeUserActions/tbt: +302%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/lcp: +10%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -61%
  • ↑ loadNewAccount/lcp: +1033%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -59%
  • ↑ confirmTx/lcp: +1054%
  • ↑ bridgeUserActions/bridge_load_page: +248%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +104%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +1022%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -26%
  • ↓ startupStandardHome/load: -28%
  • ↓ startupStandardHome/domContentLoaded: -29%
  • ↓ startupStandardHome/domInteractive: -15%
  • ↓ startupStandardHome/firstPaint: -16%
  • ↓ startupStandardHome/backgroundConnect: -29%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -67%
  • ↓ startupStandardHome/loadScripts: -29%
  • ↑ startupStandardHome/setupStore: +59%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -36%
  • ↓ startupStandardHome/longTaskMaxDuration: -33%
  • ↓ startupStandardHome/tbt: -37%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -28%
  • ↓ startupStandardHome/lcp: -13%
  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +21%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -13%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +38%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +18%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +23%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -65%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -395 Bytes 0.00%
🚨 ui 19.33 MiB +47.62 KiB +0.24%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +265 Bytes +0.01%
✅ content scripts 3.23 MiB +520 Bytes +0.02%
🚨 unzipped 79.89 MiB +48.9 KiB +0.06%
🚨 zip 24.07 MiB +11.08 KiB +0.04%

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4cc098e]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41599411834 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +72%
  • ↑ confirmTx/longTaskMaxDuration: +102%
  • ↑ confirmTx/tbt: +127%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +17%
  • ↑ bridgeUserActions/bridge_load_page: +105%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +53%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +200%
  • ↑ bridgeUserActions/longTaskMaxDuration: +46%
  • ↑ bridgeUserActions/tbt: +268%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +17%
  • ↑ loadNewAccount/lcp: +1335%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -33%
  • ↑ confirmTx/lcp: +1335%
  • ↑ bridgeUserActions/bridge_load_page: +293%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +141%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +41%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1277%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 loadNewAccount/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +15%
  • ↑ startupStandardHome/load: +12%
  • ↑ startupStandardHome/domContentLoaded: +12%
  • ↑ startupStandardHome/domInteractive: +29%
  • ↑ startupStandardHome/firstPaint: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/setupStore: +218%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↑ startupStandardHome/longTaskMaxDuration: +10%
  • ↑ startupStandardHome/tbt: +15%
  • ↑ startupStandardHome/fcp: +12%
  • ↑ startupStandardHome/lcp: +12%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +147%
  • ↑ startupStandardHome/fcp: +31%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +55%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +29%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -11%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -22%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -35%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +216 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +351 Bytes 0.00%
✅ zip 24.07 MiB +142 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@stanleyyconsensys
stanleyyconsensys added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 9089862 Nov 3, 2026
144 of 145 checks passed
@stanleyyconsensys
stanleyyconsensys deleted the fix/snap-txn-error-handle branch November 3, 2026 09:01
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch had an error being deployed

1 failed and 1 inactive deployments
segment-schema — 4cc098e3 Deployed Nov 3, 2026 by stanleyyconsensys via propose #2511
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-M team-networks PRs from the Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants