Repository navigation
fix(mfa): align the code screen with the design system - #47539
Merged
Merged
Conversation
mathieuartu
temporarily deployed
to
pr-comment
November 2, 2026 14:14 — with
GitHub Actions
Inactive
mathieuartu
had a problem deploying
to
segment-schema
November 2, 2026 14:14 — with
GitHub Actions
Failure
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (3 files, +30 -14)
|
mathieuartu
had a problem deploying
to
segment-schema
November 2, 2026 14:15 — with
GitHub Actions
Failure
mathieuartu
had a problem deploying
to
segment-schema
November 2, 2026 14:20 — with
GitHub Actions
Failure
mathieuartu
temporarily deployed
to
pr-comment
November 2, 2026 14:28 — with
GitHub Actions
Inactive
Contributor
Builds ready [1f91362]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
mathieuartu
had a problem deploying
to
segment-schema
November 2, 2026 15:02 — with
GitHub Actions
Failure
mathieuartu
enabled auto-merge
November 2, 2026 15:03
ccharly
approved these changes
Nov 2, 2026
montelaidev
approved these changes
Nov 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 2, 2026
owencraston
approved these changes
Nov 2, 2026
Contributor
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-2455
Manual testing steps
Feature: MFA email verification code entry
Background:
Given the user reaches the "Enter your verification code" screen in an MFA flow
And a 6-digit code has been sent to their email
Scenario: user no longer sees a Paste button
Then there is no "Paste" button above the code boxes
And the code boxes sit directly under the description at the standard gap
Scenario: user pastes the code with a long press
Given the user has copied the code from the email
When user long-presses any of the code boxes
Then all 6 boxes fill with the code
And the code is submitted automatically
And releasing the long press does not clear any digits
Scenario: user types the code
When user taps the boxes and types 6 digits
Then the focused box has a darker border than the others
And the code is submitted automatically after the 6th digit
Scenario: user enters a wrong code and tries again
When user enters an incorrect 6-digit code
Then the boxes clear, their borders turn red and "This code isn't correct. Try again" shows
When user types the first digit of a new code
Then the red borders and the error message disappear
Scenario: Android keyboard offers the code
Given the user is on a real Android device that has received the code
When user focuses the code boxes
Then the keyboard can suggest the one-time code
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Localized MFA OTP UI and accessibility tweaks with no auth or verification logic changes.
Overview
Updates the MFA 6-digit code entry screen so invalid-code feedback matches design-system text fields and the ticket’s retry flow.
After a wrong code, the digits still clear as before, but red cell borders and the alert now use a dedicated
showErrorState(error + empty input). As soon as the user types again, the message and red styling drop whilearia-invalidfollows the same rule.Cell styling moves to
getCellBorder: error red,border-defaulton the active cell,border-mutedotherwise (replacing primary focus rings and a thicker border). Digit typography usesHeadingLginstead of a custom size.The email Resend button no longer shows a loading state during verification—progress stays in the “Verifying…” row under the boxes.
StepMessagedrops medium font weight for step helper/error text.Adds a test that the invalid-code alert hides once the user enters a new digit.
Reviewed by Cursor Bugbot for commit 1f91362. Bugbot is set up for automated code reviews on this repo. Configure here.