Skip to content

chore(swaps): remove unused swaps constant exports - #47578

Merged
georgewrmarshall merged 3 commits into
mainfrom
cursor/remove-dead-code-swaps-constants-20261103-a4dd
Nov 3, 2026
Merged

georgewrmarshall merged 3 commits into
mainfrom
cursor/remove-dead-code-swaps-constants-20261103-a4dd

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Remove three unused swaps constant exports. SWAPS_CHAINID_COMMON_TOKEN_PAIR and MONAD stay: the pair is named from a perps-owned comment, and MONAD collides with live chain-id uses in open pull requests. Owner set: (none).

No user-facing behavior change.

path removed (file / symbol / class) why dead
shared/constants/swaps.ts MAX_ALLOWED_SLIPPAGE unused export
shared/constants/swaps.ts SEPOLIA_SWAPS_TOKEN_OBJECT unused export
shared/constants/swaps.ts DEFAULT_ERC20_APPROVE_GAS unused export

Docs/comments updated: none

Checks that passed: yarn lint:tsc, eslint on the touched file, yarn test:unit --coverage=false including shared/lib/swaps.utils.test.ts, shared/lib/swaps-utils.test.ts, and ui/pages/swaps/swaps.util.test.js (31 suites, 449 tests, 5 snapshots passed, no snapshot updates). No stylesheets changed.

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A — no UI change

After

N/A — no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Deletes unreachable constants with no remaining imports; swaps tests and typecheck were run per the PR description.

Overview
Removes three unused exports from shared/constants/swaps.ts as dead-code cleanup (aligned with the mobile extension counterpart).

Removed: MAX_ALLOWED_SLIPPAGE, SEPOLIA_SWAPS_TOKEN_OBJECT, and DEFAULT_ERC20_APPROVE_GAS. Sepolia swaps default token mapping is unchanged—it still uses GOERLI_SWAPS_TOKEN_OBJECT in SWAPS_CHAINID_DEFAULT_TOKEN_MAP.

No runtime or UI behavior change; slippage limits and approve gas continue to be handled elsewhere in the swaps stack.

Reviewed by Cursor Bugbot for commit cf9ded0. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@github-actions github-actions Bot added the size-S label Nov 3, 2026
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension and removed size-S labels Nov 3, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [341f5d6]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41612004588 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +55%
  • ↑ confirmTx/longTaskMaxDuration: +85%
  • ↑ confirmTx/tbt: +97%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +81%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +94%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +79%
  • ↑ bridgeUserActions/tbt: +109%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -39%
  • ↓ loadNewAccount/fcp: -60%
  • ↑ loadNewAccount/lcp: +1076%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -67%
  • ↑ confirmTx/lcp: +1095%
  • ↑ bridgeUserActions/bridge_load_page: +281%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +83%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +35%
  • ↑ bridgeUserActions/inp: +38%
  • ↑ bridgeUserActions/lcp: +1104%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +112%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -33%
  • ↓ startupStandardHome/load: -29%
  • ↓ startupStandardHome/domContentLoaded: -30%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↓ startupStandardHome/backgroundConnect: -23%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -29%
  • ↑ startupStandardHome/setupStore: +45%
  • ↑ startupStandardHome/fcp: +26%
  • ↓ startupStandardHome/lcp: -26%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +34%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +12%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +114 Bytes 0.00%
✅ ui 19.33 MiB +49 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -16 Bytes 0.00%
✅ content scripts 3.23 MiB -16 Bytes 0.00%
✅ unzipped 79.89 MiB +136 Bytes 0.00%
✅ zip 24.07 MiB +36 Bytes 0.00%

@vinnyhoward vinnyhoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No correctness problems found

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [833d903]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41712438051 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/lcp: +17%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +58%
  • ↑ confirmTx/longTaskMaxDuration: +77%
  • ↑ confirmTx/tbt: +95%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/lcp: +21%
  • ↑ bridgeUserActions/bridge_load_page: +76%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +93%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +87%
  • ↑ bridgeUserActions/longTaskMaxDuration: +14%
  • ↑ bridgeUserActions/tbt: +54%
  • ↑ bridgeUserActions/total: +19%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +124%
  • ↓ loadNewAccount/fcp: -66%
  • ↑ loadNewAccount/lcp: +860%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +98%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +872%
  • ↑ bridgeUserActions/bridge_load_page: +138%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +27%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +18%
  • ↓ bridgeUserActions/fcp: -74%
  • ↑ bridgeUserActions/lcp: +978%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/INP: p75 240ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +12%
  • ↑ startupStandardHome/domContentLoaded: +12%
  • ↑ startupStandardHome/domInteractive: +26%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/longTaskMaxDuration: +10%
  • ↑ startupStandardHome/tbt: +13%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -39%
  • ↓ startupStandardHome/load: -34%
  • ↓ startupStandardHome/domContentLoaded: -36%
  • ↓ startupStandardHome/domInteractive: -53%
  • ↓ startupStandardHome/backgroundConnect: -32%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -34%
  • ↑ startupStandardHome/setupStore: +19%
  • ↓ startupStandardHome/fcp: -46%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +35%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +27%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +27%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +49%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +114 Bytes 0.00%
✅ ui 19.33 MiB +49 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -16 Bytes 0.00%
✅ content scripts 3.23 MiB -16 Bytes 0.00%
✅ unzipped 79.9 MiB +136 Bytes 0.00%
✅ zip 24.07 MiB +40 Bytes 0.00%

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@georgewrmarshall georgewrmarshall added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
@georgewrmarshall
georgewrmarshall removed this pull request from the merge queue due to a manual request Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cf9ded0]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41727813714 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +12%
  • ↑ loadNewAccount/lcp: +16%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +60%
  • ↑ confirmTx/longTaskMaxDuration: +72%
  • ↑ confirmTx/tbt: +88%
  • ↑ confirmTx/cls: +11%
  • ↑ bridgeUserActions/bridge_load_page: +112%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↑ bridgeUserActions/longTaskCount: +127%
  • ↑ bridgeUserActions/longTaskTotalDuration: +108%
  • ↑ bridgeUserActions/tbt: +89%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +19%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -54%
  • ↑ loadNewAccount/lcp: +1076%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -65%
  • ↑ confirmTx/lcp: +1083%
  • ↑ bridgeUserActions/bridge_load_page: +208%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +53%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +21%
  • ↑ bridgeUserActions/inp: +135%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +1032%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/INP: p75 256ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +127%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↓ startupStandardHome/domInteractive: -39%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +100%
  • ↓ startupStandardHome/fcp: -31%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -28%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -24%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -20%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -40%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +46%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +22%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -60%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -23%
  • ↓ onboardingNewWallet/tbt: -78%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -47%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +114 Bytes 0.00%
✅ ui 19.33 MiB +49 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -16 Bytes 0.00%
✅ content scripts 3.23 MiB -16 Bytes 0.00%
✅ unzipped 79.9 MiB +136 Bytes 0.00%
✅ zip 24.07 MiB +39 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 6eab056 Nov 3, 2026
140 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-swaps-constants-20261103-a4dd branch November 3, 2026 23:30
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants