Repository navigation
feat: remove bottom nav feature flag and have it show by default - #47206
Conversation
Co-authored-by: Amélie <ameliejyc@users.noreply.github.com>
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (7 files, +28 -406)
✅ @MetaMask/confirmations (6 files, +29 -69)
👨🔧 @MetaMask/core-extension-ux (10 files, +33 -427)
👨🔧 @MetaMask/perps (8 files, +8 -86)
🧪 @MetaMask/qa (9 files, +50 -56)
🔄 @MetaMask/swaps-engineers (5 files, +15 -157)
|
Co-authored-by: Amélie <ameliejyc@users.noreply.github.com>
Co-authored-by: Amélie <ameliejyc@users.noreply.github.com>
Builds ready [c7085a5]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Co-authored-by: Amélie <ameliejyc@users.noreply.github.com>
Builds ready [d8989a8]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [4e78535]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Builds ready [35005c5]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Builds ready [3d6fbd3]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
Builds ready [1999aba]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
This reverts commit 1999aba.
Builds ready [3e5c143]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
…r than the account overview activity tab
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b4cbfd5. Configure here.
Builds ready [b4cbfd5]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [1080d13]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
| * Closes a transaction toast when it is covering the token list. | ||
| * No-op when the toast has already disappeared. | ||
| */ | ||
| private async dismissTransactionToastIfPresent(): Promise<void> { |
There was a problem hiding this comment.
that's quite annoying. I have a PR which will disable toast notifications in all specs (Except 1 for testing the toasts)
Feel free to review: #47574 I'll ping your team in slack as well 🙏



Description
Removes
coreExtensionUxCeux1141AbtestBottomNavA/B experiment and makes its treatment behavior the default. This has quite a lot of changes, mostly in e2e scope as we no longer have to account for whether bottom nav or account overview tabs are available for Perps and Activity - it will only use bottom nav by default to navigate to these now.Some changes relevant for the associated teams:
perpsBadgeSeencode has some local state I believe that can probably be removed now (assuming it was only used on the account overview tab bar)Changelog
CHANGELOG entry: Make the bottom navigation available by default and remove the feature flag
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
[screenshots/recordings]
After
Bottom nav shows on Home, Perps, Money and Activity by default.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Broad navigation and home UX changes affect how users reach Activity/Perps and post-tx badge behavior; notification vs fullscreen redirect logic adds a small regression surface in confirmations.
Reviewed by Cursor Bugbot for commit 1080d13. Bugbot is set up for automated code reviews on this repo. Configure here.