Skip to content

chore(hooks): remove unused transaction lifecycle helpers - #47478

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-transaction-lifecycle-20261029-ba1a
Nov 2, 2026
Merged

georgewrmarshall merged 1 commit into
mainfrom
cursor/remove-dead-code-transaction-lifecycle-20261029-ba1a

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes three unowned files that nothing in the extension imports. Owner set: (none).

path removed (file / symbol / class) why dead
ui/helpers/utils/transaction-display.ts file; useTransactionDisplay zero refs
ui/hooks/useBridgeHistoryLifecycle.ts file; useBridgeHistoryLifecycle zero refs
ui/hooks/useNonEvmTransactionLifecycle.ts file; useNonEvmTransactionLifecycle zero refs

No user-facing behavior change.

Each file was added on 2026-04-01 and has no colocated test, story, or README. Whole-word search found no imports, string references, or dynamic imports. No open pull request edits these paths. yarn lint:tsc passed. yarn test:unit for these paths found no tests (--passWithNoTests, no snapshot updates). ESLint does not apply: the files were deleted and no surviving file was edited.

Changelog

CHANGELOG entry: null

Related issues

Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)

Manual testing steps

N/A — deletes unreachable code. There is no user-facing behavior to click through.

Screenshots/Recordings

N/A — no UI change

Before

N/A — no UI change

After

N/A — no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Deletes unreachable code with no imports or runtime callers; no functional or security impact.

Overview
Removes three unreferenced UI modules that were never wired into the extension: useTransactionDisplay (i18n titles for pending/success/failed transaction states), useBridgeHistoryLifecycle (bridge history diffing with pending/success/failure callbacks), and useNonEvmTransactionLifecycle (non-EVM tx list diffing with recency filtering and success/failure handlers).

This is dead-code cleanup only—no surviving files are edited and there is no user-facing behavior change.

Reviewed by Cursor Bugbot for commit a975912. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Extension label Oct 29, 2026
@georgewrmarshall georgewrmarshall removed the size-M label Oct 29, 2026 — with Cursor
@georgewrmarshall georgewrmarshall self-assigned this Oct 29, 2026
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a975912]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40851553321 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/lcp: +14%
  • ↑ confirmTx/longTaskTotalDuration: +60%
  • ↑ confirmTx/longTaskMaxDuration: +95%
  • ↑ confirmTx/tbt: +106%
  • ↓ confirmTx/inp: -17%
  • ↑ bridgeUserActions/bridge_load_page: +126%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +116%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +110%
  • ↑ bridgeUserActions/longTaskMaxDuration: +37%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ bridgeUserActions/lcp: +11%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1274%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -58%
  • ↑ confirmTx/lcp: +1357%
  • ↑ bridgeUserActions/bridge_load_page: +241%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +118%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +36%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/lcp: +1163%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +15%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +195%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/domInteractive: -26%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +153%
  • ↓ startupStandardHome/fcp: -22%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +31%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +20%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.41 MiB +130 Bytes 0.00%
✅ ui 19.26 MiB +65 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.99 MiB +200 Bytes 0.00%
✅ zip 24.11 MiB +38 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@georgewrmarshall
georgewrmarshall requested a review from a team October 29, 2026 18:07
@georgewrmarshall
georgewrmarshall requested review from a team and removed request for a team November 2, 2026 17:50
@georgewrmarshall
georgewrmarshall added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 1c6f885 Nov 2, 2026
154 checks passed
@georgewrmarshall
georgewrmarshall deleted the cursor/remove-dead-code-transaction-lifecycle-20261029-ba1a branch November 2, 2026 22:31
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
pr-comment — a975912b Deployed Oct 29, 2026 by georgewrmarshall via Publish prerelease / Publish prerelease #171832
segment-schema — a975912b Deployed Oct 29, 2026 by georgewrmarshall via propose #1538
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants