Repository navigation
chore(hooks): remove unused transaction lifecycle helpers - #47478
Merged
georgewrmarshall merged 1 commit intoNov 2, 2026
Merged
georgewrmarshall merged 1 commit into
georgewrmarshall merged 1 commit into
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
October 29, 2026 09:41 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
October 29, 2026 09:57 — with
GitHub Actions
Inactive
Contributor
Builds ready [a975912]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
amandaye0h
approved these changes
Nov 2, 2026
vinnyhoward
approved these changes
Nov 2, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-transaction-lifecycle-20261029-ba1a
branch
November 2, 2026 22:31
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes three unowned files that nothing in the extension imports. Owner set:
(none).ui/helpers/utils/transaction-display.tsuseTransactionDisplayui/hooks/useBridgeHistoryLifecycle.tsuseBridgeHistoryLifecycleui/hooks/useNonEvmTransactionLifecycle.tsuseNonEvmTransactionLifecycleNo user-facing behavior change.
Each file was added on 2026-04-01 and has no colocated test, story, or README. Whole-word search found no imports, string references, or dynamic imports. No open pull request edits these paths.
yarn lint:tscpassed.yarn test:unitfor these paths found no tests (--passWithNoTests, no snapshot updates). ESLint does not apply: the files were deleted and no surviving file was edited.Changelog
CHANGELOG entry: null
Related issues
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
N/A — no UI change
After
N/A — no UI change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unreachable code with no imports or runtime callers; no functional or security impact.
Overview
Removes three unreferenced UI modules that were never wired into the extension:
useTransactionDisplay(i18n titles for pending/success/failed transaction states),useBridgeHistoryLifecycle(bridge history diffing with pending/success/failure callbacks), anduseNonEvmTransactionLifecycle(non-EVM tx list diffing with recency filtering and success/failure handlers).This is dead-code cleanup only—no surviving files are edited and there is no user-facing behavior change.
Reviewed by Cursor Bugbot for commit a975912. Bugbot is set up for automated code reviews on this repo. Configure here.