Skip to content

fix(networks): leave a non-EVM filter when basic functionality is off - #47494

Merged
NidhiKJha merged 1 commit into
mainfrom
fix/non-evm-filter-when-basic-functionality-off
Nov 2, 2026
Merged

NidhiKJha merged 1 commit into
mainfrom
fix/non-evm-filter-when-basic-functionality-off

Conversation

@NidhiKJha

@NidhiKJha NidhiKJha commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Description

Turning Basic Functionality off hides non-EVM networks from the home network picker, but the selected filter stayed on that network. The picker then showed only EVM networks while the button still named the hidden non-EVM network.

When Basic Functionality is off and the enabled filter is only non-EVM networks, the home network control bar now selects all popular networks and activates Ethereum, or the first configured EVM network if mainnet is not available. An existing EVM selection, including All networks, is left unchanged.

Changelog

CHANGELOG entry: Fixed the home network filter staying on a non-EVM network after Basic Functionality is turned off

Related issues

Fixes: #47341

Manual testing steps

  1. Run the extension and open the home screen.
  2. Open the network filter and select a non-EVM network, such as Solana.
  3. Open Settings, then Privacy
  4. Turn off Basic Functionality and confirm.
  5. Close Settings and return to the home screen.
  6. Confirm the network filter no longer shows the non-EVM network as selected.
  7. Open the network filter and confirm only EVM networks are listed, and the selection matches that list.

Screenshots/Recordings

Before

After

Screen.Recording.2026-10-29.at.8.28.46.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Localized UI state correction on the home asset control bar with a focused unit test; no auth or payment paths touched.

Reviewed by Cursor Bugbot for commit f4d3b7d. Bugbot is set up for automated code reviews on this repo. Configure here.

Turning Basic Functionality off hides non-EVM networks from the home picker, but the selected filter stayed on that network. Switch to all popular networks and a default EVM network so the selection matches the list.

Co-authored-by: Cursor <cursoragent@cursor.com>
@NidhiKJha NidhiKJha added type-bug Something isn't working team-core-extension-ux Core Extension UX team labels Oct 29, 2026
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (2 files, +60 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 asset-list/
            • 📁 asset-list-control-bar/
              • 📄 asset-list-control-bar.test.tsx +27 -0
              • 📄 asset-list-control-bar.tsx +33 -1

@NidhiKJha
NidhiKJha marked this pull request as ready for review October 29, 2026 14:57
@NidhiKJha
NidhiKJha requested a review from a team as a code owner October 29, 2026 14:57
@NidhiKJha
NidhiKJha deployed to segment-schema October 29, 2026 14:57 — with GitHub Actions Active
@NidhiKJha
NidhiKJha enabled auto-merge October 29, 2026 14:59
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f4d3b7d]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40894980766 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ confirmTx/longTaskTotalDuration: +60%
  • ↑ confirmTx/longTaskMaxDuration: +93%
  • ↑ confirmTx/tbt: +105%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +107%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +136%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +139%
  • ↑ bridgeUserActions/longTaskMaxDuration: +59%
  • ↑ bridgeUserActions/tbt: +291%
  • ↑ bridgeUserActions/total: +24%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ loadNewAccount/load_new_account: +424%
  • ↑ loadNewAccount/total: +424%
  • ↓ loadNewAccount/inp: -24%
  • ↑ loadNewAccount/fcp: +18%
  • ↑ loadNewAccount/lcp: +1275%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +18%
  • ↑ confirmTx/lcp: +1272%
  • ↑ bridgeUserActions/bridge_load_page: +273%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↑ bridgeUserActions/bridge_search_token: +22%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +78%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +1195%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +158%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +12%
  • ↑ startupStandardHome/lcp: +11%
  • ↑ startupStandardHome/domInteractive: +16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↑ startupStandardHome/fcp: +13%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +40%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +24%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -76%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -44%
  • ↓ onboardingNewWallet/tbt: -90%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -53%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.25 MiB -168.68 KiB -1.07%
🚨 ui 19.27 MiB +12.31 KiB +0.06%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -5.04 KiB -0.11%
✅ content scripts 3.22 MiB -10.15 KiB -0.31%
✅ unzipped 79.82 MiB -171.78 KiB -0.21%
✅ zip 24.05 MiB -57.1 KiB -0.23%

@sonarqubecloud

Copy link
Copy Markdown

@NidhiKJha
NidhiKJha added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual validation: ✅ succeeded

metamask-extension#47494 · 2 PASS / 0 FAIL / 0 BLOCKED · Langfuse trace

PASS: both planned UI cases passed, and no funded actions were needed.

Test results

Test case Status
non-evm-filter-fallback ✅ PASS
evm-filter-preserved ✅ PASS

Evidence

non-evm-filter-fallback ✅ PASS · 1 files

Home control bar showing Ethereum after Basic Functionality was turned off.

evm-filter-preserved ✅ PASS · 1 files

Home control bar showing Ethereum after Basic Functionality was turned off.

Full report · execution-result.json

Open in Web View Automation 

Sent by Cursor Automation: MetaMask/agent-orchestration

@NidhiKJha
NidhiKJha added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 0df0258 Nov 2, 2026
168 checks passed
@NidhiKJha
NidhiKJha deleted the fix/non-evm-filter-when-basic-functionality-off branch November 2, 2026 13:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was successfully deployed

1 active and 1 inactive deployments
pr-comment — f4d3b7db Deployed Oct 29, 2026 by NidhiKJha via Publish prerelease / Publish prerelease #171951
segment-schema — f4d3b7db Deployed Oct 29, 2026 by NidhiKJha via propose #1740
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-core-extension-ux Core Extension UX team type-bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Basic Functionality - Non EVM network keeps being selected after turning off the basic functionality setting

5 participants