Skip to content

chore(cashtag): exact match symbol or ticker cp-13.56.0 - #47602

Merged
n3ps merged 4 commits into
mainfrom
n3ps/ticker-exact-match
Nov 4, 2026
Merged

n3ps merged 4 commits into
mainfrom
n3ps/ticker-exact-match

Conversation

@n3ps

@n3ps n3ps commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Update ticker resolution to exact symbol or rwa ticker

Changelog

CHANGELOG entry: cashtag: exact symbol/ticker match

Related issues

Fixes:

Manual testing steps

  1. Open x.com
  2. Search for $TICKERs

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes user-visible cashtag resolution on external sites and depends on RWA fields from the token search API; wrong filtering could show the wrong asset or none at all.

Overview
Cashtag ticker lookup no longer treats search hits as prefix matches (e.g. $DOG won’t pick DOGE just because it has higher market cap). resolveTicker now keeps only assets whose token symbol or rwaData.ticker equals the trimmed, uppercased query, then still picks the primary hit by market cap among those exact matches.

Token search requests add includeRwaData=true so stock/RWA-backed tokens can match on their real-world ticker, not only the on-chain symbol. Tests were updated for the new matching rules and cover exact-symbol vs prefix cases and RWA ticker resolution.

Reviewed by Cursor Bugbot for commit 5a9ae03. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 3, 2026
@metamask-ci metamask-ci Bot added the team-core-extension-ux Core Extension UX team label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7f0b9b8]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 4 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41734281332 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +50%
  • ↑ confirmTx/longTaskMaxDuration: +68%
  • ↑ confirmTx/tbt: +85%
  • ↑ confirmTx/lcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +112%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +181%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +102%
  • ↑ bridgeUserActions/longTaskMaxDuration: +29%
  • ↑ bridgeUserActions/tbt: +200%
  • ↑ bridgeUserActions/total: +32%
  • ↑ bridgeUserActions/inp: +25%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1268%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +1356%
  • ↑ bridgeUserActions/bridge_load_page: +327%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +137%
  • ↑ bridgeUserActions/bridge_search_token: +24%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +65%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -28%
  • ↑ bridgeUserActions/lcp: +1338%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +16%
  • ↑ startupStandardHome/load: +12%
  • ↑ startupStandardHome/domContentLoaded: +12%
  • ↑ startupStandardHome/domInteractive: +27%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskMaxDuration: +11%
  • ↑ startupStandardHome/tbt: +15%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/domInteractive: +34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +149%
  • ↑ startupStandardHome/inp: +150%
  • ↑ startupStandardHome/fcp: +25%
  • ↑ startupStandardHome/lcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +33%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +35%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +27%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +25%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +165 Bytes 0.00%
✅ ui 19.33 MiB +65 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.9 MiB +235 Bytes 0.00%
✅ zip 24.07 MiB +60 Bytes 0.00%

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit baeeead. Configure here.

Comment thread app/scripts/cashtag/lib/data.ts Resolved
@n3ps n3ps changed the title chore(cashtag): exact match symbol or rwa ticker chore(cashtag): exact match symbol or rwa ticker cp-13.56-0 Nov 3, 2026
Include includeRwaData on cashtag symbol search so exact RWA ticker
matching can resolve hits from the API.

Co-authored-by: francis.nepomuceno <francis.nepomuceno@consensys.net>
@cursor
cursor Bot had a problem deploying to segment-schema November 3, 2026 23:39 Failure
@n3ps
n3ps requested a review from a team November 3, 2026 23:51
query: symbol,
first: '25',
includeMarketData: 'true',
includeRwaData: 'true',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point of interest 1

const symbolMatches = matches.filter(
(match) =>
match.symbol.trim().toUpperCase() === ticker ||
match.rwaData?.ticker?.trim().toUpperCase() === ticker,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point of interest 2

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5a9ae03]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41740847656 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -15%
  • ↓ loadNewAccount/lcp: -19%
  • ↑ loadNewAccount/cls: +278%
  • ↑ confirmTx/longTaskTotalDuration: +25%
  • ↑ confirmTx/longTaskMaxDuration: +40%
  • ↑ confirmTx/tbt: +44%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -15%
  • ↓ confirmTx/lcp: -14%
  • ↑ bridgeUserActions/bridge_load_page: +28%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +11%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +42%
  • ↑ bridgeUserActions/tbt: +54%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -14%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -38%
  • ↑ loadNewAccount/lcp: +1233%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +1306%
  • ↑ bridgeUserActions/bridge_load_page: +170%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↑ bridgeUserActions/bridge_search_token: +17%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +40%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -36%
  • ↑ bridgeUserActions/lcp: +1263%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/setupStore: +95%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/lcp: +14%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -31%
  • ↓ startupStandardHome/domContentLoaded: -33%
  • ↓ startupStandardHome/domInteractive: -53%
  • ↓ startupStandardHome/backgroundConnect: -24%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↑ startupStandardHome/setupStore: +35%
  • ↓ startupStandardHome/fcp: -30%
  • ↓ startupStandardHome/lcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -22%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -14%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -13%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -24%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +16%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +17%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +171 Bytes 0.00%
✅ ui 19.33 MiB +49 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -16 Bytes 0.00%
✅ content scripts 3.23 MiB -16 Bytes 0.00%
✅ unzipped 79.9 MiB +193 Bytes 0.00%
✅ zip 24.07 MiB +61 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@n3ps n3ps changed the title chore(cashtag): exact match symbol or rwa ticker cp-13.56-0 chore(cashtag): exact match symbol or ticker cp-13.56-0 Nov 4, 2026
@n3ps
n3ps added this pull request to the merge queue Nov 4, 2026
@n3ps n3ps added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 4, 2026
Merged via the queue into main with commit 2338170 Nov 4, 2026
149 of 150 checks passed
@n3ps
n3ps deleted the n3ps/ticker-exact-match branch November 4, 2026 04:59
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Nov 4, 2026
@n3ps n3ps changed the title chore(cashtag): exact match symbol or ticker cp-13.56-0 chore(cashtag): exact match symbol or ticker cp-13.56.0 Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch had an error being deployed

1 failed and 1 inactive deployments
pr-comment — 5a9ae03c Deployed Nov 3, 2026 by cursor[bot] via Publish prerelease / Publish prerelease #172552
segment-schema — 5a9ae03c Deployed Nov 3, 2026 by cursor[bot] via propose #2913
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants