Repository navigation
chore(assets-controller): bump assets controller to 20.0.2 - #47489
Conversation
Align bridge, assets-controllers, and transaction-pay so the extension resolves a single @metamask/assets-controller 20.0.1. Pass removeNft into NftDetectionController for assets-controllers 113, and keep price fixtures on checksummed asset ids. Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Merge main and move @metamask/assets-controller to 20.0.2, with bridge-controller 83.1.2, assets-controllers 113.0.0, and transaction-pay-controller 30.3.1 so the lockfile resolves a single copy. Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
Builds ready [a6f62c9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Builds ready [ed5d7d8] [reused from a6f62c9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
Not sure how pipeline passes if I assets-controllers have breaking changes here |
|
@cursor READ AND FOLLOW THESE MEMORY FILES: please fix the merge conflicts. |
|
Merge conflicts with Conflicts were only in
UPDATE_NEEDED |
Keep @metamask/assets-controller at 20.0.2, bridge-controller at 83.1.2, and transaction-pay-controller at 30.3.1 while taking the rest of main. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
20.0.2 shares one assets-controllers package, so the nested @metamask/assets-controller>@metamask/assets-controllers policy no longer matches. Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (8 files, +8 -80)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Builds ready [da12433]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 6 warn · 🔴 3 fail)
Bundle Size Diffs [🚀 Bundle size reduced!]
|
|
bergarces
left a comment
There was a problem hiding this comment.
Policy changes look ok
|
No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut. |





Description
Bumps
@metamask/assets-controllerfrom^20.0.0to^20.0.2.20.0.2(core#11078) keeps the 20.0.0 API. Balance batches use hand-rolled Multicall3aggregate3codecs, and the Ethers codecs stay in place for a byte-identical comparison.20.0.1is included on the way up and moves the package onto@metamask/assets-controllers^113.0.0,@metamask/transaction-controller^72.3.0, and@metamask/permission-controller^14.1.0.Companion ranges move so Yarn resolves a single
@metamask/assets-controller@20.0.2:@metamask/assets-controllers^112.0.2→^113.0.0.NftDetectionControllernow requiresremoveNft, so initialization forwardsnftController().removeNft.@metamask/bridge-controller^83.1.1→^83.1.2@metamask/transaction-pay-controller^30.3.0→^30.3.1LavaMoat policies pick up the permission-controller dedupe (
immeris now@metamask/permission-controller>immer). The 20.0.0 call-site migration is already on main.Changelog
CHANGELOG entry: null
Related issues
Refs: N/A — dependency bump with no linked issue. Follow-up to #47400 and core#11078.
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches asset balance/NFT-related controller packages and LavaMoat sandbox permissions; behavior changes live in upstream packages rather than extension code in this diff.
Reviewed by Cursor Bugbot for commit da12433. Bugbot is set up for automated code reviews on this repo. Configure here.