Skip to content

chore(assets-controller): bump assets controller to 20.0.2 - #47489

Merged
Prithpal-Sooriya merged 6 commits into
mainfrom
cursor/bump-assets-controller-2bbc
Nov 2, 2026
Merged

Prithpal-Sooriya merged 6 commits into
mainfrom
cursor/bump-assets-controller-2bbc

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/assets-controller from ^20.0.0 to ^20.0.2.

20.0.2 (core#11078) keeps the 20.0.0 API. Balance batches use hand-rolled Multicall3 aggregate3 codecs, and the Ethers codecs stay in place for a byte-identical comparison. 20.0.1 is included on the way up and moves the package onto @metamask/assets-controllers ^113.0.0, @metamask/transaction-controller ^72.3.0, and @metamask/permission-controller ^14.1.0.

Companion ranges move so Yarn resolves a single @metamask/assets-controller@20.0.2:

  • @metamask/assets-controllers ^112.0.2 → ^113.0.0. NftDetectionController now requires removeNft, so initialization forwards nftController().removeNft.
  • @metamask/bridge-controller ^83.1.1 → ^83.1.2
  • @metamask/transaction-pay-controller ^30.3.0 → ^30.3.1

LavaMoat policies pick up the permission-controller dedupe (immer is now @metamask/permission-controller>immer). The 20.0.0 call-site migration is already on main.

Changelog

CHANGELOG entry: null

Related issues

Refs: N/A — dependency bump with no linked issue. Follow-up to #47400 and core#11078.

Manual testing steps

  1. Build and load this branch, then unlock a wallet that holds tokens on Ethereum Mainnet.
  2. Open the home asset list and confirm symbols, balances, and fiat prices still appear.
  3. Confirm NFT detection still starts when the preference is enabled.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Medium Risk
Touches asset balance/NFT-related controller packages and LavaMoat sandbox permissions; behavior changes live in upstream packages rather than extension code in this diff.

Reviewed by Cursor Bugbot for commit da12433. Bugbot is set up for automated code reviews on this repo. Configure here.

cursoragent and others added 3 commits October 29, 2026 08:12
Align bridge, assets-controllers, and transaction-pay so the extension resolves a single @metamask/assets-controller 20.0.1. Pass removeNft into NftDetectionController for assets-controllers 113, and keep price fixtures on checksummed asset ids.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Merge main and move @metamask/assets-controller to 20.0.2, with bridge-controller 83.1.2, assets-controllers 113.0.0, and transaction-pay-controller 30.3.1 so the lockfile resolves a single copy.

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@socket-security

socket-security Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​assets-controller@​20.0.0 ⏵ 20.0.29810080 +1100 +1100
Updated@​metamask/​bridge-controller@​83.1.1 ⏵ 83.1.29810080 +1100 +1100
Updated@​metamask/​transaction-pay-controller@​30.3.0 ⏵ 30.3.19910081100 +1100

View full report

@socket-security

socket-security Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Priority Alert  (click "▶" to expand/collapse) Action
Low priority
Potential code anomaly (AI signal): npm @metamask/transaction-pay-controller is 96.0% likely to have a medium risk anomaly

Notes: This code implements a server-quote transaction flow and is not clearly malware. It signs quote-provided typed data and sends signatures to a quote-provided endpoint, and submits quote-derived transactions with requireApproval:false; a malicious or compromised quote source could therefore cause unauthorized signing or transaction submission. No fixed domain, URL, IP, credential target, or environment-variable access is present in the fragment. Severity is medium to high depending on validation and trust controls outside this file.

Confidence: 0.96

Severity: 0.63

From: package.json → npm/@metamask/transaction-pay-controller@30.3.1

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/transaction-pay-controller@30.3.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a6f62c9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40880269598 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +19%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +91%
  • ↑ confirmTx/longTaskMaxDuration: +111%
  • ↑ confirmTx/tbt: +135%
  • ↑ confirmTx/fcp: +15%
  • ↑ confirmTx/lcp: +30%
  • ↑ bridgeUserActions/bridge_load_page: +120%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +133%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +144%
  • ↑ bridgeUserActions/longTaskMaxDuration: +19%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/total: +23%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -47%
  • ↓ loadNewAccount/fcp: -58%
  • ↑ loadNewAccount/lcp: +1044%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -45%
  • ↑ confirmTx/lcp: +1064%
  • ↑ bridgeUserActions/bridge_load_page: +218%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +60%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -49%
  • ↑ bridgeUserActions/lcp: +1049%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↑ startupStandardHome/tbt: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +15%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +49%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +26%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.43 MiB +13.55 KiB +0.09%
🚨 ui 19.26 MiB +2.37 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +204 Bytes 0.00%
✅ content scripts 3.24 MiB +436 Bytes +0.01%
🚨 unzipped 80 MiB +17.26 KiB +0.02%
🚨 zip 24.11 MiB +5.48 KiB +0.02%

Co-authored-by: prithpal.sooriya <prithpal.sooriya@consensys.net>
@cursor
cursor Bot deployed to segment-schema October 29, 2026 13:44 Active
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ed5d7d8] [reused from a6f62c9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40884727452 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +15%
  • ↑ loadNewAccount/lcp: +19%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +91%
  • ↑ confirmTx/longTaskMaxDuration: +111%
  • ↑ confirmTx/tbt: +135%
  • ↑ confirmTx/fcp: +15%
  • ↑ confirmTx/lcp: +30%
  • ↑ bridgeUserActions/bridge_load_page: +120%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +133%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +144%
  • ↑ bridgeUserActions/longTaskMaxDuration: +19%
  • ↑ bridgeUserActions/tbt: +205%
  • ↑ bridgeUserActions/total: +23%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -47%
  • ↓ loadNewAccount/fcp: -58%
  • ↑ loadNewAccount/lcp: +1044%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -45%
  • ↑ confirmTx/lcp: +1064%
  • ↑ bridgeUserActions/bridge_load_page: +218%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +60%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -49%
  • ↑ bridgeUserActions/lcp: +1049%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↑ startupStandardHome/tbt: +11%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +15%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +49%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +26%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +28%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.43 MiB +13.55 KiB +0.09%
🚨 ui 19.26 MiB +2.37 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +204 Bytes 0.00%
✅ content scripts 3.24 MiB +436 Bytes +0.01%
🚨 unzipped 80 MiB +17.26 KiB +0.02%
🚨 zip 24.11 MiB +5.48 KiB +0.02%

@juanmigdr

Copy link
Copy Markdown
Member

Not sure how pipeline passes if I assets-controllers have breaking changes here

@Prithpal-Sooriya

Copy link
Copy Markdown
Contributor Author

@cursor READ AND FOLLOW THESE MEMORY FILES:

please fix the merge conflicts.

@cursor

cursor Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Merge conflicts with main are resolved and pushed to cursor/bump-assets-controller-2bbc.

Conflicts were only in package.json and yarn.lock. I kept the bump this PR already locked, and took the rest of main:

  • @metamask/assets-controller stays at 20.0.2 (a fresh install would have floated the caret to 20.1.0)
  • @metamask/bridge-controller 83.1.2
  • @metamask/transaction-pay-controller 30.3.1
  • @metamask/permission-controller ^14.1.0 from main

#47436 is already on main, and the NFT detection init matches it, including removeNft. The NFT detection unit test passed, yarn lint:tsc passed, and yarn dedupe --check passed. LavaMoat policies stay at main's versions because the only policy change from this bump is already there.

UPDATE_NEEDED

Open in Web Open in Cursor 

Keep @metamask/assets-controller at 20.0.2, bridge-controller at 83.1.2,
and transaction-pay-controller at 30.3.1 while taking the rest of main.

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

20.0.2 shares one assets-controllers package, so the nested
@metamask/assets-controller>@metamask/assets-controllers policy no longer matches.

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +8 -80)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +1 -10
        • 📁 experimental/
          • 📄 policy.json +1 -10
        • 📁 flask/
          • 📄 policy.json +1 -10
        • 📁 main/
          • 📄 policy.json +1 -10
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +1 -10
        • 📁 experimental/
          • 📄 policy.json +1 -10
        • 📁 flask/
          • 📄 policy.json +1 -10
        • 📁 main/
          • 📄 policy.json +1 -10

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [da12433]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 6 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41437855323 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/lcp: +15%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +77%
  • ↑ confirmTx/longTaskMaxDuration: +106%
  • ↑ confirmTx/tbt: +120%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +118%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +107%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +154%
  • ↑ bridgeUserActions/longTaskMaxDuration: +54%
  • ↑ bridgeUserActions/tbt: +339%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ bridgeUserActions/lcp: +11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +19%
  • ↑ loadNewAccount/lcp: +1256%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +24%
  • ↑ confirmTx/lcp: +1403%
  • ↑ bridgeUserActions/bridge_load_page: +307%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +182%
  • ↑ bridgeUserActions/bridge_search_token: +21%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +73%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +21%
  • ↑ bridgeUserActions/lcp: +1259%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +12%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +195%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/fcp: +13%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +57%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +50%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +46%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +39%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +19%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +29%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +13%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -76%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -44%
  • ↓ onboardingNewWallet/tbt: -90%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -32%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -3.37 KiB -0.02%
✅ ui 19.28 MiB -3.43 KiB -0.02%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -262 Bytes -0.01%
✅ content scripts 3.23 MiB -524 Bytes -0.02%
✅ unzipped 79.84 MiB -7.56 KiB -0.01%
✅ zip 24.06 MiB -987 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@bergarces bergarces left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy changes look ok

@Prithpal-Sooriya
Prithpal-Sooriya added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 7aa394e Nov 2, 2026
140 checks passed
@Prithpal-Sooriya
Prithpal-Sooriya deleted the cursor/bump-assets-controller-2bbc branch November 2, 2026 17:29
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was successfully deployed

1 active (outdated) and 1 inactive deployments
pr-comment — da124337 Deployed Nov 2, 2026 by cursor[bot] via Publish prerelease / Publish prerelease #172153
segment-schema — ed5d7d8f Deployed Oct 29, 2026 by cursor[bot] via propose #1678
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants