Skip to content

feat: wire removeNft into NftDetectionController and pass explicit NFT source - #47436

Merged
juanmigdr merged 6 commits into
mainfrom
feat/nft-remove-spam-and-source
Oct 29, 2026
Merged

juanmigdr merged 6 commits into
mainfrom
feat/nft-remove-spam-and-source

Conversation

@juanmigdr

@juanmigdr juanmigdr commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Depends on @metamask/assets-controllers 113.0.0 (released), which contains core#8237 and core#11106. The dependency is bumped in this PR (package.json, yarn.lock, LavaMoat policies).

Adapts the extension to two changes in @metamask/assets-controllers:

  1. core#8237 (breaking): NftDetectionController requires a removeNft option. During detection, an NFT already in state that the API now returns as spam is removed (only if its stored source is detected or unset; custom and dapp are never auto-removed). It is not added to ignoredNfts, so it can come back if un-spammed.
  2. core#11106: each NFT records a source (custom, dapp, detected). addNft, addNfts and addNftVerifyOwnership default to Source.Custom when it is omitted, so any caller that is not a manual import must pass a source explicitly.

Changes:

  • nft-detection-controller-init.ts: pass removeNft (same lazy NftController getter as addNfts).
  • metamask-controller.js getApi: addNft and addNftVerifyOwnership are only called from the UI import flow, so they now pass Source.Custom explicitly (same as the default, now explicit).
  • metamask-controller.js _updateNFTOwnership: after a confirmed contract interaction, NFTs transferred to the selected account are added from the receipt logs. This is an automatic add (not a manual import), so it now passes Source.Detected. Without it, the default Custom would exempt these NFTs from spam removal.
  • Tests for the init wiring and the three call sites.

Behavior notes for reviewers:

  • The _updateNFTOwnership change is extension-specific (mobile has no equivalent). NFTs added there are now spam-removable, and the NftAdded event reports source: 'detected' instead of 'custom' for them.
  • There is no refresh-metadata addNft caller in the extension (mobile had two); ownership refreshes use checkAndUpdate*OwnershipStatus, which keeps the stored source.
  • If an NFT is auto-removed while its details page is open, the page redirects home (no NFT in state, no token).

Reference: metamask-mobile#38283.

Changelog

CHANGELOG entry: Spam NFTs already in your wallet are now removed automatically when detected

Related issues

Fixes: ASSETS-4116

Related: core#8237, core#11106, metamask-mobile#38283

Manual testing steps

  1. Run the extension with NFT detection enabled and an account that holds a detected NFT.
  2. Make the NFT API flag that NFT as spam (or use a test account with a known spam NFT already in state) and wait for the next detection run.
  3. Verify the NFT disappears from the NFTs tab.
  4. Import an NFT manually (NFTs tab > Import NFT) that the API flags as spam, and run detection again. Verify it is not removed.
  5. Open an NFT's details page, then trigger its removal as above. Verify you are returned to the home screen.
  6. Mint or buy an NFT through a dapp. Verify it appears after the transaction confirms.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes NFT add/remove behavior and spam handling in wallet state; wrong source tagging could remove user-imported NFTs or leave spam in place.

Overview
Bumps @metamask/assets-controllers to 113.0.0 (with LavaMoat policy updates) and adapts the extension to NFT spam auto-removal and per-NFT source tracking.

NftDetectionController init now passes removeNft into NftController, matching the new required option so detection can drop spam NFTs that were added as detected (not manual imports).

metamask-controller sets Source.Custom on UI addNft / addNftVerifyOwnership API paths, and Source.Detected when NFTs are added from transaction receipt logs in _updateNFTOwnership, so auto-added NFTs stay eligible for spam removal instead of inheriting the default custom exemption.

Tests cover init delegation and the three source call sites.

Reviewed by Cursor Bugbot for commit 475d84c. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +14 -3)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +14 -3

👨‍🔧 @MetaMask/extension-platform (1 files, +14 -3)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +14 -3

💎 @MetaMask/metamask-assets (2 files, +31 -0)
  • 📁 app/
    • 📁 scripts/
      • 📁 messenger-client-init/
        • 📁 assets/
          • 📄 nft-detection-controller-init.test.ts +30 -0
          • 📄 nft-detection-controller-init.ts +1 -0

📜 @MetaMask/policy-reviewers (8 files, +80 -8)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +10 -1
        • 📁 experimental/
          • 📄 policy.json +10 -1
        • 📁 flask/
          • 📄 policy.json +10 -1
        • 📁 main/
          • 📄 policy.json +10 -1
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +10 -1
        • 📁 experimental/
          • 📄 policy.json +10 -1
        • 📁 flask/
          • 📄 policy.json +10 -1
        • 📁 main/
          • 📄 policy.json +10 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6e2ec0e]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40669870423 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/fcp: -19%
  • ↓ loadNewAccount/lcp: -19%
  • ↑ confirmTx/longTaskTotalDuration: +22%
  • ↑ confirmTx/longTaskMaxDuration: +50%
  • ↑ confirmTx/tbt: +39%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -15%
  • ↑ bridgeUserActions/bridge_load_page: +24%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +76%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +46%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↓ bridgeUserActions/fcp: -12%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +16%
  • ↑ loadNewAccount/lcp: +1244%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +19%
  • ↑ confirmTx/lcp: +1281%
  • ↑ bridgeUserActions/bridge_load_page: +313%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +155%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +45%
  • ↑ bridgeUserActions/inp: +177%
  • ↓ bridgeUserActions/fcp: -41%
  • ↑ bridgeUserActions/lcp: +1275%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/INP: p75 288ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +11%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↑ startupStandardHome/firstPaint: +12%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/loadScripts: +10%
  • ↑ startupStandardHome/setupStore: +233%
  • ↑ startupStandardHome/tbt: +14%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/lcp: +17%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -20%
  • ↓ startupStandardHome/domContentLoaded: -20%
  • ↓ startupStandardHome/domInteractive: -50%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +88%
  • ↓ startupStandardHome/fcp: -37%
  • ↓ startupStandardHome/lcp: -18%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +37%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +37%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -24%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -26%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -26%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -38%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -64%
  • ↓ dappPageLoad/domContentLoaded: -16%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.4 MiB +906 Bytes +0.01%
🚨 ui 19.25 MiB +1.41 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +15 Bytes 0.00%
✅ content scripts 3.23 MiB +54 Bytes 0.00%
✅ zip 24.03 MiB -484 Bytes 0.00%

@socket-security

socket-security Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​assets-controllers@​113.0.09710091100100

View full report

@juanmigdr
juanmigdr marked this pull request as ready for review October 28, 2026 13:50
@metamask-ci

metamask-ci Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [105b7ef]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40700130405 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ confirmTx/longTaskTotalDuration: +69%
  • ↑ confirmTx/longTaskMaxDuration: +102%
  • ↑ confirmTx/tbt: +123%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +103%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↑ bridgeUserActions/longTaskCount: +122%
  • ↑ bridgeUserActions/longTaskTotalDuration: +138%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +186%
  • ↑ bridgeUserActions/total: +21%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -24%
  • ↑ loadNewAccount/fcp: +20%
  • ↑ loadNewAccount/lcp: +1314%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -28%
  • ↑ confirmTx/lcp: +1374%
  • ↑ bridgeUserActions/bridge_load_page: +336%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +151%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +50%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +22%
  • ↑ bridgeUserActions/lcp: +1305%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +10%
  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +180%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +153%
  • ↑ startupStandardHome/lcp: +11%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +42%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +39%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +37%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -20%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -41%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.42 MiB +17.16 KiB +0.11%
🚨 ui 19.26 MiB +5.86 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +466 Bytes +0.01%
✅ content scripts 3.23 MiB +960 Bytes +0.03%
🚨 zip 24.04 MiB +6.5 KiB +0.03%

…and-source

# Conflicts:
#	package.json
#	yarn.lock
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [2dd78f7]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40854952849 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +11%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +73%
  • ↑ confirmTx/longTaskMaxDuration: +90%
  • ↑ confirmTx/tbt: +115%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +106%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +45%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +150%
  • ↑ bridgeUserActions/longTaskMaxDuration: +68%
  • ↑ bridgeUserActions/tbt: +327%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +10%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/fcp: -59%
  • ↑ loadNewAccount/lcp: +1062%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -47%
  • ↓ confirmTx/fcp: -63%
  • ↑ confirmTx/lcp: +1038%
  • ↑ bridgeUserActions/bridge_load_page: +155%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +72%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +23%
  • ↓ bridgeUserActions/fcp: -63%
  • ↑ bridgeUserActions/lcp: +1069%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -24%
  • ↓ startupStandardHome/load: -27%
  • ↓ startupStandardHome/domContentLoaded: -27%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/firstPaint: -15%
  • ↓ startupStandardHome/backgroundConnect: -29%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -28%
  • ↑ startupStandardHome/setupStore: +74%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -35%
  • ↓ startupStandardHome/longTaskMaxDuration: -31%
  • ↓ startupStandardHome/tbt: -35%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -27%
  • ↓ startupStandardHome/lcp: -13%
  • ↓ startupStandardHome/domInteractive: -39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -35%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +56%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +49%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +40%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +36%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -16%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -17%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -36%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.43 MiB +17.16 KiB +0.11%
🚨 ui 19.27 MiB +5.86 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +466 Bytes +0.01%
✅ content scripts 3.24 MiB +960 Bytes +0.03%
🚨 unzipped 80.01 MiB +25.13 KiB +0.03%
🚨 zip 24.11 MiB +6.42 KiB +0.03%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [97ddfba]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40880981489 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +417%
  • ↑ loadNewAccount/total: +417%
  • ↓ loadNewAccount/inp: -17%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +68%
  • ↑ confirmTx/longTaskMaxDuration: +90%
  • ↑ confirmTx/tbt: +98%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +96%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +93%
  • ↑ bridgeUserActions/tbt: +152%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/inp: +38%
  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -22%
  • ↑ loadNewAccount/lcp: +868%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +82%
  • ↓ confirmTx/fcp: -68%
  • ↑ confirmTx/lcp: +949%
  • ↑ bridgeUserActions/bridge_load_page: +146%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +28%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -63%
  • ↑ bridgeUserActions/lcp: +968%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +11%
  • ↑ startupStandardHome/domInteractive: +20%
  • ↑ startupStandardHome/firstPaint: +16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +158%
  • ↑ startupStandardHome/tbt: +11%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/lcp: +16%
  • ↓ startupStandardHome/domInteractive: -37%
  • ↑ startupStandardHome/backgroundConnect: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +153%
  • ↓ startupStandardHome/fcp: -34%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -10%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +50%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +31%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +28%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +21%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -93%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -30%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.43 MiB +17.16 KiB +0.11%
🚨 ui 19.27 MiB +5.86 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +466 Bytes +0.01%
✅ content scripts 3.24 MiB +960 Bytes +0.03%
🚨 unzipped 80.01 MiB +25.13 KiB +0.03%
🚨 zip 24.11 MiB +6.42 KiB +0.03%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [475d84c]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40895711229 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ confirmTx/longTaskTotalDuration: +62%
  • ↑ confirmTx/longTaskMaxDuration: +96%
  • ↑ confirmTx/tbt: +106%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +12%
  • ↑ bridgeUserActions/bridge_load_page: +107%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +109%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +200%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/lcp: +18%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/fcp: -43%
  • ↑ loadNewAccount/lcp: +1310%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↓ confirmTx/fcp: -36%
  • ↑ confirmTx/lcp: +1328%
  • ↑ bridgeUserActions/bridge_load_page: +260%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +426%
  • ↑ bridgeUserActions/bridge_search_token: +19%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +116%
  • ↑ bridgeUserActions/inp: +46%
  • ↓ bridgeUserActions/fcp: -40%
  • ↑ bridgeUserActions/lcp: +1316%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↑ startupStandardHome/firstPaint: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +188%
  • ↑ startupStandardHome/tbt: +11%
  • ↑ startupStandardHome/lcp: +15%
  • ↓ startupStandardHome/uiStartup: -27%
  • ↓ startupStandardHome/load: -21%
  • ↓ startupStandardHome/domContentLoaded: -23%
  • ↓ startupStandardHome/domInteractive: -52%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +88%
  • ↓ startupStandardHome/fcp: -35%
  • ↓ startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +45%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +40%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +38%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +50%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +34%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +29%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -47%
  • ↓ onboardingNewWallet/tbt: -95%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -72%
  • ↓ dappPageLoad/domContentLoaded: -36%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.26 MiB +6.42 KiB +0.04%
🚨 ui 19.28 MiB +5.65 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +275 Bytes +0.01%
✅ content scripts 3.23 MiB +550 Bytes +0.02%
🚨 unzipped 79.84 MiB +12.88 KiB +0.02%
🚨 zip 24.06 MiB +2.69 KiB +0.01%

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcmire you're working on removing these IIRC

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see them removed!

@juanmigdr
juanmigdr added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit b135299 Oct 29, 2026
145 checks passed
@juanmigdr
juanmigdr deleted the feat/nft-remove-spam-and-source branch October 29, 2026 17:13
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2026
@metamaskbot metamaskbot added the release-13.56.0 Issue or pull request that will be included in release 13.56.0 label Nov 2, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
pr-comment — 475d84c9 Deployed Oct 29, 2026 by juanmigdr via Publish prerelease / Publish prerelease #171959
segment-schema — 475d84c9 Deployed Oct 29, 2026 by juanmigdr via propose #1736
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.56.0 Issue or pull request that will be included in release 13.56.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants