Skip to content

fix(confirmations): stop styling the nickname modal address as disabled - #47593

Merged
bschorchit merged 3 commits into
mainfrom
fix/nickname-modal-address-readonly-upstream
Nov 5, 2026
Merged

bschorchit merged 3 commits into
mainfrom
fix/nickname-modal-address-readonly-upstream

Conversation

@bschorchit

@bschorchit bschorchit commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Context

The nickname modal shows the address in a field that is marked disabled, so the text looks faded.

Problem

The address cannot be edited, but the faded styling makes the field look inactive next to the nickname field.

Solution

The address field stays the same component and stays read-only, so it cannot be edited and the copy button is unchanged. It is no longer marked disabled, so it uses the normal text color.

Changelog

CHANGELOG entry: Stopped styling the address field in the nickname modal as disabled.

Related issues

Fixes: CONF-2213

Related: CONF-2211

This pull request only changes the disabled styling of the address field in the nickname modal. It does not change the header, Send, the recipient picker, or confirmation rows, so it does not close CONF-2211.

Manual testing steps

  1. Load the extension and unlock the wallet.
  2. Start a send, or open a confirmation, for an address that has no saved nickname.
  3. Open the nickname modal for that address.
  4. Confirm the address field is not faded, matches the nickname field's text color, cannot be edited, and the copy button still copies the full address.
  5. Confirm the header address is unchanged from the current short form.

Screenshots/Recordings

Before

The address field is faded.

After

The address field uses the normal text color and stays on one line.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Cosmetic and prop change only in the petname modal; copy behavior and edit restrictions are unchanged.

Reviewed by Cursor Bugbot for commit d815ce9. Bugbot is set up for automated code reviews on this repo. Configure here.

bschorchit and others added 3 commits October 29, 2026 19:49
The address field is read-only, so marking it disabled only faded the
text. Keep it read-only without the disabled styling.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d815ce9]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41685666498 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +70%
  • ↑ confirmTx/longTaskMaxDuration: +73%
  • ↑ confirmTx/tbt: +91%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +15%
  • ↑ confirmTx/cls: +11%
  • ↑ bridgeUserActions/bridge_load_page: +81%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +47%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +51%
  • ↑ bridgeUserActions/tbt: +56%
  • ↑ bridgeUserActions/total: +10%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -48%
  • ↑ loadNewAccount/lcp: +1007%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -52%
  • ↑ confirmTx/lcp: +1047%
  • ↑ bridgeUserActions/bridge_load_page: +195%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +24%
  • ↑ bridgeUserActions/inp: +47%
  • ↓ bridgeUserActions/fcp: -63%
  • ↑ bridgeUserActions/lcp: +1011%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -13%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -15%
  • ↑ startupStandardHome/setupStore: +82%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -20%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -18%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -14%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/domInteractive: +33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +116%
  • ↑ startupStandardHome/fcp: +31%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/confirmSrpToPwForm: -11%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -39%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.26 MiB +137 Bytes 0.00%
🚨 ui 19.33 MiB +2.11 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.23 MiB +14 Bytes 0.00%
🚨 unzipped 79.9 MiB +5.36 KiB +0.01%
🚨 zip 24.07 MiB +2.14 KiB +0.01%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@bschorchit
bschorchit added this pull request to the merge queue Nov 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@bschorchit
bschorchit added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 324a763 Nov 5, 2026
266 of 279 checks passed
@bschorchit
bschorchit deleted the fix/nickname-modal-address-readonly-upstream branch November 5, 2026 05:07
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026

This branch had an error being deployed

1 failed and 1 inactive deployments
pr-comment — d815ce9a Deployed Nov 3, 2026 by bschorchit via Publish prerelease / Publish prerelease #172443
segment-schema — d815ce9a Deployed Nov 3, 2026 by bschorchit via propose #2723
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants