Skip to content

feat(confirmations): show up to 8 decimals for send and simulation amounts - #47532

Merged
dan437 merged 9 commits into
mainfrom
cursor/send-amount-decimals-8847
Nov 3, 2026
Merged

dan437 merged 9 commits into
mainfrom
cursor/send-amount-decimals-8847

Conversation

@dan437

@dan437 dan437 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

The send confirmation heading and the simulation / estimated changes amounts showed only about 3 significant digits, and fewer decimals as the amount grew (for example 121.456 showed as 121.5 and 1,034.123 as 1,034). That can hide cents on large stablecoin sends.

formatAmount now shows up to 8 decimal places by default, without trailing zeros. Longer amounts are rounded to 8 decimals, and the existing tooltip still shows the full value. Non-zero amounts below 0.000001 still show <0.000001. The change lives in formatAmount, so it applies everywhere that formatter is used.

  • formatAmount keeps its signature and gets an optional trailing { compact } option, so no existing caller has to change. compact: true keeps the previous 3-significant-digit output.
  • Only two callers opt out with { compact: true }: the network fee when paying with a token (useGasFeeToken) and swap / bridge (formatTokenAmount).
  • The other changed files are tests and one E2E check that expected the old output.

Decisions to confirm

  • pay-token-amount.tsx (MetaMask Pay "pay with" amount) and the dapp-swap quote panel inside confirmations now show up to 8 decimals. Swap / bridge pages are unchanged.
  • In the pay-fee-with-token list, the fee amount keeps the old format, but the token balance line (shown only when fiat is off) now shows up to 8 decimals.
  • The bridge E2E helper's fallback for unpriced tokens (getExpectedQuoteTotalCosts) now uses the new default, while the bridge UI stays compact. No current spec reaches it, since all mocked quotes are priced, so it is left unchanged.
  • Permit simulation pills and token-unit rows still cut text at 15 characters, so long amounts of about 10,000 or more get cut there (the tooltip shows the full value). That limit is unchanged.

Changelog

CHANGELOG entry: Increased the precision of amounts on the send confirmation and in estimated changes to up to 8 decimals

Related issues

Fixes: CONF-2212

Manual testing steps

  1. Run the extension and start a native token send of 1.234567 ETH.
  2. Verify the confirmation heading shows 1.234567 ETH, not 1.235 ETH.
  3. Send an amount with more than 8 decimals (e.g. 1.123456789). Verify the heading shows 1.12345679 and hovering it shows 1.123456789.
  4. Send an ERC-20 amount like 1034.123. Verify the heading shows 1,034.123.
  5. Open a dapp transaction with estimated changes (e.g. a swap on a dapp). Verify the amounts show up to 8 decimals, and a tiny non-zero amount still shows <0.000001.
  6. On a network with gas fee tokens, pick a token to pay the network fee. Verify the fee amount keeps the old short format (e.g. 1.235 USDC).
  7. Open Swap / Bridge and get a quote. Verify amounts keep the old short format.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Note

Medium Risk
Widespread display change via shared formatAmount affects send and confirmation UX; incorrect rounding could mislead users, though bridge/gas fee paths are explicitly kept compact.

Reviewed by Cursor Bugbot for commit d22e17d. Bugbot is set up for automated code reviews on this repo. Configure here.

cursoragent and others added 3 commits November 2, 2026 09:57
…ounts

Co-authored-by: Daniel <dan437@users.noreply.github.com>
Co-authored-by: Daniel <dan437@users.noreply.github.com>
…cimals-8847

Co-authored-by: Daniel <dan437@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (7 files, +12 -10)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 info/
              • 📁 approve/
                • 📁 hooks/
                  • 📄 use-approve-token-simulation.test.ts +1 -1
              • 📁 batch/
                • 📁 batch-simulation-details/
                  • 📄 batch-simulation-details.test.tsx +2 -2
              • 📁 hooks/
                • 📄 useGasFeeToken.ts +2 -0
              • 📁 typed-sign/
                • 📁 typed-sign-v4-simulation/
                  • 📁 value-display/
                    • 📁 __snapshots__/
                    • 📄 value-display.test.tsx.snap +1 -1
                    • 📄 value-display.test.tsx +2 -2
          • 📁 simulation-details/
            • 📄 amount-pill.test.tsx +3 -3
          • 📁 transactions/
            • 📁 quote-swap-simulation-details/
              • 📄 quote-swap-simulation-details.test.tsx +1 -1

🔄 @MetaMask/swaps-engineers (1 files, +1 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 bridge/
        • 📁 utils/
          • 📄 quote.ts +1 -0

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Nov 2, 2026
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0b68541]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41426028495 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +101%
  • ↑ confirmTx/tbt: +129%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +29%
  • ↑ bridgeUserActions/bridge_load_page: +113%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +113%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +177%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1352%
  • ↑ bridgeUserActions/bridge_load_page: +434%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↑ bridgeUserActions/bridge_search_token: +36%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +67%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1254%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +14%
  • ↑ startupStandardHome/domInteractive: +39%
  • ↑ startupStandardHome/backgroundConnect: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +42%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +48%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +51%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +235 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +370 Bytes 0.00%
✅ zip 24.06 MiB +121 Bytes 0.00%

…decimals

Co-authored-by: Daniel <dan437@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8030f6d] [reused from 0b68541]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41428881180 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +101%
  • ↑ confirmTx/tbt: +129%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +29%
  • ↑ bridgeUserActions/bridge_load_page: +113%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +113%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +177%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1352%
  • ↑ bridgeUserActions/bridge_load_page: +434%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↑ bridgeUserActions/bridge_search_token: +36%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +67%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1254%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +14%
  • ↑ startupStandardHome/domInteractive: +39%
  • ↑ startupStandardHome/backgroundConnect: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +42%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +48%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +51%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +235 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +370 Bytes 0.00%
✅ zip 24.06 MiB +121 Bytes 0.00%

cursoragent and others added 2 commits November 2, 2026 10:58
Co-authored-by: Daniel <dan437@users.noreply.github.com>
Co-authored-by: Daniel <dan437@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [96eed2e] [reused from 0b68541]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41432997782 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/cls: +1181%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +101%
  • ↑ confirmTx/tbt: +129%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +29%
  • ↑ bridgeUserActions/bridge_load_page: +113%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +115%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +113%
  • ↑ bridgeUserActions/longTaskMaxDuration: +18%
  • ↑ bridgeUserActions/tbt: +177%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/cls: +1140%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1250%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +20%
  • ↑ confirmTx/lcp: +1352%
  • ↑ bridgeUserActions/bridge_load_page: +434%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +129%
  • ↑ bridgeUserActions/bridge_search_token: +36%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +67%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -34%
  • ↑ bridgeUserActions/lcp: +1254%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/lcp: +14%
  • ↑ startupStandardHome/domInteractive: +39%
  • ↑ startupStandardHome/backgroundConnect: +10%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +142%
  • ↑ startupStandardHome/inp: +50%
  • ↑ startupStandardHome/fcp: +42%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +48%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +51%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +235 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +370 Bytes 0.00%
✅ zip 24.06 MiB +121 Bytes 0.00%

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual validation: ✅ succeeded

metamask-extension#47532 · 4 PASS / 0 FAIL / 0 BLOCKED · Langfuse trace

The PR visually validates as intended on the inspected confirmation surfaces: native send headings, ERC-20 send headings, and simulation details now show the longer precision, while the compact-formatting smoke check still shows short ETH formatting and stable layout. No funded confirmations were submitted.

Test results

Test case Status
native-send-heading-precision ✅ PASS
erc20-send-heading-precision ✅ PASS
simulation-details-precision ✅ PASS
compact-formatting-smoke ✅ PASS

Evidence

native-send-heading-precision ✅ PASS · 1 files

Confirmation heading with the native amount rendered to 8 decimals and the token symbol visible.

erc20-send-heading-precision ✅ PASS · 1 files

Token send confirmation heading with the amount rendered to 8 decimals and the token symbol visible.

simulation-details-precision ✅ PASS · 1 files

Estimated changes section visible on the confirmation screen.

compact-formatting-smoke ✅ PASS · 1 files

Fee editor modal showing compact short ETH amounts and stable row layout.

Full report · execution-result.json

Open in Web View Automation 

Sent by Cursor Automation: MetaMask/agent-orchestration

cursoragent and others added 2 commits November 2, 2026 13:26
Restore the send heading, token value and gas fee token list item tests,
the gas fee token balance, the bridge E2E helper and the simulation details
E2E check to main. None of them break with the new formatAmount output.

Co-authored-by: Daniel <dan437@users.noreply.github.com>
… compact

Restore the roundingMode parameter and add an optional trailing
{ compact } option, so existing callers are unchanged. Only the bridge
token amount and the gas fee token amount opt out.

Co-authored-by: Daniel <dan437@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ba0ed8e]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41453330666 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +42%
  • ↑ confirmTx/longTaskMaxDuration: +67%
  • ↑ confirmTx/tbt: +73%
  • ↓ confirmTx/inp: -32%
  • ↑ bridgeUserActions/bridge_load_page: +60%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +57%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +62%
  • ↑ bridgeUserActions/longTaskMaxDuration: +11%
  • ↑ bridgeUserActions/tbt: +20%
  • ↓ bridgeUserActions/fcp: -12%
  • ↓ bridgeUserActions/lcp: -16%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/fcp: -49%
  • ↑ loadNewAccount/lcp: +1369%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1385%
  • ↑ bridgeUserActions/bridge_load_page: +425%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/bridge_search_token: +27%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +54%
  • ↑ bridgeUserActions/inp: +208%
  • ↑ bridgeUserActions/fcp: +19%
  • ↑ bridgeUserActions/lcp: +1342%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.6s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/INP: p75 320ms
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +173%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↑ startupStandardHome/tbt: +13%
  • ↓ startupStandardHome/uiStartup: -32%
  • ↓ startupStandardHome/load: -26%
  • ↓ startupStandardHome/domContentLoaded: -28%
  • ↓ startupStandardHome/domInteractive: -49%
  • ↓ startupStandardHome/backgroundConnect: -26%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -27%
  • ↑ startupStandardHome/setupStore: +51%
  • ↓ startupStandardHome/fcp: -39%
  • ↓ startupStandardHome/lcp: -25%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +15%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +17%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +15%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +38%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +21%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +21%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +20%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -79%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -50%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -27%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.28 MiB +193 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB +328 Bytes 0.00%
✅ zip 24.06 MiB +93 Bytes 0.00%

@dan437
dan437 marked this pull request as ready for review November 3, 2026 09:45
@dan437
dan437 requested review from a team as code owners November 3, 2026 09:45
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d22e17d]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41614872442 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +25%
  • ↑ loadNewAccount/lcp: +32%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +77%
  • ↑ confirmTx/longTaskMaxDuration: +99%
  • ↑ confirmTx/tbt: +123%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +131%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +42%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +139%
  • ↑ bridgeUserActions/longTaskMaxDuration: +36%
  • ↑ bridgeUserActions/tbt: +293%
  • ↑ bridgeUserActions/total: +15%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +12%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +22%
  • ↑ loadNewAccount/lcp: +1310%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -30%
  • ↑ confirmTx/lcp: +1376%
  • ↑ bridgeUserActions/bridge_load_page: +336%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +124%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +34%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1325%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -11%
  • ↓ startupStandardHome/load: -13%
  • ↓ startupStandardHome/domContentLoaded: -13%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -13%
  • ↑ startupStandardHome/setupStore: +135%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -20%
  • ↓ startupStandardHome/longTaskMaxDuration: -16%
  • ↓ startupStandardHome/tbt: -17%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -12%
  • ↑ startupStandardHome/domInteractive: +35%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +147%
  • ↑ startupStandardHome/fcp: +38%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +50%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +50%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +30%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +46%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +16%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +19%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -71%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -73%
  • ↓ dappPageLoad/domContentLoaded: -37%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +206 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +341 Bytes 0.00%
✅ zip 24.07 MiB +90 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@cursor
cursor Bot had a problem deploying to segment-schema November 3, 2026 12:53 Failure
@dan437
dan437 enabled auto-merge November 3, 2026 12:54
@dan437
dan437 added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit e231b08 Nov 3, 2026
148 of 150 checks passed
@dan437
dan437 deleted the cursor/send-amount-decimals-8847 branch November 3, 2026 13:50
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch had an error being deployed

1 failed and 1 inactive deployments
segment-schema — d22e17d3 Deployed Nov 3, 2026 by cursor[bot] via propose #2566
pr-comment — d22e17d3 Deployed Nov 3, 2026 by cursor[bot] via Publish prerelease / Publish prerelease #172364
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants