Repository navigation
chore(helpers): remove unused ui helper exports - #47518
Merged
georgewrmarshall merged 1 commit intoNov 3, 2026
Merged
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
georgewrmarshall
temporarily deployed
to
pr-comment
October 30, 2026 09:20 — with
GitHub Actions
Inactive
georgewrmarshall
temporarily deployed
to
pr-comment
October 30, 2026 09:34 — with
GitHub Actions
Inactive
Contributor
Builds ready [2d41c1b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)
Bundle Size Diffs
|
|
georgewrmarshall
enabled auto-merge
November 2, 2026 17:52
amandaye0h
approved these changes
Nov 2, 2026
n3ps
approved these changes
Nov 3, 2026
georgewrmarshall
deleted the
cursor/remove-dead-code-helper-constants-20261030
branch
November 3, 2026 04:14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Removes unused exports from unowned
ui/helpersfiles. Owner set:(none)(no CODEOWNERS match). No user-facing behavior change.The declarations are not imported anywhere. Whole-word search only hit the definitions. None of these symbols or files are referenced by an open pull request. Declaration blame is older than 90 days, and the files themselves were not edited in the last 30 days. String values that are still locale message keys remain quoted elsewhere in
ui/, soyarn verify-localesdoes not lose a message reference.Left in place on purpose: five other unused error-key exports and
getGasFormErrorText, because each is the only quoted reference to a locale message key. Locales are out of scope.Checks that passed:
yarn lint:tsc, eslint on the touched files, andyarn test:unit --coverage=falseforui/helpers/utils/confirm-tx.util.test.jsandui/helpers/constants(no snapshot updates). No stylesheets changed.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948)
Manual testing steps
N/A — deletes unreachable code. There is no user-facing behavior to click through.
Screenshots/Recordings
N/A — no UI change
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Deletes unreachable helper exports only; no runtime paths or security-sensitive logic are modified.
Overview
Removes dead exports from
ui/helpersthat are not imported anywhere—proactive cleanup with no intended user-facing behavior change.Constants: drops
STATUS_CONNECTED_TO_SNAP, three error-key constants (INSUFFICIENT_FUNDS_ERROR_KEY,TRANSACTION_ERROR_KEY,IS_SIGNING_OR_SUBMITTING), and the unusedPRIORITY_LEVEL_ICON_MAPemoji map from gas helpers.Confirm-tx utils: deletes
convertTokenToFiatandroundExponential, and removes thebignumber.jsimport that only servedroundExponential. Remaining helpers (gas totals, fee formatting, dapp gas comparison, etc.) are unchanged.Other unused symbols were left when they still anchor locale message keys (per PR notes).
Reviewed by Cursor Bugbot for commit 2d41c1b. Bugbot is set up for automated code reviews on this repo. Configure here.