Skip to content

test: enable Firefox 159 WebDriver system access via MOZ_REMOTE_ALLOW_SYSTEM_ACCESS - #47589

Merged
seaona merged 2 commits into
mainfrom
fix-firefox-pin
Nov 3, 2026
Merged

seaona merged 2 commits into
mainfrom
fix-firefox-pin

Conversation

@seaona

@seaona seaona commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

Problem
Some Firefox Selenium E2E test is failing during driver setup with UnsupportedOperationError: Navigation to "about:debugging#addons" is not allowed in this context. The cause is GitHub's new Ubuntu 24.04 runner image (ubuntu24/20261101.360), which upgraded the preinstalled Firefox from 158.0.1 to 159.0. Firefox 159 removed the --remote-allow-system-access command-line flag (Firefox bug 2054896). Our workaround from #44946 and #45014 relied on that flag, since geckodriver's --allow-system-access just passes it on to Firefox. Without system access, Firefox blocks navigation to about:debugging, where we read the extension's internal ID. The new image is still rolling out, so failures depend on which image a runner gets, not on branch changes.

Temp Fix
Set MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 in the geckodriver service environment (test/e2e/webdriver/firefox.js). Firefox inherits it when geckodriver launches it. --allow-system-access stays in place so Firefox 158 and older keep working. I confirmed it locally with Firefox 159.0 and geckodriver 0.36.0: without the variable, Firefox throws the same error as CI; with it, about:debugging#addons loads.

Eventually migrate to Playwright and use newer versions

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only WebDriver bootstrap change with no production or user-facing impact.

Overview
Fixes Firefox Selenium E2E setup on Firefox 159+ (e.g. new Ubuntu 24.04 CI images), where navigation to about:debugging#addons fails because Mozilla removed the --remote-allow-system-access CLI flag that geckodriver used to pass through via --allow-system-access.

The geckodriver service in test/e2e/webdriver/firefox.js now sets MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 on the service environment so Firefox inherits it at launch. --allow-system-access is unchanged for Firefox 153–158. Comments were updated to document both paths and link Mozilla bug 2054896.

Reviewed by Cursor Bugbot for commit d8a3ab9. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [777a7b9] [reused from e231b08]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41661884748 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -22%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +23%
  • ↑ confirmTx/longTaskMaxDuration: +42%
  • ↑ confirmTx/tbt: +41%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -19%
  • ↓ confirmTx/lcp: -15%
  • ↑ bridgeUserActions/bridge_load_page: +32%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskMaxDuration: -15%
  • ↓ bridgeUserActions/tbt: -11%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -23%
  • ↓ bridgeUserActions/lcp: -11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/lcp: +1358%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -26%
  • ↑ confirmTx/lcp: +1393%
  • ↑ bridgeUserActions/bridge_load_page: +352%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +225%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +68%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +24%
  • ↑ bridgeUserActions/lcp: +1331%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -13%
  • ↑ startupStandardHome/domInteractive: +44%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +104%
  • ↑ startupStandardHome/fcp: +47%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -18%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB 0 Bytes 0.00%
✅ ui 19.33 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB 0 Bytes 0.00%
✅ zip 24.07 MiB 0 Bytes 0.00%

@github-actions github-actions Bot added size-S and removed size-XS labels Nov 3, 2026
@seaona seaona self-assigned this Nov 3, 2026
@seaona seaona added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 3, 2026
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d8a3ab9] [reused from e231b08]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41662406863 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -22%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +23%
  • ↑ confirmTx/longTaskMaxDuration: +42%
  • ↑ confirmTx/tbt: +41%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -19%
  • ↓ confirmTx/lcp: -15%
  • ↑ bridgeUserActions/bridge_load_page: +32%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskMaxDuration: -15%
  • ↓ bridgeUserActions/tbt: -11%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -23%
  • ↓ bridgeUserActions/lcp: -11%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/lcp: +1358%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -26%
  • ↑ confirmTx/lcp: +1393%
  • ↑ bridgeUserActions/bridge_load_page: +352%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +225%
  • ↑ bridgeUserActions/bridge_search_token: +23%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +68%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +24%
  • ↑ bridgeUserActions/lcp: +1331%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/numNetworkReqs: +10%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -13%
  • ↑ startupStandardHome/domInteractive: +44%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +104%
  • ↑ startupStandardHome/fcp: +47%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -18%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -26%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB 0 Bytes 0.00%
✅ ui 19.33 MiB 0 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB 0 Bytes 0.00%
✅ zip 24.07 MiB 0 Bytes 0.00%

@seaona
seaona enabled auto-merge November 3, 2026 15:55
@seaona
seaona added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 44ba3fe Nov 3, 2026
208 of 212 checks passed
@seaona
seaona deleted the fix-firefox-pin branch November 3, 2026 16:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.57.0 on PR, as PR was added to branch 13.57.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — d8a3ab98 Deployed Nov 3, 2026 by seaona via Publish prerelease / Publish prerelease #172413
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants