You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: enable Firefox 159 WebDriver system access via MOZ_REMOTE_ALLOW_SYSTEM_ACCESS - #47589
Problem
Some Firefox Selenium E2E test is failing during driver setup with UnsupportedOperationError: Navigation to "about:debugging#addons" is not allowed in this context. The cause is GitHub's new Ubuntu 24.04 runner image (ubuntu24/20261101.360), which upgraded the preinstalled Firefox from 158.0.1 to 159.0. Firefox 159 removed the --remote-allow-system-access command-line flag (Firefox bug 2054896). Our workaround from #44946 and #45014 relied on that flag, since geckodriver's --allow-system-access just passes it on to Firefox. Without system access, Firefox blocks navigation to about:debugging, where we read the extension's internal ID. The new image is still rolling out, so failures depend on which image a runner gets, not on branch changes.
Temp Fix
Set MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 in the geckodriver service environment (test/e2e/webdriver/firefox.js). Firefox inherits it when geckodriver launches it. --allow-system-access stays in place so Firefox 158 and older keep working. I confirmed it locally with Firefox 159.0 and geckodriver 0.36.0: without the variable, Firefox throws the same error as CI; with it, about:debugging#addons loads.
Eventually migrate to Playwright and use newer versions
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Test-only WebDriver bootstrap change with no production or user-facing impact.
Overview
Fixes Firefox Selenium E2E setup on Firefox 159+ (e.g. new Ubuntu 24.04 CI images), where navigation to about:debugging#addons fails because Mozilla removed the --remote-allow-system-access CLI flag that geckodriver used to pass through via --allow-system-access.
The geckodriver service in test/e2e/webdriver/firefox.js now sets MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 on the service environment so Firefox inherits it at launch. --allow-system-access is unchanged for Firefox 153–158. Comments were updated to document both paths and link Mozilla bug 2054896.
Reviewed by Cursor Bugbot for commit d8a3ab9. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededrelease-13.57.0Issue or pull request that will be included in release 13.57.0size-Steam-qaQA team
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Some Firefox Selenium E2E test is failing during driver setup with UnsupportedOperationError: Navigation to "about:debugging#addons" is not allowed in this context. The cause is GitHub's new Ubuntu 24.04 runner image (ubuntu24/20261101.360), which upgraded the preinstalled Firefox from 158.0.1 to 159.0. Firefox 159 removed the --remote-allow-system-access command-line flag (Firefox bug 2054896). Our workaround from #44946 and #45014 relied on that flag, since geckodriver's --allow-system-access just passes it on to Firefox. Without system access, Firefox blocks navigation to about:debugging, where we read the extension's internal ID. The new image is still rolling out, so failures depend on which image a runner gets, not on branch changes.
Temp Fix
Set MOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1 in the geckodriver service environment (test/e2e/webdriver/firefox.js). Firefox inherits it when geckodriver launches it. --allow-system-access stays in place so Firefox 158 and older keep working. I confirmed it locally with Firefox 159.0 and geckodriver 0.36.0: without the variable, Firefox throws the same error as CI; with it, about:debugging#addons loads.
Eventually migrate to Playwright and use newer versions
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Test-only WebDriver bootstrap change with no production or user-facing impact.
Overview
Fixes Firefox Selenium E2E setup on Firefox 159+ (e.g. new Ubuntu 24.04 CI images), where navigation to
about:debugging#addonsfails because Mozilla removed the--remote-allow-system-accessCLI flag that geckodriver used to pass through via--allow-system-access.The geckodriver service in
test/e2e/webdriver/firefox.jsnow setsMOZ_REMOTE_ALLOW_SYSTEM_ACCESS=1on the service environment so Firefox inherits it at launch.--allow-system-accessis unchanged for Firefox 153–158. Comments were updated to document both paths and link Mozilla bug 2054896.Reviewed by Cursor Bugbot for commit d8a3ab9. Bugbot is set up for automated code reviews on this repo. Configure here.