Skip to content

chore: Bump Snaps packages - #46580

Merged
FrederikBolding merged 2 commits into
mainfrom
fb/snaps-bump-v167
Sep 23, 2026
Merged

FrederikBolding merged 2 commits into
mainfrom
fb/snaps-bump-v167

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Description

Bump Snaps packages to the latest version.

See MetaMask/snaps#4129 for changes.

Changelog

CHANGELOG entry: null

Related issues

N/A


Note

Medium Risk
Touches Snaps sandbox iframe URL and RPC/state packages that govern snap execution and encrypted state; regression could affect all installed snaps, though the change is a routine version alignment with added e2e coverage.

Overview
This PR bumps MetaMask Snaps dependencies and aligns build/runtime config with the new execution environment version.

Dependency updates in package.json / yarn.lock: @metamask/snaps-sdk (^12.1.0), @metamask/snaps-controllers (^21.1.1), @metamask/snaps-execution-environments (^11.3.1), @metamask/snaps-rpc-methods (^17.2.0), and dev @metamask/test-snaps (^3.6.0). Resolutions mirror the same SDK/controllers bumps.

Build config: IFRAME_EXECUTION_ENVIRONMENT_URL moves from iframe 11.2.0 to 11.3.1 for main, beta, experimental, and flask in builds.yml, matching @metamask/snaps-execution-environments.

E2E: test-snap-managestate.spec.ts now sets two state keys, expects combined encrypted/unencrypted state, and asserts comma-separated multi-key getState returns both keys—covering behavior from the upstream Snaps release (see MetaMask/snaps#4129).

Reviewed by Cursor Bugbot for commit 214f991. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security

socket-security Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​snaps-rpc-methods@​17.1.2 ⏵ 17.2.09910076 +19750
Updated@​metamask/​test-snaps@​3.5.2 ⏵ 3.6.092 -51007494 -2100
Updated@​metamask/​snaps-execution-environments@​11.3.0 ⏵ 11.3.19910077 +19680

View full report

@metamask-ci

metamask-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [55ea6a0]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 35852373595 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +10%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +68%
  • ↑ confirmTx/longTaskMaxDuration: +81%
  • ↑ confirmTx/tbt: +98%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +85%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +87%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +105%
  • ↑ bridgeUserActions/longTaskMaxDuration: +35%
  • ↑ bridgeUserActions/tbt: +189%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +12%
  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/fcp: -70%
  • ↑ loadNewAccount/lcp: +916%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -61%
  • ↑ confirmTx/lcp: +964%
  • ↑ bridgeUserActions/bridge_load_page: +182%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +179%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +35%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +990%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/firstPaint: +15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +44%
  • ↑ startupStandardHome/inp: +14%
  • ↑ startupStandardHome/lcp: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +180%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +34%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +40%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -76%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -43%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs
  • background: 456 Bytes (0%)
  • ui: 60 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 223 Bytes (0%)

@metamask-ci

metamask-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +23 -2)
  • 📁 test/
    • 📁 e2e/
      • 📁 snaps/
        • 📄 test-snap-managestate.spec.ts +23 -2

@metamask-ci

metamask-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [214f991] [reused from 55ea6a0]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 35854236200 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +10%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +68%
  • ↑ confirmTx/longTaskMaxDuration: +81%
  • ↑ confirmTx/tbt: +98%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +85%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +87%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +105%
  • ↑ bridgeUserActions/longTaskMaxDuration: +35%
  • ↑ bridgeUserActions/tbt: +189%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +12%
  • ↑ bridgeUserActions/lcp: +12%
  • ↑ loadNewAccount/load_new_account: +416%
  • ↑ loadNewAccount/total: +416%
  • ↓ loadNewAccount/fcp: -70%
  • ↑ loadNewAccount/lcp: +916%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/fcp: -61%
  • ↑ confirmTx/lcp: +964%
  • ↑ bridgeUserActions/bridge_load_page: +182%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +179%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +35%
  • ↓ bridgeUserActions/fcp: -61%
  • ↑ bridgeUserActions/lcp: +990%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/load: +10%
  • ↑ startupStandardHome/firstPaint: +15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +44%
  • ↑ startupStandardHome/inp: +14%
  • ↑ startupStandardHome/lcp: +18%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +180%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +34%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +40%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +14%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -76%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -43%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -57%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs
  • background: 456 Bytes (0%)
  • ui: 60 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 223 Bytes (0%)

@sonarqubecloud

Copy link
Copy Markdown

@FrederikBolding
FrederikBolding marked this pull request as ready for review September 23, 2026 11:47
@FrederikBolding
FrederikBolding requested a review from a team as a code owner September 23, 2026 11:47
@metamask-ci metamask-ci Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 23, 2026
Comment thread builds.yml
- REQUIRE_SNAPS_ALLOWLIST: true
- REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/11.2.0/index.html
- IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/11.3.1/index.html

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we forgot to update this last time around :/

@FrederikBolding
FrederikBolding added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit f5a93ad Sep 23, 2026
149 checks passed
@FrederikBolding
FrederikBolding deleted the fb/snaps-bump-v167 branch September 23, 2026 12:34
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 23, 2026
@metamaskbot metamaskbot added the release-13.51.0 Issue or pull request that will be included in release 13.51.0 label Sep 23, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 214f991a Deployed Sep 23, 2026 by FrederikBolding via identify-codeowners #82755
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.51.0 Issue or pull request that will be included in release 13.51.0 size-S team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants