Skip to content

fix(money): round withdraw available balance down to cents - #47569

Merged
jpuri merged 3 commits into
mainfrom
fix/conf-2196-money-withdraw-balance-rounding
Nov 4, 2026
Merged

jpuri merged 3 commits into
mainfrom
fix/conf-2196-money-withdraw-balance-rounding

Conversation

@jpuri

@jpuri jpuri commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Money Account withdraw screen rejected the exact balance it displayed.

With a withdrawable balance of 0.499999 mUSD, the "Available balance" label rendered as $0.50, because moneyFormatUsd formats via Intl.NumberFormat, which rounds half-up. The amount input is clamped to two decimals (FIAT_INPUT_PATTERN in custom-amount.tsx), so the smallest amount a user could type that matched the label was 0.50 — a hundredth of a cent more than they actually held. The client-side balance check in useInsufficientMoneyAccountBalanceAlert then compared 0.499999 < 0.50, raised a blocking alert, and single-action-footer relabelled Send to "Insufficient funds".

The result: no typable amount would work. 0.50 was rejected and 0.49 was the only alternative. This reproduces for any balance in the [x.xx5, x.xx9999] range, not just $0.50.

The underlying 499999 figure comes from a $0.50 USDC deposit losing one micro-unit to vault-share conversion rounding. That is service-side and out of scope here, but this fix makes it harmless.

Solution: add moneyFormatUsdSpendable, which rounds down to cents, and use it for the withdrawable balance wherever that figure doubles as a spendable target. The label now reads $0.49, which is typable, passes validation, and encodes cleanly.

Key constraints respected:

  • withdrawableFiatRaw keeps full precision, so Max still withdraws the entire 0.499999 vault balance. Nothing is stranded.
  • moneyFormatUsd is unchanged, so it stays byte-identical with mobile's moneyFormatFiat, as pinned by the shared vectors in format.test.ts. Read-only totals (home page, activity, earnings projections) keep half-up rounding, which is correct for them.
  • Sub-cent dust still collapses to $0.00 rather than rounding up.

Why not relax the balance check instead?

Two alternatives were considered and rejected:

  1. Floor both sides before comparing (as usePerpsWithdrawInsufficientBalanceAlert does) — gives 0.49 vs 0.50, which still rejects. No improvement.
  2. Round the balance half-up before comparing — would admit 0.50, but musdHumanToRaw (money-account-withdraw.ts:155) encodes with ROUND_UP, producing 500000 raw against a 499999 balance. That reverts on-chain, trading a client-side block for a failed transaction and wasted gas.

The UI must never offer an amount it cannot encode, so the fix belongs in the display.

Changelog

CHANGELOG entry: Fixed a bug where withdrawing the full available balance from a Money Account was rejected as "Insufficient funds"

Related issues

Fixes: CONF-2196

Manual testing steps

  1. Open a wallet with a Money Account holding a withdrawable balance whose exact value has more than two decimals and whose third decimal is 5 or higher — e.g. 0.499999 mUSD (a $0.50 USDC deposit produces this naturally).
  2. Go to the Money Account and start a withdraw.
  3. Observe the "Available balance" label under the amount input. It should now read $0.49, not $0.50.
  4. Type 0.49 into the amount field.
  5. Verify the Send button stays enabled and is not relabelled "Insufficient funds", and that no red amount text or inline alert appears.
  6. Complete the withdraw and verify it succeeds and $0.49 is received.
  7. Press Max instead. Verify the withdraw still drains the full vault balance (0.499999) and leaves a zero balance behind — the floor is display-only and must not strand funds.
  8. Regression check: with a balance that is already an exact number of cents (e.g. 7.06), verify the label still reads $7.06 and the full amount is typable and sendable.
  9. Regression check: on the Money home page, verify the total balance is unchanged and still rounds normally.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes how withdrawable balances are shown in Money Account withdraw and confirmation flows; incorrect rounding could still mislead users or affect validation, though behavior is narrowly scoped and heavily tested.

Overview
Fixes CONF-2196, where half-up formatting of withdrawable balance (e.g. 0.499999 → $0.50) blocked full withdrawals because the two-decimal amount field could not match the displayed label.

Adds moneyFormatUsdSpendable, which floors to cents before formatting, and uses it for withdrawableFiatFormatted in withdrawable-balance helpers, useMoneyAccountBalance, and (via projectWithdrawableFiat) confirmation flows using useMoneyAccountWithdrawableFiat. withdrawableFiatRaw stays at full precision so Max still withdraws the entire vault balance; totalFiatFormatted still uses moneyFormatUsd (half-up) for read-only totals.

Reviewed by Cursor Bugbot for commit 0ae95c1. Bugbot is set up for automated code reviews on this repo. Configure here.

The Money Account withdraw screen rejected the exact balance it displayed.
With a withdrawable balance of 0.499999 mUSD, "Available balance" rendered
as $0.50 because `moneyFormatUsd` rounds half-up. The amount input is
clamped to two decimals, so the smallest amount a user could type that
matched the label was 0.50 - a hundredth of a cent more than they held.
The client-side balance check then blocked the withdraw with "Insufficient
funds", leaving no typable amount that would work.

Add `moneyFormatUsdSpendable`, which rounds down to cents, and use it for
the withdrawable balance wherever that figure doubles as a spendable
target. Half-up rounding stays in place for read-only totals, so
`moneyFormatUsd` remains byte-identical with mobile's `moneyFormatFiat`.

`withdrawableFiatRaw` is left at full precision, so Max still withdraws the
whole vault balance.

The balance comparison and the calldata encoder are deliberately untouched.
The encoder rounds up (`musdHumanToRaw`), so relaxing the check to admit
0.50 would have encoded 500000 raw against a 499999 balance and reverted
on-chain - trading a client-side block for a failed transaction.
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Nov 3, 2026
@jpuri jpuri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 3, 2026
@jpuri
jpuri marked this pull request as ready for review November 3, 2026 05:13
@jpuri
jpuri enabled auto-merge November 3, 2026 05:14
@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [9eb1e7d]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41582425574 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +415%
  • ↑ loadNewAccount/total: +415%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +31%
  • ↑ confirmTx/longTaskMaxDuration: +51%
  • ↑ confirmTx/tbt: +55%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -16%
  • ↓ confirmTx/lcp: -10%
  • ↑ bridgeUserActions/bridge_load_page: +45%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +65%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +101%
  • ↑ bridgeUserActions/tbt: +30%
  • ↓ bridgeUserActions/fcp: -15%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +422%
  • ↑ loadNewAccount/total: +422%
  • ↑ loadNewAccount/fcp: +29%
  • ↑ loadNewAccount/lcp: +1443%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↑ confirmTx/fcp: +31%
  • ↑ confirmTx/lcp: +1485%
  • ↑ bridgeUserActions/bridge_load_page: +381%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +230%
  • ↑ bridgeUserActions/bridge_search_token: +54%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +82%
  • ↑ bridgeUserActions/inp: +77%
  • ↑ bridgeUserActions/fcp: +23%
  • ↑ bridgeUserActions/lcp: +1433%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.7s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +20%
  • ↑ startupStandardHome/firstPaint: +10%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +131%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +44%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +38%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +36%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -88%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -15%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -16%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -32%
  • ↓ dappPageLoad/firstContentfulPaint: -32%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +124 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +259 Bytes 0.00%
✅ zip 24.07 MiB +82 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6ec8032]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41603724825 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/fcp: -16%
  • ↓ loadNewAccount/lcp: -14%
  • ↑ loadNewAccount/cls: +1195%
  • ↑ confirmTx/longTaskTotalDuration: +33%
  • ↑ confirmTx/longTaskMaxDuration: +50%
  • ↑ confirmTx/tbt: +58%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -16%
  • ↑ bridgeUserActions/bridge_load_page: +66%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +61%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +54%
  • ↑ bridgeUserActions/tbt: +27%
  • ↓ bridgeUserActions/fcp: -15%
  • ↑ bridgeUserActions/cls: +1181%
  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -70%
  • ↑ loadNewAccount/lcp: +860%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -69%
  • ↑ confirmTx/lcp: +858%
  • ↑ bridgeUserActions/bridge_load_page: +150%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +30%
  • ↓ bridgeUserActions/bridge_search_token: -13%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +12%
  • ↑ bridgeUserActions/inp: +46%
  • ↓ bridgeUserActions/fcp: -73%
  • ↑ bridgeUserActions/lcp: +1250%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 load
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/load: -11%
  • ↓ startupStandardHome/domContentLoaded: -12%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -12%
  • ↑ startupStandardHome/setupStore: +89%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -18%
  • ↓ startupStandardHome/longTaskMaxDuration: -14%
  • ↓ startupStandardHome/tbt: -15%
  • ↓ startupStandardHome/fcp: -11%
  • ↑ startupStandardHome/load: +16%
  • ↑ startupStandardHome/domContentLoaded: +14%
  • ↑ startupStandardHome/domInteractive: +45%
  • ↑ startupStandardHome/backgroundConnect: +21%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/loadScripts: +16%
  • ↑ startupStandardHome/setupStore: +163%
  • ↑ startupStandardHome/inp: +150%
  • ↑ startupStandardHome/fcp: +49%
  • ↑ startupStandardHome/lcp: +19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +46%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +42%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +49%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +28%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +20%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -49%
  • ↓ onboardingNewWallet/tbt: -96%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +124 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.89 MiB +259 Bytes 0.00%
✅ zip 24.07 MiB +90 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0ae95c1]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41808709335 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/lcp: +10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +44%
  • ↑ confirmTx/longTaskMaxDuration: +63%
  • ↑ confirmTx/tbt: +74%
  • ↓ confirmTx/inp: -13%
  • ↑ bridgeUserActions/bridge_load_page: +53%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +100%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +38%
  • ↑ bridgeUserActions/tbt: +46%
  • ↑ bridgeUserActions/total: +14%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -79%
  • ↑ loadNewAccount/lcp: +1072%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -71%
  • ↑ confirmTx/lcp: +861%
  • ↑ bridgeUserActions/bridge_load_page: +89%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +61%
  • ↓ bridgeUserActions/bridge_search_token: -14%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -76%
  • ↑ bridgeUserActions/lcp: +724%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/load: -13%
  • ↓ startupStandardHome/domContentLoaded: -13%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↓ startupStandardHome/loadScripts: -13%
  • ↑ startupStandardHome/setupStore: +43%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↓ startupStandardHome/longTaskTotalDuration: -19%
  • ↓ startupStandardHome/longTaskMaxDuration: -15%
  • ↓ startupStandardHome/tbt: -17%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -12%
  • ↑ startupStandardHome/cls: +400%
  • ↑ startupStandardHome/domInteractive: +41%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +132%
  • ↑ startupStandardHome/fcp: +39%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -15%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -11%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +38%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +23%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -71%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -70%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -34%
  • ↓ onboardingNewWallet/tbt: -90%
  • ↓ onboardingNewWallet/total: -67%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +130 Bytes 0.00%
✅ ui 19.33 MiB +124 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.64 MiB +259 Bytes 0.00%
✅ zip 23.81 MiB +99 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@jpuri
jpuri added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 7fef6e2 Nov 4, 2026
144 of 145 checks passed
@jpuri
jpuri deleted the fix/conf-2196-money-withdraw-balance-rounding branch November 4, 2026 10:06
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
@metamaskbot metamaskbot added the release-13.57.0 Issue or pull request that will be included in release 13.57.0 label Nov 9, 2026

This branch had an error being deployed

1 failed and 1 inactive deployments
pr-comment — 0ae95c11 Deployed Nov 4, 2026 by jpuri via Publish prerelease / Publish prerelease #172592
segment-schema — 0ae95c11 Deployed Nov 4, 2026 by jpuri via propose #2973
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.57.0 Issue or pull request that will be included in release 13.57.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants