Skip to content

Hook up shared TokenRatesController - #12066

Merged
adonesky1 merged 1 commit into
developfrom
feat/token-rates-controller
Sep 15, 2021
Merged

adonesky1 merged 1 commit into
developfrom
feat/token-rates-controller

Conversation

@adonesky1

@adonesky1 adonesky1 commented Sep 10, 2021 •

Copy link
Copy Markdown
Contributor

Explanation: Enables token fiat conversion rates (for network/token pairs that are supported by coingecko api). Cu

Manual testing steps:

  • In settings, enable show fiat on testnets
  • Go to Binance Smart Chain and import a token (like Binance-Peg Ethereum Token).
  • You should see a fiat conversion for this token (you may need a balance to fully confirm)
  • Verify that token rate conversions are up and accurate on Mainnet
  • The API is still limited in the native currencies that it supports to get conversion rates against so it will require a change on the tokenRatesController to get broader support - currently working on it here

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1
adonesky1 force-pushed the feat/token-rates-controller branch from 5550376 to 255fc52 Compare September 14, 2021 15:36
@adonesky1
adonesky1 force-pushed the feat/token-rates-controller branch from 255fc52 to a4e78df Compare September 14, 2021 16:29
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [a4e78df]
Page Load Metrics (296 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint504002678440
domContentLoaded2183892784522
load2334152964823
domInteractive2183892784522

@adonesky1
adonesky1 marked this pull request as ready for review September 14, 2021 17:27
@adonesky1
adonesky1 requested a review from a team as a code owner September 14, 2021 17:27
@adonesky1
adonesky1 requested a review from ryanml September 14, 2021 17:27
@adonesky1 adonesky1 changed the title [WIP] Hook up shared TokenRatesController Hook up shared TokenRatesController Sep 14, 2021
Comment thread ui/selectors/confirm-transaction.js Resolved

@danjm danjm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1
adonesky1 merged commit 9d968ba into develop Sep 15, 2021
@adonesky1
adonesky1 deleted the feat/token-rates-controller branch September 15, 2021 19:02
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants