Repository navigation
Add CollectiblesController & CollectibleDetectionController - #12443
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
699779a to
90c47bc
Compare
|
This will make the extension reliant upon OpenSea. Have you investigated what it would take for us to support NFTs without relying upon the OpenSea API? That was suggested as an acceptance criteria for this task in some of our earlier discussions. |
That would make sense to me! At a glance, it looks like the code for detecting tokens v.s. NFTs is already distinct. |
a2789fd to
104c87c
Compare
Builds ready [4a90e5b]Page Load Metrics (697 ± 32 ms)
highlights:storybook
|
4a90e5b to
38d2179
Compare
Builds ready [4a663f9]Page Load Metrics (757 ± 19 ms)
highlights:storybook
|
ryanml
left a comment
There was a problem hiding this comment.
LGTM! thanks for the changes here
|
@danjm I've realized that there are still some ways that the OpenSea API will get hit (we attempt to detect collectibles when a user changes accounts) unless we put this behind a feature flag. |
9e00d75 to
649cd9c
Compare
649cd9c to
656037c
Compare
Builds ready [656037c]Page Load Metrics (718 ± 21 ms)
highlights:storybook
|
Explanation:
Next Steps: