Skip to content

devDeps: bump @metamask/eslint-config* from v9 to v12 - #20073

Closed
legobeat wants to merge 52 commits into
MetaMask:developfrom
legobeat:devdeps-eslint
Closed

legobeat wants to merge 52 commits into
MetaMask:developfrom
legobeat:devdeps-eslint

Conversation

@legobeat

@legobeat legobeat commented Jul 18, 2023 •

Copy link
Copy Markdown
Contributor

Explanation

  • Update @metamask/eslint-config* packages to latest
    • Align peerDependencies
      • Exception: typescript (leaving as separate)
    • lint:fix, update rules

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 18, 2023
@socket-security

socket-security Bot commented Jul 18, 2023 •

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Jul 18, 2023 •

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore eslint-plugin-n@15.7.0

@legobeat
legobeat force-pushed the devdeps-eslint branch 2 times, most recently from 55d1f5e to f245650 Compare August 30, 2023 22:28
Comment thread .eslintrc.base.js Resolved
@legobeat
legobeat force-pushed the devdeps-eslint branch 3 times, most recently from 650ace1 to 5d36d22 Compare August 31, 2023 00:14
@legobeat legobeat added the team-application-security Application security team label Aug 31, 2023
@legobeat
legobeat force-pushed the devdeps-eslint branch 2 times, most recently from ea6bcfb to f440d0a Compare August 31, 2023 06:46
@legobeat

legobeat commented Aug 31, 2023 •

Copy link
Copy Markdown
Contributor Author

Currently this leaves quite a bit of warnings (137 warnings) in the log, which is rather noisy. Much of these should be addressed, though I felt that's out of scope for this PR.

Open to suggestions in changes with regards to that.

@legobeat

This comment was marked as resolved.

@legobeat
legobeat force-pushed the devdeps-eslint branch 4 times, most recently from e308bc9 to 616a802 Compare August 31, 2023 11:55
@legobeat
legobeat marked this pull request as ready for review August 31, 2023 11:59
@legobeat
legobeat requested review from a team and kumavis as code owners August 31, 2023 11:59
@legobeat legobeat changed the title devDeps: bump @metamask/eslint-config* to latest devDeps: bump @metamask/eslint-config* from v9 to v12 Aug 31, 2023
@legobeat
legobeat requested a review from jiexi September 2, 2023 00:40
@legobeat legobeat mentioned this pull request Sep 3, 2023
9 tasks
@legobeat
legobeat requested a review from brad-decker September 3, 2023 08:38
@HowardBraham
HowardBraham removed their request for review December 5, 2023 17:01
@legobeat
legobeat marked this pull request as draft January 19, 2024 08:25
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale issues and PRs marked as stale label Mar 19, 2024
@github-actions

github-actions Bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions Bot closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file stale issues and PRs marked as stale team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants