Repository navigation
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #21733 +/- ##
===========================================
+ Coverage 67.70% 68.51% +0.82%
===========================================
Files 1044 1049 +5
Lines 40478 41696 +1218
Branches 10880 11112 +232
===========================================
+ Hits 27403 28568 +1165
- Misses 13075 13128 +53 ☔ View full report in Codecov by Sentry. |
|
Hi @bschorchit -- thanks for tagging the issue. As a new contributor to MetaMask, I'm unsure of the process at this point. Is there anything I can do to help bring attention to this PR? Happy to do a pair session or something else if it helps a reviewer get context more quickly. |
|
Hi @dghelm, sorry for the delay in getting to this PR. We'll be prioritizing this soon (expect 1-2 weeks). |
| * @returns If chain is built on the OPStack | ||
| */ | ||
| export function isOpStack(chainId: string) { | ||
| return isOptimism(chainId) || isBase(chainId) || isOpbnb(chainId); |
There was a problem hiding this comment.
Should probably add Zora here if #20501 is getting added. Happy to pull key changes in to this PR.
|
Thank you for the latest addition and contributions, the team will be wrapping up a work this week that is currently blocking moving on to this. Sorry for the delay, but we're planning to get to this soon. |
|
@bschorchit Curious if you have any update on the blocking work? |
|
New push to resolve merge conflicts (updating for Op Sepolia testnet support). @bschorchit please let me know if there's anything else on my end to keep an eye on with Dencun upgrades :) |
|
Hello @dghelm, First and foremost, thank you very much for your valuable contribution! I believe @bschorchit will provide an update shortly. However, I wanted to inform you that the team has decided to pause this PR temporarily. This decision comes as we are in the midst of transitioning to incorporate To clarify the sequence of implementation, it will proceed as follows:
Upon reviewing this PR, I noticed only minor differences compared to the Optimism flow. Therefore, I will be preparing the upcoming PRs for Scroll, and your initial PR will be instrumental in this process (thank you once again). As soon as the final PR is prepared, I will reach out to you, @dghelm, to conduct the final manual QA. |
Excited to see the progress @OGPoyraz ! Would it be helpful (or speed things up) if I or someone from our team used your Optimism code changes to start PR drafts to core and extension for the adjustments needed for Scroll? |
|
Update: addition of Scroll to the new Transaction Controller behavior is implemented in #23991 |





Description
Motivation
The changes in this PR add MultiLayer Gas Fee information for Scroll. Its goal is to meet users' expectations that have used Op stack networks like Optimism and Base. In those networks, the multi-dimensional gas (L2 Fee for normal gas stuff and L1 Fee for data availablility) is presented to the user for legacy txs, so they have a clear expectation of transaction fees. Arbitrum and Linea take another approach -- fully hide the fee breakdown from users and just call it "gas," which gives an equally consistent user experience.
For Scroll, the L2 fee (which works nearly identically to Op Stack's) is also not included in
estimate_gascalls, but users have been reporting poor experiences using MetaMask with Scroll because it's missing much of the fee paid for transactions. This PR will go a long way to helping users understand and have a consistent experience across Op and Scroll.Note: Currently, Scroll does not support type-2 (EIP-1559) transactions, so Optimism's type-0 tx code works sufficiently for the needs of Scroll users.
Implementation
Key changes:
shared/constants/network.tsui/selectors/selectors.js, moving the functionality toui/helpers/utils/multiLayerFee/networks.js(Thanks to @pajicf for the initial work on this PR during Scroll Alpha testnet)
Related issues
None identified. Tangentially related to #21139 , but doesn't fix it. (This PR adds current legacy tx support to Scroll, doesn't extend the feature to 1559 txs.)
Manual testing steps
Screenshots/Recordings
NOTE: Please see this comment for latest screenshots.
Before
Send:



After
Send:



Pre-merge author checklist
Pre-merge reviewer checklist