Skip to content

fix: Cherry pick 1b4417d for 12.1.1 - #26780

Merged
gambinish merged 4 commits into
Version-v12.1.1from
fix/cherry-pick-mmassets-362
Aug 30, 2024
Merged

gambinish merged 4 commits into
Version-v12.1.1from
fix/cherry-pick-mmassets-362

Conversation

@gambinish

@gambinish gambinish commented Aug 29, 2024 •

Copy link
Copy Markdown
Contributor

Description

Backports changes from MATIC - POL update, including state migration: #26671

Open in GitHub Codespaces

Related issues

Fixes: MATIC ticker should now be POL. Should automatically update for users.

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title fix: Cherry pick hofix 1b4417d8a57ced140e0ea31aed08758f74002faa for 12.1.1 fix: Cherry pick 1b4417d for 12.1.1 Aug 29, 2024
@codecov

codecov Bot commented Aug 29, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.86%. Comparing base (0ef30b9) to head (a131703).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.1.1   #26780      +/-   ##
===================================================
+ Coverage            69.84%   69.86%   +0.03%     
===================================================
  Files                 1371     1372       +1     
  Lines                48791    48835      +44     
  Branches             13453    13484      +31     
===================================================
+ Hits                 34074    34118      +44     
  Misses               14717    14717              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [8d7acc1]
Page Load Metrics (332 ± 306 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint644661208240
domContentLoaded9183323718
load392119332637306
domInteractive9183323718

@gambinish
gambinish marked this pull request as ready for review August 29, 2024 23:16
@gambinish
gambinish requested review from a team as code owners August 29, 2024 23:16
@gambinish
gambinish requested a review from Gudahtt August 29, 2024 23:16

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing one more reference to MATIC in app/scripts/controllers/metamask-notifications/constants/notification-schema.ts. Looks like this should be updated to POL as well. This wasn't included in the change we landed on develop because the file doesn't exist there.

@gambinish
gambinish requested a review from a team as a code owner August 30, 2024 16:51
@Gudahtt
Gudahtt dismissed their stale review August 30, 2024 17:18

Requested change has been made

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [a131703]
Page Load Metrics (595 ± 496 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint613461356029
domContentLoaded106732189
load4830155951034496
domInteractive106732189

@gambinish
gambinish merged commit 1548351 into Version-v12.1.1 Aug 30, 2024
@gambinish
gambinish deleted the fix/cherry-pick-mmassets-362 branch August 30, 2024 17:41
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants