Skip to content

fix: Apply padding to Snaps UI root element no matter the type - #26850

Merged
FrederikBolding merged 1 commit into
developfrom
fb/fix-snaps-ui-root-padding
Sep 3, 2024
Merged

FrederikBolding merged 1 commit into
developfrom
fb/fix-snaps-ui-root-padding

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Sep 3, 2024 •

Copy link
Copy Markdown
Member

Description

Fixes a problem where padding would not be applied correctly to the first child of the Snaps UI container. We were expecting all root elements to be div. But many different types of components are allowed at the root. Quick fix by applying the padding no matter what type the root element is.

Open in GitHub Codespaces

Screenshots/Recordings

Before

image

After

image

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Sep 3, 2024
@FrederikBolding
FrederikBolding requested a review from a team as a code owner September 3, 2024 08:33
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 3, 2024
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2024

Copy link
Copy Markdown

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [70f8b8e]
Page Load Metrics (1876 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint162724411882243117
domContentLoaded161824261856237114
load162324431876247119
domInteractive228237168

@codecov

codecov Bot commented Sep 3, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (5c5bc87) to head (70f8b8e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26850   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1424     1424           
  Lines        49567    49567           
  Branches     13867    13867           
========================================
  Hits         34759    34759           
  Misses       14808    14808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding
FrederikBolding merged commit 74dc3e7 into develop Sep 3, 2024
@FrederikBolding
FrederikBolding deleted the fb/fix-snaps-ui-root-padding branch September 3, 2024 12:21
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 3, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants