Skip to content

fix: sticky footer UI issue on Snaps Home Page in extended view - #27799

Merged
david0xd merged 1 commit into
developfrom
dd/fix-snaps-home-footer-extended
Oct 14, 2024
Merged

david0xd merged 1 commit into
developfrom
dd/fix-snaps-home-footer-extended

Conversation

@david0xd

@david0xd david0xd commented Oct 11, 2024 •

Copy link
Copy Markdown
Contributor

Description

Fix issue with sticky Snaps UI Footer component in extended view.

Open in GitHub Codespaces

Related issues

Fixes: n/a

Manual testing steps

  1. Try all the Snaps that use custom footer (Home Page Snap, Custom Dialog Snap with custom UI, etc.).
  2. Make sure that footer has correct width matching the width of the content view.

Screenshots/Recordings

Before

image

After

Screenshot 2024-10-11 at 20 38 13
Screenshot 2024-10-11 at 20 38 48
Screenshot 2024-10-11 at 20 40 55
Screenshot 2024-10-11 at 20 41 15
Screenshot 2024-10-11 at 20 56 29

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added type-bug Something isn't working area-UI Relating to the user interface. team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Oct 11, 2024
@david0xd david0xd self-assigned this Oct 11, 2024
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd added regression-RC-12.5.0 regression-main Regression bug that was found on main branch, but not yet present in production labels Oct 11, 2024
@david0xd
david0xd marked this pull request as ready for review October 11, 2024 19:21
@david0xd
david0xd requested a review from a team as a code owner October 11, 2024 19:21

@bowensanders bowensanders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@david0xd
david0xd force-pushed the dd/fix-snaps-home-footer-extended branch from b0096c3 to c06ed75 Compare October 14, 2024 11:37
@sonarqubecloud

Copy link
Copy Markdown

@FrederikBolding
FrederikBolding added this pull request to the merge queue Oct 14, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [c06ed75]
Page Load Metrics (1834 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16452097184110852
domContentLoaded16112081180510550
load16432099183410952
domInteractive22186624522
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@FrederikBolding
FrederikBolding added this pull request to the merge queue Oct 14, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@david0xd
david0xd added this pull request to the merge queue Oct 14, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@david0xd
david0xd added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit c678db2 Oct 14, 2024
@david0xd
david0xd deleted the dd/fix-snaps-home-footer-extended branch October 14, 2024 13:39
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 14, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-UI Relating to the user interface. regression-main Regression bug that was found on main branch, but not yet present in production regression-RC-12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) type-bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants