Repository navigation
chore: Remove remote mode - #34041
Merged
Merged
Conversation
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +1 -16)
🎨 @MetaMask/design-system-engineers (1 files, +0 -1)
🖥️ @MetaMask/wallet-ux (2 files, +2 -22)
|
Collaborator
Builds ready [3b7d060]
UI Startup Metrics (1162 ± 81 ms)
Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1701 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2757 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2063 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2045 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2034 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 378 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1708 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1471 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1471 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 117 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1450 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2138 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1821 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1821 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 85 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1799 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 529ms | Sum of p95 exceeds: 1613ms Sum of all benchmark exceeds: 2142ms Bundle size diffs [🚀 Bundle size reduced!]
|
kevinbluer
force-pushed
the
chore/remove-remote-mode
branch
from
July 3, 2025 16:01
f26fc29 to
342dec3
Compare
Collaborator
Builds ready [342dec3]
UI Startup Metrics (1243 ± 65 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2711 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2013 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2011 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 21 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1753 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 274 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 173 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1695 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1440 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2114 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1748 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 428ms | Sum of p95 exceeds: 1431.8ms Sum of all benchmark exceeds: 1859.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
kevinbluer
force-pushed
the
chore/remove-remote-mode
branch
from
July 3, 2025 19:06
342dec3 to
a7f2d75
Compare
Collaborator
Builds ready [a7f2d75]
UI Startup Metrics (1233 ± 60 ms)
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2251 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 259 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2645 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1699 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 316 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 78 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1674 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1446 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1426 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2091 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1773 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1773 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1757 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 403ms | Sum of p95 exceeds: 1192.8ms Sum of all benchmark exceeds: 1595.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
kevinbluer
force-pushed
the
chore/remove-remote-mode
branch
from
July 8, 2025 14:51
a7f2d75 to
e656333
Compare
kevinbluer
marked this pull request as ready for review
July 8, 2025 14:57
Collaborator
Builds ready [e656333]
UI Startup Metrics (1235 ± 68 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 23 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2278 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1713 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1707 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1702 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2722 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2038 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2027 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 340 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2013 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1672 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1714 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1455 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2080 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1684 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1683 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1662 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 549ms | Sum of p95 exceeds: 941.8ms Sum of all benchmark exceeds: 1490.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
kevinbluer
force-pushed
the
chore/remove-remote-mode
branch
2 times, most recently
from
July 8, 2025 15:59
c72e166 to
74c689d
Compare
Collaborator
Builds ready [74c689d]
UI Startup Metrics (1236 ± 70 ms)
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2276 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1733 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 252 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1722 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2718 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2019 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2010 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 291 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 79 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1432 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1412 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2018 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 269 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 44 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1695 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 418ms | Sum of p95 exceeds: 1015.8ms Sum of all benchmark exceeds: 1433.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
caieu
previously approved these changes
Jul 9, 2025
Co-authored-by: Caainã Jeronimo <caainaje@gmail.com>
kevinbluer
force-pushed
the
chore/remove-remote-mode
branch
from
July 9, 2025 17:25
2055ce0 to
1b287cd
Compare
Collaborator
Builds ready [1b287cd]
UI Startup Metrics (1233 ± 69 ms)
Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 19 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2252 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 262 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2739 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2035 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2026 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 23 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2013 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 19 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1796 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 334 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 48 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 28 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1650 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1403 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1403 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2128 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 79 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1715 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 266ms | Sum of p95 exceeds: 1479.8ms Sum of all benchmark exceeds: 1745.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [54c787d]
UI Startup Metrics (1251 ± 69 ms)
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1193 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2383 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1810 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1803 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1799 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2945 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2197 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2185 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 364 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 26 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2173 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 183 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 9 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1704 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 71 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 48 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1731 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1453 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1452 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 13 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1430 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2166 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1764 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1763 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 320 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 74 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 48 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 70 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1741 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 42 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 920ms | Sum of p95 exceeds: 2319.8ms Sum of all benchmark exceeds: 3239.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
matthewwalsh0
previously approved these changes
Jul 10, 2025
darkwing
previously approved these changes
Jul 14, 2025
georgewrmarshall
previously approved these changes
Jul 14, 2025
Collaborator
Builds ready [1cd8d0c]
UI Startup Metrics (1254 ± 60 ms)
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1194 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 26 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2389 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1809 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1801 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 15 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1797 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2779 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2117 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2101 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 69 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2087 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1706 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 49 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 74 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1767 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1458 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2240 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1898 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1898 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1874 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1060ms | Sum of p95 exceeds: 2218.8ms Sum of all benchmark exceeds: 3278.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
kevinbluer
dismissed stale reviews from georgewrmarshall, darkwing, and caieu
via
July 24, 2025 22:13
34a704a
Collaborator
Builds ready [34a704a]
UI Startup Metrics (1309 ± 45 ms)
Benchmark value 1126 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1118 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 871 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1386 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 277 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 943 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2415 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1928 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1921 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 60 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1903 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2836 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2438 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2433 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 285 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2231 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1516 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1307 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1307 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1283 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1974 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1545 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1545 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 384 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 66 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1502 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 1983 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 183 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1680 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 1884ms | Sum of p95 exceeds: 2949.8ms Sum of all benchmark exceeds: 4833.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
georgewrmarshall
approved these changes
Jul 29, 2025
georgewrmarshall
left a comment
Contributor
There was a problem hiding this comment.
Approved on behalf of @MetaMask/design-system-engineers
darkwing
approved these changes
Jul 29, 2025
matthewwalsh0
approved these changes
Jul 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the work-in-progress Remote Mode feature. For reference it was being developed behind a feature flag (
vaultRemoteMode) and not yet enabled.Related issues
Fixes: NA
Manual testing steps
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist