Skip to content

chore: Remove remote mode - #34041

Merged
kevinbluer merged 7 commits into
mainfrom
chore/remove-remote-mode
Jul 30, 2025
Merged

kevinbluer merged 7 commits into
mainfrom
chore/remove-remote-mode

Conversation

@kevinbluer

@kevinbluer kevinbluer commented Jul 2, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR removes the work-in-progress Remote Mode feature. For reference it was being developed behind a feature flag (vaultRemoteMode) and not yet enabled.

Open in GitHub Codespaces

Related issues

Fixes: NA

Manual testing steps

  1. Review / assess removed code and ensure no regressions

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-vault-deprecated MetaMask Vault Team is now Prediction Markets label Jul 2, 2025
@metamaskbot

metamaskbot commented Jul 2, 2025 •

Copy link
Copy Markdown
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +1 -16)
  • 📁 app/
    • 📁 scripts/
      • 📁 controller-init/
        • 📁 confirmations/
          • 📄 transaction-controller-init.ts +0 -7
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 pages/
          • 📁 send/
            • 📁 components/
              • 📄 account-picker.tsx +1 -9

🎨 @MetaMask/design-system-engineers (1 files, +0 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 component-library/
        • 📁 icon/
          • 📄 icon.types.ts +0 -1

🖥️ @MetaMask/wallet-ux (2 files, +2 -22)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 activity-list-item/
          • 📄 activity-list-item.js +1 -13
        • 📁 pages/
          • 📁 send/
            • 📁 components/
              • 📄 account-picker.tsx +1 -9

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [3b7d060]
UI Startup Metrics (1162 ± 81 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1162105117168112001295
load99389315908010171122
domContentLoaded98688615838010111112
domInteractive17135371635
firstPaint64878114239110071061
backgroundConnect74283811
firstReactRender22177172335
getState1563982030
initialActions002001
loadScripts785676138381811915
setupStore85203914
WebpackHomeuiStartup22721718294022223642756
load17101282224918518152063
domContentLoaded17041278222918318112045
domInteractive1812102151459
firstPaint1606951679179322
backgroundConnect2611353342845
firstReactRender26192414119388404
getState1456191630
initialActions317134
loadScripts17011276221718218072034
setupStore1776392031
FirefoxBrowserifyHomeuiStartup14141244194713514681659
load1237107515739412991449
domContentLoaded1237107515739412991449
domInteractive1223545377119378
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20136672129
firstReactRender25215842530
getState105709927
initialActions001001
loadScripts1220106315509312821425
setupStore16431238870
WebpackHomeuiStartup17081411248921918172138
load14711224213817315891821
domContentLoaded14701224213817315891821
domInteractive11635782103100313
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241685102441
firstReactRender44355844751
getState154129221185
initialActions102111
loadScripts14501206212017315661799
setupStore14624331931
Benchmark value 2272 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1701 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2757 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2063 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2045 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2034 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 378 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1708 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1471 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1471 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 117 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1450 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2138 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1821 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1821 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 85 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1799 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 529ms | Sum of p95 exceeds: 1613ms
Sum of all benchmark exceeds: 2142ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.26 KiB (0.48%)
  • ui: -73.66 KiB (-1%)
  • common: -31.67 KiB (-0.37%)

@kevinbluer
kevinbluer force-pushed the chore/remove-remote-mode branch from f26fc29 to 342dec3 Compare July 3, 2025 16:01
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [342dec3]
UI Startup Metrics (1243 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1243112415016512831365
load106490812536211031173
domContentLoaded105790312506210971163
domInteractive18135671740
firstPaint698136117642510871152
backgroundConnect84252811
firstReactRender2415152152533
getState1564282131
initialActions40266715
loadScripts80766598757852903
setupStore952641020
WebpackHomeuiStartup22401714290223023342710
load17041239211619218012016
domContentLoaded16981235210319117972012
domInteractive181276131458
firstPaint1616245369192299
backgroundConnect221078112746
firstReactRender23491508115360406
getState14453111546
initialActions112267261020
loadScripts16951234209219017952010
setupStore217311312143
FirefoxBrowserifyHomeuiStartup13951209206915414501753
load1208104915859612591396
domContentLoaded1208104915859612591396
domInteractive1163640962119274
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21136392240
firstReactRender24213632530
getState215297489173
initialActions407911321
loadScripts1189103415649612351374
setupStore124185211052
WebpackHomeuiStartup16941411260921817812114
load14591205189515515601768
domContentLoaded14581204189415515601768
domInteractive106604736895297
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615338332646
firstReactRender42335334448
getState146215221132
initialActions6019420321
loadScripts14391188186915415391748
setupStore15527531949
Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2240 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2711 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2013 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2011 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 21 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1753 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 274 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 173 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1695 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1440 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2114 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1748 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 428ms | Sum of p95 exceeds: 1431.8ms
Sum of all benchmark exceeds: 1859.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.25 KiB (0.48%)
  • ui: -78.99 KiB (-1.07%)
  • common: -31.67 KiB (-0.37%)

@kevinbluer
kevinbluer force-pushed the chore/remove-remote-mode branch from 342dec3 to a7f2d75 Compare July 3, 2025 19:06
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [a7f2d75]
UI Startup Metrics (1233 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233111414566012691329
load105994012415610911163
domContentLoaded105293312305610851157
domInteractive19144981742
firstPaint74083123841710781141
backgroundConnect84253814
firstReactRender22184352332
getState1573682130
initialActions40296716
loadScripts80469199155833902
setupStore84243814
WebpackHomeuiStartup22511684283619323372645
load17071247210615717771967
domContentLoaded16991242207115317721961
domInteractive1912126201471
firstPaint1696258680177325
backgroundConnect2710289322555
firstReactRender25990411112379396
getState1454671629
initialActions822751021
loadScripts16951240206015217701958
setupStore237315412043
FirefoxBrowserifyHomeuiStartup14151210188813714821699
load1230107815919512981418
domContentLoaded1230107815919512981418
domInteractive1213658283128316
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513326332156
firstReactRender25213532531
getState14512519960
initialActions408312315
loadScripts1211106715739312821384
setupStore15425737978
WebpackHomeuiStartup16731407243719817572091
load14451217198716115521773
domContentLoaded14451216198616115511773
domInteractive1113338969108297
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23158192442
firstReactRender41305644448
getState156100141334
initialActions7021322521
loadScripts14261202197016015331757
setupStore1056610829
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2251 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 259 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2645 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 21 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1699 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 316 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 60 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 78 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1674 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1446 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1426 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2091 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1773 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1773 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1757 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 403ms | Sum of p95 exceeds: 1192.8ms
Sum of all benchmark exceeds: 1595.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.25 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.68 KiB (-0.37%)

@kevinbluer
kevinbluer force-pushed the chore/remove-remote-mode branch from a7f2d75 to e656333 Compare July 8, 2025 14:51
@kevinbluer
kevinbluer marked this pull request as ready for review July 8, 2025 14:57
@kevinbluer
kevinbluer requested review from a team as code owners July 8, 2025 14:57
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [e656333]
UI Startup Metrics (1235 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1235110414426812851338
load106394912476011041157
domContentLoaded105594212376010971152
domInteractive17144361737
firstPaint738134118642010891149
backgroundConnect94849923
firstReactRender23154052536
getState1463372028
initialActions506810823
loadScripts80770497659849905
setupStore85264817
WebpackHomeuiStartup22781722284222124132722
load17121249214018618232038
domContentLoaded17061245212818518132027
domInteractive1912127161549
firstPaint1696746679208339
backgroundConnect25114882941
firstReactRender26192413115380403
getState195273271939
initialActions112182191130
loadScripts17021243211518318082012
setupStore197184182134
FirefoxBrowserifyHomeuiStartup13571147183013914011672
load1182102215059112431386
domContentLoaded1182102215059112431386
domInteractive1053746960112202
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231299132447
firstReactRender25215342530
getState12518020956
initialActions6015320226
loadScripts1163101014919112141362
setupStore13418428761
WebpackHomeuiStartup17141408237219118182080
load14741213180214715921684
domContentLoaded14741213180214715911683
domInteractive1075639568100306
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2514112142549
firstReactRender43355134548
getState166122161436
initialActions8126828521
loadScripts14541197174214515731662
setupStore126189191133
Benchmark value 1235 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 23 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2278 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1713 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1707 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1702 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2722 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2038 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2027 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 340 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2013 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1672 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1714 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1455 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2080 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1684 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1683 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1662 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 549ms | Sum of p95 exceeds: 941.8ms
Sum of all benchmark exceeds: 1490.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.25 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.68 KiB (-0.37%)

@kevinbluer
kevinbluer force-pushed the chore/remove-remote-mode branch 2 times, most recently from c72e166 to 74c689d Compare July 8, 2025 15:59
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [74c689d]
UI Startup Metrics (1236 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1236110114577012781372
load106494412356511031188
domContentLoaded105794012296510981181
domInteractive18135671740
firstPaint718132123742410771177
backgroundConnect84485913
firstReactRender22185362338
getState16698112231
initialActions40618518
loadScripts81069898264848936
setupStore85314817
WebpackHomeuiStartup22761682294223624112717
load17321227222618818542029
domContentLoaded17261223220418618492018
domInteractive181280141557
firstPaint1606373985175293
backgroundConnect251055103045
firstReactRender25290421120381406
getState1554481934
initialActions13224830933
loadScripts17221221219118418452009
setupStore217181242144
FirefoxBrowserifyHomeuiStartup13681136193714014191632
load1191100814889512621358
domContentLoaded1191100814889512621357
domInteractive1083444565109291
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313184212155
firstReactRender25213532631
getState14520229979
initialActions8019728241
loadScripts117199614579212361332
setupStore1039414732
WebpackHomeuiStartup16681391240119717692018
load14321185202216115401714
domContentLoaded14321184202216115401714
domInteractive100364625994269
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251589122745
firstReactRender41325444447
getState166117161444
initialActions40224415
loadScripts14121169198616115231695
setupStore145245281049
Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2276 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1733 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 252 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1722 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2718 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2019 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2010 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 291 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 79 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1432 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1412 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2018 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 269 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 44 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1695 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 418ms | Sum of p95 exceeds: 1015.8ms
Sum of all benchmark exceeds: 1433.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.25 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.68 KiB (-0.37%)

caieu
caieu previously approved these changes Jul 9, 2025
@kevinbluer
kevinbluer force-pushed the chore/remove-remote-mode branch from 2055ce0 to 1b287cd Compare July 9, 2025 17:25
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [1b287cd]
UI Startup Metrics (1233 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233110715356912751369
load106394313826711061169
domContentLoaded105693713766710981163
domInteractive17144761636
firstPaint72680138742610861166
backgroundConnect84334918
firstReactRender22164352434
getState1453271928
initialActions40255715
loadScripts811689113066851917
setupStore84264917
WebpackHomeuiStartup22521811310923123682739
load17001321229718317902035
domContentLoaded16931316228418117782026
domInteractive191290161468
firstPaint1746475695183288
backgroundConnect241074102745
firstReactRender26292403120382400
getState185198221838
initialActions102209211023
loadScripts16891313227117917752012
setupStore1776892133
FirefoxBrowserifyHomeuiStartup14091202205517314651796
load12201051157910912871457
domContentLoaded12191051157910912871457
domInteractive1163750982113334
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313119172234
firstReactRender26224942733
getState16527934948
initialActions5010414328
loadScripts11991038155510612661389
setupStore18422442775
WebpackHomeuiStartup16501357225420217462128
load14031142183516014891739
domContentLoaded14021142183516014891739
domInteractive107455158197313
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2614265332243
firstReactRender58458066270
getState186192291279
initialActions8124328219
loadScripts13771121180515314591715
setupStore11510512926
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 19 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2252 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 262 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2739 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2035 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2026 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 23 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2013 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 19 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1796 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 334 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 48 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 28 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 75 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1650 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1403 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1403 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1378 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2128 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1739 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 79 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1715 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 266ms | Sum of p95 exceeds: 1479.8ms
Sum of all benchmark exceeds: 1745.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.26 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.67 KiB (-0.37%)

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [54c787d]
UI Startup Metrics (1251 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1251110115046912931379
load107495612866311071193
domContentLoaded106795112806311001184
domInteractive18145871737
firstPaint63882128144010941144
backgroundConnect84233911
firstReactRender23165572340
getState1654072128
initialActions30205316
loadScripts818712101759851925
setupStore84193817
WebpackHomeuiStartup23821769300026025082945
load18091319230523019622196
domContentLoaded18021315229822919552185
domInteractive201296171667
firstPaint1817048484212364
backgroundConnect3212319403164
firstReactRender22392443108349401
getState205356362145
initialActions11225626926
loadScripts17981312228622719522173
setupStore2973455322183
FirefoxBrowserifyHomeuiStartup13951169221016914631704
load12151036164710812501436
domContentLoaded12141036164610812501436
domInteractive1123580986111223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2314117142350
firstReactRender26225852632
getState15533838971
initialActions8018227248
loadScripts11941022161010512271413
setupStore13418624761
WebpackHomeuiStartup17301427257021718162166
load14521209203815315221764
domContentLoaded14521209203815315211763
domInteractive102515137290320
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23155682642
firstReactRender61468876574
getState166115181348
initialActions12126339570
loadScripts14301191200215215011741
setupStore155330341042
Benchmark value 1251 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1193 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2383 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1810 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1803 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1799 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2945 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2197 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2185 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 364 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 26 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2173 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 183 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 9 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1704 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 71 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 48 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1731 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1453 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1452 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 13 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1430 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2166 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1764 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1763 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 320 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 74 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 48 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 70 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1741 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 42 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 920ms | Sum of p95 exceeds: 2319.8ms
Sum of all benchmark exceeds: 3239.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.26 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.67 KiB (-0.37%)

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
matthewwalsh0
matthewwalsh0 previously approved these changes Jul 10, 2025
caieu
caieu previously approved these changes Jul 10, 2025

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caieu
caieu previously approved these changes Jul 14, 2025

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkwing
darkwing previously approved these changes Jul 14, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [1cd8d0c]
UI Startup Metrics (1254 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1254112413916012891372
load107696512155511101193
domContentLoaded106996012085511051179
domInteractive18144671739
firstPaint73679122442810941189
backgroundConnect83334912
firstReactRender22144262537
getState1663872229
initialActions50499526
loadScripts81571594753845912
setupStore95315920
WebpackHomeuiStartup23881764287320624952778
load18081307221217518982117
domContentLoaded18011303220717218932100
domInteractive2012102171669
firstPaint1706773589192310
backgroundConnect2810191203355
firstReactRender22491426107339398
getState265310482377
initialActions153204331230
loadScripts17971301220517118912087
setupStore217217272139
FirefoxBrowserifyHomeuiStartup13851199236118614391706
load1195105916199912611379
domContentLoaded1195105916199912611379
domInteractive1123650785110313
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313183202148
firstReactRender23195152430
getState16536441949
initialActions6016620319
loadScripts1175104816099512391342
setupStore16422336774
WebpackHomeuiStartup17671481350227118452240
load14801233323625015521898
domContentLoaded14801233323525015511898
domInteractive1133654887100313
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251698102642
firstReactRender59427566470
getState177207241536
initialActions10128137421
loadScripts14581205321425015291874
setupStore145295301132
Benchmark value 1254 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1194 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 26 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2389 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1809 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1801 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 15 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1797 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2779 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2117 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2101 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 69 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2087 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1706 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 49 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 74 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1767 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1458 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2240 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1898 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1898 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1874 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1060ms | Sum of p95 exceeds: 2218.8ms
Sum of all benchmark exceeds: 3278.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.26 KiB (0.48%)
  • ui: -79 KiB (-1.07%)
  • common: -31.67 KiB (-0.37%)

@kevinbluer
kevinbluer dismissed stale reviews from georgewrmarshall, darkwing, and caieu via 34a704a July 24, 2025 22:13
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [34a704a]
UI Startup Metrics (1309 ± 45 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1309117214554513411386
load112598313145211641196
domContentLoaded111797813025111591188
domInteractive201368101842
firstPaint72182131846011301183
backgroundConnect25323830410257276
firstReactRender20145862131
getState1047911927
initialActions20184110
loadScripts871739103551911943
setupStore74315719
WebpackHomeuiStartup24151877295820025142835
load19281394250421620172438
domContentLoaded19211387249821520092432
domInteractive1912208231561
firstPaint1566169281171322
backgroundConnect60123698739284
firstReactRender1468937268173320
getState2142654715178
initialActions52335615
loadScripts19021384245320520052230
setupStore216229401654
FirefoxBrowserifyHomeuiStartup15161320233017115501974
load13071135178710913611545
domContentLoaded13061135178710913611545
domInteractive12638792114117384
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2815189192949
firstReactRender312170143066
getState133197311039
initialActions7019521424
loadScripts12821113176010513391502
setupStore1039514738
WebpackHomeuiStartup16691475218715417491983
load14201245183613115041715
domContentLoaded14201245183613115041715
domInteractive1023435546106183
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2718103122849
firstReactRender51416965564
getState923971424
initialActions7018521315
loadScripts13961226181012814811680
setupStore14426634828
Benchmark value 1309 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1126 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1118 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 871 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1386 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 277 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 943 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2415 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1928 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1921 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 60 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1903 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2836 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2438 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2433 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 285 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2231 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1516 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1307 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1307 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1283 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1974 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1545 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1545 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 384 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 66 exceeds gate value 55 for firefox browserify home p95 firstReactRender
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1502 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1983 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 183 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1680 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 1884ms | Sum of p95 exceeds: 2949.8ms
Sum of all benchmark exceeds: 4833.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 26.26 KiB (0.48%)
  • ui: -80.37 KiB (-1.08%)
  • common: -31.72 KiB (-0.37%)

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @MetaMask/design-system-engineers

@matthewwalsh0
matthewwalsh0 added this pull request to the merge queue Jul 30, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@kevinbluer
kevinbluer added this pull request to the merge queue Jul 30, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@kevinbluer
kevinbluer added this pull request to the merge queue Jul 30, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@kevinbluer
kevinbluer added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 3303305 Jul 30, 2025
@kevinbluer
kevinbluer deleted the chore/remove-remote-mode branch July 30, 2025 21:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2025
@metamaskbot metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.1.0 Issue or pull request that will be included in release 13.1.0 team-vault-deprecated MetaMask Vault Team is now Prediction Markets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants