Skip to content

fix: cp-13.11.2 bump bitcoin - #38437

Merged
Battambang merged 2 commits into
mainfrom
chore/bitcoin-bump-1.8.0
Dec 1, 2025
Merged

Battambang merged 2 commits into
mainfrom
chore/bitcoin-bump-1.8.0

Conversation

@Battambang

@Battambang Battambang commented Dec 1, 2025 •

Copy link
Copy Markdown
Contributor

Description

Updates bitcoin to 1.8.0, which removes onRpcRequest method..

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Removed onRpcRequest (#568)

Related issues

Fixes: Remove onRpcRequest.

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit 22174ad. Configure here.

@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aganglada aganglada changed the title fix: bump bitcoin fix: cp-13.11.2 bump bitcoin Dec 1, 2025
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​bitcoin-wallet-snap@​1.7.0 ⏵ 1.8.01001008398 +1100

View full report

@Battambang
Battambang enabled auto-merge December 1, 2025 14:50

@aganglada aganglada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, rpc is disallowed ✅

gauthierpetetin added a commit that referenced this pull request Dec 1, 2025
This PR updates the change log for 13.11.2. (Hotfix - no test plan
generated.)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates `CHANGELOG.md` for 13.11.2 with a Bitcoin Snap upgrade fix and
refreshed version comparison links.
> 
> - **Changelog (`CHANGELOG.md`)**:
> - Adds `13.11.2` section under *Fixed*: upgrade Bitcoin Snap (#38437).
> - Updates version comparison references: `[Unreleased]` baseline to
`v13.11.2...HEAD` and adds `[13.11.2]` link.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
bee7ccf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [6796f22]
UI Startup Metrics (1234 ± 112 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12341004160311213021413
load103685113679710881208
domContentLoaded103084613589610791188
domInteractive2515101182279
firstPaint64790140741410461189
backgroundConnect21519426713222237
firstReactRender28207092949
getState3416117193786
initialActions104112
loadScripts821654111893869982
setupStore1154151219
numNetworkReqs1257821576
BrowserifyPower User HomeuiStartup20851644287829622972698
load1028899147913810321439
domContentLoaded1015890147113910181419
domInteractive37191642636105
firstPaint4769815203639371074
backgroundConnect24220680192230500
firstReactRender5939121176296
getState19514469475197248
initialActions104112
loadScripts80667912571358071195
setupStore20116072329
numNetworkReqs1746842783209416
WebpackStandard HomeuiStartup8297071110828581005
load64256986875659815
domContentLoaded63856585974654808
domInteractive2715114232399
firstPaint224104807156217629
backgroundConnect1068081018
firstReactRender27204563238
getState291485153660
initialActions104112
loadScripts63556285072651799
setupStore1163741319
numNetworkReqs1257720571
WebpackPower User HomeuiStartup17001293243127619532151
load6885861131102695954
domContentLoaded6785811124103685949
domInteractive39172023535136
firstPaint265118705153285641
backgroundConnect66763515618575
firstReactRender624798106783
getState18713178383185220
initialActions105112
loadScripts6755791115101683941
setupStore22754132451
numNetworkReqs1696944480217355
FirefoxBrowserifyStandard HomeuiStartup12941031169813613721596
load106789014088311181204
domContentLoaded106689014088311141204
domInteractive56301462882116
firstPaint------
backgroundConnect48212103653143
firstReactRender23173752436
getState156205291227
initialActions103122
loadScripts103787713767610841161
setupStore136184201030
numNetworkReqs1156416762
BrowserifyPower User HomeuiStartup27162170372532029093416
load12721112175115412851636
domContentLoaded12721112175115412851635
domInteractive1295464995122387
firstPaint------
backgroundConnect14254818123138440
firstReactRender67451402069124
getState28561982198333741
initialActions218134
loadScripts12381067171714912511584
setupStore18524782192210687
numNetworkReqs99623216380242
WebpackStandard HomeuiStartup15541325204314316191839
load1286111216069413341465
domContentLoaded1285111216069413341465
domInteractive69302473487131
firstPaint------
backgroundConnect53212173564122
firstReactRender28217393041
getState187164281464
initialActions205124
loadScripts1255109215648113061400
setupStore187241281474
numNetworkReqs1256517762
WebpackPower User HomeuiStartup28902259458465630324475
load14701179277540415162534
domContentLoaded14701178277540415152534
domInteractive103324529498387
firstPaint------
backgroundConnect138311305195122281
firstReactRender5938189166182
getState26427979217367796
initialActions4058827
loadScripts13941153262932214592379
setupStore1316693163160575
numNetworkReqs101552616182244
📊 Page Load Benchmark Results

Current Commit: 6796f22 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.00s (±68ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 698ms (±64ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.00s 68ms 962ms 1.29s 1.23s 1.29s
domContentLoaded 698ms 64ms 664ms 950ms 917ms 950ms
firstPaint 77ms 12ms 64ms 184ms 88ms 184ms
firstContentfulPaint 77ms 12ms 64ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@Battambang
Battambang added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 3160a77 Dec 1, 2025
179 of 182 checks passed
@Battambang
Battambang deleted the chore/bitcoin-bump-1.8.0 branch December 1, 2025 15:57
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-XS team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants