Skip to content

ci: turn on the Triage and Retry System by default (no retry-ci label needed) - #44956

Merged
HowardBraham merged 2 commits into
mainfrom
mq-retry
Jul 29, 2026
Merged

HowardBraham merged 2 commits into
mainfrom
mq-retry

Conversation

@HowardBraham

@HowardBraham HowardBraham commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

In March, I started the Triage and Retry System, and it's been fully operational since April. But it's kind of been in stealth mode, where someone has to apply the retry-ci label for it to work.

While it's been in stealth mode, I've been monitoring the decisions it would make with a custom Sentry dashboard https://metamask.sentry.io/dashboard/521041/?project=4510302346608640, and adjusting .github/rules/retry-config.jsonc so it makes better decisions about when to retry.

Now it has almost 4 months of data, and I'm confident it will make intelligent decisions.

The new rules (applies for both pull requests and Merge Queue runs)

  • If CI fails, decide whether it's a transient error or a deterministic error (.github/rules/retry-config.jsonc)
  • If it's a transient error
    • Retry once automatically, from attempt 1 to attempt 2
    • Adding a retry-ci label allows attempt 3 (which will remove the label), and adding it again allows attempt 4
  • If it's a deterministic error
    • Do not retry

It also handles the edge cases of retry failure, cancellation, manual dequeue, and replaced merge-group entries without rerunning stale CI or leaving merge-queue status pending.

Testing

  • Added unit coverage for the retry-budget decision matrix.
  • Ran a fork-based end-to-end validation campaign through 24 scenarios for PR and merge-queue retries, including automatic retries, label-funded retries, terminal cases, cancellation, manual dequeue, retry API failure handling, replaced merge groups, and successful queue resolution.
  • Verified merge-queue behavior with GitHub workflow, queue, and commit-status APIs.

Changelog

CHANGELOG entry: null

Related issues

Closes: MetaMask/MetaMask-planning#7454


Note

Medium Risk
Changes default CI retry behavior and merge-queue status deferral for all PRs; incorrect classification or budget sync could retry real failures or leave the queue stuck, though policy is centralized and heavily tested.

Overview
Turns on the Triage and Retry System by default for PR and merge-queue runs: retryable (transient) failures on attempt 1 rerun automatically to attempt 2 without the retry-ci label. The label still funds extra retries (attempts 2→3 and 3→4) and is removed only on label-funded reruns, via a shared retry-budget policy used by classify-failures.mts and mirrored in ci-status-gate.yml deferral logic.

Merge queue and stale-run safety: before rerunning failed merge-group jobs, triage verifies the queue entry and temporary ref are still current; stale or unverified entries get a terminal All jobs pass failure instead of a wasted rerun. For pull_request, retries are skipped if the PR head SHA has moved past the failed run.

Classification tuning: retry-config.jsonc adds transient patterns (OIDC expiry, Sonar/GitHub flakes, etc.) and deterministic patterns (ESLint/node-test summaries, Sass, baselines, publish/Storybook denials) so auto-retries target infra flakes, not real breakages.

New unit tests cover the retry-budget matrix and merge-queue verification helpers.

Reviewed by Cursor Bugbot for commit 4ca1e60. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-extension-platform Extension Platform team label Jul 28, 2026
@metamask-ci

metamask-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [15b146e] [reused from 7b6dde7]
⚡ Performance Benchmarks (Total: 🟢 2 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30384097695 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 longTaskTotalDuration(p95) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 doneButtonToAssetList(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions

Benchmarkfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
confirmTx
[Sentry log · main/release]
🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ loadNewAccount/inp: -24%
  • ↑ loadNewAccount/lcp: +1142%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/lcp: +1104%
  • ↑ bridgeUserActions/bridge_load_page: +152%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +94%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/lcp: +1132%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyAccountManagement, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyAssets, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
importSrpHome
[Sentry log · main/release]
–🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -14%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -24%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -83%
  • ↑ onboardingImportWallet/longTaskTotalDuration: +12%
  • ↑ onboardingImportWallet/tbt: +17%
  • ↓ onboardingImportWallet/total: -41%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -21%
  • ↑ onboardingNewWallet/doneButtonToAssetList: +13%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +17%
  • ↑ onboardingNewWallet/total: +12%
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

@HowardBraham
HowardBraham marked this pull request as draft July 28, 2026 18:01
@HowardBraham
HowardBraham marked this pull request as ready for review July 28, 2026 19:34
@metamask-ci

metamask-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [edc526b] [reused from a738050]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30392533852 | Baseline logs

Metricschrome-webpack
onboardingNewWallet
[Sentry log · main/release]
🔴 agreeButtonToOnboardingSuccess(p95) [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions, firefox/webpack/interactionUserActions

✅ No regressions detected

Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, chrome/webpack/startupPowerUserHome, firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API 🔴 1

⚠️ Missing data: chrome/webpack/userJourneyOnboardingImport, chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyAccountManagement, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyOnboardingImport, firefox/webpack/userJourneyOnboardingNew, firefox/webpack/userJourneyAssets, firefox/webpack/userJourneyAccountManagement, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpack
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +12%
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

@github-actions github-actions Bot added size-L and removed size-M labels Jul 28, 2026
Comment thread .github/scripts/shared/retry-budget.mts Resolved
@metamask-ci

metamask-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d8ad6db] [reused from a738050]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 6 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30395356000 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 doneButtonToHomeScreen(p75) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 agreeButtonToOnboardingSuccess(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ bridgeUserActions/bridge_load_page: +93%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +23%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↑ loadNewAccount/load_new_account: +17%
  • ↑ loadNewAccount/total: +17%
  • ↑ loadNewAccount/lcp: +1157%
  • ↑ confirmTx/confirm_tx: +13%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +13%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1263%
  • ↑ bridgeUserActions/bridge_load_page: +186%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +92%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +174%
  • ↓ bridgeUserActions/fcp: -46%
  • ↑ bridgeUserActions/lcp: +1179%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +50%
  • ↑ startupStandardHome/fcp: +52%
  • ↑ startupPowerUserHome/domInteractive: +11%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↓ startupPowerUserHome/setupStore: -74%
  • ↑ startupPowerUserHome/inp: +14%
  • ↑ startupPowerUserHome/fcp: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 216ms
  • 🟡 startupPowerUserHome/LCP: p75 3.1s
User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
–🟢 [CI log]
swap
[Sentry log · main/release]
–🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/doneButtonToHomeScreen: +21%
  • ↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +44%
  • ↑ onboardingImportWallet/longTaskCount: +29%
  • ↑ onboardingImportWallet/longTaskTotalDuration: +13%
  • ↑ onboardingImportWallet/tbt: +19%
  • ↑ onboardingImportWallet/total: +25%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +12%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/inp: +11%
  • ↑ solanaAssetDetails/fcp: +12%
  • ↑ importSrpHome/homeAfterImportWithNewWallet: +23%
  • ↑ importSrpHome/total: +22%
  • ↓ importSrpHome/cls: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 336ms
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/LCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d8ad6db. Configure here.

@metamask-ci

metamask-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cf48d08] [reused from a738050]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 6 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30396103614 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 doneButtonToHomeScreen(p75) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 agreeButtonToOnboardingSuccess(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ bridgeUserActions/bridge_load_page: +93%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +23%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↑ loadNewAccount/load_new_account: +17%
  • ↑ loadNewAccount/total: +17%
  • ↑ loadNewAccount/lcp: +1157%
  • ↑ confirmTx/confirm_tx: +13%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +13%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1263%
  • ↑ bridgeUserActions/bridge_load_page: +186%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +92%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +174%
  • ↓ bridgeUserActions/fcp: -46%
  • ↑ bridgeUserActions/lcp: +1179%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +50%
  • ↑ startupStandardHome/fcp: +52%
  • ↑ startupPowerUserHome/domInteractive: +11%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↓ startupPowerUserHome/setupStore: -74%
  • ↑ startupPowerUserHome/inp: +14%
  • ↑ startupPowerUserHome/fcp: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 216ms
  • 🟡 startupPowerUserHome/LCP: p75 3.1s
User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
–🟢 [CI log]
swap
[Sentry log · main/release]
–🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/doneButtonToHomeScreen: +21%
  • ↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +44%
  • ↑ onboardingImportWallet/longTaskCount: +29%
  • ↑ onboardingImportWallet/longTaskTotalDuration: +13%
  • ↑ onboardingImportWallet/tbt: +19%
  • ↑ onboardingImportWallet/total: +25%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +12%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/inp: +11%
  • ↑ solanaAssetDetails/fcp: +12%
  • ↑ importSrpHome/homeAfterImportWithNewWallet: +23%
  • ↑ importSrpHome/total: +22%
  • ↓ importSrpHome/cls: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 336ms
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/LCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

itsyoboieltr
itsyoboieltr previously approved these changes Jul 28, 2026
// deferred status would never post — leaving the queue stuck. Instead, post on
// any merge_group where we won't retry. If the gate didn't actually defer, this
// posts a redundant failure status — harmless, since ci-status-gate already
// posted one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull-request retries bypass the new freshness guard. If commit A fails and commit B is pushed before triage reruns commit A, GitHub retains commit A’s original GITHUB_REF; main.yml groups PR runs by that ref with cancel-in-progress, so the stale rerun can cancel commit B’s current CI. Commit B can then remain without a terminal All jobs pass status. Add an open/current-head check against HEAD_SHA, which should be analogous to the merge-queue verification.

with Love,
Codex 5.6 Sol Extra-High

@metamask-ci

metamask-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4ca1e60] [reused from 7dce891]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 30487792094 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 openAccountMenuToAccountListLoaded(p95) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 doneButtonToAssetList(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🔴 bridge_load_page

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +18%
  • ↑ loadNewAccount/total: +18%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +32%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↑ loadNewAccount/load_new_account: +22%
  • ↑ loadNewAccount/total: +22%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -46%
  • ↑ loadNewAccount/lcp: +1115%
  • ↑ confirmTx/confirm_tx: +12%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +12%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +10%
  • ↑ confirmTx/lcp: +1179%
  • ↑ bridgeUserActions/bridge_load_page: +1937%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +60%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +180%
  • ↓ bridgeUserActions/inp: -15%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +1196%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/numNetworkReqs: -17%
User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyAccountManagement, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
importSrpHome
[Sentry log · main/release]
🟡 [CI log]
🟡 total
–
assetDetails
[Sentry log · main/release]
–🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
–🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -16%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -15%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -15%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -19%
  • ↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +141%
  • ↓ onboardingImportWallet/longTaskCount: -14%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -35%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -20%
  • ↓ onboardingImportWallet/tbt: -31%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -13%
  • ↑ onboardingNewWallet/doneButtonToAssetList: +13%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +19%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -12%
  • ↑ onboardingNewWallet/tbt: +16%
  • ↑ onboardingNewWallet/total: +12%
  • ↑ importSrpHome/homeAfterImportWithNewWallet: +32%
  • ↑ importSrpHome/longTaskCount: +13%
  • ↑ importSrpHome/total: +31%
  • ↓ importSrpHome/cls: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 320ms
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

@davidmurdoch davidmurdoch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my robot says its good.

@HowardBraham
HowardBraham added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit 9b623cc Jul 29, 2026
53 checks passed
@HowardBraham
HowardBraham deleted the mq-retry branch July 29, 2026 23:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
@github-actions github-actions Bot removed the skip-e2e Skip E2E test jobs label Jul 29, 2026
@metamaskbot metamaskbot added the release-13.43.0 Issue or pull request that will be included in release 13.43.0 label Jul 29, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 4ca1e600 Deployed Jul 29, 2026 by HowardBraham via Publish prerelease / Publish prerelease #155578
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.43.0 Issue or pull request that will be included in release 13.43.0 risk:medium size-L skip-release-validation team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants