Skip to content

test: fix flaky test Perps Take Profit / Stop Loss simulates take-profit fill: TP set on ETH long then stream clears the position - #45323

Closed
seaona wants to merge 6 commits into
mainfrom
flaky-perps-profit
Closed

seaona wants to merge 6 commits into
mainfrom
flaky-perps-profit

Conversation

@seaona

@seaona seaona commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Description

The test failed because Perps home rendered "Recent activity — No transactions yet" instead of the populated list.

The Perps close-fill E2E flow could only learn about the simulated fill from a single live WebSocket frame, which is dropped whenever no Perps view is mounted during the back-navigation to Perps home, and nothing recovered it afterwards because userFills POSTs fell through to a catch-all mock returning {} and home's Recent Activity reused a coalesced snapshot taken at startup, so "See All" never rendered and the test timed out.

Fixes:

  • the mock server now records each pushed fill and replays it for userFills POSTs (reset per test via onCleanup)
  • the flow opens Perps Activity directly by route instead of via home, since that page fetches with forceFreshOnMount and therefore always queries the wire, making the assertion independent of WebSocket timing.

See artifact:
image

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. ci was triggered with the e2e quality gate (changing the affected test) to verify the fix

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
E2E test and mock-server changes only; no production app behavior is modified.

Overview
Addresses flaky Perps Take Profit / Stop Loss E2E where Activity never showed the simulated close fill because the test relied on a live userFills WebSocket frame and navigation through Perps home (empty/stale Recent Activity, no “See All”).

The perps WS mock now records fills from pushUserFillsClosePositionSnapshot and replies to userFills info POSTs with that snapshot (shared across position mock bundles), with resetPushedUserFills on perps WS onCleanup so state does not leak between tests.

assertPerpsActivityShowsCloseFill drops the back-nav → home → “See All” path and opens Perps Activity directly via PERPS_ACTIVITY_ROUTE, so the assertion uses a fresh userFills fetch instead of racing the stream against home’s coalesced preview.

The suite describe title was changed to append TEST (likely accidental debug naming).

Reviewed by Cursor Bugbot for commit 974160b. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci metamask-ci Bot added the team-qa QA team label Aug 7, 2026
@metamask-ci

metamask-ci Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (4 files, +71 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📁 perps/
            • 📄 perps-activity-page.ts +13 -0
            • 📄 perps-market-list-page.ts +13 -0
      • 📁 tests/
        • 📁 perps/
          • 📁 mocks/
            • 📄 websocketPositionMocks.ts +44 -0
            • 📄 perps-tpsl.spec.ts +1 -1

🧪 @MetaMask/qa (4 files, +66 -9)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 flows/
          • 📄 perps-activity-close-fill.flow.ts +23 -8
        • 📁 pages/
          • 📁 home/
            • 📄 perps-tab.ts +17 -1
          • 📁 perps/
            • 📄 perps-activity-page.ts +13 -0
            • 📄 perps-market-list-page.ts +13 -0

@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [df20e83] [reused from f1790c6]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31189146219 | Baseline logs

Metricschrome-webpack
onboardingNewWallet
[Sentry log · main/release]
🔴 longTaskTotalDuration(p95) [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5

⚠️ Missing data: chrome/webpack/interactionUserActions, firefox/webpack/interactionUserActions

✅ No regressions detected

Startup Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/startupStandardHome, chrome/webpack/startupPowerUserHome, firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

✅ No regressions detected

User Journey Benchmarks · Samples: 5 · mock API 🔴 1

⚠️ Missing data: chrome/webpack/userJourneyOnboardingImport, chrome/webpack/userJourneyAssets, chrome/webpack/userJourneyAccountManagement, chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyOnboardingImport, firefox/webpack/userJourneyOnboardingNew, firefox/webpack/userJourneyAssets, firefox/webpack/userJourneyAccountManagement, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpack
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -14%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -17%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +12%
  • ↑ onboardingNewWallet/tbt: +51%
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

@seaona seaona self-assigned this Aug 7, 2026
@seaona seaona added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed flaky tests labels Aug 7, 2026
@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [ea9ae88]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 14 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31192264463 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 srpButtonToSrpForm(p95) [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🔴 bridge_load_asset_picker

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +19%
  • ↑ loadNewAccount/total: +19%
  • ↑ loadNewAccount/inp: +29%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ confirmTx/longTaskMaxDuration: +48%
  • ↓ confirmTx/tbt: -17%
  • ↑ confirmTx/inp: +21%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +32%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +63%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +22%
  • ↓ bridgeUserActions/tbt: -11%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ loadNewAccount/load_new_account: +21%
  • ↑ loadNewAccount/total: +21%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -47%
  • ↑ loadNewAccount/lcp: +1426%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↑ confirmTx/lcp: +1164%
  • ↑ bridgeUserActions/bridge_load_page: +358%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +1280%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +217%
  • ↓ bridgeUserActions/inp: -15%
  • ↑ bridgeUserActions/lcp: +1173%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↑ startupStandardHome/setupStore: +131%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↑ startupPowerUserHome/uiStartup: +17%
  • ↑ startupPowerUserHome/load: +35%
  • ↑ startupPowerUserHome/domContentLoaded: +35%
  • ↑ startupPowerUserHome/domInteractive: +31%
  • ↑ startupPowerUserHome/backgroundConnect: +51%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↑ startupPowerUserHome/loadScripts: +36%
  • ↑ startupPowerUserHome/setupStore: +233%
  • ↑ startupPowerUserHome/fcp: +25%
  • ↑ startupPowerUserHome/lcp: +34%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.9s
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +28%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +18%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -43%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -79%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -12%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -56%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -89%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +260%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +260%
  • ↑ solanaAssetDetails/inp: +19%
  • ↑ solanaAssetDetails/fcp: +13%
  • ↓ importSrpHome/loginToHomeScreen: -18%
  • ↓ importSrpHome/longTaskCount: -37%
  • ↓ importSrpHome/longTaskTotalDuration: -46%
  • ↓ importSrpHome/longTaskMaxDuration: -25%
  • ↓ importSrpHome/tbt: -54%
  • ↓ importSrpHome/inp: -30%
  • ↑ importSrpHome/cls: +484%
  • ↓ sendTransactions/openSendPageFromHome: -28%
  • ↑ sendTransactions/selectTokenToSendFormLoaded: +122%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -97%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -94%
  • ↓ sendTransactions/inp: -30%
  • ↓ sendTransactions/lcp: -61%
  • ↑ sendTransactions/cls: +171%
  • ↑ swap/openSwapPageFromHome: +247%
  • ↑ swap/fetchAndDisplaySwapQuotes: +119%
  • ↑ swap/longTaskCount: +33%
  • ↑ swap/longTaskTotalDuration: +15%
  • ↑ swap/longTaskMaxDuration: +20%
  • ↑ swap/total: +119%
  • ↓ swap/lcp: -67%
  • ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 216ms
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 2.1s
  • 🟡 swap/FCP: p75 2.2s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13.94 KiB (0.09%)
  • ui: 13.63 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1.91 KiB (0.1%)
  • zip: 5.57 KiB (0.03%)

@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7e8aea6] [reused from ea9ae88]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 14 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31194978941 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 srpButtonToSrpForm(p95) [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🔴 bridge_load_asset_picker

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +19%
  • ↑ loadNewAccount/total: +19%
  • ↑ loadNewAccount/inp: +29%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ confirmTx/longTaskMaxDuration: +48%
  • ↓ confirmTx/tbt: -17%
  • ↑ confirmTx/inp: +21%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +32%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +63%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +22%
  • ↓ bridgeUserActions/tbt: -11%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ loadNewAccount/load_new_account: +21%
  • ↑ loadNewAccount/total: +21%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -47%
  • ↑ loadNewAccount/lcp: +1426%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↑ confirmTx/lcp: +1164%
  • ↑ bridgeUserActions/bridge_load_page: +358%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +1280%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +217%
  • ↓ bridgeUserActions/inp: -15%
  • ↑ bridgeUserActions/lcp: +1173%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↑ startupStandardHome/setupStore: +131%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↑ startupPowerUserHome/uiStartup: +17%
  • ↑ startupPowerUserHome/load: +35%
  • ↑ startupPowerUserHome/domContentLoaded: +35%
  • ↑ startupPowerUserHome/domInteractive: +31%
  • ↑ startupPowerUserHome/backgroundConnect: +51%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↑ startupPowerUserHome/loadScripts: +36%
  • ↑ startupPowerUserHome/setupStore: +233%
  • ↑ startupPowerUserHome/fcp: +25%
  • ↑ startupPowerUserHome/lcp: +34%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.9s
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +28%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +18%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +22%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -43%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -79%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -12%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -56%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -89%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +260%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +260%
  • ↑ solanaAssetDetails/inp: +19%
  • ↑ solanaAssetDetails/fcp: +13%
  • ↓ importSrpHome/loginToHomeScreen: -18%
  • ↓ importSrpHome/longTaskCount: -37%
  • ↓ importSrpHome/longTaskTotalDuration: -46%
  • ↓ importSrpHome/longTaskMaxDuration: -25%
  • ↓ importSrpHome/tbt: -54%
  • ↓ importSrpHome/inp: -30%
  • ↑ importSrpHome/cls: +484%
  • ↓ sendTransactions/openSendPageFromHome: -28%
  • ↑ sendTransactions/selectTokenToSendFormLoaded: +122%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -97%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -94%
  • ↓ sendTransactions/inp: -30%
  • ↓ sendTransactions/lcp: -61%
  • ↑ sendTransactions/cls: +171%
  • ↑ swap/openSwapPageFromHome: +247%
  • ↑ swap/fetchAndDisplaySwapQuotes: +119%
  • ↑ swap/longTaskCount: +33%
  • ↑ swap/longTaskTotalDuration: +15%
  • ↑ swap/longTaskMaxDuration: +20%
  • ↑ swap/total: +119%
  • ↓ swap/lcp: -67%
  • ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 216ms
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 2.1s
  • 🟡 swap/FCP: p75 2.2s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13.94 KiB (0.09%)
  • ui: 13.63 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1.91 KiB (0.1%)
  • zip: 5.57 KiB (0.03%)

@seaona
seaona marked this pull request as ready for review August 7, 2026 16:28
@seaona
seaona requested review from a team as code owners August 7, 2026 16:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 974160b. Configure here.

} from './mocks/websocketPositionMocks';

describe('Perps Take Profit / Stop Loss', function (this: Suite) {
describe('Perps Take Profit / Stop Loss TEST', function (this: Suite) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental TEST in suite name

Medium Severity

The suite title was renamed to Perps Take Profit / Stop Loss TEST. That looks like a leftover from forcing the E2E quality gate rather than an intentional rename — the file header and PR title still use the original name.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 974160b. Configure here.

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [974160b]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 15 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31197605216 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +18%
  • ↑ loadNewAccount/total: +18%
  • ↓ confirmTx/longTaskTotalDuration: -20%
  • ↑ confirmTx/longTaskMaxDuration: +34%
  • ↓ confirmTx/tbt: -34%
  • ↑ bridgeUserActions/bridge_load_page: +25%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +53%
  • ↓ bridgeUserActions/longTaskCount: -44%
  • ↓ bridgeUserActions/longTaskTotalDuration: -42%
  • ↓ bridgeUserActions/longTaskMaxDuration: -15%
  • ↓ bridgeUserActions/tbt: -45%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ loadNewAccount/load_new_account: +21%
  • ↑ loadNewAccount/total: +21%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -55%
  • ↑ loadNewAccount/lcp: +1160%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +142%
  • ↑ confirmTx/lcp: +1174%
  • ↑ bridgeUserActions/bridge_load_page: +165%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +66%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +19%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -42%
  • ↑ bridgeUserActions/lcp: +1138%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 confirmTx/INP: p75 256ms
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -32%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -30%
  • ↓ startupStandardHome/firstPaint: -21%
  • ↓ startupStandardHome/backgroundConnect: -35%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -42%
  • ↓ startupStandardHome/longTaskMaxDuration: -37%
  • ↓ startupStandardHome/tbt: -45%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -23%
  • ↓ startupStandardHome/domInteractive: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↑ startupPowerUserHome/uiStartup: +10%
  • ↑ startupPowerUserHome/load: +14%
  • ↑ startupPowerUserHome/domContentLoaded: +14%
  • ↑ startupPowerUserHome/domInteractive: +22%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↑ startupPowerUserHome/loadScripts: +14%
  • ↑ startupPowerUserHome/setupStore: +287%
  • ↑ startupPowerUserHome/fcp: +20%
  • ↑ startupPowerUserHome/lcp: +28%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +32%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +11%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +12%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -78%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -50%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -81%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -16%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -53%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -93%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +271%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +271%
  • ↑ solanaAssetDetails/inp: +19%
  • ↑ solanaAssetDetails/fcp: +24%
  • ↓ importSrpHome/loginToHomeScreen: -30%
  • ↓ importSrpHome/homeAfterImportWithNewWallet: -34%
  • ↓ importSrpHome/longTaskCount: -65%
  • ↓ importSrpHome/longTaskTotalDuration: -65%
  • ↓ importSrpHome/longTaskMaxDuration: -42%
  • ↓ importSrpHome/tbt: -65%
  • ↓ importSrpHome/total: -33%
  • ↓ importSrpHome/inp: -33%
  • ↓ importSrpHome/lcp: -17%
  • ↑ importSrpHome/cls: +484%
  • ↓ sendTransactions/openSendPageFromHome: -18%
  • ↑ sendTransactions/selectTokenToSendFormLoaded: +145%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -98%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -93%
  • ↓ sendTransactions/inp: -26%
  • ↑ sendTransactions/fcp: +12%
  • ↓ sendTransactions/lcp: -62%
  • ↑ sendTransactions/cls: +171%
  • ↑ swap/openSwapPageFromHome: +212%
  • ↑ swap/fetchAndDisplaySwapQuotes: +119%
  • ↑ swap/longTaskCount: +33%
  • ↑ swap/longTaskTotalDuration: +25%
  • ↑ swap/longTaskMaxDuration: +31%
  • ↑ swap/tbt: +26%
  • ↑ swap/total: +120%
  • ↓ swap/lcp: -72%
  • ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🔴 sendTransactions/INP: p75 744ms
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🔴 swap/INP: p75 768ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13.94 KiB (0.09%)
  • ui: 13.67 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1.91 KiB (0.1%)
  • zip: 5.58 KiB (0.03%)

@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [974160b]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 15 warn · 🔴 1 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31197605216 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +18%
  • ↑ loadNewAccount/total: +18%
  • ↓ confirmTx/longTaskTotalDuration: -20%
  • ↑ confirmTx/longTaskMaxDuration: +34%
  • ↓ confirmTx/tbt: -34%
  • ↑ bridgeUserActions/bridge_load_page: +25%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +53%
  • ↓ bridgeUserActions/longTaskCount: -44%
  • ↓ bridgeUserActions/longTaskTotalDuration: -42%
  • ↓ bridgeUserActions/longTaskMaxDuration: -15%
  • ↓ bridgeUserActions/tbt: -45%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ loadNewAccount/load_new_account: +21%
  • ↑ loadNewAccount/total: +21%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -55%
  • ↑ loadNewAccount/lcp: +1160%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +142%
  • ↑ confirmTx/lcp: +1174%
  • ↑ bridgeUserActions/bridge_load_page: +165%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +66%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +19%
  • ↓ bridgeUserActions/inp: -15%
  • ↓ bridgeUserActions/fcp: -42%
  • ↑ bridgeUserActions/lcp: +1138%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 confirmTx/INP: p75 256ms
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -32%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -30%
  • ↓ startupStandardHome/firstPaint: -21%
  • ↓ startupStandardHome/backgroundConnect: -35%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -32%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -42%
  • ↓ startupStandardHome/longTaskMaxDuration: -37%
  • ↓ startupStandardHome/tbt: -45%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -23%
  • ↓ startupStandardHome/domInteractive: -19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↑ startupPowerUserHome/uiStartup: +10%
  • ↑ startupPowerUserHome/load: +14%
  • ↑ startupPowerUserHome/domContentLoaded: +14%
  • ↑ startupPowerUserHome/domInteractive: +22%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↑ startupPowerUserHome/loadScripts: +14%
  • ↑ startupPowerUserHome/setupStore: +287%
  • ↑ startupPowerUserHome/fcp: +20%
  • ↑ startupPowerUserHome/lcp: +28%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +32%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +11%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +12%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -78%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -50%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -81%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -16%
  • ↓ onboardingNewWallet/longTaskCount: -38%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -53%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -93%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +271%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +271%
  • ↑ solanaAssetDetails/inp: +19%
  • ↑ solanaAssetDetails/fcp: +24%
  • ↓ importSrpHome/loginToHomeScreen: -30%
  • ↓ importSrpHome/homeAfterImportWithNewWallet: -34%
  • ↓ importSrpHome/longTaskCount: -65%
  • ↓ importSrpHome/longTaskTotalDuration: -65%
  • ↓ importSrpHome/longTaskMaxDuration: -42%
  • ↓ importSrpHome/tbt: -65%
  • ↓ importSrpHome/total: -33%
  • ↓ importSrpHome/inp: -33%
  • ↓ importSrpHome/lcp: -17%
  • ↑ importSrpHome/cls: +484%
  • ↓ sendTransactions/openSendPageFromHome: -18%
  • ↑ sendTransactions/selectTokenToSendFormLoaded: +145%
  • ↓ sendTransactions/reviewTransactionToConfirmationPage: -98%
  • ↓ sendTransactions/longTaskCount: -100%
  • ↓ sendTransactions/longTaskTotalDuration: -100%
  • ↓ sendTransactions/longTaskMaxDuration: -100%
  • ↓ sendTransactions/tbt: -100%
  • ↓ sendTransactions/total: -93%
  • ↓ sendTransactions/inp: -26%
  • ↑ sendTransactions/fcp: +12%
  • ↓ sendTransactions/lcp: -62%
  • ↑ sendTransactions/cls: +171%
  • ↑ swap/openSwapPageFromHome: +212%
  • ↑ swap/fetchAndDisplaySwapQuotes: +119%
  • ↑ swap/longTaskCount: +33%
  • ↑ swap/longTaskTotalDuration: +25%
  • ↑ swap/longTaskMaxDuration: +31%
  • ↑ swap/tbt: +26%
  • ↑ swap/total: +120%
  • ↓ swap/lcp: -72%
  • ↓ swap/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 swap/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 2.0s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🔴 sendTransactions/INP: p75 744ms
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🔴 swap/INP: p75 768ms
  • 🟡 swap/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13.94 KiB (0.09%)
  • ui: 13.67 KiB (0.07%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 1.91 KiB (0.1%)
  • zip: 5.58 KiB (0.03%)

@seaona
seaona marked this pull request as draft August 7, 2026 17:33
@metamask-ci

metamask-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d995e63] [reused from bc18c5c]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 11 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31203505266 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 srpButtonToSrpForm(p95) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 longTaskCount(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +18%
  • ↑ loadNewAccount/total: +18%
  • ↑ loadNewAccount/inp: +14%
  • ↓ confirmTx/longTaskTotalDuration: -11%
  • ↑ confirmTx/longTaskMaxDuration: +47%
  • ↓ confirmTx/tbt: -19%
  • ↑ confirmTx/fcp: +13%
  • ↑ bridgeUserActions/bridge_load_page: +13%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +220%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskMaxDuration: -14%
  • ↓ bridgeUserActions/tbt: -41%
  • ↑ bridgeUserActions/total: +26%
  • ↑ bridgeUserActions/inp: +15%
  • ↑ bridgeUserActions/fcp: +13%
  • ↓ loadNewAccount/inp: -39%
  • ↓ loadNewAccount/fcp: -69%
  • ↑ loadNewAccount/lcp: +860%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -65%
  • ↑ confirmTx/lcp: +997%
  • ↑ bridgeUserActions/bridge_load_page: +143%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +42%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +11%
  • ↓ bridgeUserActions/inp: -31%
  • ↓ bridgeUserActions/fcp: -84%
  • ↑ bridgeUserActions/lcp: +812%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↑ startupStandardHome/domInteractive: +47%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↑ startupStandardHome/fcp: +49%
  • ↑ startupStandardHome/lcp: +10%
  • ↓ startupPowerUserHome/uiStartup: -20%
  • ↓ startupPowerUserHome/backgroundConnect: -12%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↓ startupPowerUserHome/setupStore: -72%
  • ↓ startupPowerUserHome/inp: -11%
  • ↓ startupPowerUserHome/lcp: -11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.6s
User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
–🟡 [CI log]
swap
[Sentry log · main/release]
–🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -34%
  • ↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +29%
  • ↑ onboardingImportWallet/longTaskCount: +43%
  • ↓ onboardingImportWallet/total: -21%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -10%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -19%
  • ↑ onboardingNewWallet/longTaskCount: +25%
  • ↑ onboardingNewWallet/longTaskTotalDuration: +12%
  • ↑ onboardingNewWallet/tbt: +73%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +288%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +288%
  • ↑ solanaAssetDetails/inp: +27%
  • ↑ solanaAssetDetails/fcp: +22%
  • ↑ importSrpHome/homeAfterImportWithNewWallet: +31%
  • ↑ importSrpHome/longTaskCount: +20%
  • ↓ importSrpHome/longTaskMaxDuration: -39%
  • ↑ importSrpHome/total: +28%
  • ↑ importSrpHome/inp: +17%
  • ↓ importSrpHome/cls: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/INP: p75 360ms
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 assetDetails/LCP: p75 2.7s
  • 🟡 solanaAssetDetails/FCP: p75 2.1s
  • 🟡 solanaAssetDetails/LCP: p75 2.7s
  • 🟡 sendTransactions/FCP: p75 2.0s
  • 🟡 sendTransactions/LCP: p75 2.7s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -59%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 0 Bytes (0%)

if (await activityPage.isAnyTransactionCardPresent()) {
return true;
}
pushUserFills();

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-push until the fill lands. A userFills snapshot both replaces the controller's fills cache and notifies live subscribers, but neither helps if it arrives while a view is mid-mount: the cache read happens once, and the live subscriber is not registered yet. The controller then answers perpsGetOrderFills from that initialized-but-empty cache without ever going to the wire, so nothing retries on its own. Pushing again once the view is up is delivered straight to the mounted subscriber. Snapshots replace rather than append, so repeating one is harmless.

@metamask-ci

metamask-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5fa1a5b] [reused from d1029ef]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 12 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 31366705583 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 srpButtonToSrpForm(p95) [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🔴 longTaskMaxDuration(p95) [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]
🟡 load_new_account
🟡 [CI log]
🟡 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +18%
  • ↑ loadNewAccount/total: +18%
  • ↑ loadNewAccount/inp: +14%
  • ↓ confirmTx/longTaskTotalDuration: -18%
  • ↑ confirmTx/longTaskMaxDuration: +36%
  • ↓ confirmTx/tbt: -31%
  • ↑ bridgeUserActions/bridge_load_page: +19%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +70%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↑ bridgeUserActions/longTaskTotalDuration: +25%
  • ↑ bridgeUserActions/tbt: +57%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ loadNewAccount/load_new_account: +21%
  • ↑ loadNewAccount/total: +21%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/fcp: +14%
  • ↑ loadNewAccount/lcp: +1175%
  • ↑ confirmTx/confirm_tx: +14%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +14%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -47%
  • ↑ confirmTx/lcp: +1378%
  • ↑ bridgeUserActions/bridge_load_page: +235%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +188%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +27%
  • ↓ bridgeUserActions/inp: -15%
  • ↑ bridgeUserActions/fcp: +15%
  • ↑ bridgeUserActions/lcp: +1245%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
–🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/firstPaint: +12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↑ startupStandardHome/setupStore: +14%
  • ↓ startupStandardHome/numNetworkReqs: -14%
  • ↓ startupStandardHome/uiStartup: -23%
  • ↓ startupStandardHome/load: -17%
  • ↓ startupStandardHome/domContentLoaded: -17%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -17%
  • ↓ startupStandardHome/setupStore: -19%
  • ↓ startupStandardHome/numNetworkReqs: -13%
  • ↓ startupStandardHome/lcp: -16%
  • ↑ startupPowerUserHome/load: +14%
  • ↑ startupPowerUserHome/domContentLoaded: +14%
  • ↑ startupPowerUserHome/domInteractive: +32%
  • ↑ startupPowerUserHome/backgroundConnect: +48%
  • ↓ startupPowerUserHome/firstReactRender: -99%
  • ↑ startupPowerUserHome/initialActions: +11%
  • ↑ startupPowerUserHome/loadScripts: +15%
  • ↑ startupPowerUserHome/setupStore: +272%
  • ↑ startupPowerUserHome/fcp: +29%
  • ↑ startupPowerUserHome/lcp: +18%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.4s
User Journey Benchmarks · Samples: 5 · mock API 🔴 4

⚠️ Missing data: chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 doneButtonToHomeScreen
🔴 total
🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🔴 [CI log]
🔴 total
🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
🟡 assetClickToPriceChart
importSrpHome
[Sentry log · main/release]
🟡 [CI log]
🟡 total
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +14%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -11%
  • ↑ onboardingImportWallet/doneButtonToHomeScreen: +25%
  • ↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +202%
  • ↑ onboardingImportWallet/longTaskCount: +43%
  • ↑ onboardingImportWallet/longTaskTotalDuration: +12%
  • ↑ onboardingImportWallet/tbt: +20%
  • ↑ onboardingImportWallet/total: +73%
  • ↑ onboardingNewWallet/tbt: +27%
  • ↑ solanaAssetDetails/assetClickToPriceChart: +270%
  • ↓ solanaAssetDetails/longTaskCount: -100%
  • ↓ solanaAssetDetails/longTaskTotalDuration: -100%
  • ↓ solanaAssetDetails/longTaskMaxDuration: -100%
  • ↓ solanaAssetDetails/tbt: -100%
  • ↑ solanaAssetDetails/total: +270%
  • ↑ solanaAssetDetails/inp: +27%
  • ↑ solanaAssetDetails/fcp: +23%
  • ↑ importSrpHome/loginToHomeScreen: +37%
  • ↑ importSrpHome/homeAfterImportWithNewWallet: +31%
  • ↑ importSrpHome/longTaskCount: +34%
  • ↑ importSrpHome/longTaskTotalDuration: +20%
  • ↑ importSrpHome/total: +31%
  • ↑ importSrpHome/inp: +17%
  • ↑ importSrpHome/lcp: +21%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/INP: p75 360ms
  • 🟡 assetDetails/FCP: p75 2.1s
  • 🟡 assetDetails/LCP: p75 2.7s
  • 🟡 solanaAssetDetails/FCP: p75 2.1s
  • 🟡 solanaAssetDetails/LCP: p75 2.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -58%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle size diffs
  • background: -2 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: -39 Bytes (0%)

@seaona seaona closed this Aug 10, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 5fa1a5b6 Deployed Aug 10, 2026 by seaona via Publish prerelease / Publish prerelease #157704
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed risk:low size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant