Skip to content

feat: adopt SentinelApiService for transaction simulation - #47487

Merged
matthewwalsh0 merged 4 commits into
mainfrom
feat/adopt-sentinel-simulation
Nov 12, 2026
Merged

matthewwalsh0 merged 4 commits into
mainfrom
feat/adopt-sentinel-simulation

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Description

Adopts MetaMask/core#9476. With it, TransactionController sends all Sentinel simulation requests through the SentinelApiService:simulateTransactions messenger action.

  • Bumps @metamask/transaction-controller from 72.3.0 to ^73.1.2. @metamask/wallet@21.0.0 already delegates SentinelApiService:simulateTransactions to the TransactionController messenger.
  • getSimulationConfig now returns only { newUrl }. SentinelApiService adds the bearer token itself via AuthenticationController:getBearerToken.

SentinelApiService is already registered on the root messenger, so no further wiring is needed.

Changelog

CHANGELOG entry: null

Related issues

Refs: MetaMask/core#9476

Manual testing steps

  1. Enable transaction simulations.
  2. Start a send or dapp transaction and check that simulation balance changes are shown.
  3. With an active Shield subscription, check that simulation requests go to the Shield gateway with an Authorization header.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes transaction simulation wiring and Shield gateway config shape during signing; dependency bump affects a core controller path.

Overview
Upgrades @metamask/transaction-controller to ^73.1.2 so Sentinel simulation runs through SentinelApiService:simulateTransactions instead of the controller calling fetch directly.

getSimulationConfig in wallet init now returns only { newUrl } from Shield gateway resolution; bearer tokens are no longer passed through this hook because the new service obtains them via AuthenticationController:getBearerToken. A unit test asserts that behavior.

LavaMoat policies are updated for the new dependency graph (@metamask/sentinel-api-service, tighter uuid crypto globals, no fetch on @metamask/transaction-controller). E2E simulation mocks use request id 1 instead of 0 to match the updated simulation RPC flow.

Reviewed by Cursor Bugbot for commit 6eead18. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci metamask-ci Bot added the team-confirmations Push issues to confirmations team label Oct 29, 2026
@socket-security

socket-security Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​transaction-controller@​72.3.0 ⏵ 73.1.298 +110081100 +1100

View full report

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (8 files, +24 -16)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +3 -2
        • 📁 experimental/
          • 📄 policy.json +3 -2
        • 📁 flask/
          • 📄 policy.json +3 -2
        • 📁 main/
          • 📄 policy.json +3 -2
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +3 -2
        • 📁 experimental/
          • 📄 policy.json +3 -2
        • 📁 flask/
          • 📄 policy.json +3 -2
        • 📁 main/
          • 📄 policy.json +3 -2

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3679919]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40880942777 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +13%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +107%
  • ↑ confirmTx/tbt: +129%
  • ↑ confirmTx/fcp: +16%
  • ↑ confirmTx/lcp: +10%
  • ↑ bridgeUserActions/bridge_load_page: +133%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +138%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +113%
  • ↑ bridgeUserActions/longTaskMaxDuration: +48%
  • ↑ bridgeUserActions/tbt: +214%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1316%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +191%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +136%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1270%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -38%
  • ↓ startupStandardHome/load: -34%
  • ↓ startupStandardHome/domContentLoaded: -36%
  • ↓ startupStandardHome/domInteractive: -55%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -35%
  • ↑ startupStandardHome/setupStore: +40%
  • ↓ startupStandardHome/fcp: -50%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +46%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +48%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +26%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +27%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +33%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -50%
  • ↓ onboardingNewWallet/tbt: -98%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -30%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.41 MiB -763 Bytes 0.00%
✅ ui 19.26 MiB -347 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +58 Bytes 0.00%
✅ content scripts 3.23 MiB +116 Bytes 0.00%
✅ unzipped 79.99 MiB -931 Bytes 0.00%
✅ zip 24.11 MiB -354 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [4576265] [reused from 3679919]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40883928738 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +13%
  • ↑ confirmTx/longTaskTotalDuration: +74%
  • ↑ confirmTx/longTaskMaxDuration: +107%
  • ↑ confirmTx/tbt: +129%
  • ↑ confirmTx/fcp: +16%
  • ↑ confirmTx/lcp: +10%
  • ↑ bridgeUserActions/bridge_load_page: +133%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +138%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +113%
  • ↑ bridgeUserActions/longTaskMaxDuration: +48%
  • ↑ bridgeUserActions/tbt: +214%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/inp: +31%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1316%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +12%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +191%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +136%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +18%
  • ↑ bridgeUserActions/lcp: +1270%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +19%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +211%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -38%
  • ↓ startupStandardHome/load: -34%
  • ↓ startupStandardHome/domContentLoaded: -36%
  • ↓ startupStandardHome/domInteractive: -55%
  • ↓ startupStandardHome/backgroundConnect: -33%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -35%
  • ↑ startupStandardHome/setupStore: +40%
  • ↓ startupStandardHome/fcp: -50%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +46%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +35%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -96%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -93%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +48%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +26%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +27%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +33%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -80%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -50%
  • ↓ onboardingNewWallet/tbt: -98%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -70%
  • ↓ dappPageLoad/domContentLoaded: -30%
  • ↓ dappPageLoad/firstPaint: -50%
  • ↓ dappPageLoad/firstContentfulPaint: -50%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.41 MiB -763 Bytes 0.00%
✅ ui 19.26 MiB -347 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +58 Bytes 0.00%
✅ content scripts 3.23 MiB +116 Bytes 0.00%
✅ unzipped 79.99 MiB -931 Bytes 0.00%
✅ zip 24.11 MiB -354 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [31c7422]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40891204488 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↓ loadNewAccount/inp: -17%
  • ↑ loadNewAccount/lcp: +12%
  • ↑ confirmTx/longTaskTotalDuration: +53%
  • ↑ confirmTx/longTaskMaxDuration: +85%
  • ↑ confirmTx/tbt: +94%
  • ↑ bridgeUserActions/bridge_load_page: +91%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +145%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +136%
  • ↑ bridgeUserActions/longTaskMaxDuration: +54%
  • ↑ bridgeUserActions/tbt: +284%
  • ↑ bridgeUserActions/total: +20%
  • ↑ loadNewAccount/load_new_account: +424%
  • ↑ loadNewAccount/total: +424%
  • ↓ loadNewAccount/inp: -32%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1278%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +22%
  • ↑ confirmTx/lcp: +1310%
  • ↑ bridgeUserActions/bridge_load_page: +305%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +123%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +82%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +14%
  • ↑ bridgeUserActions/lcp: +1241%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -13%
  • ↓ startupStandardHome/load: -15%
  • ↓ startupStandardHome/domContentLoaded: -15%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -16%
  • ↑ startupStandardHome/setupStore: +105%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -23%
  • ↓ startupStandardHome/longTaskMaxDuration: -19%
  • ↓ startupStandardHome/tbt: -20%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -15%
  • ↓ startupStandardHome/domInteractive: -31%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +137%
  • ↓ startupStandardHome/fcp: -29%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +47%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +42%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +24%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +36%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +16%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +26%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -84%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -77%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -46%
  • ↓ onboardingNewWallet/tbt: -93%
  • ↓ onboardingNewWallet/total: -80%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.25 MiB -763 Bytes 0.00%
✅ ui 19.27 MiB -347 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +58 Bytes 0.00%
✅ content scripts 3.22 MiB +116 Bytes 0.00%
✅ unzipped 79.82 MiB -931 Bytes 0.00%
✅ zip 24.05 MiB -342 Bytes 0.00%

pedronfigueiredo added a commit that referenced this pull request Nov 6, 2026
Copied from #47487. Drop this commit when #47487,
or a released @metamask/wallet that delegates the action, lands.

The transaction-controller 73 preview build simulates transactions through
the SentinelApiService:simulateTransactions messenger action (core #9476),
which @metamask/wallet 20.0.0 does not delegate to TransactionController.

- Patch @metamask/wallet 20.0.0 to delegate
  SentinelApiService:simulateTransactions to TransactionController.
- Return only the simulation URL from getSimulationConfig. SentinelApiService
  adds the bearer token itself.
- Update the simulation e2e request mocks to the JSON-RPC id the service
  sends.
pedronfigueiredo added a commit that referenced this pull request Nov 7, 2026
Copied from #47487. Drop this commit when #47487,
or a released @metamask/wallet that delegates the action, lands.

The transaction-controller 73 preview build simulates transactions through
the SentinelApiService:simulateTransactions messenger action (core #9476),
which @metamask/wallet 20.0.0 does not delegate to TransactionController.

- Patch @metamask/wallet 20.0.0 to delegate
  SentinelApiService:simulateTransactions to TransactionController.
- Return only the simulation URL from getSimulationConfig. SentinelApiService
  adds the bearer token itself.
- Update the simulation e2e request mocks to the JSON-RPC id the service
  sends.
LabinatorSolutions pushed a commit to LabinatorSolutions/metamask-extension that referenced this pull request Nov 11, 2026
…llet 21 (MetaMask#47744)

## **Description**

`@metamask/wallet` 21.0.0 now constructs `NetworkEnablementController`
(NEC) itself, together with its messenger. This PR bumps
`@metamask/wallet` to `^21.0.0` and
`@metamask/network-enablement-controller` to `^7.1.0`, and switches the
extension to use the wallet-owned instance (ASSETS-4169).

- Removes the legacy `messenger-client-init` NEC init and its messenger
factory.
- `metamask-controller.js` now gets the controller through
`this.wallet.getInstance('NetworkEnablementController')`. Persistence is
unchanged because the instance is already in the explicit store maps.
- Adds `app/scripts/wallet-init/network-enablement-controller.ts`
(`setupNetworkEnablementController`). It holds the client-side behaviour
that was previously in the init:
- Re-runs `init()` once `MultichainNetworkController` is registered. The
`init()` call made by `Wallet.init()` cannot read it yet, and that error
is swallowed.
- On a fresh install with no persisted `enabledNetworkMap`, enables all
popular networks, or localhost when `IN_TEST` is set.
- When a Config Registry auto-enabled network is added, restores the
previous enabled-network map so the user's selection doesn't change.
- Keeps the existing Solana account-change and account-group-change
handlers.
- Adds a dedicated init messenger in `wallet-init/messengers` that
delegates only the actions and events the setup needs.

Note: on a fresh install the NEC map now starts from NEC's default keys
(for example Sei and Monad) rather than only the configured networks.
After `enableAllPopularNetworks()` the enabled set is the same as
before.

Related work:
- MetaMask#47487 (Sentinel API service). Wallet 21 also delegates
`SentinelApiService:simulateTransactions` to `TransactionController`.
That has no effect here because `TransactionController` stays pinned to
72.3.0, so Sentinel adoption is left to that PR.
- MetaMask#47269 (AssetsController via wallet) touches the same wallet-init
area.
- Mobile counterpart: MetaMask/metamask-mobile#39132.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[ASSETS-4169](https://consensyssoftware.atlassian.net/browse/ASSETS-4169)

## **Manual testing steps**

1. Build and load the extension, then create a new wallet.
2. Open the network filter on the home page and verify that all popular
networks are enabled.
3. Select a single network in the filter, then lock and reload the
extension. Verify the single-network selection is kept.
4. Add a network that the Config Registry auto-enables (for example from
the network list). Verify the network filter selection does not change.
5. Upgrade an existing profile from `main` to this build. Verify its
previous network selection is kept.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[ASSETS-4169]:
https://consensyssoftware.atlassian.net/browse/ASSETS-4169?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes wallet initialization order and default network-filter
behavior on fresh installs and during auto-enabled network adds;
regressions would affect which networks users see across the extension.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
5a1c852. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**

`@metamask/wallet` 21.0.0 now constructs `NetworkEnablementController`
(NEC) itself, together with its messenger. This PR bumps
`@metamask/wallet` to `^21.0.0` and
`@metamask/network-enablement-controller` to `^7.1.0`, and switches the
extension to use the wallet-owned instance (ASSETS-4169).

- Removes the legacy `messenger-client-init` NEC init and its messenger
factory.
- `metamask-controller.js` now gets the controller through
`this.wallet.getInstance('NetworkEnablementController')`. Persistence is
unchanged because the instance is already in the explicit store maps.
- Adds `app/scripts/wallet-init/network-enablement-controller.ts`
(`setupNetworkEnablementController`). It holds the client-side behaviour
that was previously in the init:
- Re-runs `init()` once `MultichainNetworkController` is registered. The
`init()` call made by `Wallet.init()` cannot read it yet, and that error
is swallowed.
- On a fresh install with no persisted `enabledNetworkMap`, enables all
popular networks, or localhost when `IN_TEST` is set.
- When a Config Registry auto-enabled network is added, restores the
previous enabled-network map so the user's selection doesn't change.
- Keeps the existing Solana account-change and account-group-change
handlers.
- Adds a dedicated init messenger in `wallet-init/messengers` that
delegates only the actions and events the setup needs.

Note: on a fresh install the NEC map now starts from NEC's default keys
(for example Sei and Monad) rather than only the configured networks.
After `enableAllPopularNetworks()` the enabled set is the same as
before.

LavaMoat webpack policies are intentionally unchanged. Regenerating them
for wallet 21 and network-enablement-controller 7.1 (`@metamaskbot
update-policies` or `yarn lavamoat:auto`) is left out of this PR, so the
LavaMoat policy checks are expected to fail until that follow-up.

Related work:
- MetaMask#47487 (Sentinel API service). Wallet 21 also delegates
`SentinelApiService:simulateTransactions` to `TransactionController`.
That has no effect here because `TransactionController` stays pinned to
72.3.0, so Sentinel adoption is left to that PR.
- MetaMask#47269 (AssetsController via wallet) touches the same wallet-init
area.
- Mobile counterpart: MetaMask/metamask-mobile#39132.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[ASSETS-4169](https://consensyssoftware.atlassian.net/browse/ASSETS-4169)

## **Manual testing steps**

1. Build and load the extension, then create a new wallet.
2. Open the network filter on the home page and verify that all popular
networks are enabled.
3. Select a single network in the filter, then lock and reload the
extension. Verify the single-network selection is kept.
4. Add a network that the Config Registry auto-enables (for example from
the network list). Verify the network filter selection does not change.
5. Upgrade an existing profile from `main` to this build. Verify its
previous network selection is kept.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


[ASSETS-4169]:
https://consensyssoftware.atlassian.net/browse/ASSETS-4169?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-fc07b32c-7a00-448e-8948-e163799bd337?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-fc07b32c-7a00-448e-8948-e163799bd337&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Xiaoming Wang <dawnseeker8@users.noreply.github.com>
@matthewwalsh0
matthewwalsh0 force-pushed the feat/adopt-sentinel-simulation branch from 31c7422 to 37199d1 Compare November 12, 2026 10:08
@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [37199d1]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43197638722 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -40%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/lcp: +725%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskMaxDuration: +19%
  • ↑ confirmTx/tbt: +18%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +727%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +44%
  • ↓ bridgeUserActions/bridge_search_token: -10%
  • ↓ bridgeUserActions/longTaskTotalDuration: -18%
  • ↓ bridgeUserActions/longTaskMaxDuration: -19%
  • ↓ bridgeUserActions/tbt: -30%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -16%
  • ↑ bridgeUserActions/lcp: +731%
  • ↑ bridgeUserActions/cls: +577%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +25%
  • ↑ loadNewAccount/lcp: +1270%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +13%
  • ↑ confirmTx/lcp: +1297%
  • ↑ bridgeUserActions/bridge_load_page: +306%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↑ bridgeUserActions/bridge_search_token: +22%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +61%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +22%
  • ↑ bridgeUserActions/lcp: +1346%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +48%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +72%
  • ↓ startupStandardHome/firstPaint: -53%
  • ↓ startupStandardHome/backgroundConnect: -13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +71%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +70%
  • ↑ startupStandardHome/longTaskMaxDuration: +84%
  • ↑ startupStandardHome/tbt: +86%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -58%
  • ↑ startupStandardHome/lcp: +88%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -38%
  • ↓ startupStandardHome/load: -36%
  • ↓ startupStandardHome/domContentLoaded: -37%
  • ↓ startupStandardHome/domInteractive: -56%
  • ↓ startupStandardHome/backgroundConnect: -30%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -36%
  • ↑ startupStandardHome/setupStore: +46%
  • ↓ startupStandardHome/fcp: -48%
  • ↓ startupStandardHome/lcp: -33%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +20%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +33%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +17%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -66%
  • ↓ dappPageLoad/domContentLoaded: -32%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.22 MiB -794 Bytes 0.00%
✅ ui 19.5 MiB -347 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +58 Bytes 0.00%
✅ content scripts 3.22 MiB +116 Bytes 0.00%
✅ unzipped 79.93 MiB -962 Bytes 0.00%
✅ zip 24.01 MiB -363 Bytes 0.00%

@matthewwalsh0
matthewwalsh0 marked this pull request as ready for review November 12, 2026 10:42
@matthewwalsh0
matthewwalsh0 requested a review from a team as a code owner November 12, 2026 10:42
jpuri
jpuri previously approved these changes Nov 12, 2026

@jpuri jpuri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in policy files look good as it is not adding any new packge.

@jpuri

jpuri commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

This is some feedback by model, I am not very sure but it may be worth attention

transaction-controller.ts:265 ([comment](#47487 (comment))): getSimulationConfig no longer returns authorization. Instead, @metamask/sentinel-api-service@2.1.0 adds the bearer token to every simulateTransactions request, without checking that the URL is the Shield gateway.

  • A signed-in user without Shield gets the public Sentinel URL, which used to receive no Authorization header. Now it gets their bearer token.
  • The same happens when getToken fails and the code falls back to the original URL, because the service fetches the token again.
  • The token-attaching code lives in the core service. The fix could go there (only add the token for the Shield URL) or here.

@matthewwalsh0

Copy link
Copy Markdown
Member Author

This is some feedback by model, I am not very sure but it may be worth attention

transaction-controller.ts:265 ([comment](#47487 (comment))): getSimulationConfig no longer returns authorization. Instead, @metamask/sentinel-api-service@2.1.0 adds the bearer token to every simulateTransactions request, without checking that the URL is the Shield gateway.

  • A signed-in user without Shield gets the public Sentinel URL, which used to receive no Authorization header. Now it gets their bearer token.
  • The same happens when getToken fails and the code falls back to the original URL, because the service fetches the token again.
  • The token-attaching code lives in the core service. The fix could go there (only add the token for the Shield URL) or here.

We apply the token always now, with or without Shield 👍

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [6eead18]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43229609853 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +922%
  • ↑ loadNewAccount/cls: +629%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +40%
  • ↑ confirmTx/longTaskMaxDuration: +41%
  • ↑ confirmTx/tbt: +47%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +910%
  • ↑ bridgeUserActions/bridge_load_page: +78%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +18%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +63%
  • ↑ bridgeUserActions/longTaskMaxDuration: +15%
  • ↑ bridgeUserActions/tbt: +32%
  • ↓ bridgeUserActions/inp: -12%
  • ↑ bridgeUserActions/lcp: +891%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/fcp: +16%
  • ↑ loadNewAccount/lcp: +1249%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1290%
  • ↑ bridgeUserActions/bridge_load_page: +210%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +166%
  • ↑ bridgeUserActions/bridge_search_token: +25%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +55%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +19%
  • ↑ bridgeUserActions/lcp: +1256%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +70%
  • ↑ startupStandardHome/domContentLoaded: +70%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +68%
  • ↑ startupStandardHome/setupStore: +82%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +66%
  • ↑ startupStandardHome/longTaskMaxDuration: +98%
  • ↑ startupStandardHome/tbt: +83%
  • ↓ startupStandardHome/inp: -18%
  • ↑ startupStandardHome/fcp: +66%
  • ↑ startupStandardHome/lcp: +643%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -36%
  • ↑ startupStandardHome/backgroundConnect: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -31%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +13%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +25%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +32%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +18%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +36%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +34%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -44%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -84%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -38%
  • ↓ dappPageLoad/firstContentfulPaint: -38%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.22 MiB -794 Bytes 0.00%
✅ ui 19.51 MiB -342 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +58 Bytes 0.00%
✅ content scripts 3.2 MiB +116 Bytes 0.00%
✅ unzipped 79.93 MiB -957 Bytes 0.00%
✅ zip 24.02 MiB -370 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@matthewwalsh0
matthewwalsh0 requested a review from jpuri November 12, 2026 14:27
@matthewwalsh0
matthewwalsh0 added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 97bb5dc Nov 12, 2026
140 checks passed
@matthewwalsh0
matthewwalsh0 deleted the feat/adopt-sentinel-simulation branch November 12, 2026 16:59
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026
@gauthierpetetin

Copy link
Copy Markdown
Contributor

No release label on PR. Adding release label release-13.58.0 on PR, as PR was added to branch 13.58.0 when release was cut.

This branch was previously deployed

1 inactive deployment
pr-comment — 6eead185 Deployed Nov 12, 2026 by matthewwalsh0 via Publish prerelease / Publish prerelease #174320
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants